Jim Meyering
8cc2bbe33c
qparams.c: Use virReportOOMError(NULL), not qparam_report_oom()
...
* src/qparams.c (VIR_FROM_THIS): Define to VIR_FROM_NONE.
(qparam_report_oom): Remove definition.
Replace all uses.
2009-01-28 16:13:46 +00:00
John Levon
499189694a
fix mis-use of PF_UNIX as a protocol
2009-01-28 14:36:23 +00:00
Jim Meyering
be33b189a5
libvirt_proxy: avoid potential buffer overflow
...
* proxy/libvirt_proxy.c (proxyReadClientSocket): Ensure that
we've read an entire virProxyPacket before dereferencing "req".
Analysis and patch by "Rasputin" <rasputin@email.ru>. Details in
<http://thread.gmane.org/gmane.comp.emulators.libvirt/11459 >.
2009-01-28 14:08:33 +00:00
Jim Meyering
eb0849f370
* po/POTFILES.in: Add src/lxc_conf.c
2009-01-28 13:59:56 +00:00
John Levon
c2102c60ea
remove reference to non-existent *.res
2009-01-28 13:45:50 +00:00
Jim Meyering
555de859cc
avoid printf format-mismatch warnings
...
* qemud/qemud.c (qemudClientReadBuf, qemudClientWriteBuf):
Use %lld and a (long long int) cast to print a ssize_t value.
2009-01-28 11:31:39 +00:00
Daniel P. Berrange
489fde7680
Add support for copy-on-write storage volumes
2009-01-27 18:30:03 +00:00
Jim Meyering
765bca14d1
* POTFILES.in: update: remove src/lxc_conf.c; Add src/bridge.c.
2009-01-27 15:37:34 +00:00
Daniel P. Berrange
2c22a68ce2
Added complete set of RNG schemas for all XML formats
2009-01-27 15:29:53 +00:00
Daniel P. Berrange
04b120e481
Added link to libvirt-qpid on front page, and docs on URI formats for each driver
2009-01-27 14:49:09 +00:00
Jim Meyering
f03d3439cd
virterror.c: don't read beyond end of buffer upon OOM
...
* src/virterror.c (virReportSystemErrorFull): Fix typo in
my previous change. Patch by Daniel P. Berrange.
2009-01-27 12:26:53 +00:00
Mark McLoughlin
b4f62abbf1
kvm/virtio: Set IFF_VNET_HDR when setting up tap fds
...
IFF_VNET_HDR is a tun/tap flag that allows you to send and receive
large (i.e. GSO) packets and packets with partial checksums. Setting
the flag means that every packet is proceeded by the same header which
virtio uses to communicate GSO/csum metadata.
By enabling this flag on the tap fds we create, we greatly increase
the achievable throughput with virtio_net.
However, we need to be careful to only set the flag when a) QEMU has
support for this ABI and b) the value of the flag is queryable using
the TUNGETIFF ioctl.
It's nearly five months since kvm-74 - the first KVM release with this
feature - was released. Up until now, we've not added libvirt support
because there is no clean way to detect support for this in QEMU at
runtime. A brief attempt to add a "info capabilities" monitor command
to QEMU floundered. Perfect is the enemy of good enough. Probing the
KVM version will suffice for now.
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
2009-01-27 11:12:05 +00:00
Jim Meyering
e15147c141
fix errors in virReportSystemErrorFull
...
* src/virterror.c (virStrerror): New function.
(virReportSystemErrorFull): Don't leak "combined".
In fact, don't even attempt allocation.
Do include the result of formatted print in final diagnostic.
2009-01-27 10:57:18 +00:00
Jim Meyering
4e8f63fdaa
use gnulib's stpcpy module
...
* bootstrap (modules): Add stpcpy, and pull in gnulib bits:
* gnulib/lib/stpcpy.c: New file.
* gnulib/m4/stpcpy.m4: New file.
* gnulib/lib/Makefile.am: Update.
* gnulib/m4/gnulib-cache.m4: Update.
* gnulib/m4/gnulib-comp.m4: Update.
2009-01-27 10:30:30 +00:00
Jim Meyering
aa7c4102aa
update from gnulib
2009-01-27 10:29:55 +00:00
Jim Meyering
339cc9d992
build: avoid format warnings
...
* src/proxy_internal.c (xenProxyCommand): Mark a diagnostic.
* src/xen_unified.c (xenUnifiedOpen, xenUnifiedAddDomainInfo):
Fix unmarked diagnostics by removing the diagnostic altogether:
replace each xenUnifiedError(...,VIR_ERR_NO_MEMORY call with a
call to virReportOOMError.
2009-01-27 08:50:03 +00:00
Jim Meyering
69d947eb80
* src/virterror.c (virErrorMsg): Correct indentation.
2009-01-27 08:49:15 +00:00
John Levon
39e49ad7c9
fix recursive lock hang in xenstore driver
2009-01-23 19:18:24 +00:00
Daniel P. Berrange
ad70b32414
Support QEMU disk format specification in XML
2009-01-23 16:22:20 +00:00
Jim Meyering
5f0c720163
.cvsignore: Add explicit list of generated files.
...
* .hgignore: Regenerate.
* m4/.gitignore: Regenerate.
2009-01-23 16:15:49 +00:00
Jim Meyering
727d4fdc6e
fix comment typo: s/contains/continues/
...
* src/libvirt.c (virStorageVolFree): Correct typo in comment.
2009-01-23 14:18:43 +00:00
Jim Meyering
7523642c01
qemud: don't dereference NULL on failed virGetUserDirectory
...
* qemud/qemud.c (qemudInitPaths): Return right away,
upon virGetUserDirectory failure.
2009-01-23 13:50:59 +00:00
Jim Meyering
3b22f80f07
m4: update from gnulib to avoid warnings from cutting-edge autoconf
...
* gnulib/m4/errno_h.m4
* gnulib/m4/gnulib-comp.m4
* gnulib/m4/multiarch.m4
2009-01-23 13:32:48 +00:00
Jim Meyering
48dc345f2d
correct and tighten up .*ignore files
...
* .cvsignore: Don't ignore *.orig or *.rej. They're not build products.
Don't ignore the entire m4 directory.
* Makefile.maint (sync-vcs-ignore-files): Correct quoting.
Use sed rather than a for loop.
Search only version-controled files (for reproducibility)
* gnulib/lib/netinet/.cvsignore: Append missing newline-at-EOF,
so that the use of sed doesn't mistakenly concatenate lines.
* gnulib/lib/sys/.cvsignore: Likewise.
* m4/.cvsignore: Ignore acinclude.m4 and aclocal.m4, not *.m4.
* .hgignore: Regenerate.
* all .gitignore files: Regenerate.
2009-01-23 13:32:17 +00:00
Jim Meyering
6278bb191a
maint: update list of error function names and adapt
...
* Makefile.maint (msg_gen_function): Update list.
Remove some now-unused names, add some new ones.
* src/hash.c (virHashError): Remove unused definition.
* src/openvz_conf.h (openvzLog): Likewise.
* src/xen_unified.c: Mark newly-exposed diagnostics for translation.
2009-01-23 12:29:29 +00:00
John Levon
e80f10064e
parse IP address for bridge interfaces
2009-01-23 01:48:47 +00:00
Daniel P. Berrange
c4985e9419
use the gnulib random_r function
2009-01-22 20:27:01 +00:00
Daniel P. Berrange
1b745219c7
Remove use of non-reentrant POSIX apis
2009-01-22 19:41:48 +00:00
Jim Meyering
d0eab955c2
xm_internal.c: fix locking bug: s/Lock/Unlock/
...
* src/xm_internal.c (xenXMDomainDefineXML): Release lock, (don't
try to acquire it) upon failure, just before returning.
2009-01-22 19:18:24 +00:00
John Levon
a7acdde406
generate .hgignore
2009-01-22 19:03:11 +00:00
John Levon
7420fec81b
Remove non-existent symbol from linker script
2009-01-22 18:33:13 +00:00
John Levon
fb4ec82358
Support script for bridge interface type
2009-01-22 18:29:13 +00:00
Daniel P. Berrange
39e6ded8ae
Fix to xen test case for threadsafety patches
2009-01-22 18:19:20 +00:00
John Levon
2b29698352
Least privilege support for Solaris
2009-01-22 17:49:41 +00:00
Daniel P. Berrange
e52d74e536
Make xen driver threadsafe
2009-01-21 18:11:14 +00:00
Mark McLoughlin
20921cc284
If you un-install libvirt and re-install it, you get a warning
...
from the post-install script:
Installing : libvirt
ln: creating symbolic link `/etc/libvirt/qemu/networks/autostart/default.xml': File exists
See https://bugzilla.redhat.com/462011
2009-01-21 10:50:03 +00:00
Daniel P. Berrange
e3672d9695
Allow storage driver to handle daemon restarts
2009-01-20 22:43:07 +00:00
Daniel P. Berrange
23a090ab92
Allow virtual networks to survive daemon restart
2009-01-20 22:36:10 +00:00
Daniel P. Berrange
a964a6dad6
Support ac97 soundcard model
2009-01-20 22:15:55 +00:00
Daniel P. Berrange
554d82a200
Use global thread-local error for all python error reporting
2009-01-20 22:10:52 +00:00
John Levon
839c6de58b
libvirtd: respect LIBVIRT_DEBUG when logging to syslog
2009-01-20 21:50:31 +00:00
Daniel Veillard
5fb1e29c7e
* src/logging.c: fix openlog() ident lifetime for Solaris
...
daniel
2009-01-20 21:34:44 +00:00
Daniel P. Berrange
89408fd3a0
Refresh GNULIB, also pulling in random_r module
2009-01-20 21:05:33 +00:00
Daniel P. Berrange
a888b22cf9
Support domain events in test driver
2009-01-20 20:23:53 +00:00
Daniel P. Berrange
071be08079
Add syntax check rule to look for non-reentrant POSIX apis
2009-01-20 20:19:55 +00:00
Jim Meyering
3548e9aae8
don't ignore write failure
...
* src/network_driver.c (networkEnableIpForwarding): This function
would always return 1 (success). Now it returns 0 upon write or
close failure, being careful to preserve any errno from a write failure.
Add comments.
2009-01-20 19:29:08 +00:00
Daniel P. Berrange
d82071710e
Dynamically adjust worker threads in daemon
2009-01-20 19:27:11 +00:00
Daniel P. Berrange
f61341173b
Allow concurrent processing of RPC calls in daemon
2009-01-20 19:25:15 +00:00
Daniel P. Berrange
84ef468ba8
Fix some misleading comments in XM driver
2009-01-20 18:20:09 +00:00
Daniel P. Berrange
2c7be88d15
Remove a use of strerror() in error reporting in remote driver
2009-01-20 17:47:13 +00:00
Daniel P. Berrange
788bedd904
Remove use of static data in Xen XM driver
2009-01-20 17:34:56 +00:00
Daniel Veillard
0fc5b2fbc9
Activate RHEL5 specific flags when needed
...
* libvirt.spec.in: try to autodetect when rhel5 option should be
passed to configure
Daniel
2009-01-20 17:27:34 +00:00
Daniel P. Berrange
e428a69e6f
Remove use of static data in Xen inotify driver
2009-01-20 17:19:23 +00:00
Daniel P. Berrange
437ac354fc
Make error reporting threadsafe by avoiding strerror
2009-01-20 17:13:33 +00:00
Daniel Veillard
25415eb104
* src/qemu_driver.c: remove a warning when printing a file offset
...
daniel
2009-01-20 16:39:35 +00:00
Daniel P. Berrange
61674cc17d
Make RPC call dispatch threaded
2009-01-20 16:36:34 +00:00
Daniel Veillard
458a673cb7
remove stdout_fd, stderr_fd from virDomainObj
...
* src/domain_conf.h src/lxc_driver.c src/uml_driver.c: virDomainObj
doesn't need stdout and stderr fields anymore, patch from
Guido Günther
daniel
2009-01-20 16:10:20 +00:00
Daniel Veillard
6d004d3f8a
* src/domain_conf.h src/qemu_driver.c: use monitor fd for QEmu/KVM
...
domain shutdown and read saved vm status on libvirtd startup,
last 2 patches from Guido Günther finishing up the surviving the
libvirt daemon restart
daniel
2009-01-20 15:52:11 +00:00
Daniel Veillard
103ee5d4c2
Fix apibuild.py and update/regenerate localizations
...
* docs/apibuild.py: fix the parser with another Win32 keyword
* po/*: updated a couple of translations and regenerated
daniel
2009-01-20 15:42:07 +00:00
Jim Meyering
45062390a6
fix "make syntax-check" failures
...
* ChangeLog: Start with TAB, not 8 spaces.
* src/virterror.c: Remove trailing spaces.
2009-01-20 13:51:52 +00:00
Daniel P. Berrange
763e33c373
Fix config summary output alignment
2009-01-20 12:25:40 +00:00
Daniel P. Berrange
a776fad370
Add public APIs for ref counting on public objects
2009-01-20 12:14:03 +00:00
Daniel P. Berrange
0466ff28f2
Fix actual vs expected data comparison order to get correct diff +++/--- output
2009-01-20 12:03:40 +00:00
Daniel P. Berrange
ead04dcbe8
Thread local error reporting
2009-01-20 12:01:45 +00:00
Daniel P. Berrange
c790f6d25e
Avoid bogus event loop wakeups in remote driver when doing RPC call
2009-01-20 11:45:09 +00:00
Daniel P. Berrange
ed493909f7
Add locking to the remote driver
2009-01-20 11:41:24 +00:00
Guido Günther
8dfbfe3145
daemonize qemu processes
2009-01-19 21:55:54 +00:00
Guido Günther
5d99a309e6
save domstate as string in status file
2009-01-19 21:06:26 +00:00
Daniel Veillard
9a969b86a9
* src/xen_internal.c src/xend_internal.c: Relax NUMA checking
...
for RHEL-5 and change the detection stategy for default Xen
accesses, patch by Markus Armbruster
daniel
2009-01-19 20:16:10 +00:00
Daniel Veillard
b751b46bc5
Fix PVFB version check for RHEL-5
...
* src/xend_internal.c src/xm_internal.c: fix paravirt framebuffer
handling since it was backoprted for RHEL-5, patch by Markus
Armbruster
daniel
2009-01-19 19:49:30 +00:00
Daniel Veillard
e676a699e8
* src/xend_internal.c src/xm_internal.c: fix fully virt network
...
device configuration for Xen on RHEL-5, patch by Markus Armbruster
daniel
2009-01-19 18:12:00 +00:00
Daniel Veillard
4fbbbbd336
* configure.in: add a --with-rhel5-api configure option
...
for the Xen specific version of RHEL-5, patch by Markus Armbruster
daniel
2009-01-19 17:41:39 +00:00
Daniel Veillard
99ed5b4bee
Two bug fixes coming from RHEL and Markus being added to AUTHORS
...
* src/xm_internal.c: two bug fixes coming from RHEL package
posted by Markus Armbruster
* AUTHORS: adding Markus
daniel
2009-01-19 15:24:41 +00:00
Jim Meyering
1fe181e36f
tests: virsh-all and virsh-synopsis were not being run
...
* tests/Makefile.am (test_scripts): Add two missing backslashes.
2009-01-16 18:07:24 +00:00
Jim Meyering
735329b824
tests: exercise a bug that could make virsh and libvirtd segfault
...
* tests/define-dev-segfault: New file.
* tests/Makefile.am (test_scripts): Add define-dev-segfault.
2009-01-16 18:06:33 +00:00
Cole Robinson
46d4a5e047
Fix segfault with console device back compat.
2009-01-16 16:50:11 +00:00
Daniel P. Berrange
dd9b3fb594
Fix bug when fork isn't available (Win32) in remote driver
2009-01-15 20:13:12 +00:00
Daniel P. Berrange
2be79b1d5e
Reduce exit paths in remote driver APIs
2009-01-15 20:07:10 +00:00
Daniel P. Berrange
19d1bf2562
Remove use of macros in remote driver private data access
2009-01-15 20:04:44 +00:00
Daniel P. Berrange
0cd119e7b8
Fix incorrect use of private data field in remote driver
2009-01-15 20:03:10 +00:00
Daniel P. Berrange
4dac0a1105
Generic internal threads API
2009-01-15 19:56:05 +00:00
Daniel P. Berrange
52e51d278e
Implement virKill for Win32 platform
2009-01-15 19:40:21 +00:00
John Levon
4d713eabf5
Avoid passing NULL to printf %s specifier
2009-01-15 17:54:20 +00:00
John Levon
c7095a4b4c
Improve xend_get error message
2009-01-15 15:17:53 +00:00
John Levon
443698d2b2
implement capabilities parsing for Solaris
2009-01-15 01:35:17 +00:00
John Levon
406c05f2e7
Fix xs_unwatch() to correctly pass the token
2009-01-15 01:23:32 +00:00
John Levon
c8070bf632
Fix activeDomainList handling
2009-01-15 01:21:36 +00:00
John Levon
65316d7940
Fix ref-counting for Xen driver event registration
2009-01-15 01:18:37 +00:00
John Levon
d6511cf6de
Fix devhelp build dependencies
2009-01-14 17:36:05 +00:00
John Levon
9e58678a98
Let devhelp build in a separate objdir.
2009-01-14 17:30:39 +00:00
John Levon
231dde6dc4
remove references to non-existent files in docs/
2009-01-14 17:24:18 +00:00
John Levon
5b6c39f51f
Mark Xen PV CD-ROM devices as such
2009-01-14 16:21:12 +00:00
John Levon
d052118dae
Improve compiler flag checking
2009-01-14 15:23:26 +00:00
Jim Meyering
37abbb387e
qemud.c: fix error in yesterday's change: s/X_OK/R_OK/
...
* qemud/qemud.c (main): Fix error s/X_OK/R_OK/ reported by
Daniel Berrange.
2009-01-13 12:22:24 +00:00
Jim Meyering
17bfd657b7
* HACKING: Clarify "bool" vs. XDR/wire-format.
2009-01-13 10:45:41 +00:00
Daniel Veillard
890915054f
fix the QEmu links
...
* docs/index.html docs/index.html.in docs/relatedlinks.html
docs/relatedlinks.html.in: fix the QEmu links
daniel
2009-01-12 21:09:09 +00:00
Richard W.M. Jones
e0a2770f67
Fix invocation of rpcgen.
...
* qemud/Makefile.am: Fix invocation of rpcgen, and make sure
we run the right one.
2009-01-12 19:19:22 +00:00
Jim Meyering
fe54138020
tests: quiet virsh-all
...
* tests/virsh-all: For now, ignore diagnostics and exit status,
when running all virsh commands.
2009-01-12 18:23:10 +00:00
Jim Meyering
6954d44e53
diagnose "libvirtd --config=no-such-file"
...
* qemud/qemud.c (remoteReadConfigFile): Don't return 0 (success)
when the config file is unreadable or nonexistent
Return -1, not 0, upon virConfReadFile failure.
(main): If remote_config_file is not specified via --config(-f),
use the default config file only if it exists. Otherwise,
use /dev/null.
* src/conf.c (virConfReadFile): Don't diagnose virFileReadAll
failure, since it already does that.
2009-01-12 18:22:32 +00:00
Jim Meyering
1c947488f6
fix non-srcdir build failure
...
* qemud/Makefile.am (check-local): Prefix use of test_libvirtd.aug
with $(srcdir)/. Add quotes around $(AUGPARSE), in case it expands
to something unusual.
2009-01-12 18:21:49 +00:00