Compare commits

...

3 Commits

Author SHA1 Message Date
antonios-f 1c43fe43d5 Merge branch 'spice-vnc-default-audio-backend' into 'master'
src/qemu/qemu_domain.c: Fix overriding audioBackend in qemuDomainDefSuggestDefaultAudioBackend

See merge request libvirt/libvirt!271
2024-05-09 11:28:33 +00:00
Daniel P. Berrangé 632eb94e43 docs: ensure HTML/images are built before running reference tests
The 'check-html-references' test will process the built HTML files,
so they must exist before it is run, along with any images that
they point to.

If using the older 'configure_file' command, no changes are needed
since that always gets executed at 'meson setup' time, rather than
at 'meson compile' time.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2024-05-09 09:20:29 +01:00
Anton Fadeev 971753af89 src/qemu/qemu_domain.c: Fix overriding audioBackend in qemuDomainDefSuggestDefaultAudioBackend
If we have Spice and VNC graphics in domain XML, and Spice graphics defined before VNC, audioBackend will be overrided in qemuDomainDefSuggestDefaultAudioBackend to VIR_DOMAIN_AUDIO_TYPE_NONE, and we will have no sound in Spice session, like this https://bugs.launchpad.net/qemu/+bug/1900352. If the flag addAudio already set, we do not need to override audioBackend. This commit fix the issue.
2023-06-29 08:52:21 +00:00
4 changed files with 8 additions and 3 deletions

View File

@ -18,7 +18,8 @@ foreach file : docs_image_files
# This hack enables us to view the web pages
# from within the uninstalled build tree
if meson.version().version_compare('>=0.64.0')
fs.copyfile(file)
imgfile = fs.copyfile(file)
install_web_deps += imgfile
else
configure_file(input: file, output: file, copy: true)
endif

View File

@ -26,7 +26,8 @@ foreach file : docs_logo_files
# This hack enables us to view the web pages
# from within the uninstalled build tree
if meson.version().version_compare('>=0.64.0')
fs.copyfile(file)
logofile = fs.copyfile(file)
install_web_deps += logofile
else
configure_file(input: file, output: file, copy: true)
endif

View File

@ -360,6 +360,7 @@ if tests_enabled[0]
'--webroot',
meson.project_build_root() / 'docs'
],
depends: install_web_deps,
env: runutf8,
suite: 'script'
)

View File

@ -3951,7 +3951,9 @@ qemuDomainDefSuggestDefaultAudioBackend(virQEMUDriver *driver,
audioPassthrough = true;
} else {
audioPassthrough = false;
*audioBackend = VIR_DOMAIN_AUDIO_TYPE_NONE;
if (!*addAudio) {
*audioBackend = VIR_DOMAIN_AUDIO_TYPE_NONE;
}
}
*addAudio = true;
break;