#include #include #include #include #include #include "internal.h" #include "virjson.h" #include "testutils.h" #define VIR_FROM_THIS VIR_FROM_NONE struct testInfo { const char *doc; const char *expect; bool pass; }; static int testJSONFromString(const void *data) { const struct testInfo *info = data; virJSONValuePtr json; const char *expectstr = info->expect ? info->expect : info->doc; char *formatted = NULL; int ret = -1; json = virJSONValueFromString(info->doc); if (!json) { if (info->pass) { VIR_TEST_VERBOSE("Fail to parse %s\n", info->doc); goto cleanup; } else { VIR_TEST_DEBUG("Fail to parse %s\n", info->doc); ret = 0; goto cleanup; } } if (!info->pass) { VIR_TEST_VERBOSE("Should not have parsed %s\n", info->doc); goto cleanup; } VIR_TEST_DEBUG("Parsed %s\n", info->doc); if (!(formatted = virJSONValueToString(json, false))) { VIR_TEST_VERBOSE("Failed to format json data\n"); goto cleanup; } if (STRNEQ(expectstr, formatted)) { virTestDifference(stderr, expectstr, formatted); goto cleanup; } ret = 0; cleanup: VIR_FREE(formatted); virJSONValueFree(json); return ret; } static int testJSONAddRemove(const void *data) { const struct testInfo *info = data; virJSONValuePtr json; virJSONValuePtr name = NULL; char *result = NULL; int ret = -1; json = virJSONValueFromString(info->doc); if (!json) { VIR_TEST_VERBOSE("Fail to parse %s\n", info->doc); ret = -1; goto cleanup; } switch (virJSONValueObjectRemoveKey(json, "name", &name)) { case 1: if (!info->pass) { VIR_TEST_VERBOSE("should not remove from non-object %s\n", info->doc); goto cleanup; } break; case -1: if (!info->pass) ret = 0; else VIR_TEST_VERBOSE("Fail to recognize non-object %s\n", info->doc); goto cleanup; default: VIR_TEST_VERBOSE("unexpected result when removing from %s\n", info->doc); goto cleanup; } if (STRNEQ_NULLABLE(virJSONValueGetString(name), "sample")) { VIR_TEST_VERBOSE("unexpected value after removing name: %s\n", NULLSTR(virJSONValueGetString(name))); goto cleanup; } if (virJSONValueObjectRemoveKey(json, "name", NULL)) { VIR_TEST_VERBOSE("%s", "unexpected success when removing missing key\n"); goto cleanup; } if (virJSONValueObjectAppendString(json, "newname", "foo") < 0) { VIR_TEST_VERBOSE("%s", "unexpected failure adding new key\n"); goto cleanup; } if (!(result = virJSONValueToString(json, false))) { VIR_TEST_VERBOSE("%s", "failed to stringize result\n"); goto cleanup; } if (STRNEQ(info->expect, result)) { virTestDifference(stderr, info->expect, result); goto cleanup; } ret = 0; cleanup: virJSONValueFree(json); virJSONValueFree(name); VIR_FREE(result); return ret; } static int testJSONLookup(const void *data) { const struct testInfo *info = data; virJSONValuePtr json; virJSONValuePtr value = NULL; char *result = NULL; int rc; int number; const char *str; int ret = -1; json = virJSONValueFromString(info->doc); if (!json) { VIR_TEST_VERBOSE("Fail to parse %s\n", info->doc); ret = -1; goto cleanup; } value = virJSONValueObjectGetObject(json, "a"); if (value) { if (!info->pass) { VIR_TEST_VERBOSE("lookup for 'a' in '%s' should have failed\n", info->doc); goto cleanup; } else { result = virJSONValueToString(value, false); if (STRNEQ_NULLABLE(result, "{}")) { VIR_TEST_VERBOSE("lookup for 'a' in '%s' found '%s' but " "should have found '{}'\n", info->doc, NULLSTR(result)); goto cleanup; } VIR_FREE(result); } } else if (info->pass) { VIR_TEST_VERBOSE("lookup for 'a' in '%s' should have succeeded\n", info->doc); goto cleanup; } number = 2; rc = virJSONValueObjectGetNumberInt(json, "b", &number); if (rc == 0) { if (!info->pass) { VIR_TEST_VERBOSE("lookup for 'b' in '%s' should have failed\n", info->doc); goto cleanup; } else if (number != 1) { VIR_TEST_VERBOSE("lookup for 'b' in '%s' found %d but " "should have found 1\n", info->doc, number); goto cleanup; } } else if (info->pass) { VIR_TEST_VERBOSE("lookup for 'b' in '%s' should have succeeded\n", info->doc); goto cleanup; } str = virJSONValueObjectGetString(json, "c"); if (str) { if (!info->pass) { VIR_TEST_VERBOSE("lookup for 'c' in '%s' should have failed\n", info->doc); goto cleanup; } else if (STRNEQ(str, "str")) { VIR_TEST_VERBOSE("lookup for 'c' in '%s' found '%s' but " "should have found 'str'\n", info->doc, str); goto cleanup; } } else if (info->pass) { VIR_TEST_VERBOSE("lookup for 'c' in '%s' should have succeeded\n", info->doc); goto cleanup; } value = virJSONValueObjectGetArray(json, "d"); if (value) { if (!info->pass) { VIR_TEST_VERBOSE("lookup for 'd' in '%s' should have failed\n", info->doc); goto cleanup; } else { result = virJSONValueToString(value, false); if (STRNEQ_NULLABLE(result, "[]")) { VIR_TEST_VERBOSE("lookup for 'd' in '%s' found '%s' but " "should have found '[]'\n", info->doc, NULLSTR(result)); goto cleanup; } VIR_FREE(result); } } else if (info->pass) { VIR_TEST_VERBOSE("lookup for 'd' in '%s' should have succeeded\n", info->doc); goto cleanup; } ret = 0; cleanup: virJSONValueFree(json); VIR_FREE(result); return ret; } static int testJSONCopy(const void *data) { const struct testInfo *info = data; virJSONValuePtr json = NULL; virJSONValuePtr jsonCopy = NULL; char *result = NULL; char *resultCopy = NULL; int ret = -1; json = virJSONValueFromString(info->doc); if (!json) { VIR_TEST_VERBOSE("Failed to parse %s\n", info->doc); goto cleanup; } jsonCopy = virJSONValueCopy(json); if (!jsonCopy) { VIR_TEST_VERBOSE("Failed to copy JSON data\n"); goto cleanup; } result = virJSONValueToString(json, false); if (!result) { VIR_TEST_VERBOSE("Failed to format original JSON data\n"); goto cleanup; } resultCopy = virJSONValueToString(json, false); if (!resultCopy) { VIR_TEST_VERBOSE("Failed to format copied JSON data\n"); goto cleanup; } if (STRNEQ(result, resultCopy)) { if (virTestGetVerbose()) virTestDifference(stderr, result, resultCopy); goto cleanup; } VIR_FREE(result); VIR_FREE(resultCopy); result = virJSONValueToString(json, true); if (!result) { VIR_TEST_VERBOSE("Failed to format original JSON data\n"); goto cleanup; } resultCopy = virJSONValueToString(json, true); if (!resultCopy) { VIR_TEST_VERBOSE("Failed to format copied JSON data\n"); goto cleanup; } if (STRNEQ(result, resultCopy)) { if (virTestGetVerbose()) virTestDifference(stderr, result, resultCopy); goto cleanup; } ret = 0; cleanup: VIR_FREE(result); VIR_FREE(resultCopy); virJSONValueFree(json); virJSONValueFree(jsonCopy); return ret; } static int testJSONDeflatten(const void *data) { const struct testInfo *info = data; virJSONValuePtr injson = NULL; virJSONValuePtr deflattened = NULL; char *infile = NULL; char *indata = NULL; char *outfile = NULL; char *actual = NULL; int ret = -1; if (virAsprintf(&infile, "%s/virjsondata/deflatten-%s-in.json", abs_srcdir, info->doc) < 0 || virAsprintf(&outfile, "%s/virjsondata/deflatten-%s-out.json", abs_srcdir, info->doc) < 0) goto cleanup; if (virTestLoadFile(infile, &indata) < 0) goto cleanup; if (!(injson = virJSONValueFromString(indata))) goto cleanup; if ((deflattened = virJSONValueObjectDeflatten(injson))) { if (!info->pass) { VIR_TEST_VERBOSE("%s: deflattening should have failed\n", info->doc); goto cleanup; } } else { if (!info->pass) ret = 0; goto cleanup; } if (!(actual = virJSONValueToString(deflattened, true))) goto cleanup; if (virTestCompareToFile(actual, outfile) < 0) goto cleanup; ret = 0; cleanup: virJSONValueFree(injson); virJSONValueFree(deflattened); VIR_FREE(infile); VIR_FREE(indata); VIR_FREE(outfile); VIR_FREE(actual); return ret; } static int testJSONEscapeObj(const void *data ATTRIBUTE_UNUSED) { virJSONValuePtr json = NULL; virJSONValuePtr nestjson = NULL; virJSONValuePtr parsejson = NULL; char *neststr = NULL; char *result = NULL; const char *parsednestedstr; int ret = -1; if (virJSONValueObjectCreate(&nestjson, "s:stringkey", "stringvalue", "i:numberkey", 1234, "b:booleankey", false, NULL) < 0) { VIR_TEST_VERBOSE("failed to create nested json object"); goto cleanup; } if (!(neststr = virJSONValueToString(nestjson, false))) { VIR_TEST_VERBOSE("failed to format nested json object"); goto cleanup; } if (virJSONValueObjectCreate(&json, "s:test", neststr, NULL) < 0) { VIR_TEST_VERBOSE("Failed to create json object"); goto cleanup; } if (!(result = virJSONValueToString(json, false))) { VIR_TEST_VERBOSE("Failed to format json object"); goto cleanup; } if (!(parsejson = virJSONValueFromString(result))) { VIR_TEST_VERBOSE("Failed to parse JSON with nested JSON in string"); goto cleanup; } if (!(parsednestedstr = virJSONValueObjectGetString(parsejson, "test"))) { VIR_TEST_VERBOSE("Failed to retrieve string containing nested json"); goto cleanup; } if (STRNEQ(parsednestedstr, neststr)) { virTestDifference(stderr, neststr, parsednestedstr); goto cleanup; } ret = 0; cleanup: VIR_FREE(neststr); VIR_FREE(result); virJSONValueFree(json); virJSONValueFree(nestjson); virJSONValueFree(parsejson); return ret; } static int testJSONObjectFormatSteal(const void *opaque ATTRIBUTE_UNUSED) { virJSONValuePtr a1 = NULL; virJSONValuePtr a2 = NULL; virJSONValuePtr t1 = NULL; virJSONValuePtr t2 = NULL; int ret = -1; if (!(a1 = virJSONValueNewString("test")) || !(a2 = virJSONValueNewString("test"))) { VIR_TEST_VERBOSE("Failed to create json object"); } if (virJSONValueObjectCreate(&t1, "a:t", &a1, "s:f", NULL, NULL) != -1) { VIR_TEST_VERBOSE("virJSONValueObjectCreate(t1) should have failed\n"); goto cleanup; } if (a1) { VIR_TEST_VERBOSE("appended object a1 was not consumed\n"); goto cleanup; } if (virJSONValueObjectCreate(&t2, "s:f", NULL, "a:t", &a1, NULL) != -1) { VIR_TEST_VERBOSE("virJSONValueObjectCreate(t2) should have failed\n"); goto cleanup; } if (!a2) { VIR_TEST_VERBOSE("appended object a2 was consumed\n"); goto cleanup; } ret = 0; cleanup: virJSONValueFree(a1); virJSONValueFree(a2); virJSONValueFree(t1); virJSONValueFree(t2); return ret; } static int mymain(void) { int ret = 0; #if !WITH_STABLE_ORDERING_JANSSON fputs("libvirt not compiled with recent enough Jansson, skipping this test\n", stderr); return EXIT_AM_SKIP; #endif #define DO_TEST_FULL(name, cmd, doc, expect, pass) \ do { \ struct testInfo info = { doc, expect, pass }; \ if (virTestRun(name, testJSON ## cmd, &info) < 0) \ ret = -1; \ } while (0) /** * DO_TEST_PARSE: * @name: test name * @doc: source JSON string * @expect: expected output JSON formatted from parsed @doc * * Parses @doc and formats it back. If @expect is NULL the result has to be * identical to @doc. */ #define DO_TEST_PARSE(name, doc, expect) \ DO_TEST_FULL(name, FromString, doc, expect, true) #define DO_TEST_PARSE_FAIL(name, doc) \ DO_TEST_FULL(name, FromString, doc, NULL, false) DO_TEST_PARSE("Simple", "{\"return\": {}, \"id\": \"libvirt-1\"}", "{\"return\":{},\"id\":\"libvirt-1\"}"); DO_TEST_PARSE("NotSoSimple", "{\"QMP\": {\"version\": {\"qemu\":" "{\"micro\": 91, \"minor\": 13, \"major\": 0}," "\"package\": \" (qemu-kvm-devel)\"}, \"capabilities\": []}}", "{\"QMP\":{\"version\":{\"qemu\":" "{\"micro\":91,\"minor\":13,\"major\":0}," "\"package\":\" (qemu-kvm-devel)\"},\"capabilities\":[]}}"); DO_TEST_PARSE("Harder", "{\"return\": [{\"filename\": " "\"unix:/home/berrange/.libvirt/qemu/lib/tck.monitor,server\"," "\"label\": \"charmonitor\"}, {\"filename\": \"pty:/dev/pts/158\"," "\"label\": \"charserial0\"}], \"id\": \"libvirt-3\"}", "{\"return\":[{\"filename\":" "\"unix:/home/berrange/.libvirt/qemu/lib/tck.monitor,server\"," "\"label\":\"charmonitor\"},{\"filename\":\"pty:/dev/pts/158\"," "\"label\":\"charserial0\"}],\"id\":\"libvirt-3\"}"); DO_TEST_PARSE("VeryHard", "{\"return\":[{\"name\":\"quit\"},{\"name\":" "\"eject\"},{\"name\":\"change\"},{\"name\":\"screendump\"}," "{\"name\":\"stop\"},{\"name\":\"cont\"},{\"name\":" "\"system_reset\"},{\"name\":\"system_powerdown\"}," "{\"name\":\"device_add\"},{\"name\":\"device_del\"}," "{\"name\":\"cpu\"},{\"name\":\"memsave\"},{\"name\":" "\"pmemsave\"},{\"name\":\"migrate\"},{\"name\":" "\"migrate_cancel\"},{\"name\":\"migrate_set_speed\"}," "{\"name\":\"client_migrate_info\"},{\"name\":" "\"migrate_set_downtime\"},{\"name\":\"netdev_add\"}," "{\"name\":\"netdev_del\"},{\"name\":\"block_resize\"}," "{\"name\":\"balloon\"},{\"name\":\"set_link\"},{\"name\":" "\"getfd\"},{\"name\":\"closefd\"},{\"name\":\"block_passwd\"}," "{\"name\":\"set_password\"},{\"name\":\"expire_password\"}," "{\"name\":\"qmp_capabilities\"},{\"name\":" "\"human-monitor-command\"},{\"name\":\"query-version\"}," "{\"name\":\"query-commands\"},{\"name\":\"query-chardev\"}," "{\"name\":\"query-block\"},{\"name\":\"query-blockstats\"}," "{\"name\":\"query-cpus\"},{\"name\":\"query-pci\"},{\"name\":" "\"query-kvm\"},{\"name\":\"query-status\"},{\"name\":" "\"query-mice\"},{\"name\":\"query-vnc\"},{\"name\":" "\"query-spice\"},{\"name\":\"query-name\"},{\"name\":" "\"query-uuid\"},{\"name\":\"query-migrate\"},{\"name\":" "\"query-balloon\"}],\"id\":\"libvirt-2\"}", NULL); DO_TEST_FULL("add and remove", AddRemove, "{\"name\": \"sample\", \"value\": true}", "{\"value\":true,\"newname\":\"foo\"}", true); DO_TEST_FULL("add and remove", AddRemove, "[ 1 ]", NULL, false); DO_TEST_FULL("copy and free", Copy, "{\"return\": [{\"name\": \"quit\"}, {\"name\": \"eject\"}," "{\"name\": \"change\"}, {\"name\": \"screendump\"}," "{\"name\": \"stop\"}, {\"name\": \"cont\"}, {\"name\": " "\"system_reset\"}, {\"name\": \"system_powerdown\"}, " "{\"name\": \"device_add\"}, {\"name\": \"device_del\"}, " "{\"name\": \"cpu\"}, {\"name\": \"memsave\"}, {\"name\": " "\"pmemsave\"}, {\"name\": \"migrate\"}, {\"name\": " "\"migrate_cancel\"}, {\"name\": \"migrate_set_speed\"}," "{\"name\": \"client_migrate_info\"}, {\"name\": " "\"migrate_set_downtime\"}, {\"name\": \"netdev_add\"}, " "{\"name\": \"netdev_del\"}, {\"name\": \"block_resize\"}," "{\"name\": \"balloon\"}, {\"name\": \"set_link\"}, {\"name\":" "\"getfd\"}, {\"name\": \"closefd\"}, {\"name\": \"block_passwd\"}," "{\"name\": \"set_password\"}, {\"name\": \"expire_password\"}," "{\"name\": \"qmp_capabilities\"}, {\"name\": " "\"human-monitor-command\"}, {\"name\": \"query-version\"}," "{\"name\": \"query-commands\"}, {\"name\": \"query-chardev\"}," "{\"name\": \"query-block\"}, {\"name\": \"query-blockstats\"}, " "{\"name\": \"query-cpus\"}, {\"name\": \"query-pci\"}, {\"name\":" "\"query-kvm\"}, {\"name\": \"query-status\"}, {\"name\": " "\"query-mice\"}, {\"name\": \"query-vnc\"}, {\"name\": " "\"query-spice\"}, {\"name\": \"query-name\"}, {\"name\": " "\"query-uuid\"}, {\"name\": \"query-migrate\"}, {\"name\": " "\"query-balloon\"}], \"id\": \"libvirt-2\"}", NULL, true); DO_TEST_PARSE("almost nothing", "[]", NULL); DO_TEST_PARSE_FAIL("nothing", ""); DO_TEST_PARSE("number without garbage", "[ 234545 ]", "[234545]"); DO_TEST_PARSE_FAIL("number with garbage", "[ 2345b45 ]"); DO_TEST_PARSE("float without garbage", "[ 1.024e19 ]", "[1.024e19]"); DO_TEST_PARSE_FAIL("float with garbage", "[ 0.0314159ee+100 ]"); DO_TEST_PARSE("string", "[ \"The meaning of life\" ]", "[\"The meaning of life\"]"); DO_TEST_PARSE_FAIL("unterminated string", "[ \"The meaning of lif ]"); DO_TEST_PARSE("integer", "1", NULL); DO_TEST_PARSE("boolean", "true", NULL); DO_TEST_PARSE("null", "null", NULL); DO_TEST_PARSE("escaping symbols", "[\"\\\"\\t\\n\\\\\"]", NULL); DO_TEST_PARSE("escaped strings", "[\"{\\\"blurb\\\":\\\"test\\\"}\"]", NULL); DO_TEST_PARSE_FAIL("incomplete keyword", "tr"); DO_TEST_PARSE_FAIL("overdone keyword", "[ truest ]"); DO_TEST_PARSE_FAIL("unknown keyword", "huh"); DO_TEST_PARSE_FAIL("comments", "[ /* nope */\n1 // not this either\n]"); DO_TEST_PARSE_FAIL("trailing garbage", "[] []"); DO_TEST_PARSE_FAIL("list without array", "1, 1"); DO_TEST_PARSE_FAIL("parser abuse", "1] [2"); DO_TEST_PARSE_FAIL("invalid UTF-8", "\"\x80\""); DO_TEST_PARSE_FAIL("object with numeric keys", "{ 1:1, 2:1, 3:2 }"); DO_TEST_PARSE_FAIL("unterminated object", "{ \"1\":1, \"2\":1, \"3\":2"); DO_TEST_PARSE_FAIL("unterminated array of objects", "[ {\"name\": \"John\"}, {\"name\": \"Paul\"}, "); DO_TEST_PARSE_FAIL("array of an object with an array as a key", "[ {[\"key1\", \"key2\"]: \"value\"} ]"); DO_TEST_PARSE_FAIL("object with unterminated key", "{ \"key:7 }"); DO_TEST_PARSE_FAIL("duplicate key", "{ \"a\": 1, \"a\": 1 }"); DO_TEST_FULL("lookup on array", Lookup, "[ 1 ]", NULL, false); DO_TEST_FULL("lookup on string", Lookup, "\"str\"", NULL, false); DO_TEST_FULL("lookup on integer", Lookup, "1", NULL, false); DO_TEST_FULL("lookup with missing key", Lookup, "{ }", NULL, false); DO_TEST_FULL("lookup with wrong type", Lookup, "{ \"a\": 1, \"b\": \"str\", \"c\": [], \"d\": {} }", NULL, false); DO_TEST_FULL("lookup with correct type", Lookup, "{ \"a\": {}, \"b\": 1, \"c\": \"str\", \"d\": [] }", NULL, true); DO_TEST_FULL("create object with nested json in attribute", EscapeObj, NULL, NULL, true); DO_TEST_FULL("stealing of attributes while creating objects", ObjectFormatSteal, NULL, NULL, true); #define DO_TEST_DEFLATTEN(name, pass) \ DO_TEST_FULL(name, Deflatten, name, NULL, pass) DO_TEST_DEFLATTEN("unflattened", true); DO_TEST_DEFLATTEN("basic-file", true); DO_TEST_DEFLATTEN("basic-generic", true); DO_TEST_DEFLATTEN("deep-file", true); DO_TEST_DEFLATTEN("deep-generic", true); DO_TEST_DEFLATTEN("nested", true); DO_TEST_DEFLATTEN("double-key", false); DO_TEST_DEFLATTEN("concat", true); DO_TEST_DEFLATTEN("concat-double-key", false); DO_TEST_DEFLATTEN("qemu-sheepdog", true); return (ret == 0) ? EXIT_SUCCESS : EXIT_FAILURE; } VIR_TEST_MAIN(mymain)