libvirt/scripts/check-symfile.py
Andrea Bolognani 2757e91c2b scripts: Make check-symfile.py work on alpha
The script expects each of the symbols that it looks for to
be in one of three sections, which in nm(1) are described as
follows:

  T - The symbol is in the text (code) section.
  B - The symbol is in the BSS data section. This section
      typically contains zero-initialized or uninitialized
      data, although the exact behavior is system dependent.
  D - The symbol is in the initialized data section.

When building on alpha, however, some of the symbols show up
in one of two additional sections, specifically:

  S - The symbol is in an uninitialized or zero-initialized
      data section for small objects.
  G - The symbol is in an initialized data section for small
      objects.

In other words, S is the same as B and G is the same as D,
except with some optimization for small objects that for some
reason is applied on alpha but not on other architectures.

I have confirmed that, for all the symbols that the script
complained about being missing on alpha, the section is the
expected one, that is, symbols that are reported as B on x86
are reported as S on alpha, and symbols that are reported as
D on x86 are reported as G on alpha.

Note that, while the B section doesn't seem to be used at all
on alpha, at least in our case, the D section still is.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
2024-01-30 18:05:15 +01:00

79 lines
2.0 KiB
Python
Executable File

#!/usr/bin/env python3
#
# Copyright (C) 2012-2019 Red Hat, Inc.
#
# This library is free software; you can redistribute it and/or
# modify it under the terms of the GNU Lesser General Public
# License as published by the Free Software Foundation; either
# version 2.1 of the License, or (at your option) any later version.
#
# This library is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
# Lesser General Public License for more details.
#
# You should have received a copy of the GNU Lesser General Public
# License along with this library. If not, see
# <http://www.gnu.org/licenses/>.
import re
import subprocess
import sys
if len(sys.argv) < 3:
print("syntax: %s SYMFILE ELFLIB(S)" % sys.argv[0], file=sys.stderr)
symfile = sys.argv[1]
elflibs = sys.argv[2:]
wantsyms = {}
gotsyms = {}
ret = 0
with open(symfile, "r") as fh:
for line in fh:
line = line.strip()
if "{" in line:
continue
if "}" in line:
continue
if line in ["global:", "local:"]:
continue
if line == "":
continue
if line[0] == '#':
continue
if "*" in line:
continue
line = line.strip(";")
if line in wantsyms:
print("Symbol %s is listed twice" % line, file=sys.stderr)
ret = 1
else:
wantsyms[line] = True
for elflib in elflibs:
nm = subprocess.Popen(["nm", elflib], shell=False,
stdout=subprocess.PIPE).stdout
for line in nm:
line = line.decode("utf-8")
symmatch = re.search(r'''^\S+\s(?:[TBSDG])\s(\S+)\s*$''', line)
if symmatch is None:
continue
gotsyms[symmatch.group(1)] = True
for sym in wantsyms.keys():
if sym in gotsyms:
continue
print("Expected symbol '%s' is not in ELF library" % sym, file=sys.stderr)
ret = 1
sys.exit(ret)