libvirt/tests/sysinfotest.c
Michal Privoznik bd11c753f3 virsysinfo: Calculate OEM string index better
As can be seen in earlier commits, there can be two OEM strings
with the same index. But since our parser
(virSysinfoParseOEMStrings()) doesn't expect that, it increments
index in each run and thus skips over these strings.
Fortunately, we have the right index at hand - we're just
skipping over it in a loop. Just reconstruct the index back
inside the loop.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
2024-07-25 16:51:17 +02:00

157 lines
4.5 KiB
C

/*
* sysinfotest.c: Testcase(s) for virSysinfoRead
*
* Copyright (C) 2013 Red Hat, Inc.
* Copyright IBM Corp. 2012
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2.1 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this library. If not, see
* <http://www.gnu.org/licenses/>.
*/
#include <config.h>
#include <unistd.h>
#include "internal.h"
#include "virbuffer.h"
#include "virsysinfo.h"
#include "testutils.h"
#include "virfile.h"
#define LIBVIRT_VIRSYSINFOPRIV_H_ALLOW
#include "virsysinfopriv.h"
#define LIBVIRT_VIRCOMMANDPRIV_H_ALLOW
#include "vircommandpriv.h"
#define VIR_FROM_THIS VIR_FROM_NONE
struct testSysinfoData {
const char *name; /* test name, also base name for result files */
virSysinfoDef *(*func)(void); /* sysinfo gathering function */
};
static void
testDMIDecodeDryRun(const char *const*args G_GNUC_UNUSED,
const char *const*env G_GNUC_UNUSED,
const char *input G_GNUC_UNUSED,
char **output,
char **error,
int *status,
void *opaque)
{
const char *sysinfo = opaque;
if (STREQ_NULLABLE(args[1], "--dump") &&
STREQ_NULLABLE(args[2], "--oem-string")) {
if (!args[3]) {
*error = g_strdup("dmidecode: option '--oem-string' requires an argument");
*status = EXIT_FAILURE;
return;
}
if (STREQ(args[3], "2")) {
*output = g_strdup("Some valid OEM string\n");
*error = g_strdup_printf("No OEM string number %s", args[3]);
return;
} else if (STREQ(args[3], "3")) {
*output = g_strdup("Ha ha ha try parsing\\n\n"
" String 3: this correctly\n"
" String 4:then\n");
} else {
*error = g_strdup_printf("No OEM string number %s", args[3]);
*status = EXIT_FAILURE;
return;
}
} else {
if (virFileReadAll(sysinfo, 10 * 1024 * 1024, output) < 0) {
*error = g_strdup(virGetLastErrorMessage());
*status = EXIT_FAILURE;
return;
}
}
*error = g_strdup("");
*status = 0;
}
static int
testSysinfo(const void *data)
{
const struct testSysinfoData *testdata = data;
const char *sysfsActualData;
g_autoptr(virSysinfoDef) ret = NULL;
g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
g_autofree char *sysinfo = NULL;
g_autofree char *cpuinfo = NULL;
g_autofree char *expected = NULL;
g_autoptr(virCommandDryRunToken) dryRunToken = virCommandDryRunTokenNew();
sysinfo = g_strdup_printf("%s/sysinfodata/%ssysinfo.data", abs_srcdir, testdata->name);
cpuinfo = g_strdup_printf("%s/sysinfodata/%scpuinfo.data", abs_srcdir, testdata->name);
expected = g_strdup_printf("%s/sysinfodata/%ssysinfo.expect", abs_srcdir, testdata->name);
virCommandSetDryRun(dryRunToken, NULL, false, false, testDMIDecodeDryRun, sysinfo);
virSysinfoSetup(sysinfo, cpuinfo);
ret = testdata->func();
if (!ret)
return -1;
if (virSysinfoFormat(&buf, ret) < 0)
return -1;
if (!(sysfsActualData = virBufferCurrentContent(&buf)))
return -1;
return virTestCompareToFile(sysfsActualData, expected);
}
#define TEST(name, func) \
do { \
struct testSysinfoData data = { name, func }; \
if (virTestRun(name " sysinfo", testSysinfo, &data) < 0) \
ret = EXIT_FAILURE; \
} while (0)
static int
mymain(void)
{
int ret = EXIT_SUCCESS;
TEST("s390", virSysinfoReadS390);
TEST("s390-freq", virSysinfoReadS390);
TEST("ppc", virSysinfoReadPPC);
TEST("x86", virSysinfoReadDMI);
TEST("arm", virSysinfoReadARM);
TEST("arm-rpi2", virSysinfoReadARM);
TEST("aarch64", virSysinfoReadARM);
TEST("aarch64-moonshot", virSysinfoReadARM);
TEST("aarch64-gigabyte", virSysinfoReadARM);
TEST("aarch64-hpe-apollo", virSysinfoReadARM);
return ret;
}
#undef TEST
#undef TEST_FULL
VIR_TEST_MAIN(mymain)