libvirt/src/util
Daniel P. Berrange 68b19542ec Use explicit boolean comparison in OOM check
GCC 7 gets upset by

   if (!tmp && (size * count))

warning

  util/viralloc.c: In function 'virReallocN':
  util/viralloc.c:246:23: error: '*' in boolean context, suggest '&&' instead [-Werror=int-in-bool-context]
     if (!tmp && (size * count)) {
                 ~~~~~~^~~~~~~~

Keep it happy by adding != 0 to the right hand expression
so it realizes we really are wanting to treat the result
of the arithmetic expression as a boolean

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
(cherry picked from commit 09db97d3cb)
2017-08-04 15:58:05 -04:00
..
iohelper.c More usage of virGetLastErrorMessage 2016-05-19 15:17:03 -04:00
keymaps.csv
viralloc.c Use explicit boolean comparison in OOM check 2017-08-04 15:58:05 -04:00
viralloc.h util: Remove need for STATIC_ANALYSIS check 2016-05-19 16:30:04 -04:00
virarch.c
virarch.h util: Add space before comment end marker 2015-09-14 11:32:44 +02:00
viratomic.c
viratomic.h
viraudit.c audit: use bool for audit log choice 2014-10-29 09:55:09 -06:00
viraudit.h audit: use bool for audit log choice 2014-10-29 09:55:09 -06:00
virauth.c Remove unnecessary curly brackets in src/util/ 2014-11-14 17:13:35 +01:00
virauth.h
virauthconfig.c util: Fix broken syntax-check 2016-06-16 06:17:58 -04:00
virauthconfig.h
virbitmap.c util: bitmap: Mention the size == 0 handling 2016-07-09 11:03:32 +02:00
virbitmap.h Introduce virBitmapParseUnlimited 2016-06-20 12:09:52 +02:00
virbuffer.c build: cleanup GCC < 4.6 -Wlogical-op workaround 2016-04-11 12:09:11 +02:00
virbuffer.h util: buffer: Add support for adding text blocks with indentation 2015-03-25 15:42:52 +01:00
vircgroup.c Avoid hidden cgroup mount points 2017-08-03 17:19:37 -04:00
vircgroup.h util: Extract and rename qemuDomainDelCgroupForThread to virCgroupDelThread 2016-08-24 15:44:47 -04:00
vircgrouppriv.h tests: Add tests for virCgroupDetectMounts 2015-03-18 09:53:24 +01:00
virclosecallbacks.c util: fix crash in virClassIsDerivedFrom for CloseCallbacks objects 2017-05-10 15:42:45 -04:00
virclosecallbacks.h conf: Split virDomainObjList into a separate file 2015-11-30 13:55:10 +01:00
vircommand.c virCommandExec: Report error if execve fails 2016-07-12 13:34:35 +02:00
vircommand.h util: Add exitstatus parameter to virCommandRunRegex 2016-05-18 08:29:24 -04:00
vircommandpriv.h
virconf.c Use ATTRIBUTE_FALLTHROUGH 2017-08-04 15:57:15 -04:00
virconf.h util: conf: Rename VIR_CONF_{U,}LONG -> VIR_CONF_{U,}LLONG 2016-07-18 15:49:57 +02:00
vircrypto.c Fix padding of encrypted data 2017-05-30 18:27:30 -04:00
vircrypto.h util: Introduce virCryptoGenerateRandom 2016-05-20 11:09:05 -04:00
virdbus.c dbus: Don't unref NULL messages 2016-02-11 11:35:02 +01:00
virdbus.h dbus: Don't unref NULL messages 2016-02-11 11:35:02 +01:00
virdbuspriv.h build: fix build when not using dbus 2014-11-20 08:48:19 -07:00
virdnsmasq.c dnsmasq: disable IPv6 default gateway in RA for isolated networks 2016-07-13 13:49:03 +03:00
virdnsmasq.h dnsmasq: disable IPv6 default gateway in RA for isolated networks 2016-07-13 13:49:03 +03:00
virebtables.c
virebtables.h
virendian.h util: Introduce virReadBufInt16LE and virReadBufInt16BE 2016-06-24 13:23:02 -04:00
virerror.c util: Fix virGetLastErrorMessage to return proper error when 'err' is NULL 2016-05-11 20:10:35 +02:00
virerror.h Introduce virErrorCopyNew 2015-07-10 11:47:13 +02:00
virevent.c docs: event impl. registration before hypervisor connection 2015-10-15 19:50:58 -04:00
virevent.h
vireventpoll.c util: remove redundant comments 2016-06-16 13:09:19 -04:00
vireventpoll.h
virfile.c Prohibit opendir in syntax-check 2016-06-24 14:20:57 +02:00
virfile.h Introduce virDirOpenQuiet 2016-06-24 14:20:57 +02:00
virfirewall.c dbus: Don't unref NULL messages 2016-02-11 11:35:02 +01:00
virfirewall.h test: fix nwfilter tests following changes in virfirewall.c 2014-12-22 16:57:21 -05:00
virfirewallpriv.h
virfirmware.c driver config: Introduce virFirmware object 2016-06-13 14:13:16 -06:00
virfirmware.h driver config: Introduce virFirmware object 2016-06-13 14:13:16 -06:00
virgettext.c util: Add virGettextInitialize, convert the code 2016-04-14 13:22:40 -04:00
virgettext.h util: Add virGettextInitialize, convert the code 2016-04-14 13:22:40 -04:00
virgic.c gic: Introduce virGICVersion enumeration 2016-02-16 14:58:58 +01:00
virgic.h qemu: Probe GIC capabilities 2016-04-20 12:46:48 +02:00
virhash.c util: Refactor virHashForEach so it returns as soon as an iterator fails 2016-02-17 12:46:34 +01:00
virhash.h util: Refactor virHashForEach so it returns as soon as an iterator fails 2016-02-17 12:46:34 +01:00
virhashcode.c Use ATTRIBUTE_FALLTHROUGH 2017-08-04 15:57:15 -04:00
virhashcode.h headers: Remove unnecessary keyword extern from function declaration 2016-05-11 09:06:32 +02:00
virhook.c libxl: add hooks support 2016-08-02 14:20:31 +02:00
virhook.h libxl: add hooks support 2016-08-02 14:20:31 +02:00
virhostcpu.c util: hostcpu: Drop obsolete compatibility code 2016-07-11 11:12:52 +02:00
virhostcpu.h Rename kvmGetMaxVCPUs() to virHostCPUGetKVMMaxVCPUs() 2016-06-24 18:52:21 +02:00
virhostcpupriv.h nodeinfo: move host CPU APIs out into virhostcpu.c file 2016-06-09 18:31:11 +01:00
virhostdev.c More usage of virGetLastErrorMessage 2016-05-19 15:17:03 -04:00
virhostdev.h hostdev: Rename virHostdevUpdateDomainActiveDevices() 2015-10-26 13:50:35 +01:00
virhostmem.c nodeinfo: move host memory APIs out into virhostmem file 2016-06-09 18:43:18 +01:00
virhostmem.h nodeinfo: move host memory APIs out into virhostmem file 2016-06-09 18:43:18 +01:00
viridentity.c util: identity: Harden virIdentitySetCurrent() 2015-03-25 13:37:41 +01:00
viridentity.h Add typesafe APIs for virIdentity attributes 2014-09-24 15:29:22 +01:00
virinitctl.c Add support for /run/initctl 2014-10-22 13:09:49 +01:00
virinitctl.h
viriptables.c Drop paths.h include 2016-03-18 09:43:45 +01:00
viriptables.h
viriscsi.c util: Introduce virISCSINodeNew 2016-07-28 08:27:13 -04:00
viriscsi.h util: Introduce virISCSINodeNew 2016-07-28 08:27:13 -04:00
virjson.c util: json: Make first argument of virJSONValueCopy const 2016-07-27 13:24:20 +02:00
virjson.h util: json: Make first argument of virJSONValueCopy const 2016-07-27 13:24:20 +02:00
virkeycode-mapgen.py
virkeycode.c
virkeycode.h
virkeyfile.c
virkeyfile.h
virkmod.c Typos: Get rid of dependan(t|cies) 2015-04-02 16:05:32 +02:00
virkmod.h
virlease.c nss: Implement _nss_libvirt_gethostbyname3_r 2016-03-18 17:29:53 +01:00
virlease.h Export virLease* functions for leases file handling 2016-03-18 17:29:53 +01:00
virlockspace.c virJSONValueArraySize: return ssize_t 2015-10-09 15:25:08 +02:00
virlockspace.h
virlog.c virlog: Introduce virLogFilterListFree 2016-07-04 16:44:58 +02:00
virlog.h virlog: Introduce virLogFilterListFree 2016-07-04 16:44:58 +02:00
virmacaddr.c util: Functions to update host network device's multicast filter 2014-10-28 14:14:25 -04:00
virmacaddr.h util: Functions to update host network device's multicast filter 2014-10-28 14:14:25 -04:00
virnetdev.c util: new files virnetdevip.[ch] for IP-related netdev functions 2016-06-26 19:33:09 -04:00
virnetdev.h Clean up after virNetDevIP creation 2016-06-27 12:42:48 +02:00
virnetdevbandwidth.c virnetdevbandwidth: Compute quantum value 2016-02-05 16:43:19 +01:00
virnetdevbandwidth.h virNetDevBandwidthUpdateRate: turn class_id into integer 2015-08-11 16:10:32 +02:00
virnetdevbridge.c Use ATTRIBUTE_FALLTHROUGH 2017-08-04 15:57:15 -04:00
virnetdevbridge.h util: functions to manage bridge fdb (forwarding database) 2014-12-08 14:39:12 -05:00
virnetdevip.c util: support setting peer for virNetDevIPInfo addresses 2016-07-01 21:13:31 -04:00
virnetdevip.h conf: allow setting peer address in <ip> element of <interface> 2016-07-01 21:13:30 -04:00
virnetdevmacvlan.c virNetDevMacVLanCreateWithVPortProfile: Drop @ret 2016-08-10 16:56:45 +02:00
virnetdevmacvlan.h util: set vlan tag for macvtap passthrough mode on SRIOV VFs 2016-05-10 14:04:19 -04:00
virnetdevmidonet.c util: functions to support binding/unbinding midonet virtualports 2015-03-17 12:56:37 -04:00
virnetdevmidonet.h util: functions to support binding/unbinding midonet virtualports 2015-03-17 12:56:37 -04:00
virnetdevopenvswitch.c virnetdevopenvswitch: Don't call strlen() twice on the same string 2016-01-27 13:01:24 +01:00
virnetdevopenvswitch.h
virnetdevtap.c util: fix build in virNetDevTapGetRealDeviceName 2016-06-24 21:41:43 +03:00
virnetdevtap.h Change int to size_t in size var for tap/vhost FDs 2015-01-15 11:07:13 +00:00
virnetdevveth.c Cleanup "/sys/class/net" usage 2015-04-15 16:43:28 +02:00
virnetdevveth.h
virnetdevvlan.c
virnetdevvlan.h
virnetdevvportprofile.c util: move virNetDevLinkDump to virnetlink.c 2016-06-26 19:33:07 -04:00
virnetdevvportprofile.h util: functions to support binding/unbinding midonet virtualports 2015-03-17 12:56:37 -04:00
virnetlink.c util: move virNetDevLinkDump to virnetlink.c 2016-06-26 19:33:07 -04:00
virnetlink.h util: move virNetDevLinkDump to virnetlink.c 2016-06-26 19:33:07 -04:00
virnodesuspend.c
virnodesuspend.h
virnuma.c Use virDirOpenIfExists 2016-06-24 14:20:57 +02:00
virnuma.h util: Add virNumaGetHostNodeset 2014-12-16 11:15:27 +01:00
virobject.c util: Make the virDomainListFree helper more universal 2015-05-11 08:28:53 +02:00
virobject.h util: Make the virDomainListFree helper more universal 2015-05-11 08:28:53 +02:00
virpci.c Use virDirOpenQuiet 2016-06-24 14:20:57 +02:00
virpci.h Change virDevicePCIAddress to virPCIDeviceAddress 2016-05-02 15:46:23 +02:00
virperf.c virPerfEventIsEnabled: Don't crash on shut off domains 2016-06-03 10:52:16 +02:00
virperf.h Drop virPerfGetEventFd 2016-06-03 10:52:16 +02:00
virpidfile.c network: escape quotes for dsmasq conf contents 2015-06-09 13:56:00 -04:00
virpidfile.h util: Introduce virPidFileForceCleanupPath 2014-11-03 16:43:23 +01:00
virpolkit.c util: polkit: Fix polkit agent startup 2016-05-09 13:54:52 +02:00
virpolkit.h util: Introduce API's for Polkit text authentication 2016-03-01 06:50:16 -05:00
virportallocator.c Introduce virBitmapIsBitSet 2015-03-13 15:31:33 +01:00
virportallocator.h util: Allow port allocator to skip bind() check 2014-09-11 15:40:14 -06:00
virprobe.h Log dtrace/systemd probes at INFO level instead of DEBUG 2015-01-15 11:07:13 +00:00
virprocess.c Use virDirOpen 2016-06-24 14:20:57 +02:00
virprocess.h process: Add virProcessGetMaxMemLock() 2015-12-17 10:12:47 +01:00
virqemu.c virqemu: Reflect return type of virJSONValueArraySize() 2016-08-04 15:30:38 +02:00
virqemu.h qemu: command: Add infrastructure for object specified disk sources 2016-07-27 13:33:10 +02:00
virrandom.c util: Perform proper virRandomBytes return value checking 2016-06-07 10:18:36 -04:00
virrandom.h util: Introduce virRandomBytes 2016-04-06 20:27:09 -04:00
virrotatingfile.c rotatingfile: mark log files as close-on-exec 2015-12-04 18:18:39 +00:00
virrotatingfile.h util: Avoid variable named 'truncate' shadowing global declaration 2015-11-30 15:32:47 +01:00
virscsi.c Use virDirOpen 2016-06-24 14:20:57 +02:00
virscsi.h Convert SCSI logical unit from unsigned int to unsigned long long 2015-06-22 16:03:33 -04:00
virseclabel.c virseclabel: Resolve Coverity FORWARD_NULL issue 2014-07-14 05:44:20 -04:00
virseclabel.h virSecurityDeviceLabelDef: substitute 'norelabel' with 'relabel' 2014-07-11 10:36:02 +02:00
virsecret.c util: Introduce virSecretLookupFormatSecret 2016-06-23 12:30:28 -04:00
virsecret.h util: Introduce virSecretLookupFormatSecret 2016-06-23 12:30:28 -04:00
virsexpr.c Remove unnecessary curly brackets in src/util/ 2014-11-14 17:13:35 +01:00
virsexpr.h
virsocketaddr.c util: allow calling virSocketAddrGetIPPrefix with NULL netmask or address 2016-06-26 19:33:08 -04:00
virsocketaddr.h lxc: use correct prefix when setting veth IP address 2016-06-26 19:33:08 -04:00
virstats.c maint: clean up _virDomainInterfaceStats 2014-09-17 11:28:48 -06:00
virstats.h headers: Remove unnecessary keyword extern from function declaration 2016-05-11 09:06:32 +02:00
virstorageencryption.c virStorageEncryptionSecretFree: Don't leak secret lookup definition 2016-07-11 14:21:01 +02:00
virstorageencryption.h encryption: Add <cipher> and <ivgen> to encryption 2016-07-01 15:46:57 -04:00
virstoragefile.c qemu: Fix crash hot plugging luks volume 2016-08-20 08:21:19 -04:00
virstoragefile.h storage: remove "luks" storage volume type 2016-07-27 18:59:15 +01:00
virstring.c util: Make virStringArrayHasString() const-correct 2016-08-16 19:32:58 +02:00
virstring.h util: Make virStringArrayHasString() const-correct 2016-08-16 19:32:58 +02:00
virsysinfo.c build: cleanup GCC < 4.6 -Wlogical-op workaround 2016-04-11 12:09:11 +02:00
virsysinfo.h virSysinfo: Introduce SMBIOS type 2 support 2015-06-18 10:10:26 +02:00
virsystemd.c virsystemd: Fix error check 2016-08-08 08:15:59 +02:00
virsystemd.h systemd: Modernize machine naming 2016-02-05 16:11:50 +01:00
virthread.c virCondWaitUntil: calculate timespec correctly 2015-04-16 15:39:22 +02:00
virthread.h virThread: Set thread job 2015-03-25 10:00:53 +01:00
virthreadjob.c Add support for tracking thread jobs 2015-03-25 10:00:53 +01:00
virthreadjob.h Add support for tracking thread jobs 2015-03-25 10:00:53 +01:00
virthreadpool.c admin: Introduce virAdmServerSetThreadPoolParameters 2016-04-18 17:07:46 +02:00
virthreadpool.h admin: Introduce virAdmServerSetThreadPoolParameters 2016-04-18 17:07:46 +02:00
virtime.c Add functions for handling exponential backoff loops. 2016-04-15 16:54:28 +01:00
virtime.h Add functions for handling exponential backoff loops. 2016-04-15 16:54:28 +01:00
virtpm.c tpm: adapt sysfs cancel path for new TPM driver 2015-11-17 20:52:13 -05:00
virtpm.h
virtypedparam.c Libvirt: virTypedParamsValidate: Fix detection of multiple parameters 2016-04-18 15:57:20 +02:00
virtypedparam.h Turn 1<<31 into 1U<<31 2016-05-28 13:49:14 +02:00
viruri.c uri: convert to typesafe virConf accessors 2016-07-12 09:58:21 +01:00
viruri.h livirt: Move URI alias matching to util 2015-11-30 09:44:28 +01:00
virusb.c Use virDirOpen 2016-06-24 14:20:57 +02:00
virusb.h
virutil.c Use ATTRIBUTE_FALLTHROUGH 2017-08-04 15:57:15 -04:00
virutil.h util: add function for looking up the user shell 2016-06-09 18:44:52 +01:00
viruuid.c util: factor out reading file into preallocated buffer 2016-05-03 08:58:30 -04:00
viruuid.h
virxdrdefs.h Unify int types handling in protocol files 2016-01-11 19:56:06 +03:00
virxml.c util: new function virXMLNodeSanitizeNamespaces() 2016-07-01 13:04:49 -04:00
virxml.h util: new function virXMLNodeSanitizeNamespaces() 2016-07-01 13:04:49 -04:00