External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 05:35:25 +00:00
Code Issues Packages Projects Releases Wiki Activity
v4.1-maint
libvirt/tools
History
Michal Privoznik 846d3b5874 vshCommandOpt: Do more checking if skipChecks is set 
Currently if cmd->skipChecks is set (done only from completers)
some basic checks are skipped because we're working over
partially parsed command. See a26ff63ae4 for more detailed
explanation. Anyway, the referenced commit was too aggressive in
disabling checks and effectively returned success even in clear
case of failure. For instance:

  # domif-getlink --interface <TAB><TAB>

causes virshDomainInterfaceCompleter() to be called, which calls
virshDomainGetXML() which eventually calls
vshCommandOptStringReq(.., name = "domain"); The --domain
argument is required for the command and if not present -1 should
be returned to tell the caller the argument was not found. Well,
zero is returned meaning the argument was not found but it's not
required either.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
2018-02-28 10:36:24 +01:00
..
bash-completion tools: Provide bash autompletion file 2018-01-11 18:53:04 +01:00
nss Remove backslash alignment attempts 2017-11-03 13:24:12 +01:00
wireshark Remove backslash alignment attempts 2017-11-03 13:24:12 +01:00
libvirt_win_icon_16x16.ico Move virsh into tools/ directory 2009-09-21 14:41:45 +01:00
libvirt_win_icon_32x32.ico Move virsh into tools/ directory 2009-09-21 14:41:45 +01:00
libvirt_win_icon_48x48.ico Move virsh into tools/ directory 2009-09-21 14:41:45 +01:00
libvirt_win_icon_64x64.ico Move virsh into tools/ directory 2009-09-21 14:41:45 +01:00
libvirt-guests.init.in Use https:// links for most sites 2017-10-16 10:22:34 +01:00
libvirt-guests.service.in Use https:// links for most sites 2017-10-16 10:22:34 +01:00
libvirt-guests.sh.in tools: avoid text spilling into variables 2018-02-23 13:03:56 +01:00
libvirt-guests.sysconf tools: Fix docs in libvirt-guests configuration file 2017-08-21 16:12:42 +02:00
Makefile.am build: passing the "-z defs" linker flag to prevent undefined symbols 2018-02-09 11:05:10 +00:00
virsh_win_icon.rc Move virsh into tools/ directory 2009-09-21 14:41:45 +01:00
virsh-completer.c virshDomainNameCompleter: Prune accepted flags 2018-01-31 15:41:51 +01:00
virsh-completer.h virsh: Introduce virshSnapshotNameCompleter 2018-01-24 13:51:23 +01:00
virsh-console.c tools: Introduce new client generic module vsh 2015-08-14 15:45:44 +02:00
virsh-console.h tools: Introduce new client generic module vsh 2015-08-14 15:45:44 +02:00
virsh-domain-monitor.c virsh: Introduce virshDomainInterfaceCompleter 2018-01-11 18:53:04 +01:00
virsh-domain-monitor.h tools: Introduce new client generic module vsh 2015-08-14 15:45:44 +02:00
virsh-domain.c virsh: Fix internal naming of some blockjob commands 2018-02-19 15:25:00 +01:00
virsh-domain.h virsh-util: Move domain lookup helpers into virsh-util 2017-04-12 13:23:10 +02:00
virsh-edit.c Add ATTRIBUTE_FALLTHROUGH for switch cases without break 2017-02-23 10:11:16 +00:00
virsh-host.c util: Rename virBitmapDataToString to virBitmapDataFormat 2017-11-18 10:45:10 +01:00
virsh-host.h maint: fix up copyright notice inconsistencies 2012-09-20 16:30:55 -06:00
virsh-interface.c virsh: Introduce virshInterfaceNameCompleter 2018-01-24 13:51:21 +01:00
virsh-interface.h Remove backslash alignment attempts 2017-11-03 13:24:12 +01:00
virsh-network.c virsh: Introduce virshNetworkNameCompleter 2018-01-24 13:51:21 +01:00
virsh-network.h Remove backslash alignment attempts 2017-11-03 13:24:12 +01:00
virsh-nodedev.c virsh: Introduce virshNodeDeviceNameCompleter 2018-01-24 13:51:22 +01:00
virsh-nodedev.h maint: fix up copyright notice inconsistencies 2012-09-20 16:30:55 -06:00
virsh-nwfilter.c virsh: Introduce virshNWFilterNameCompleter 2018-01-24 13:51:22 +01:00
virsh-nwfilter.h Remove backslash alignment attempts 2017-11-03 13:24:12 +01:00
virsh-pool.c virsh: fixing segfault by pool autocompleter function. 2018-02-28 10:07:35 +01:00
virsh-pool.h Remove backslash alignment attempts 2017-11-03 13:24:12 +01:00
virsh-secret.c virsh: Introduce virshSecretUUIDCompleter 2018-01-24 13:51:23 +01:00
virsh-secret.h maint: fix up copyright notice inconsistencies 2012-09-20 16:30:55 -06:00
virsh-snapshot.c virsh: Introduce virshSnapshotNameCompleter 2018-01-24 13:51:23 +01:00
virsh-snapshot.h maint: fix up copyright notice inconsistencies 2012-09-20 16:30:55 -06:00
virsh-util.c virsh: Implement sparse stream to vol-upload 2017-05-18 07:42:13 +02:00
virsh-util.h virsh: Implement sparse stream to vol-upload 2017-05-18 07:42:13 +02:00
virsh-volume.c virsh: Introduce virshStorageVolNameCompleter 2018-01-24 13:51:19 +01:00
virsh-volume.h Remove backslash alignment attempts 2017-11-03 13:24:12 +01:00
virsh.c vsh: Introduce complete command 2018-01-11 18:53:04 +01:00
virsh.h virsh: Introduce virshStoragePoolNameCompleter 2018-01-24 13:49:56 +01:00
virsh.pod virsh: detach-disk: Add --print-xml switch 2018-02-14 16:04:46 +01:00
virt-admin-completer.c virt-admin: Introduce vshAdmServerCompleter 2018-01-11 18:53:04 +01:00
virt-admin-completer.h virt-admin: Introduce vshAdmServerCompleter 2018-01-11 18:53:04 +01:00
virt-admin.c virt-admin: Introduce vshAdmServerCompleter 2018-01-11 18:53:04 +01:00
virt-admin.h Revert "admin: Rename virAdmConnect to virAdmDaemon" 2015-12-21 10:07:59 +01:00
virt-admin.pod Use https:// links for most sites 2017-10-16 10:22:34 +01:00
virt-host-validate-bhyve.c virsh: Define multi line macros properly 2017-11-04 08:38:08 +01:00
virt-host-validate-bhyve.h virt-host-validate: add bhyve support 2017-03-11 21:22:58 +04:00
virt-host-validate-common.c virt-host-validate: Fix warning for IOMMU detection on PPC 2017-08-24 18:37:37 -04:00
virt-host-validate-common.h headers: Remove unnecessary keyword extern from function declaration 2016-05-11 09:06:32 +02:00
virt-host-validate-lxc.c virt-host-validate: require fuse for LXC if compiled in 2017-10-12 21:32:07 +02:00
virt-host-validate-lxc.h headers: Remove unnecessary keyword extern from function declaration 2016-05-11 09:06:32 +02:00
virt-host-validate-qemu.c tools: handle missing switch enum cases 2018-02-21 16:59:44 +00:00
virt-host-validate-qemu.h headers: Remove unnecessary keyword extern from function declaration 2016-05-11 09:06:32 +02:00
virt-host-validate.c virt-host-validate: add bhyve support 2017-03-11 21:22:58 +04:00
virt-host-validate.pod Use https:// links for most sites 2017-10-16 10:22:34 +01:00
virt-login-shell.c virstring: Unify string list function names 2016-11-25 13:54:05 +01:00
virt-login-shell.conf virt-login-shell: add ability to auto-detect shell from container 2016-06-10 11:03:02 +01:00
virt-login-shell.pod Use https:// links for most sites 2017-10-16 10:22:34 +01:00
virt-pki-validate.in fix regex to check CN from server certificate 2018-02-08 18:05:05 +01:00
virt-pki-validate.pod Use https:// links for most sites 2017-10-16 10:22:34 +01:00
virt-sanlock-cleanup.in build: Extract pod from source files 2016-04-25 15:40:43 +02:00
virt-sanlock-cleanup.pod Use https:// links for most sites 2017-10-16 10:22:34 +01:00
virt-xml-validate.in build: Extract pod from source files 2016-04-25 15:40:43 +02:00
virt-xml-validate.pod Use https:// links for most sites 2017-10-16 10:22:34 +01:00
vsh.c vshCommandOpt: Do more checking if skipChecks is set 2018-02-28 10:36:24 +01:00
vsh.h vsh: Drop redundant definition searches from vshCmd{def,Grp}Help 2018-01-25 16:20:27 +01:00