libvirt/tools
Michal Privoznik 01a2339e1f virsh-domain: Fix @ret handling in cmdSetmem and cmdSetmaxmem
These functions initialize @ret to true and only after something
fails either they call cleanup code (which consists only from
virshDomainFree()) and return false, or they set ret = false and
carry on (when the failure occurred close to cleanup code).

Switch them to the usual pattern in which ret is initialized to
failure, goto cleanup is used and ret is set to true only after
everything succeeded.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
2021-05-19 15:31:36 +02:00
..
bash-completion tools: Generate per-command bash completion script 2021-04-22 11:01:27 +02:00
nss meson: Fix build with -Dtest_coverage=true 2021-01-19 16:25:50 +01:00
wireshark Remove references to deleted Makefile.am 2021-04-13 11:21:00 +02:00
libvirt_recover_xattrs.sh tools: Fix dry run of libvirt_recover_xattrs.sh 2021-03-02 09:42:38 +01:00
libvirt_win_icon_16x16.ico
libvirt_win_icon_32x32.ico
libvirt_win_icon_48x48.ico
libvirt_win_icon_64x64.ico
libvirt-guests.service.in
libvirt-guests.sh.in libvirt-guests: Sync time for autostarted guests 2020-11-04 12:18:05 +01:00
libvirt-guests.sysconf libvirt-guests: Remove obsolete Windows comment 2020-12-07 10:38:44 +00:00
meson.build Fix spelling 2021-04-15 15:42:21 +02:00
virsh_win_icon.rc
virsh-backup.c virsh: limit completion of backup-{begin, dumpxml} to active domains 2020-09-14 15:52:40 +02:00
virsh-backup.h
virsh-checkpoint.c virshCheckpointListCollect: Do not pass NULL to qsort 2021-04-19 16:09:56 -04:00
virsh-checkpoint.h
virsh-completer-checkpoint.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virsh-completer-checkpoint.h
virsh-completer-domain.c virsh: Fix completion logic to guestvcpus command 2021-04-22 13:46:48 +02:00
virsh-completer-domain.h virsh: Add mountpoint completion to domfsfreeze/domfsthaw command 2021-04-22 13:46:44 +02:00
virsh-completer-host.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virsh-completer-host.h virsh: Add logical CPU IDs completion for nodecpustats command 2020-11-10 18:34:02 +01:00
virsh-completer-interface.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virsh-completer-interface.h virsh: Add interface mac completion to iface-name command 2020-11-10 18:34:11 +01:00
virsh-completer-network.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virsh-completer-network.h virsh: Add mac completion to net-dhcp-leases command 2020-11-10 18:34:23 +01:00
virsh-completer-nodedev.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virsh-completer-nodedev.h
virsh-completer-nwfilter.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virsh-completer-nwfilter.h
virsh-completer-pool.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virsh-completer-pool.h
virsh-completer-secret.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virsh-completer-secret.h
virsh-completer-snapshot.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virsh-completer-snapshot.h
virsh-completer-volume.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virsh-completer-volume.h
virsh-completer.c Replace virStringSplit with g_strsplit 2021-02-11 17:05:34 +01:00
virsh-completer.h
virsh-console.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virsh-console.h
virsh-domain-monitor.c cmdDomBlkError: Fix crash when initial call to virDomainGetDiskErrors fails 2021-04-19 11:04:53 +02:00
virsh-domain-monitor.h
virsh-domain.c virsh-domain: Fix @ret handling in cmdSetmem and cmdSetmaxmem 2021-05-19 15:31:36 +02:00
virsh-domain.h virsh: Move/add some of function declarations to virsh-domain.h 2020-11-10 18:34:26 +01:00
virsh-edit.c
virsh-host.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virsh-host.h tools: remove unnecessary includes 2020-08-03 15:30:40 +02:00
virsh-interface.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virsh-interface.h
virsh-network.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virsh-network.h
virsh-nodedev.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virsh-nodedev.h
virsh-nwfilter.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virsh-nwfilter.h
virsh-pool.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virsh-pool.h
virsh-secret.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virsh-secret.h tools: remove unnecessary includes 2020-08-03 15:30:40 +02:00
virsh-snapshot.c cmdSnapshotList: Fix memory leak 2021-04-19 16:09:56 -04:00
virsh-snapshot.h tools: remove unnecessary includes 2020-08-03 15:30:40 +02:00
virsh-util.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virsh-util.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virsh-volume.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virsh-volume.h
virsh.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virsh.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virt-admin-completer.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virt-admin-completer.h
virt-admin.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virt-admin.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virt-host-validate-bhyve.c virt-host-validate-bhyve.c: Reintroduce @ret to virHostValidateBhyve() 2020-05-05 14:45:58 +02:00
virt-host-validate-bhyve.h
virt-host-validate-common.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virt-host-validate-common.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virt-host-validate-lxc.c
virt-host-validate-lxc.h
virt-host-validate-qemu.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virt-host-validate-qemu.h
virt-host-validate.c lib: Prefer WITH_* prefix for #if conditionals 2020-09-02 10:28:10 +02:00
virt-login-shell-helper.c Replace AbsPath judgement method with g_path_is_absolute() 2021-04-21 10:02:09 +02:00
virt-login-shell.c
virt-login-shell.conf
virt-pki-validate.in
virt-sanlock-cleanup.in
virt-xml-validate.in
vsh-table.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
vsh-table.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
vsh.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
vsh.h vsh: Rework how option to complete is found 2021-01-26 16:46:41 +01:00