libvirt

mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-23 06:05:27 +00:00

History

Martin Kletzander a8743c3938 rpc: Remove keepalive_required option Since its introduction in 2011 (particularly in commit `f4324e3292`), the option doesn't work. It just effectively disables all incoming connections. That's because the client private data that contain the 'keepalive_supported' boolean, are initialized to zeroes so the bool is false and the only other place where the bool is used is when checking whether the client supports keepalive. Thus, according to the server, no client supports keepalive. Removing this instead of fixing it is better because a) apparently nobody ever tried it since 2011 (4 years without one month) and b) we cannot know whether the client supports keepalive until we get a ping or pong keepalive packet. And that won't happen until after we dispatched the ConnectOpen call. Another two reasons would be c) the keepalive_required was tracked on the server level, but keepalive_supported was in private data of the client as well as the check that was made in the remote layer, thus making all other instances of virNetServer miss this feature unless they all implemented it for themselves and d) we can always add it back in case there is a request and a use-case for it. Signed-off-by: Martin Kletzander <mkletzan@redhat.com>		2015-08-10 13:15:56 +02:00
..
input-data-admin-nomdns.json
input-data-anon-clients.json
input-data-initial-nomdns.json
input-data-initial.json
input-data-no-keepalive-required.json
output-data-admin-nomdns.json
output-data-anon-clients.json
output-data-initial-nomdns.json
output-data-initial.json
output-data-no-keepalive-required.json
README

README

   virnetservertest data files
   ===========================

The various input-data-*.json files are a record of all the historical
formats that libvirt has been able to produce data for. Everytime a
new field is added to the JSON output, a *new* input data file should
be created. We must not add new fields to existing input-data files,
nor must we ever re-structure them if code changes, as we must check
new code handles the legacy formats.

The various output-data-*.json files are the record of what the *new*
JSON output should look like for the correspondingly named input-data
file. It is permissible to change the existing output-data-*.json
files if the format we save in is updated.