libvirt/tests/virscsitest.c
Alexander Kuznetsov 20afcd4b14 util: Change return type of virSCSIDeviceSetUsedBy to void
This function return value is invariant since 18f3771, so change
its type and remove all dependent checks.

Found by Linux Verification Center (linuxtesting.org) with Svace.

Reported-by: Pavel Nekrasov <p.nekrasov@fobos-nt.ru>
Signed-off-by: Alexander Kuznetsov <kuznetsovam@altlinux.org>
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
2024-12-16 11:28:21 +01:00

221 lines
5.3 KiB
C

/*
* Copyright (C) 2014 Red Hat, Inc.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2.1 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this library. If not, see
* <http://www.gnu.org/licenses/>.
*
*/
#include <config.h>
#include <unistd.h>
#include "virscsi.h"
#include "testutils.h"
#include "virlog.h"
#define VIR_FROM_THIS VIR_FROM_NONE
#define VIR_SCSI_DATA "/virscsidata"
VIR_LOG_INIT("tests.scsitest");
static char *virscsi_prefix;
static int
test1(const void *data G_GNUC_UNUSED)
{
g_autofree char *name = NULL;
if (!(name = virSCSIDeviceGetDevName(virscsi_prefix,
"scsi_host1", 0, 0, 0)))
return -1;
if (STRNEQ(name, "sdh"))
return -1;
return 0;
}
/*
* Two test devices are used, one has address "0:0:0:0", the
* other has address "1:0:0:0", see "virscsidata/" for more
* details.
*/
static int
test2(const void *data G_GNUC_UNUSED)
{
g_autoptr(virSCSIDeviceList) list = NULL;
virSCSIDevice *dev = NULL;
virSCSIDevice *dev1 = NULL;
bool free_dev = true;
bool free_dev1 = true;
virSCSIDevice *tmp = NULL;
g_autofree char *sgname = NULL;
int ret = -1;
sgname = virSCSIDeviceGetSgName(virscsi_prefix,
"scsi_host1", 0, 0, 0);
if (!sgname || STRNEQ(sgname, "sg8"))
goto cleanup;
if (!(dev = virSCSIDeviceNew(virscsi_prefix, "scsi_host1",
0, 0, 0, false, true)))
goto cleanup;
if (STRNEQ_NULLABLE(virSCSIDeviceGetName(dev), "1:0:0:0") ||
virSCSIDeviceGetAdapter(dev) != 1 ||
virSCSIDeviceGetBus(dev) != 0 ||
virSCSIDeviceGetTarget(dev) != 0 ||
virSCSIDeviceGetUnit(dev) != 0 ||
virSCSIDeviceGetReadonly(dev) ||
!virSCSIDeviceGetShareable(dev))
goto cleanup;
if (!virSCSIDeviceIsAvailable(dev))
goto cleanup;
virSCSIDeviceSetUsedBy(dev, "QEMU", "fc18");
if (virSCSIDeviceIsAvailable(dev))
goto cleanup;
virSCSIDeviceSetUsedBy(dev, "QEMU", "fc20");
if (virSCSIDeviceIsAvailable(dev))
goto cleanup;
if (!(list = virSCSIDeviceListNew()))
goto cleanup;
if (virSCSIDeviceListAdd(list, dev) < 0)
goto cleanup;
/* virSCSIDeviceListDispose will take care of freeing
* the device.
*/
free_dev = false;
if (!virSCSIDeviceListFind(list, dev))
goto cleanup;
virSCSIDeviceListDel(list, dev, "QEMU", "fc20");
if (!virSCSIDeviceListFind(list, dev))
goto cleanup;
if (virSCSIDeviceIsAvailable(dev))
goto cleanup;
if (virSCSIDeviceListCount(list) != 1)
goto cleanup;
if (!(dev1 = virSCSIDeviceNew(virscsi_prefix, "scsi_host0",
0, 0, 0, true, false)))
goto cleanup;
if (virSCSIDeviceListAdd(list, dev1) < 0)
goto cleanup;
/* virSCSIDeviceListDispose will take care of freeing
* the device.
*/
free_dev1 = false;
if (virSCSIDeviceListCount(list) != 2)
goto cleanup;
if (!(tmp = virSCSIDeviceListSteal(list, dev1)))
goto cleanup;
virSCSIDeviceFree(tmp);
if (virSCSIDeviceListCount(list) != 1)
goto cleanup;
ret = 0;
cleanup:
if (free_dev)
virSCSIDeviceFree(dev);
if (free_dev1)
virSCSIDeviceFree(dev1);
return ret;
}
static int
create_symlink(const char *tmpdir, const char *src_name, const char *dst_name)
{
g_autofree char *src_path = NULL;
g_autofree char *dst_path = NULL;
src_path = g_strdup_printf("%s/%s", virscsi_prefix, src_name);
dst_path = g_strdup_printf("%s/%s", tmpdir, dst_name);
if (symlink(src_path, dst_path) < 0) {
VIR_WARN("Failed to create symlink '%s' to '%s'", src_path, dst_path);
return -1;
}
return 0;
}
static int
mymain(void)
{
int ret = 0;
char *tmpdir = NULL;
char template[] = "/tmp/libvirt_XXXXXX";
virscsi_prefix = g_strdup_printf("%s" VIR_SCSI_DATA, abs_srcdir);
tmpdir = g_mkdtemp(template);
if (tmpdir == NULL) {
VIR_WARN("Failed to create temporary directory");
ret = -1;
goto cleanup;
}
#define CREATE_SYMLINK(src_name, dst_name) \
do { \
if (create_symlink(tmpdir, src_name, dst_name) < 0) { \
ret = -1; \
goto cleanup; \
} \
} while (0)
CREATE_SYMLINK("0-0-0-0", "0:0:0:0");
CREATE_SYMLINK("1-0-0-0", "1:0:0:0");
CREATE_SYMLINK("sg0", "sg0");
CREATE_SYMLINK("sg8", "sg8");
VIR_FREE(virscsi_prefix);
virscsi_prefix = g_strdup(tmpdir);
if (virTestRun("test1", test1, NULL) < 0)
ret = -1;
if (virTestRun("test2", test2, NULL) < 0)
ret = -1;
cleanup:
if (getenv("LIBVIRT_SKIP_CLEANUP") == NULL)
virFileDeleteTree(tmpdir);
VIR_FREE(virscsi_prefix);
return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
}
VIR_TEST_MAIN(mymain)