mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-09-24 16:35:44 +00:00
2593f9692d
The current virDomainMigrateFinish3 method signature attempts to distinguish two types of errors, by allowing return with ret== 0, but ddomain == NULL, to indicate a failure to start the guest. This is flawed, because when ret == 0, there is no way for the virErrorPtr details to be sent back to the client. Change the signature of virDomainMigrateFinish3 so it simply returns a virDomainPtr, in the same way as virDomainMigrateFinish2 The disk locking code will protect against the only possible failure mode this doesn't account for (loosing conenctivity to libvirtd after Finish3 starts the CPUs, but before the client sees the reply for Finish3). * src/driver.h, src/libvirt.c, src/libvirt_internal.h: Change virDomainMigrateFinish3 to return a virDomainPtr instead of int * src/remote/remote_driver.c, src/remote/remote_protocol.x, daemon/remote.c, src/qemu/qemu_driver.c, src/qemu/qemu_migration.c: Update for API change
188 lines
7.7 KiB
C
188 lines
7.7 KiB
C
/*
|
|
* libvirt.h: publically exported APIs, not for public use
|
|
*
|
|
* Copyright (C) 2006-2008 Red Hat, Inc.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*
|
|
* NB This file is ABI sensitive. Things here impact the wire
|
|
* protocol ABI in the remote driver. Same rules as for things
|
|
* include/libvirt/libvirt.h apply. ie this file is *append* only
|
|
*/
|
|
|
|
#ifndef __LIBVIRT_H_
|
|
# define __LIBVIRT_H_
|
|
|
|
# include "internal.h"
|
|
|
|
# ifdef WITH_LIBVIRTD
|
|
int virStateInitialize(int privileged);
|
|
int virStateCleanup(void);
|
|
int virStateReload(void);
|
|
int virStateActive(void);
|
|
# endif
|
|
|
|
/* Feature detection. This is a libvirt-private interface for determining
|
|
* what features are supported by the driver.
|
|
*
|
|
* The remote driver passes features through to the real driver at the
|
|
* remote end unmodified, except if you query a VIR_DRV_FEATURE_REMOTE*
|
|
* feature.
|
|
*
|
|
*/
|
|
enum {
|
|
/* Driver supports V1-style virDomainMigrate, ie. domainMigratePrepare/
|
|
* domainMigratePerform/domainMigrateFinish.
|
|
*/
|
|
VIR_DRV_FEATURE_MIGRATION_V1 = 1,
|
|
|
|
/* Driver is not local. */
|
|
VIR_DRV_FEATURE_REMOTE = 2,
|
|
|
|
/* Driver supports V2-style virDomainMigrate, ie. domainMigratePrepare2/
|
|
* domainMigratePerform/domainMigrateFinish2.
|
|
*/
|
|
VIR_DRV_FEATURE_MIGRATION_V2 = 3,
|
|
|
|
/* Driver supports peer-2-peer virDomainMigrate ie source host
|
|
* does all the prepare/perform/finish steps directly
|
|
*/
|
|
VIR_DRV_FEATURE_MIGRATION_P2P = 4,
|
|
|
|
/* Driver supports migration with only the source host involved,
|
|
* no libvirtd connetions on the destination at all, only the
|
|
* perform step is used.
|
|
*/
|
|
VIR_DRV_FEATURE_MIGRATION_DIRECT = 5,
|
|
|
|
/*
|
|
* Driver supports V3-style virDomainMigrate, ie domainMigrateBegin3/
|
|
* domainMigratePrepare3/domainMigratePerform3/domainMigrateFinish3/
|
|
* domainMigrateConfirm3.
|
|
*/
|
|
VIR_DRV_FEATURE_MIGRATION_V3 = 6,
|
|
};
|
|
|
|
|
|
int virDrvSupportsFeature (virConnectPtr conn, int feature);
|
|
|
|
int virDomainMigratePrepare (virConnectPtr dconn,
|
|
char **cookie,
|
|
int *cookielen,
|
|
const char *uri_in,
|
|
char **uri_out,
|
|
unsigned long flags,
|
|
const char *dname,
|
|
unsigned long resource);
|
|
int virDomainMigratePerform (virDomainPtr domain,
|
|
const char *cookie,
|
|
int cookielen,
|
|
const char *uri,
|
|
unsigned long flags,
|
|
const char *dname,
|
|
unsigned long resource);
|
|
virDomainPtr virDomainMigrateFinish (virConnectPtr dconn,
|
|
const char *dname,
|
|
const char *cookie,
|
|
int cookielen,
|
|
const char *uri,
|
|
unsigned long flags);
|
|
int virDomainMigratePrepare2 (virConnectPtr dconn,
|
|
char **cookie,
|
|
int *cookielen,
|
|
const char *uri_in,
|
|
char **uri_out,
|
|
unsigned long flags,
|
|
const char *dname,
|
|
unsigned long resource,
|
|
const char *dom_xml);
|
|
virDomainPtr virDomainMigrateFinish2 (virConnectPtr dconn,
|
|
const char *dname,
|
|
const char *cookie,
|
|
int cookielen,
|
|
const char *uri,
|
|
unsigned long flags,
|
|
int retcode);
|
|
int virDomainMigratePrepareTunnel(virConnectPtr dconn,
|
|
virStreamPtr st,
|
|
unsigned long flags,
|
|
const char *dname,
|
|
unsigned long resource,
|
|
const char *dom_xml);
|
|
|
|
|
|
char *virDomainMigrateBegin3(virDomainPtr domain,
|
|
const char *xmlin,
|
|
char **cookieout,
|
|
int *cookieoutlen,
|
|
unsigned long flags,
|
|
const char *dname,
|
|
unsigned long resource);
|
|
|
|
int virDomainMigratePrepare3(virConnectPtr dconn,
|
|
const char *cookiein,
|
|
int cookieinlen,
|
|
char **cookieout,
|
|
int *cookieoutlen,
|
|
const char *uri_in,
|
|
char **uri_out,
|
|
unsigned long flags,
|
|
const char *dname,
|
|
unsigned long resource,
|
|
const char *dom_xml);
|
|
|
|
int virDomainMigratePrepareTunnel3(virConnectPtr dconn,
|
|
virStreamPtr st,
|
|
const char *cookiein,
|
|
int cookieinlen,
|
|
char **cookieout,
|
|
int *cookieoutlen,
|
|
unsigned long flags,
|
|
const char *dname,
|
|
unsigned long resource,
|
|
const char *dom_xml);
|
|
|
|
|
|
int virDomainMigratePerform3(virDomainPtr dom,
|
|
const char *xmlin,
|
|
const char *cookiein,
|
|
int cookieinlen,
|
|
char **cookieout,
|
|
int *cookieoutlen,
|
|
const char *dconnuri, /* libvirtd URI if Peer2Peer, NULL otherwise */
|
|
const char *uri, /* VM Migration URI */
|
|
unsigned long flags,
|
|
const char *dname,
|
|
unsigned long resource);
|
|
|
|
virDomainPtr virDomainMigrateFinish3(virConnectPtr dconn,
|
|
const char *dname,
|
|
const char *cookiein,
|
|
int cookieinlen,
|
|
char **cookieout,
|
|
int *cookieoutlen,
|
|
const char *dconnuri, /* libvirtd URI if Peer2Peer, NULL otherwise */
|
|
const char *uri, /* VM Migration URI, NULL in tunnelled case */
|
|
unsigned long flags,
|
|
int cancelled); /* Kill the dst VM */
|
|
|
|
int virDomainMigrateConfirm3(virDomainPtr domain,
|
|
const char *cookiein,
|
|
int cookieinlen,
|
|
unsigned long flags,
|
|
int restart); /* Restart the src VM */
|
|
|
|
#endif
|