libvirt/src/util
Andrea Bolognani 40204c05c5 util: Report error in virFileWrapperFdClose()
libvirt_iohelper is used internally by the virFileWrapperFd APIs;
more specifically, in the QEMU driver we have the doCoreDump() and
qemuDomainSaveMemory() helper functions as users, and those in turn
end up being called by the implementation of several driver APIs.

By calling virReportError() if libvirt_iohelper has failed, we
overwrite whatever generic error message QEMU might have raised
with the more useful one generated by the helper program.

After this commit, the user will be able to see the error directly
instead of having to dig in the journal or libvirtd log.

https://bugzilla.redhat.com/show_bug.cgi?id=1578741

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
2019-02-25 16:34:37 +01:00
..
iohelper.c iohelper: Remove remaining newlines from error messages 2019-02-20 08:51:39 +01:00
Makefile.inc.am util: move all firewalld-specific stuff into its own files 2019-02-01 12:08:37 -05:00
viralloc.c Fix minor typos in messages and docs 2018-12-05 10:39:54 +01:00
viralloc.h util: alloc: Introduce 'VIR_AUTOCLEAN' macros for clearing stack'd structs 2019-02-22 10:05:45 +01:00
virarch.c
virarch.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virarptable.c Remove all Author(s): lines from source file headers 2018-12-13 16:08:38 +00:00
virarptable.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
viratomic.c
viratomic.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
viraudit.c
viraudit.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virauth.c
virauth.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virauthconfig.c Remove all Author(s): lines from source file headers 2018-12-13 16:08:38 +00:00
virauthconfig.h util: Use a semicolon for all VIR_DEFINE_AUTOPTR_FUNC 2019-02-08 06:57:23 -05:00
virbitmap.c Remove all Author(s): lines from source file headers 2018-12-13 16:08:38 +00:00
virbitmap.h util: Use a semicolon for all VIR_DEFINE_AUTOPTR_FUNC 2019-02-08 06:57:23 -05:00
virbuffer.c util: buf: Remove virBufferEscapeN 2019-02-22 10:05:45 +01:00
virbuffer.h util: buffer: Introduce VIR_AUTOCLEAN function for virBuffer 2019-02-22 10:05:45 +01:00
vircgroup.c vircgroup: Try harder to kill cgroup 2019-02-07 11:16:29 +01:00
vircgroup.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
vircgroupbackend.c Require a semicolon for VIR_ENUM_IMPL calls 2019-02-03 17:46:29 -05:00
vircgroupbackend.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
vircgrouppriv.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
vircgroupv1.c Use NULLSTR_EMPTY 2019-02-14 14:09:38 +01:00
vircgroupv1.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
vircgroupv2.c Use NULLSTR_EMPTY 2019-02-14 14:09:38 +01:00
vircgroupv2.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virclosecallbacks.c Require a semicolon for VIR_ONCE_GLOBAL_INIT calls 2019-02-03 17:46:29 -05:00
virclosecallbacks.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
vircommand.c vircommand: Ensure buffers are NULL-terminated 2019-02-19 15:58:59 +01:00
vircommand.h util: Use a semicolon for all VIR_DEFINE_AUTOPTR_FUNC 2019-02-08 06:57:23 -05:00
vircommandpriv.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virconf.c Require a semicolon for VIR_ENUM_IMPL calls 2019-02-03 17:46:29 -05:00
virconf.h Require a semicolon to VIR_ENUM_DECL calls 2019-02-03 17:46:29 -05:00
vircrypto.c Fix minor typos in messages and docs 2018-12-05 10:39:54 +01:00
vircrypto.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virdbus.c lib: Use more of VIR_STEAL_PTR() 2019-01-28 14:46:58 +01:00
virdbus.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virdbuspriv.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virdevmapper.c Require a semicolon for VIR_ONCE_GLOBAL_INIT calls 2019-02-03 17:46:29 -05:00
virdevmapper.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virdnsmasq.c Require a semicolon for VIR_ONCE_GLOBAL_INIT calls 2019-02-03 17:46:29 -05:00
virdnsmasq.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virebtables.c Remove all Author(s): lines from source file headers 2018-12-13 16:08:38 +00:00
virebtables.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virendian.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virerror.c Require a semicolon for VIR_ENUM_IMPL calls 2019-02-03 17:46:29 -05:00
virerror.h util: Use a semicolon for all VIR_DEFINE_AUTOPTR_FUNC 2019-02-08 06:57:23 -05:00
virerrorpriv.h util: error: Export virErrorMsg for use in testsuite 2018-12-14 13:54:50 +01:00
virevent.c Remove all Author(s): lines from source file headers 2018-12-13 16:08:38 +00:00
virevent.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
vireventpoll.c Remove all Author(s): lines from source file headers 2018-12-13 16:08:38 +00:00
vireventpoll.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virfcp.c Remove all Author(s): lines from source file headers 2018-12-13 16:08:38 +00:00
virfcp.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virfdstream.c Require a semicolon for VIR_ONCE_GLOBAL_INIT calls 2019-02-03 17:46:29 -05:00
virfdstream.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virfile.c util: Report error in virFileWrapperFdClose() 2019-02-25 16:34:37 +01:00
virfile.h util: Use a semicolon for all VIR_DEFINE_AUTOPTR_FUNC 2019-02-08 06:57:23 -05:00
virfilecache.c Require a semicolon for VIR_ONCE_GLOBAL_INIT calls 2019-02-03 17:46:29 -05:00
virfilecache.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virfirewall.c Require a semicolon for VIR_ONCE_GLOBAL_INIT calls 2019-02-03 17:46:29 -05:00
virfirewall.h util: Use a semicolon for all VIR_DEFINE_AUTOPTR_FUNC 2019-02-08 06:57:23 -05:00
virfirewalld.c util: fix memory leak in virFirewallDInterfaceSetZone() 2019-02-13 14:30:14 -05:00
virfirewalld.h util: new virFirewallD APIs + docs 2019-02-01 12:08:37 -05:00
virfirewalldpriv.h util: move all firewalld-specific stuff into its own files 2019-02-01 12:08:37 -05:00
virfirewallpriv.h util: move all firewalld-specific stuff into its own files 2019-02-01 12:08:37 -05:00
virfirmware.c Remove all Author(s): lines from source file headers 2018-12-13 16:08:38 +00:00
virfirmware.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virgettext.c
virgettext.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virgic.c Require a semicolon for VIR_ENUM_IMPL calls 2019-02-03 17:46:29 -05:00
virgic.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virhash.c Require a semicolon for VIR_ONCE_GLOBAL_INIT calls 2019-02-03 17:46:29 -05:00
virhash.h util: Use a semicolon for all VIR_DEFINE_AUTOPTR_FUNC 2019-02-08 06:57:23 -05:00
virhashcode.c
virhashcode.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virhook.c Require a semicolon for VIR_ENUM_IMPL calls 2019-02-03 17:46:29 -05:00
virhook.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virhostcpu.c Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virhostcpu.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virhostcpupriv.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virhostdev.c Require a semicolon for VIR_ONCE_GLOBAL_INIT calls 2019-02-03 17:46:29 -05:00
virhostdev.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virhostmem.c Remove all Author(s): lines from source file headers 2018-12-13 16:08:38 +00:00
virhostmem.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
viridentity.c Require a semicolon for VIR_ONCE_GLOBAL_INIT calls 2019-02-03 17:46:29 -05:00
viridentity.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virinitctl.c virinitctl: Provide a stub list of init fifos for non-Linux 2019-02-07 16:17:56 +01:00
virinitctl.h virinitctl: Expose fifo paths and allow caller to chose one 2019-02-07 11:24:09 +01:00
viriptables.c util: move virtual network firwall rules into private chains 2019-01-29 13:37:11 +00:00
viriptables.h util: move virtual network firwall rules into private chains 2019-01-29 13:37:11 +00:00
viriscsi.c
viriscsi.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virjson.c virjson: add convenience wrapper for appending string to array 2019-01-25 09:21:24 -06:00
virjson.h util: Use a semicolon for all VIR_DEFINE_AUTOPTR_FUNC 2019-02-08 06:57:23 -05:00
virkeycode.c Require a semicolon for VIR_ENUM_IMPL calls 2019-02-03 17:46:29 -05:00
virkeycode.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virkeyfile.c Remove all Author(s): lines from source file headers 2018-12-13 16:08:38 +00:00
virkeyfile.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virkmod.c
virkmod.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virlease.c Remove EMPTY_STR macro 2019-02-14 14:09:38 +01:00
virlease.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virlockspace.c Revert "virlockspace: Allow caller to specify start and length offset in virLockSpaceAcquireResource" 2018-11-16 13:42:39 +01:00
virlockspace.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virlog.c Require a semicolon for VIR_ONCE_GLOBAL_INIT calls 2019-02-03 17:46:29 -05:00
virlog.h Require a semicolon for VIR_LOG_INIT calls 2019-02-03 17:46:29 -05:00
virmacaddr.c Remove all Author(s): lines from source file headers 2018-12-13 16:08:38 +00:00
virmacaddr.h util: Use a semicolon for all VIR_DEFINE_AUTOPTR_FUNC 2019-02-08 06:57:23 -05:00
virmacmap.c Remove all Author(s): lines from source file headers 2018-12-13 16:08:38 +00:00
virmacmap.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virmdev.c Require a semicolon for VIR_ONCE_GLOBAL_INIT calls 2019-02-03 17:46:29 -05:00
virmdev.h util: Use a semicolon for all VIR_DEFINE_AUTOPTR_FUNC 2019-02-08 06:57:23 -05:00
virmodule.c Fix minor typos in messages and docs 2018-12-05 10:39:54 +01:00
virmodule.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virnetdev.c util: Use a semicolon for all VIR_DEFINE_AUTOPTR_FUNC 2019-02-08 06:57:23 -05:00
virnetdev.h util: Use a semicolon for all VIR_DEFINE_AUTOPTR_FUNC 2019-02-08 06:57:23 -05:00
virnetdevbandwidth.c Remove all Author(s): lines from source file headers 2018-12-13 16:08:38 +00:00
virnetdevbandwidth.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virnetdevbridge.c Remove all Author(s): lines from source file headers 2018-12-13 16:08:38 +00:00
virnetdevbridge.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virnetdevip.c virnetdevip: Avoid cast align warning 2019-01-15 13:00:52 +01:00
virnetdevip.h util: Use a semicolon for all VIR_DEFINE_AUTOPTR_FUNC 2019-02-08 06:57:23 -05:00
virnetdevmacvlan.c Require a semicolon for VIR_ENUM_IMPL calls 2019-02-03 17:46:29 -05:00
virnetdevmacvlan.h Require a semicolon to VIR_ENUM_DECL calls 2019-02-03 17:46:29 -05:00
virnetdevmidonet.c Remove all Author(s): lines from source file headers 2018-12-13 16:08:38 +00:00
virnetdevmidonet.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virnetdevopenvswitch.c Remove all Author(s): lines from source file headers 2018-12-13 16:08:38 +00:00
virnetdevopenvswitch.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virnetdevtap.c Remove all Author(s): lines from source file headers 2018-12-13 16:08:38 +00:00
virnetdevtap.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virnetdevveth.c Remove all Author(s): lines from source file headers 2018-12-13 16:08:38 +00:00
virnetdevveth.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virnetdevvlan.c Remove all Author(s): lines from source file headers 2018-12-13 16:08:38 +00:00
virnetdevvlan.h util: Use a semicolon for all VIR_DEFINE_AUTOPTR_FUNC 2019-02-08 06:57:23 -05:00
virnetdevvportprofile.c Use NULLSTR_EMPTY 2019-02-14 14:09:38 +01:00
virnetdevvportprofile.h Require a semicolon to VIR_ENUM_DECL calls 2019-02-03 17:46:29 -05:00
virnetlink.c util: Use a semicolon for all VIR_DEFINE_AUTOPTR_FUNC 2019-02-08 06:57:23 -05:00
virnetlink.h util: Use a semicolon for all VIR_DEFINE_AUTOPTR_FUNC 2019-02-08 06:57:23 -05:00
virnodesuspend.c
virnodesuspend.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virnuma.c Use NULLSTR_EMPTY 2019-02-14 14:09:38 +01:00
virnuma.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virobject.c util: alloc: Introduce VIR_AUTOUNREF macro 2019-02-18 10:31:21 +01:00
virobject.h util: alloc: Introduce VIR_AUTOUNREF macro 2019-02-18 10:31:21 +01:00
virpci.c Require a semicolon for VIR_ONCE_GLOBAL_INIT calls 2019-02-03 17:46:29 -05:00
virpci.h util: Use a semicolon for all VIR_DEFINE_AUTOPTR_FUNC 2019-02-08 06:57:23 -05:00
virperf.c Require a semicolon for VIR_ENUM_IMPL calls 2019-02-03 17:46:29 -05:00
virperf.h util: Use a semicolon for all VIR_DEFINE_AUTOPTR_FUNC 2019-02-08 06:57:23 -05:00
virpidfile.c
virpidfile.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virpolkit.c
virpolkit.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virportallocator.c Require a semicolon for VIR_ONCE_GLOBAL_INIT calls 2019-02-03 17:46:29 -05:00
virportallocator.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virprobe.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virprocess.c Require a semicolon for VIR_ENUM_IMPL calls 2019-02-03 17:46:29 -05:00
virprocess.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virqemu.c
virqemu.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virrandom.c Remove all Author(s): lines from source file headers 2018-12-13 16:08:38 +00:00
virrandom.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virresctrl.c Require a semicolon for VIR_ONCE_GLOBAL_INIT calls 2019-02-03 17:46:29 -05:00
virresctrl.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virresctrlpriv.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virrotatingfile.c lib: Use more of VIR_STEAL_PTR() 2019-01-28 14:46:58 +01:00
virrotatingfile.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virscsi.c util: Use a semicolon for all VIR_DEFINE_AUTOPTR_FUNC 2019-02-08 06:57:23 -05:00
virscsi.h util: Use a semicolon for all VIR_DEFINE_AUTOPTR_FUNC 2019-02-08 06:57:23 -05:00
virscsihost.c
virscsihost.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virscsivhost.c Require a semicolon for VIR_ONCE_GLOBAL_INIT calls 2019-02-03 17:46:29 -05:00
virscsivhost.h util: Use a semicolon for all VIR_DEFINE_AUTOPTR_FUNC 2019-02-08 06:57:23 -05:00
virseclabel.c
virseclabel.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virsecret.c Require a semicolon for VIR_ENUM_IMPL calls 2019-02-03 17:46:29 -05:00
virsecret.h Require a semicolon to VIR_ENUM_DECL calls 2019-02-03 17:46:29 -05:00
virsexpr.c
virsexpr.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virsocketaddr.c util: set missing data length in virSocketAddrPrefixToNetmask() 2019-02-21 12:59:09 -05:00
virsocketaddr.h util: Use a semicolon for all VIR_DEFINE_AUTOPTR_FUNC 2019-02-08 06:57:23 -05:00
virstorageencryption.c Require a semicolon for VIR_ENUM_IMPL calls 2019-02-03 17:46:29 -05:00
virstorageencryption.h Require a semicolon to VIR_ENUM_DECL calls 2019-02-03 17:46:29 -05:00
virstoragefile.c util: Use virStorageSourceNew in virStorageFileMetadataNew 2019-02-18 14:00:15 +01:00
virstoragefile.h util: Replace virStorageSourceFree with virObjectUnref 2019-02-18 10:31:21 +01:00
virstoragefilebackend.c Require a semicolon for VIR_ONCE_GLOBAL_INIT calls 2019-02-03 17:46:29 -05:00
virstoragefilebackend.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virstring.c Remove all Author(s): lines from source file headers 2018-12-13 16:08:38 +00:00
virstring.h util: Use a semicolon for all VIR_DEFINE_AUTOPTR_FUNC 2019-02-08 06:57:23 -05:00
virsysinfo.c Require a semicolon for VIR_ENUM_IMPL calls 2019-02-03 17:46:29 -05:00
virsysinfo.h Require a semicolon to VIR_ENUM_DECL calls 2019-02-03 17:46:29 -05:00
virsysinfopriv.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virsystemd.c Use NULLSTR_EMPTY 2019-02-14 14:09:38 +01:00
virsystemd.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virsystemdpriv.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virthread.c
virthread.h Require a semicolon for VIR_ONCE_GLOBAL_INIT calls 2019-02-03 17:46:29 -05:00
virthreadjob.c Require a semicolon for VIR_ONCE_GLOBAL_INIT calls 2019-02-03 17:46:29 -05:00
virthreadjob.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virthreadpool.c Remove all Author(s): lines from source file headers 2018-12-13 16:08:38 +00:00
virthreadpool.h Remove even more Author(s): lines from source files 2019-01-03 13:24:18 +01:00
virtime.c Remove all Author(s): lines from source file headers 2018-12-13 16:08:38 +00:00
virtime.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virtpm.c Remove all Author(s): lines from source file headers 2018-12-13 16:08:38 +00:00
virtpm.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virtypedparam.c Require a semicolon for VIR_ENUM_IMPL calls 2019-02-03 17:46:29 -05:00
virtypedparam.h Require a semicolon to VIR_ENUM_DECL calls 2019-02-03 17:46:29 -05:00
viruri.c Use NULLSTR_EMPTY 2019-02-14 14:09:38 +01:00
viruri.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virusb.c Require a semicolon for VIR_ONCE_GLOBAL_INIT calls 2019-02-03 17:46:29 -05:00
virusb.h util: Use a semicolon for all VIR_DEFINE_AUTOPTR_FUNC 2019-02-08 06:57:23 -05:00
virutil.c Require a semicolon for VIR_ENUM_IMPL calls 2019-02-03 17:46:29 -05:00
virutil.h Require a semicolon for VIR_ENUM_IMPL calls 2019-02-03 17:46:29 -05:00
viruuid.c Remove all Author(s): lines from source file headers 2018-12-13 16:08:38 +00:00
viruuid.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virvhba.c
virvhba.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virvsock.c
virvsock.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virxdrdefs.h Enforce a standard header file guard symbol name 2018-12-14 10:47:13 +00:00
virxml.c Remove even more Author(s): lines from source files 2019-01-03 13:24:18 +01:00
virxml.h Remove even more Author(s): lines from source files 2019-01-03 13:24:18 +01:00