External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-08-04 07:53:50 +00:00
Code Issues Packages Projects Releases Wiki Activity
08bb5eeba7
libvirt/tools
History
Christian Ehrhardt 08bb5eeba7 tools: fix check_guests_shutdown loop 
The recent fix to libvirt-guests.sh.in works for what it intended to fix
(variable scope) but failed to adapt the loop in check_guests_shutdown
correctly. Due to that it currently might detect all guests as "Failed to
determine state of guest" by bad var content or just assumes they are shut
down by picking up an empty variable.

This commit fixes loop to use the passed value and the call in the loop
to actually use the variable assigned in the iterated.

Fixes: 7e476356 "tools: fix variable scope in in check_guests_shutdown"
Fixes: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1764668

Reviewed-by: Dariusz Gadomski <dariusz.gadomski@canonical.com>
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
2018-04-24 10:43:42 +02:00
..
bash-completion tools: Provide bash autompletion file 2018-01-11 18:53:04 +01:00
nss Remove backslash alignment attempts 2017-11-03 13:24:12 +01:00
wireshark Remove backslash alignment attempts 2017-11-03 13:24:12 +01:00
libvirt_win_icon_16x16.ico Move virsh into tools/ directory 2009-09-21 14:41:45 +01:00
libvirt_win_icon_32x32.ico Move virsh into tools/ directory 2009-09-21 14:41:45 +01:00
libvirt_win_icon_48x48.ico Move virsh into tools/ directory 2009-09-21 14:41:45 +01:00
libvirt_win_icon_64x64.ico Move virsh into tools/ directory 2009-09-21 14:41:45 +01:00
libvirt-guests.init.in Use https:// links for most sites 2017-10-16 10:22:34 +01:00
libvirt-guests.service.in Use https:// links for most sites 2017-10-16 10:22:34 +01:00
libvirt-guests.sh.in tools: fix check_guests_shutdown loop 2018-04-24 10:43:42 +02:00
libvirt-guests.sysconf lxc: allow use of lxc:///system URI as preferred format 2018-04-12 16:52:01 +01:00
Makefile.am make sure libvirt is linked first 2018-03-05 16:49:50 +00:00
virsh_win_icon.rc Move virsh into tools/ directory 2009-09-21 14:41:45 +01:00
virsh-completer.c virshDomainNameCompleter: Prune accepted flags 2018-01-31 15:41:51 +01:00
virsh-completer.h virsh: Introduce virshSnapshotNameCompleter 2018-01-24 13:51:23 +01:00
virsh-console.c tools: Introduce new client generic module vsh 2015-08-14 15:45:44 +02:00
virsh-console.h tools: Introduce new client generic module vsh 2015-08-14 15:45:44 +02:00
virsh-domain-monitor.c virsh: add missing help info of --source to domifaddr 2018-03-29 13:29:49 -04:00
virsh-domain-monitor.h tools: Introduce new client generic module vsh 2015-08-14 15:45:44 +02:00
virsh-domain.c keycodemapdb: Update submodule 2018-03-12 16:30:49 +01:00
virsh-domain.h virsh-util: Move domain lookup helpers into virsh-util 2017-04-12 13:23:10 +02:00
virsh-edit.c virsh-edit: remove unreachable break 2018-03-08 16:51:31 +01:00
virsh-host.c util: Rename virBitmapDataToString to virBitmapDataFormat 2017-11-18 10:45:10 +01:00
virsh-host.h maint: fix up copyright notice inconsistencies 2012-09-20 16:30:55 -06:00
virsh-interface.c virsh: Introduce virshInterfaceNameCompleter 2018-01-24 13:51:21 +01:00
virsh-interface.h Remove backslash alignment attempts 2017-11-03 13:24:12 +01:00
virsh-network.c virsh: Introduce virshNetworkNameCompleter 2018-01-24 13:51:21 +01:00
virsh-network.h Remove backslash alignment attempts 2017-11-03 13:24:12 +01:00
virsh-nodedev.c virsh: Introduce virshNodeDeviceNameCompleter 2018-01-24 13:51:22 +01:00
virsh-nodedev.h maint: fix up copyright notice inconsistencies 2012-09-20 16:30:55 -06:00
virsh-nwfilter.c virsh: Introduce virshNWFilterNameCompleter 2018-01-24 13:51:22 +01:00
virsh-nwfilter.h Remove backslash alignment attempts 2017-11-03 13:24:12 +01:00
virsh-pool.c tools: Add support for additional adapter parent options 2018-03-12 09:00:37 -04:00
virsh-pool.h Remove backslash alignment attempts 2017-11-03 13:24:12 +01:00
virsh-secret.c virsh: Introduce virshSecretUUIDCompleter 2018-01-24 13:51:23 +01:00
virsh-secret.h maint: fix up copyright notice inconsistencies 2012-09-20 16:30:55 -06:00
virsh-snapshot.c virsh: Introduce virshSnapshotNameCompleter 2018-01-24 13:51:23 +01:00
virsh-snapshot.h maint: fix up copyright notice inconsistencies 2012-09-20 16:30:55 -06:00
virsh-util.c virsh: Implement sparse stream to vol-upload 2017-05-18 07:42:13 +02:00
virsh-util.h virsh: Implement sparse stream to vol-upload 2017-05-18 07:42:13 +02:00
virsh-volume.c virsh: Clear vsh last error during virshCommandOptVolBy 2018-04-17 11:19:13 -04:00
virsh-volume.h Remove backslash alignment attempts 2017-11-03 13:24:12 +01:00
virsh.c vsh: Introduce complete command 2018-01-11 18:53:04 +01:00
virsh.h virsh: Introduce virshStoragePoolNameCompleter 2018-01-24 13:49:56 +01:00
virsh.pod lxc: allow use of lxc:///system URI as preferred format 2018-04-12 16:52:01 +01:00
virt-admin-completer.c virt-admin: Introduce vshAdmServerCompleter 2018-01-11 18:53:04 +01:00
virt-admin-completer.h virt-admin: Introduce vshAdmServerCompleter 2018-01-11 18:53:04 +01:00
virt-admin.c virt-admin: Introduce vshAdmServerCompleter 2018-01-11 18:53:04 +01:00
virt-admin.h Revert "admin: Rename virAdmConnect to virAdmDaemon" 2015-12-21 10:07:59 +01:00
virt-admin.pod Use https:// links for most sites 2017-10-16 10:22:34 +01:00
virt-host-validate-bhyve.c virsh: Define multi line macros properly 2017-11-04 08:38:08 +01:00
virt-host-validate-bhyve.h virt-host-validate: add bhyve support 2017-03-11 21:22:58 +04:00
virt-host-validate-common.c virt-host-validate: Fix warning for IOMMU detection on PPC 2017-08-24 18:37:37 -04:00
virt-host-validate-common.h headers: Remove unnecessary keyword extern from function declaration 2016-05-11 09:06:32 +02:00
virt-host-validate-lxc.c virt-host-validate: require fuse for LXC if compiled in 2017-10-12 21:32:07 +02:00
virt-host-validate-lxc.h headers: Remove unnecessary keyword extern from function declaration 2016-05-11 09:06:32 +02:00
virt-host-validate-qemu.c tools: handle missing switch enum cases 2018-02-21 16:59:44 +00:00
virt-host-validate-qemu.h headers: Remove unnecessary keyword extern from function declaration 2016-05-11 09:06:32 +02:00
virt-host-validate.c po: provide custom make rules for po file management 2018-04-19 10:35:58 +01:00
virt-host-validate.pod Use https:// links for most sites 2017-10-16 10:22:34 +01:00
virt-login-shell.c lxc: allow use of lxc:///system URI as preferred format 2018-04-12 16:52:01 +01:00
virt-login-shell.conf virt-login-shell: add ability to auto-detect shell from container 2016-06-10 11:03:02 +01:00
virt-login-shell.pod Use https:// links for most sites 2017-10-16 10:22:34 +01:00
virt-pki-validate.in fix regex to check CN from server certificate 2018-02-08 18:05:05 +01:00
virt-pki-validate.pod Use https:// links for most sites 2017-10-16 10:22:34 +01:00
virt-sanlock-cleanup.in build: Extract pod from source files 2016-04-25 15:40:43 +02:00
virt-sanlock-cleanup.pod Use https:// links for most sites 2017-10-16 10:22:34 +01:00
virt-xml-validate.in build: Extract pod from source files 2016-04-25 15:40:43 +02:00
virt-xml-validate.pod Use https:// links for most sites 2017-10-16 10:22:34 +01:00
vsh.c vshCommandOpt: Do more checking if skipChecks is set 2018-02-28 10:36:24 +01:00
vsh.h vsh: Drop redundant definition searches from vshCmd{def,Grp}Help 2018-01-25 16:20:27 +01:00