mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2025-01-05 12:35:20 +00:00
0a476f1521
Previously we were ignoring "nodeset" attribute for hugepage pages
if there was no guest NUMA topology configured in the domain XML.
Commit <fa6bdf6afa878b8d7c5ed71664ee72be8967cdc5> partially fixed
that issue but it introduced a somehow valid regression.
In case that there is no guest NUMA topology configured and the
"nodeset" attribute is set to "0" it was accepted and was working
properly even though it was not completely valid XML.
This patch introduces a workaround that it will ignore the nodeset="0"
only in case that there is no guest NUMA topology in order not to
hit the validation error.
After this commit the following XML configuration is valid:
<memoryBacking>
<hugepages>
<page size='2048' unit='KiB' nodeset='0'/>
</hugepages>
</memoryBacking>
but this configuration remains invalid:
<memoryBacking>
<hugepages>
<page size='2048' unit='KiB' nodeset='0'/>
<page size='1048576' unit='KiB'/>
</hugepages>
</memoryBacking>
The issue with the second configuration is that it was originally
working, however changing the order of the <page> elements resolved
into using different page size for the guest. The code is written
in a way that it expect only one page configured and always uses only
the first page in case that there is no guest NUMA topology configured.
See qemuBuildMemPathStr() function for details.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1591235
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
|
||
|---|---|---|
| .. | ||
| access | ||
| admin | ||
| bhyve | ||
| conf | ||
| cpu | ||
| esx | ||
| hyperv | ||
| interface | ||
| keycodemapdb@16e5b07876 | ||
| libxl | ||
| locking | ||
| logging | ||
| lxc | ||
| network | ||
| node_device | ||
| nwfilter | ||
| openvz | ||
| phyp | ||
| qemu | ||
| remote | ||
| rpc | ||
| secret | ||
| security | ||
| storage | ||
| test | ||
| uml | ||
| util | ||
| vbox | ||
| vmware | ||
| vmx | ||
| vz | ||
| xenapi | ||
| xenconfig | ||
| admin_protocol-structs | ||
| check-aclperms.pl | ||
| check-aclrules.pl | ||
| check-driverimpls.pl | ||
| check-drivername.pl | ||
| check-symfile.pl | ||
| check-symsorting.pl | ||
| datatypes.c | ||
| datatypes.h | ||
| driver-hypervisor.h | ||
| driver-interface.h | ||
| driver-network.h | ||
| driver-nodedev.h | ||
| driver-nwfilter.h | ||
| driver-secret.h | ||
| driver-state.h | ||
| driver-storage.h | ||
| driver-stream.h | ||
| driver.c | ||
| driver.h | ||
| dtrace2systemtap.pl | ||
| internal.h | ||
| libvirt_admin_private.syms | ||
| libvirt_admin_public.syms | ||
| libvirt_atomic.syms | ||
| libvirt_driver_modules.syms | ||
| libvirt_esx.syms | ||
| libvirt_internal.h | ||
| libvirt_libssh2.syms | ||
| libvirt_libssh.syms | ||
| libvirt_linux.syms | ||
| libvirt_lxc.syms | ||
| libvirt_openvz.syms | ||
| libvirt_private.syms | ||
| libvirt_probes.d | ||
| libvirt_public.syms | ||
| libvirt_qemu_probes.d | ||
| libvirt_qemu.syms | ||
| libvirt_remote.syms | ||
| libvirt_sasl.syms | ||
| libvirt_vmware.syms | ||
| libvirt_vmx.syms | ||
| libvirt_xenconfig.syms | ||
| libvirt-admin.c | ||
| libvirt-admin.conf | ||
| libvirt-domain-snapshot.c | ||
| libvirt-domain.c | ||
| libvirt-host.c | ||
| libvirt-interface.c | ||
| libvirt-lxc.c | ||
| libvirt-lxc.pc.in | ||
| libvirt-network.c | ||
| libvirt-nodedev.c | ||
| libvirt-nwfilter.c | ||
| libvirt-qemu.c | ||
| libvirt-qemu.pc.in | ||
| libvirt-secret.c | ||
| libvirt-storage.c | ||
| libvirt-stream.c | ||
| libvirt.c | ||
| libvirt.conf | ||
| libvirt.pc.in | ||
| lock_protocol-structs | ||
| lxc_monitor_protocol-structs | ||
| lxc_protocol-structs | ||
| Makefile.am | ||
| qemu_protocol-structs | ||
| README | ||
| remote_protocol-structs | ||
| virkeepaliveprotocol-structs | ||
| virnetprotocol-structs | ||
libvirt library code README
===========================
The directory provides the bulk of the libvirt codebase. Everything
except for the libvirtd daemon and client tools. The build uses a
large number of libtool convenience libraries - one for each child
directory, and then links them together for the final libvirt.so,
although some bits get linked directly to libvirtd daemon instead.
The files directly in this directory are supporting the public API
entry points & data structures.
There are two core shared modules to be aware of:
* util/ - a collection of shared APIs that can be used by any
code. This directory is always in the include path
for all things built
* conf/ - APIs for parsing / manipulating all the official XML
files used by the public API. This directory is only
in the include path for driver implementation modules
* vmx/ - VMware VMX config handling (used by esx/ and vmware/)
Then there are the hypervisor implementations:
* bhyve - bhyve - The BSD Hypervisor
* esx/ - VMware ESX and GSX support using vSphere API over SOAP
* hyperv/ - Microsoft Hyper-V support using WinRM
* lxc/ - Linux Native Containers
* openvz/ - OpenVZ containers using cli tools
* phyp/ - IBM Power Hypervisor using CLI tools over SSH
* qemu/ - QEMU / KVM using qemu CLI/monitor
* remote/ - Generic libvirt native RPC client
* test/ - A "mock" driver for testing
* uml/ - User Mode Linux
* vbox/ - Virtual Box using native API
* vmware/ - VMware Workstation and Player using the vmrun tool
* xen/ - Xen using hypercalls, XenD SEXPR & XenStore
* xenapi/ - Xen using libxenserver
Finally some secondary drivers that are shared for several HVs.
Currently these are used by LXC, OpenVZ, QEMU, UML and Xen drivers.
The ESX, Hyper-V, Power Hypervisor, Remote, Test & VirtualBox drivers all
implement the secondary drivers directly
* cpu/ - CPU feature management
* interface/ - Host network interface management
* network/ - Virtual NAT networking
* nwfilter/ - Network traffic filtering rules
* node_device/ - Host device enumeration
* secret/ - Secret management
* security/ - Mandatory access control drivers
* storage/ - Storage management drivers
Since both the hypervisor and secondary drivers can be built as
dlopen()able modules, it is *FORBIDDEN* to have build dependencies
between these directories. Drivers are only allowed to depend on
the public API, and the internal APIs in the util/ and conf/
directories