libvirt/tools
Martin Kletzander 0ac13b189f virsh: Do not try connecting first time without polkit agent
Trying to connect once without a polkit agent will generate an error on the
server side which seems too rough given it only serves the purpose of the client
(virsh in this case) to figure out that an agent is needed.  Thankfully we can
just try running the agent.  It does not break anything as we are running it
with `--fallback`, which makes sure it does not replace an existing agent in
case there is one already registered.

The second piece of code trying to start the polkit text agent is kept in order
to _really_ try out starting the agent (and error out when failing to do so)
just in case the agent was not available the first time it was ran.  Even though
it should not happen it avoids a very rare race condition and really does not
add much complexity.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1945501

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
2021-11-23 12:51:09 +01:00
..
bash-completion tools: Generate per-command bash completion script 2021-04-22 11:01:27 +02:00
nss Don't call qsort() over NULL 2021-06-14 14:16:44 +02:00
wireshark Remove references to deleted Makefile.am 2021-04-13 11:21:00 +02:00
libvirt_recover_xattrs.sh tools: Fix dry run of libvirt_recover_xattrs.sh 2021-03-02 09:42:38 +01:00
libvirt_win_icon_16x16.ico
libvirt_win_icon_32x32.ico
libvirt_win_icon_48x48.ico
libvirt_win_icon_64x64.ico
libvirt-guests.service.in build: don't hardcode /etc in the config related files 2019-08-09 14:06:31 +01:00
libvirt-guests.sh.in libvirt-guests: Sync time for autostarted guests 2020-11-04 12:18:05 +01:00
libvirt-guests.sysconf libvirt-guests: Remove obsolete Windows comment 2020-12-07 10:38:44 +00:00
meson.build tools: Add virt-pki-query-dn binary 2021-11-12 12:37:29 +01:00
virsh_win_icon.rc
virsh-backup.c virsh: Use 'virshCompletePathLocalExisting' for options reading local files 2021-09-17 09:40:46 +02:00
virsh-backup.h backup: Implement virsh support for backup 2019-12-10 12:41:56 +01:00
virsh-checkpoint.c virsh: Introduce virshCompleteEmpty and use it for places where we can't suggest anything 2021-09-17 09:40:46 +02:00
virsh-checkpoint.h backup: Implement virsh support for checkpoints 2019-07-26 16:48:58 -05:00
virsh-completer-checkpoint.c tools: virsh: use automatic cleanup for virDomainObj 2021-08-16 13:10:33 +02:00
virsh-completer-checkpoint.h virsh-completer*.h: Use modern header style 2021-09-17 09:40:46 +02:00
virsh-completer-domain.c virsh-completer: Provide completer for '--top' and '--base' for blockjobs 2021-09-17 09:40:46 +02:00
virsh-completer-domain.h virsh-completer: Provide completer for '--top' and '--base' for blockjobs 2021-09-17 09:40:46 +02:00
virsh-completer-host.c virsh-host: Avoid 'vir' prefix for locally declared VIR_ENUM* helpers 2021-07-23 09:59:12 +02:00
virsh-completer-host.h virsh-completer*.h: Use modern header style 2021-09-17 09:40:46 +02:00
virsh-completer-interface.c virsh: Add wrapper for virInterfaceFree 2021-10-06 09:23:25 +02:00
virsh-completer-interface.h virsh-completer*.h: Use modern header style 2021-09-17 09:40:46 +02:00
virsh-completer-network.c virsh: Add wrapper for virNetworkFree 2021-10-06 09:25:47 +02:00
virsh-completer-network.h virsh-completer*.h: Use modern header style 2021-09-17 09:40:46 +02:00
virsh-completer-nodedev.c virsh: Add wrapper for virNodeDeviceFree 2021-10-06 09:26:25 +02:00
virsh-completer-nodedev.h virsh-completer*.h: Use modern header style 2021-09-17 09:40:46 +02:00
virsh-completer-nwfilter.c virsh: Add wrapper for virNWFilterFree 2021-10-06 09:27:03 +02:00
virsh-completer-nwfilter.h virsh-completer*.h: Use modern header style 2021-09-17 09:40:46 +02:00
virsh-completer-pool.c virsh: Add wrapper for virStoragePoolFree 2021-10-06 09:24:17 +02:00
virsh-completer-pool.h virsh-completer*.h: Use modern header style 2021-09-17 09:40:46 +02:00
virsh-completer-secret.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virsh-completer-secret.h virsh-completer*.h: Use modern header style 2021-09-17 09:40:46 +02:00
virsh-completer-snapshot.c tools: virsh: use automatic cleanup for virDomainObj 2021-08-16 13:10:33 +02:00
virsh-completer-snapshot.h virsh-completer*.h: Use modern header style 2021-09-17 09:40:46 +02:00
virsh-completer-volume.c virsh: Add wrapper for virStorageVolFree 2021-10-06 09:25:22 +02:00
virsh-completer-volume.h virsh-completer*.h: Use modern header style 2021-09-17 09:40:46 +02:00
virsh-completer.c virsh: Introduce virshCompleteEmpty and use it for places where we can't suggest anything 2021-09-17 09:40:46 +02:00
virsh-completer.h virsh: Introduce virshCompleteEmpty and use it for places where we can't suggest anything 2021-09-17 09:40:46 +02:00
virsh-console.c virsh: Add wrapper for virStreamFree 2021-10-06 09:27:43 +02:00
virsh-console.h tools: use #pragma once in headers 2019-06-19 17:12:34 +02:00
virsh-domain-monitor.c virsh: Display vhostuser socket path in domblklist 2021-09-09 13:56:06 +02:00
virsh-domain-monitor.h virsh: Fix virshDomainInterfaceSourceCompleter 2020-01-07 16:12:55 +01:00
virsh-domain.c lib: Drop needless one line labels 2021-11-22 12:39:59 +01:00
virsh-domain.h virsh: Support vhostuser in attach-interface 2021-08-18 14:21:40 +02:00
virsh-edit.c Use G_GNUC_FALLTHROUGH instead of ATTRIBUTE_FALLTHROUGH 2019-10-15 16:14:19 +02:00
virsh-host.c lib: Drop needless one line labels 2021-11-22 12:39:59 +01:00
virsh-host.h virsh-host: Avoid 'vir' prefix for locally declared VIR_ENUM* helpers 2021-07-23 09:59:12 +02:00
virsh-interface.c virsh: Add wrapper for virInterfaceFree 2021-10-06 09:23:25 +02:00
virsh-interface.h tools: use #pragma once in headers 2019-06-19 17:12:34 +02:00
virsh-network.c virsh: Add wrapper for virNetworkFree 2021-10-06 09:25:47 +02:00
virsh-network.h tools: use #pragma once in headers 2019-06-19 17:12:34 +02:00
virsh-nodedev.c lib: Drop needless one line labels 2021-11-22 12:39:59 +01:00
virsh-nodedev.h tools: s/Nodedev/NodeDevice/ 2019-08-09 09:03:53 +02:00
virsh-nwfilter.c virsh: Add wrapper for virNWFilterFree 2021-10-06 09:27:03 +02:00
virsh-nwfilter.h tools: use #pragma once in headers 2019-06-19 17:12:34 +02:00
virsh-pool.c virsh: Add wrapper for virStoragePoolFree 2021-10-06 09:24:17 +02:00
virsh-pool.h virsh-pool: Remove static from virshStoragePoolList{Free,Collect} 2021-06-16 10:32:33 +02:00
virsh-secret.c virsh: Introduce virshCompleteEmpty and use it for places where we can't suggest anything 2021-09-17 09:40:46 +02:00
virsh-secret.h tools: remove unnecessary includes 2020-08-03 15:30:40 +02:00
virsh-snapshot.c tools: virsh-snapshot: refactor small functions 2021-09-20 09:35:22 +02:00
virsh-snapshot.h tools: remove unnecessary includes 2020-08-03 15:30:40 +02:00
virsh-util.c virsh: Add wrapper for virStreamFree 2021-10-06 09:27:43 +02:00
virsh-util.h virsh: Add wrapper for virStreamFree 2021-10-06 09:27:43 +02:00
virsh-volume.c lib: Drop needless one line labels 2021-11-22 12:39:59 +01:00
virsh-volume.h tools: use #pragma once in headers 2019-06-19 17:12:34 +02:00
virsh.c virsh: Do not try connecting first time without polkit agent 2021-11-23 12:51:09 +01:00
virsh.h virsh: completer: Introduce dummy completer for local files 2021-09-17 09:40:46 +02:00
virt-admin-completer.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virt-admin-completer.h tools: use #pragma once in headers 2019-06-19 17:12:34 +02:00
virt-admin.c virsh: Remove hack using 'VSH_CMD_FLAG_ALIAS' to hide virsh commands 2021-09-17 09:40:46 +02:00
virt-admin.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virt-host-validate-bhyve.c virt-host-validate-bhyve.c: Reintroduce @ret to virHostValidateBhyve() 2020-05-05 14:45:58 +02:00
virt-host-validate-bhyve.h tools: use #pragma once in headers 2019-06-19 17:12:34 +02:00
virt-host-validate-ch.c tools: add virt-host-validate-ch for ch driver 2021-10-12 17:28:35 +02:00
virt-host-validate-ch.h tools: add virt-host-validate-ch for ch driver 2021-10-12 17:28:35 +02:00
virt-host-validate-common.c tools: Fix virt-host-validate SEV detection 2021-10-06 11:23:24 -06:00
virt-host-validate-common.h tools: only fail validations if VIR_HOST_VALIDATE_FAIL is set 2021-06-08 08:52:07 +02:00
virt-host-validate-lxc.c
virt-host-validate-lxc.h tools: use #pragma once in headers 2019-06-19 17:12:34 +02:00
virt-host-validate-qemu.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virt-host-validate-qemu.h tools: use #pragma once in headers 2019-06-19 17:12:34 +02:00
virt-host-validate.c tools: add virt-host-validate-ch for ch driver 2021-10-12 17:28:35 +02:00
virt-login-shell-helper.c Prefer g_auto(GStrv) over g_strfreev() 2021-11-11 16:16:17 +01:00
virt-login-shell.c build: generate configmake.h in root directory 2020-01-29 14:51:39 +00:00
virt-login-shell.conf
virt-pki-query-dn.c tools: Add virt-pki-query-dn binary 2021-11-12 12:37:29 +01:00
virt-pki-validate.in tools: Fix permissions for virt-pki-validate.in 2019-07-01 17:20:32 +02:00
virt-sanlock-cleanup.in
virt-xml-validate.in tools: fix XML validator detection of network port XML schema 2019-09-12 16:06:57 +01:00
vsh-table.c util: alloc: Reimplement VIR_APPEND_ELEMENT using virAppendElement 2021-08-06 08:53:25 +02:00
vsh-table.h vsh: table: define cleanup function 2021-08-11 10:52:58 +02:00
vsh.c Prefer g_auto(GStrv) over g_strfreev() 2021-11-11 16:16:17 +01:00
vsh.h vsh: Introduce '--completers-missing' for 'self-test' command 2021-09-17 09:40:46 +02:00