Laine Stump a2c1bedbd8 util: fix virFileOpenAs return value and resulting error logs ... This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=851411 https://bugzilla.redhat.com/show_bug.cgi?id=955500 The first problem was that virFileOpenAs was returning fd (-1) in one of the error cases rather than ret (-errno), so the caller thought that the error was EPERM rather than ENOENT. The second problem was that some log messages in the general purpose qemuOpenFile() function would always say "Failed to create" even if the caller hadn't included O_CREAT (i.e. they were trying to open an existing file). This fixes virFileOpenAs to jump down to the error return (which returns ret instead of fd) in the previously mentioned incorrect failure case of virFileOpenAs(), removes all error logging from virFileOpenAs() (since the callers report it), and modifies qemuOpenFile to appropriately use "open" or "create" in its log messages. NB: I seriously considered removing logging from all callers of virFileOpenAs(), but there is at least one case where the caller doesn't want virFileOpenAs() to log any errors, because it's just going to try again (qemuOpenFile()). We can't simply make a silent variation of virFileOpenAs() though, because qemuOpenFile() can't make the decision about whether or not it wants to retry until after virFileOpenAs() has already returned an error code. Likewise, I also considered changing virFileOpenAs() to return -1 with errno set on return, and may still do that, but only as a separate patch, as it obscures the intent of this patch too much.		2013-05-10 13:09:25 -04:00
..
libxl_conf.c	Adapt to VIR_STRDUP and VIR_STRNDUP in src/libxl/*	2013-05-09 14:00:45 +02:00
libxl_conf.h	maint: Rename xmlconf to xmlopt and virDomainXMLConfig to virDomainXMLOption	2013-04-04 22:18:56 +02:00
libxl_driver.c	util: fix virFileOpenAs return value and resulting error logs	2013-05-10 13:09:25 -04:00
libxl_driver.h	maint: fix up copyright notice inconsistencies	2012-09-20 16:30:55 -06:00