libvirt

mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-28 23:45:20 +00:00

History

Eric Blake 00ef048f62 fdstream: drop delete argument

Revert 6a1f5f568f8.  Now that libvirt_iohelper takes fds by
inheritance rather than by open() (commit 1eb66479), there is
no longer a race where the parent can unlink() a file prior to
the iohelper open()ing the same file.  From there, it makes
more sense to have the callers both create and unlink, rather
than the caller create and the stream unlink, since the latter
was only needed when iohelper had to do the unlink.

* src/fdstream.h (virFDStreamOpenFile, virFDStreamCreateFile):
Callers are responsible for deletion.
* src/fdstream.c (virFDStreamOpenFileInternal): Don't leak created
file on failure.
(virFDStreamOpenFile, virFDStreamCreateFile): Drop parameter.
* src/lxc/lxc_driver.c (lxcDomainOpenConsole): Update callers.
* src/qemu/qemu_driver.c (qemuDomainScreenshot)
(qemuDomainOpenConsole): Likewise.
* src/storage/storage_driver.c (storageVolumeDownload)
(storageVolumeUpload): Likewise.
* src/uml/uml_driver.c (umlDomainOpenConsole): Likewise.
* src/vbox/vbox_tmpl.c (vboxDomainScreenshot): Likewise.
* src/xen/xen_driver.c (xenUnifiedDomainOpenConsole): Likewise.

2011-08-02 14:53:43 -06:00

block_stats.c

build: rename files.h to virfile.h

2011-07-21 10:34:51 -06:00

block_stats.h

Remove virConnectPtr from virRaiseErrorFull

2011-04-17 07:22:23 +02:00

xen_driver.c

fdstream: drop delete argument

2011-08-02 14:53:43 -06:00

xen_driver.h

xen: drop unused callbacks