libvirt/src/vbox
Eric Blake 11f20e43f1 event: move event filtering to daemon (regression fix)
https://bugzilla.redhat.com/show_bug.cgi?id=1058839

Commit f9f56340 for CVE-2014-0028 almost had the right idea - we
need to check the ACL rules to filter which events to send.  But
it overlooked one thing: the event dispatch queue is running in
the main loop thread, and therefore does not normally have a
current virIdentityPtr.  But filter checks can be based on current
identity, so when libvirtd.conf contains access_drivers=["polkit"],
we ended up rejecting access for EVERY event due to failure to
look up the current identity, even if it should have been allowed.

Furthermore, even for events that are triggered by API calls, it
is important to remember that the point of events is that they can
be copied across multiple connections, which may have separate
identities and permissions.  So even if events were dispatched
from a context where we have an identity, we must change to the
correct identity of the connection that will be receiving the
event, rather than basing a decision on the context that triggered
the event, when deciding whether to filter an event to a
particular connection.

If there were an easy way to get from virConnectPtr to the
appropriate virIdentityPtr, then object_event.c could adjust the
identity prior to checking whether to dispatch an event.  But
setting up that back-reference is a bit invasive.  Instead, it
is easier to delay the filtering check until lower down the
stack, at the point where we have direct access to the RPC
client object that owns an identity.  As such, this patch ends
up reverting a large portion of the framework of commit f9f56340.
We also have to teach 'make check' to special-case the fact that
the event registration filtering is done at the point of dispatch,
rather than the point of registration.  Note that even though we
don't actually use virConnectDomainEventRegisterCheckACL (because
the RegisterAny variant is sufficient), we still generate the
function for the purposes of documenting that the filtering
takes place.

Also note that I did not entirely delete the notion of a filter
from object_event.c; I still plan on using that for my upcoming
patch series for qemu monitor events in libvirt-qemu.so.  In
other words, while this patch changes ACL filtering to live in
remote.c and therefore we have no current client of the filtering
in object_event.c, the notion of filtering in object_event.c is
still useful down the road.

* src/check-aclrules.pl: Exempt event registration from having to
pass checkACL filter down call stack.
* daemon/remote.c (remoteRelayDomainEventCheckACL)
(remoteRelayNetworkEventCheckACL): New functions.
(remoteRelay*Event*): Use new functions.
* src/conf/domain_event.h (virDomainEventStateRegister)
(virDomainEventStateRegisterID): Drop unused parameter.
* src/conf/network_event.h (virNetworkEventStateRegisterID):
Likewise.
* src/conf/domain_event.c (virDomainEventFilter): Delete unused
function.
* src/conf/network_event.c (virNetworkEventFilter): Likewise.
* src/libxl/libxl_driver.c: Adjust caller.
* src/lxc/lxc_driver.c: Likewise.
* src/network/bridge_driver.c: Likewise.
* src/qemu/qemu_driver.c: Likewise.
* src/remote/remote_driver.c: Likewise.
* src/test/test_driver.c: Likewise.
* src/uml/uml_driver.c: Likewise.
* src/vbox/vbox_tmpl.c: Likewise.
* src/xen/xen_driver.c: Likewise.

Signed-off-by: Eric Blake <eblake@redhat.com>
2014-02-05 08:03:31 -07:00
..
README maint: refer to correct license file 2013-05-20 14:32:11 -06:00
vbox_CAPI_v2_2.h maint: refer to correct license file 2013-05-20 14:32:11 -06:00
vbox_CAPI_v3_0.h maint: refer to correct license file 2013-05-20 14:32:11 -06:00
vbox_CAPI_v3_1.h maint: refer to correct license file 2013-05-20 14:32:11 -06:00
vbox_CAPI_v3_2.h maint: refer to correct license file 2013-05-20 14:32:11 -06:00
vbox_CAPI_v4_0.h maint: refer to correct license file 2013-05-20 14:32:11 -06:00
vbox_CAPI_v4_1.h maint: refer to correct license file 2013-05-20 14:32:11 -06:00
vbox_CAPI_v4_2_20.h vbox: add support for v4.2.20+ and v4.3.4+ 2014-01-22 23:12:52 +01:00
vbox_CAPI_v4_2.h Add support for VirtualBox 4.2 APIs 2013-06-07 14:47:45 +01:00
vbox_CAPI_v4_3_4.h vbox: add support for v4.2.20+ and v4.3.4+ 2014-01-22 23:12:52 +01:00
vbox_CAPI_v4_3.h vbox: import vbox_CAPI_v4_3.h from SDK 2013-11-25 13:25:12 +02:00
vbox_driver.c vbox: add support for v4.2.20+ and v4.3.4+ 2014-01-22 23:12:52 +01:00
vbox_driver.h maint: refer to correct license file 2013-05-20 14:32:11 -06:00
vbox_glue.c maint: fix up copyright notice inconsistencies 2012-09-20 16:30:55 -06:00
vbox_glue.h maint: fix up copyright notice inconsistencies 2012-09-20 16:30:55 -06:00
vbox_MSCOMGlue.c Adapt to VIR_ALLOC and virAsprintf in src/vbox/* 2013-07-10 11:07:33 +02:00
vbox_MSCOMGlue.h maint: fix up copyright notice inconsistencies 2012-09-20 16:30:55 -06:00
vbox_tmpl.c event: move event filtering to daemon (regression fix) 2014-02-05 08:03:31 -07:00
vbox_V2_2.c vbox: add support for v4.2.20+ and v4.3.4+ 2014-01-22 23:12:52 +01:00
vbox_V3_0.c vbox: add support for v4.2.20+ and v4.3.4+ 2014-01-22 23:12:52 +01:00
vbox_V3_1.c vbox: add support for v4.2.20+ and v4.3.4+ 2014-01-22 23:12:52 +01:00
vbox_V3_2.c vbox: add support for v4.2.20+ and v4.3.4+ 2014-01-22 23:12:52 +01:00
vbox_V4_0.c vbox: add support for v4.2.20+ and v4.3.4+ 2014-01-22 23:12:52 +01:00
vbox_V4_1.c vbox: add support for v4.2.20+ and v4.3.4+ 2014-01-22 23:12:52 +01:00
vbox_V4_2_20.c vbox: add support for v4.2.20+ and v4.3.4+ 2014-01-22 23:12:52 +01:00
vbox_V4_2.c vbox: add support for v4.2.20+ and v4.3.4+ 2014-01-22 23:12:52 +01:00
vbox_V4_3_4.c vbox: add support for v4.2.20+ and v4.3.4+ 2014-01-22 23:12:52 +01:00
vbox_V4_3.c vbox: add support for v4.2.20+ and v4.3.4+ 2014-01-22 23:12:52 +01:00
vbox_XPCOMCGlue.c Remove all direct use of getenv 2013-10-21 14:03:52 +01:00
vbox_XPCOMCGlue.h maint: refer to correct license file 2013-05-20 14:32:11 -06:00

    Licensing

Note that much of the vbox in this directory is LGPLv2-only.  Thus, it
cannot be linked into any software that also wants to use GPLv3+ code.
This readme file is:

Copyright (C) 2009, 2013 Red Hat, Inc.

Copying and distribution of this file, with or without modification,
are permitted in any medium without royalty provided the copyright
notice and this notice are preserved.  This file is offered as-is,
without warranty of any kind.

    Explanation about the how multi-version support
    for VirtualBox libvirt driver is implemented.

Since VirtualBox adds multiple new features for each release, it is but
natural that the C API which VirtualBox exposes is volatile across
versions and thus needs a good mechanism to handle multiple versions
during runtime. The solution was something like this:

Firstly the file structure is as below:

vbox_CAPI_v2_2.h
vbox_XPCOMCGlue.h
vbox_XPCOMCGlue.c
These files are C API/glue code files directly taken from the
VirtualBox OSE source and is needed for C API to work as expected.

vbox_driver.h
vbox_driver.c
These files have the main logic for registering the virtualbox driver
with libvirt.

vbox_V2_2.c
The file which has version dependent changes and includes the template
file for given below for all of its functionality.

vbox_tmpl.c
The file where all the real driver implementation code exists.

Now there would be a vbox_V*.c file (for eg: vbox_V2_2.c for V2.2) for
each major virtualbox version which would do some preprocessor magic
and include the template file (vbox_tmpl.c) in it for the functionality
it offers.