External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-11-02 11:21:12 +00:00
Code Issues Packages Projects Releases Wiki Activity
10a8b1f958
libvirt/src/security
History
Eric Blake 3e2c3d8f6d build: use correct type for pid and similar types 
No thanks to 64-bit windows, with 64-bit pid_t, we have to avoid
constructs like 'int pid'.  Our API in libvirt-qemu cannot be
changed without breaking ABI; but then again, libvirt-qemu can
only be used on systems that support UNIX sockets, which rules
out Windows (even if qemu could be compiled there) - so for all
points on the call chain that interact with this API decision,
we require a different variable name to make it clear that we
audited the use for safety.

Adding a syntax-check rule only solves half the battle; anywhere
that uses printf on a pid_t still needs to be converted, but that
will be a separate patch.

* cfg.mk (sc_correct_id_types): New syntax check.
* src/libvirt-qemu.c (virDomainQemuAttach): Document why we didn't
use pid_t for pid, and validate for overflow.
* include/libvirt/libvirt-qemu.h (virDomainQemuAttach): Tweak name
for syntax check.
* src/vmware/vmware_conf.c (vmwareExtractPid): Likewise.
* src/driver.h (virDrvDomainQemuAttach): Likewise.
* tools/virsh.c (cmdQemuAttach): Likewise.
* src/remote/qemu_protocol.x (qemu_domain_attach_args): Likewise.
* src/qemu_protocol-structs (qemu_domain_attach_args): Likewise.
* src/util/cgroup.c (virCgroupPidCode, virCgroupKillInternal):
Likewise.
* src/qemu/qemu_command.c(qemuParseProcFileStrings): Likewise.
(qemuParseCommandLinePid): Use pid_t for pid.
* daemon/libvirtd.c (daemonForkIntoBackground): Likewise.
* src/conf/domain_conf.h (_virDomainObj): Likewise.
* src/probes.d (rpc_socket_new): Likewise.
* src/qemu/qemu_command.h (qemuParseCommandLinePid): Likewise.
* src/qemu/qemu_driver.c (qemudGetProcessInfo, qemuDomainAttach):
Likewise.
* src/qemu/qemu_process.c (qemuProcessAttach): Likewise.
* src/qemu/qemu_process.h (qemuProcessAttach): Likewise.
* src/uml/uml_driver.c (umlGetProcessInfo): Likewise.
* src/util/virnetdev.h (virNetDevSetNamespace): Likewise.
* src/util/virnetdev.c (virNetDevSetNamespace): Likewise.
* tests/testutils.c (virtTestCaptureProgramOutput): Likewise.
* src/conf/storage_conf.h (_virStoragePerms): Use mode_t, uid_t,
and gid_t rather than int.
* src/security/security_dac.c (virSecurityDACSetOwnership): Likewise.
* src/conf/storage_conf.c (virStorageDefParsePerms): Avoid
compiler warning.
2012-03-02 06:57:43 -07:00
..
security_apparmor.c apparmor: Mark pid parameter as unused 2012-01-11 12:27:47 +01:00
security_apparmor.h Refactor the security drivers to simplify usage 2011-01-10 18:10:52 +00:00
security_dac.c build: use correct type for pid and similar types 2012-03-02 06:57:43 -07:00
security_dac.h Refactor the security drivers to simplify usage 2011-01-10 18:10:52 +00:00
security_driver.c Refactor the security drivers to simplify usage 2011-01-10 18:10:52 +00:00
security_driver.h Change security driver APIs to use virDomainDefPtr instead of virDomainObjPtr 2012-01-11 09:52:18 +00:00
security_manager.c security: Driver 'none' cannot create confined guests 2012-02-08 11:55:56 +01:00
security_manager.h Add two new security label types 2012-02-02 17:44:37 -07:00
security_nop.c Change security driver APIs to use virDomainDefPtr instead of virDomainObjPtr 2012-01-11 09:52:18 +00:00
security_nop.h Refactor the security drivers to simplify usage 2011-01-10 18:10:52 +00:00
security_selinux.c qemu: eliminate "Ignoring open failure" when using root-squash NFS 2012-02-03 16:47:43 -05:00
security_selinux.h Refactor the security drivers to simplify usage 2011-01-10 18:10:52 +00:00
security_stack.c Change security driver APIs to use virDomainDefPtr instead of virDomainObjPtr 2012-01-11 09:52:18 +00:00
security_stack.h Refactor the security drivers to simplify usage 2011-01-10 18:10:52 +00:00
virt-aa-helper.c apparmor: Add missing comma 2012-02-06 09:22:46 +01:00