mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-08-27 19:11:16 +00:00
Right-aligning backslashes when defining macros or using complex commands in Makefiles looks cute, but as soon as any changes is required to the code you end up with either distractingly broken alignment or unnecessarily big diffs where most of the changes are just pushing all backslashes a few characters to one side. Generated using $ git grep -El '[[:blank:]][[:blank:]]\\$' | \ grep -E '*\.([chx]|am|mk)$$' | \ while read f; do \ sed -Ei 's/[[:blank:]]*[[:blank:]]\\$/ \\/g' "$f"; \ done Signed-off-by: Andrea Bolognani <abologna@redhat.com>
217 lines
5.5 KiB
C
217 lines
5.5 KiB
C
#include <config.h>
|
|
|
|
#include "testutils.h"
|
|
|
|
#ifdef WITH_BHYVE
|
|
|
|
# include "datatypes.h"
|
|
|
|
# include "util/viruuid.h"
|
|
# include "bhyve/bhyve_driver.h"
|
|
# include "bhyve/bhyve_capabilities.h"
|
|
# include "bhyve/bhyve_utils.h"
|
|
# include "bhyve/bhyve_parse_command.h"
|
|
|
|
# define VIR_FROM_THIS VIR_FROM_BHYVE
|
|
|
|
static bhyveConn driver;
|
|
|
|
typedef enum {
|
|
FLAG_EXPECT_FAILURE = 1,
|
|
FLAG_EXPECT_PARSE_ERROR = 2,
|
|
FLAG_EXPECT_WARNING = 4,
|
|
} virBhyveArgv2XMLTestFlags;
|
|
|
|
static int
|
|
testCompareXMLToArgvFiles(const char *xmlfile,
|
|
const char *cmdfile,
|
|
unsigned int flags)
|
|
|
|
{
|
|
char *actualxml = NULL;
|
|
char *cmd = NULL;
|
|
char *log = NULL;
|
|
int ret = -1;
|
|
virDomainDefPtr vmdef = NULL;
|
|
|
|
if (virTestLoadFile(cmdfile, &cmd) < 0)
|
|
goto fail;
|
|
|
|
if (!(vmdef = bhyveParseCommandLineString(cmd, driver.bhyvecaps,
|
|
driver.xmlopt))) {
|
|
if ((flags & FLAG_EXPECT_FAILURE) && !virTestOOMActive()) {
|
|
VIR_TEST_DEBUG("Got expected failure from "
|
|
"bhyveParseCommandLineString.\n");
|
|
} else {
|
|
goto fail;
|
|
}
|
|
} else if ((flags & FLAG_EXPECT_FAILURE) && !virTestOOMActive()) {
|
|
VIR_TEST_DEBUG("Did not get expected failure from "
|
|
"bhyveParseCommandLineString.\n");
|
|
goto fail;
|
|
}
|
|
|
|
if (!virTestOOMActive()) {
|
|
if ((log = virTestLogContentAndReset()) == NULL)
|
|
goto fail;
|
|
if (flags & FLAG_EXPECT_WARNING) {
|
|
if (*log) {
|
|
VIR_TEST_DEBUG("Got expected warning from "
|
|
"bhyveParseCommandLineString:\n%s",
|
|
log);
|
|
} else {
|
|
VIR_TEST_DEBUG("bhyveParseCommandLineString "
|
|
"should have logged a warning\n");
|
|
goto fail;
|
|
}
|
|
} else { /* didn't expect a warning */
|
|
if (*log) {
|
|
VIR_TEST_DEBUG("Got unexpected warning from "
|
|
"bhyveParseCommandLineString:\n%s",
|
|
log);
|
|
goto fail;
|
|
}
|
|
}
|
|
}
|
|
|
|
if (vmdef && !virDomainDefCheckABIStability(vmdef, vmdef, driver.xmlopt)) {
|
|
VIR_TEST_DEBUG("ABI stability check failed on %s", xmlfile);
|
|
goto fail;
|
|
}
|
|
|
|
if (vmdef && !(actualxml = virDomainDefFormat(vmdef, driver.caps, 0)))
|
|
goto fail;
|
|
|
|
if (vmdef && virTestCompareToFile(actualxml, xmlfile) < 0)
|
|
goto fail;
|
|
|
|
ret = 0;
|
|
|
|
fail:
|
|
VIR_FREE(actualxml);
|
|
VIR_FREE(cmd);
|
|
VIR_FREE(log);
|
|
virDomainDefFree(vmdef);
|
|
return ret;
|
|
}
|
|
|
|
struct testInfo {
|
|
const char *name;
|
|
unsigned int flags;
|
|
};
|
|
|
|
static int
|
|
testCompareXMLToArgvHelper(const void *data)
|
|
{
|
|
int result = -1;
|
|
const struct testInfo *info = data;
|
|
char *xml = NULL;
|
|
char *args = NULL;
|
|
|
|
if (virAsprintf(&xml, "%s/bhyveargv2xmldata/bhyveargv2xml-%s.xml",
|
|
abs_srcdir, info->name) < 0 ||
|
|
virAsprintf(&args, "%s/bhyveargv2xmldata/bhyveargv2xml-%s.args",
|
|
abs_srcdir, info->name) < 0)
|
|
goto cleanup;
|
|
|
|
result = testCompareXMLToArgvFiles(xml, args, info->flags);
|
|
|
|
cleanup:
|
|
VIR_FREE(xml);
|
|
VIR_FREE(args);
|
|
return result;
|
|
}
|
|
|
|
static int
|
|
mymain(void)
|
|
{
|
|
int ret = 0;
|
|
|
|
if ((driver.caps = virBhyveCapsBuild()) == NULL)
|
|
return EXIT_FAILURE;
|
|
|
|
if ((driver.xmlopt = virDomainXMLOptionNew(NULL, NULL,
|
|
NULL, NULL, NULL)) == NULL)
|
|
return EXIT_FAILURE;
|
|
|
|
# define DO_TEST_FULL(name, flags) \
|
|
do { \
|
|
static struct testInfo info = { \
|
|
name, (flags) \
|
|
}; \
|
|
if (virTestRun("BHYVE ARGV-2-XML " name, \
|
|
testCompareXMLToArgvHelper, &info) < 0) \
|
|
ret = -1; \
|
|
} while (0)
|
|
|
|
# define DO_TEST(name) \
|
|
DO_TEST_FULL(name, 0)
|
|
|
|
# define DO_TEST_FAIL(name) \
|
|
DO_TEST_FULL(name, 5)
|
|
|
|
# define DO_TEST_WARN(name) \
|
|
DO_TEST_FULL(name, 4)
|
|
|
|
# define DO_TEST_FAIL_SILENT(name) \
|
|
DO_TEST_FULL(name, 1)
|
|
|
|
# define DO_TEST_PARSE_ERROR(name) \
|
|
DO_TEST_FULL(name, 2)
|
|
|
|
driver.grubcaps = BHYVE_GRUB_CAP_CONSDEV;
|
|
driver.bhyvecaps = BHYVE_CAP_RTC_UTC;
|
|
|
|
DO_TEST("base");
|
|
DO_TEST("oneline");
|
|
DO_TEST("name");
|
|
DO_TEST("console");
|
|
DO_TEST_FAIL("console2");
|
|
DO_TEST_FAIL("console3");
|
|
DO_TEST_FAIL("console4");
|
|
DO_TEST("acpiapic");
|
|
DO_TEST("utc");
|
|
DO_TEST("vcpus");
|
|
DO_TEST("cdrom");
|
|
DO_TEST("ahci-hd");
|
|
DO_TEST("virtio-blk");
|
|
DO_TEST("virtio-net");
|
|
DO_TEST("e1000");
|
|
DO_TEST_WARN("virtio-net2");
|
|
DO_TEST_WARN("virtio-net3");
|
|
DO_TEST_WARN("virtio-net4");
|
|
DO_TEST_WARN("disk-toomany");
|
|
DO_TEST("uuid");
|
|
DO_TEST_FAIL("uuid2");
|
|
DO_TEST("memsize-large");
|
|
DO_TEST("memsize-human");
|
|
DO_TEST_FAIL("memsize-fail");
|
|
DO_TEST("custom-loader");
|
|
DO_TEST("bhyveload-custom");
|
|
DO_TEST("bhyveload-vda");
|
|
DO_TEST_FAIL("bhyveload-name-mismatch");
|
|
DO_TEST_FAIL("bhyverun-name-mismatch");
|
|
DO_TEST_FAIL("bhyveload-mem-mismatch");
|
|
DO_TEST_FAIL("bhyverun-mem-mismatch");
|
|
DO_TEST_FAIL("bhyveload-mem-mismatch");
|
|
DO_TEST_FAIL("bhyveload-memsize-fail");
|
|
DO_TEST("bhyveload-bootorder");
|
|
DO_TEST_FAIL("extraargs");
|
|
|
|
virObjectUnref(driver.caps);
|
|
virObjectUnref(driver.xmlopt);
|
|
|
|
return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
|
|
}
|
|
|
|
VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/bhyveargv2xmlmock.so")
|
|
|
|
#else
|
|
|
|
int main(void)
|
|
{
|
|
return EXIT_AM_SKIP;
|
|
}
|
|
|
|
#endif /* WITH_BHYVE */
|