libvirt/src
Eric Blake 1413560966 snapshot: fix memory leak on error
Leak introduced in commit 0436d32.  If we allocate an actions array,
but fail early enough to never consume it with the qemu monitor
transaction call, we leaked memory.

But our semantics of making the transaction command free the caller's
memory is awkward; avoiding the memory leak requires making every
intermediate function in the call chain check for error.  It is much
easier to fix things so that the function that allocates also frees,
while the call chain leaves the caller's data intact.  To do that,
I had to hack our JSON data structure to make it easy to protect a
portion of an arbitrary JSON tree from being freed.

* src/util/json.h (virJSONType): Name the enum.
(_virJSONValue): New field.
* src/util/json.c (virJSONValueFree): Use it to protect a portion
of an array.
* src/qemu/qemu_monitor_json.c (qemuMonitorJSONTransaction): Avoid
freeing caller's data.
* src/qemu/qemu_driver.c (qemuDomainSnapshotCreateDiskActive):
Free actions array on failure.
2012-04-06 08:39:34 -06:00
..
conf conf: Plug memory leaks on virDomainDiskDefParseXML 2012-04-05 17:41:05 +08:00
cpu Cleanup for a return statement in source files 2012-03-26 14:45:22 -06:00
esx Consistent style for usage of sizeof operator 2012-03-30 11:47:24 +01:00
hyperv Consistent style for usage of sizeof operator 2012-03-30 11:47:24 +01:00
interface Cleanup for a return statement in source files 2012-03-26 14:45:22 -06:00
libxl Consistent style for usage of sizeof operator 2012-03-30 11:47:24 +01:00
locking sanlock: Use STREQ_NULLABLE instead of STREQ on strings that may be null 2012-03-08 11:49:32 +01:00
lxc Consistent style for usage of sizeof operator 2012-03-30 11:47:24 +01:00
network Attach vm-id to Open vSwitch interfaces. 2012-03-08 14:44:15 -05:00
node_device Consistent style for usage of sizeof operator 2012-03-30 11:47:24 +01:00
nwfilter Cleanup for a return statement in source files 2012-03-26 14:45:22 -06:00
openvz openvz: support vzctl 3.1 2012-04-04 14:32:15 -06:00
phyp Lookup auth credentials in config file before prompting 2012-03-23 13:24:07 +00:00
qemu snapshot: fix memory leak on error 2012-04-06 08:39:34 -06:00
remote Fix typo in previous patch 2012-03-30 12:44:28 +01:00
rpc Consistent style for usage of sizeof operator 2012-03-30 11:47:24 +01:00
secret secret: add Ceph secret type 2011-10-28 11:34:17 -06:00
security Consistent style for usage of sizeof operator 2012-03-30 11:47:24 +01:00
storage Consistent style for usage of sizeof operator 2012-03-30 11:47:24 +01:00
test Cleanup for a return statement in source files 2012-03-26 14:45:22 -06:00
uml Consistent style for usage of sizeof operator 2012-03-30 11:47:24 +01:00
util snapshot: fix memory leak on error 2012-04-06 08:39:34 -06:00
vbox Consistent style for usage of sizeof operator 2012-03-30 11:47:24 +01:00
vmware build: use correct type for pid and similar types 2012-03-02 06:57:43 -07:00
vmx Centralize error reporting for URI parsing/formatting problems 2012-03-23 12:59:21 +00:00
xen Consistent style for usage of sizeof operator 2012-03-30 11:47:24 +01:00
xenapi Consistent style for usage of sizeof operator 2012-03-30 11:47:24 +01:00
xenxs xen config: No vfb in HVM guest configuration 2012-04-06 12:54:16 +08:00
datatypes.c Cleanup for a return statement in source files 2012-03-26 14:45:22 -06:00
datatypes.h Fixed URI parsing 2012-02-24 16:49:21 -07:00
driver.c libvirt: do not mix internal flags into public API 2011-07-18 13:50:51 -06:00
driver.h xml: use long long internally, to centralize overflow checks 2012-03-07 18:24:43 -07:00
dtrace2systemtap.pl Add a systemtap script for watching QEMU monitor interactions 2011-10-27 10:42:14 +01:00
fdstream.c fdstream: Add internal callback on stream close 2012-02-27 15:05:17 +01:00
fdstream.h fdstream: Add internal callback on stream close 2012-02-27 15:05:17 +01:00
gnutls_1_0_compat.h Fix detection of GnuTLS 1.x.y 2011-08-03 19:22:29 +02:00
internal.h Consistent style for usage of sizeof operator 2012-03-30 11:47:24 +01:00
libvirt_daemon.syms
libvirt_dbus.syms Fix build on Mingw32 wrt export of virNetServerGetDBusConn 2011-11-21 11:46:52 +00:00
libvirt_driver_modules.syms
libvirt_internal.h Introduce virConnectSetKeepAlive 2011-11-24 11:44:08 +01:00
libvirt_linux.syms Add linuxNodeInfoCPUPopulate to src/libvirt_linux.syms 2012-04-04 14:33:27 +01:00
libvirt_network.syms network: provide internal API to return IP of a network 2011-07-25 13:48:55 +08:00
libvirt_nwfilter.syms
libvirt_private.syms Support clock=variable relative to localtime 2012-04-02 09:08:31 -06:00
libvirt_public.syms Introduce virDomainPMWakeup API 2012-02-27 11:43:59 +01:00
libvirt_qemu.syms Define a QEMU specific API to attach to a running QEMU process 2011-07-12 15:39:03 +01:00
libvirt_sasl.syms build: fix mingw build without sasl 2011-10-11 16:30:25 -06:00
libvirt_vmx.syms esx: Move VMX handling code out of the driver directory 2010-12-21 22:40:17 +01:00
libvirt_xenxs.syms Fix build with --with-driver-modules enabled 2011-05-27 09:51:28 +02:00
libvirt-qemu.c build: use correct type for pid and similar types 2012-03-02 06:57:43 -07:00
libvirt.c build: fix mingw ssize_t, syntax check 2012-03-30 11:10:54 -06:00
libvirt.conf Allow overriding default URI in config file 2012-03-15 11:20:17 +00:00
Makefile.am Add helper API for finding auth file path 2012-03-23 13:24:07 +00:00
nodeinfo.c Consistent style for usage of sizeof operator 2012-03-30 11:47:24 +01:00
nodeinfo.h add nodeGetCPUmap() for getting available CPU IDs in a cpumap. 2012-03-06 21:54:48 -07:00
probes.d build: use correct type for pid and similar types 2012-03-02 06:57:43 -07:00
qemu_protocol-structs build: use correct type for pid and similar types 2012-03-02 06:57:43 -07:00
README hyperv: Add basic documentation 2011-08-26 17:52:55 +02:00
remote_protocol-structs build: fix incorrect enum declaration 2012-03-23 14:29:00 -06:00
virkeepaliveprotocol-structs build: Properly generate and check virkeepaliveprotocol-structs 2011-11-24 14:44:04 +01:00
virnetprotocol-structs Extend RPC protocol to allow FD passing 2011-10-28 10:27:15 +01:00

       libvirt library code README
       ===========================

The directory provides the bulk of the libvirt codebase. Everything
except for the libvirtd daemon and client tools. The build uses a
large number of libtool convenience libraries - one for each child
directory, and then links them together for the final libvirt.so,
although some bits get linked directly to libvirtd daemon instead.

The files directly in this directory are supporting the public API
entry points & data structures.

There are two core shared modules to be aware of:

 * util/  - a collection of shared APIs that can be used by any
            code. This directory is always in the include path
            for all things built

 * conf/  - APIs for parsing / manipulating all the official XML
            files used by the public API. This directory is only
            in the include path for driver implementation modules

 * vmx/   - VMware VMX config handling (used by esx/ and vmware/)


Then there are the hypervisor implementations:

 * esx/          - VMware ESX and GSX support using vSphere API over SOAP
 * hyperv/       - Microsoft Hyper-V support using WinRM
 * lxc/          - Linux Native Containers
 * openvz/       - OpenVZ containers using cli tools
 * phyp/         - IBM Power Hypervisor using CLI tools over SSH
 * qemu/         - QEMU / KVM using qemu CLI/monitor
 * remote/       - Generic libvirt native RPC client
 * test/         - A "mock" driver for testing
 * uml/          - User Mode Linux
 * vbox/         - Virtual Box using native API
 * vmware/       - VMware Workstation and Player using the vmrun tool
 * xen/          - Xen using hypercalls, XenD SEXPR & XenStore
 * xenapi/       - Xen using libxenserver


Finally some secondary drivers that are shared for several HVs.
Currently these are used by LXC, OpenVZ, QEMU, UML and Xen drivers.
The ESX, Hyper-V, Power Hypervisor, Remote, Test & VirtualBox drivers all
implement the secondary drivers directly

 * cpu/          - CPU feature management
 * interface/    - Host network interface management
 * network/      - Virtual NAT networking
 * nwfilter/     - Network traffic filtering rules
 * node_device/  - Host device enumeration
 * secret/       - Secret management
 * security/     - Mandatory access control drivers
 * storage/      - Storage management drivers


Since both the hypervisor and secondary drivers can be built as
dlopen()able modules, it is *FORBIDDEN* to have build dependencies
between these directories. Drivers are only allowed to depend on
the public API, and the internal APIs in the util/ and conf/
directories