mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2025-01-09 06:25:19 +00:00
158ba8730e
The dispatcher functions have numerous places where they
return to the caller. This leads to duplicated cleanup
code, often resulting in memory leaks. It makes it harder
to ensure that errors are dispatched before freeing objects,
which may overwrite the original error.
The standard pattern is now
remoteDispatchXXX(...) {
int rv = -1;
....
if (XXX < 0)
goto cleanup;
...
if (XXXX < 0)
goto cleanup;
...
rv = 0;
cleanup:
if (rv < 0)
remoteDispatchError(rerr);
...free all other stuff..
return rv;
}
* daemon/remote.c: Centralize all cleanup paths
* daemon/stream.c: s/remoteDispatchConnError/remoteDispatchError/
* daemon/dispatch.c, daemon/dispatch.h: Replace
remoteDispatchConnError with remoteDispatchError
removing unused virConnectPtr
|
||
|---|---|---|
| .. | ||
| .gitignore | ||
| dispatch.c | ||
| dispatch.h | ||
| libvirtd.aug | ||
| libvirtd.c | ||
| libvirtd.conf | ||
| libvirtd.h | ||
| libvirtd.init.in | ||
| libvirtd.logrotate.in | ||
| libvirtd.lxc.logrotate.in | ||
| libvirtd.pod.in | ||
| libvirtd.policy-0 | ||
| libvirtd.policy-1 | ||
| libvirtd.qemu.logrotate.in | ||
| libvirtd.sasl | ||
| libvirtd.stp | ||
| libvirtd.sysconf | ||
| libvirtd.uml.logrotate.in | ||
| libvirtd.upstart | ||
| Makefile.am | ||
| mdns.c | ||
| mdns.h | ||
| probes.d | ||
| qemu_dispatch_args.h | ||
| qemu_dispatch_prototypes.h | ||
| qemu_dispatch_ret.h | ||
| qemu_dispatch_table.h | ||
| remote_dispatch_args.h | ||
| remote_dispatch_prototypes.h | ||
| remote_dispatch_ret.h | ||
| remote_dispatch_table.h | ||
| remote_generate_stubs.pl | ||
| remote.c | ||
| remote.h | ||
| stream.c | ||
| stream.h | ||
| test_libvirtd.aug | ||
| THREADING.txt | ||