libvirt/tests
Andrea Bolognani 1839c5c46e qemu: Improve error message for failed firmware autoselection
The current message can be misleading, because it seems to suggest
that no firmware of the requested type is available on the system.

What actually happens most of the time, however, is that despite
having multiple firmwares of the right type to choose from, none
of them is suitable because of lacking some specific feature or
being incompatible with some setting that the user has explicitly
enabled.

Providing an error message that describes exactly the problem is
not feasible, since we would have to list each candidate along
with the reason why we rejected it, which would get out of hand
quickly.

As a small but hopefully helpful improvement over the current
situation, reword the error message to make it clearer that the
culprit is not necessarily the firmware type, but rather the
overall domain configuration.

Suggested-by: Michael Kjörling <7d1340278307@ewoof.net>
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
2023-09-22 15:50:35 +02:00
..
bhyveargv2xmldata
bhyvefirmwaredata
bhyvexml2argvdata
bhyvexml2xmloutdata
capabilityschemadata
chxml2xmlin tests: chxml2xmlin: Fix path format for fake paths 2023-08-25 10:07:36 +02:00
chxml2xmlout test: Introduce chxml2xmltest 2023-02-14 13:59:45 +01:00
commanddata
cputestdata scripts: Fix the flake8 syntax-check failures 2023-06-29 11:51:27 +02:00
domainbackupxml2xmlin schemas: backup: Allow missing 'type' attribute for backup disk 2023-05-16 10:26:33 +02:00
domainbackupxml2xmlout schemas: backup: Allow missing 'type' attribute for backup disk 2023-05-16 10:26:33 +02:00
domaincapsdata cpu_map: Add cpu model EPYC Genoa 2023-09-06 20:35:45 +02:00
domainconfdata
domainschemadata tests: qemu: Move testing of default cache and disk source with space to 'sata-device' 2023-03-06 20:55:49 +01:00
fchostdata/fc_host
genericxml2xmlindata conf: Generate MAC address instead of keeping all zeroes 2023-09-04 16:01:24 +02:00
genericxml2xmloutdata conf: Generate MAC address instead of keeping all zeroes 2023-09-04 16:01:24 +02:00
interfaceschemadata
libxlxml2domconfigdata libxl: Support specifying a custom firmware path 2023-03-10 11:01:42 -07:00
lxcconf2xmldata
lxcxml2xmldata
lxcxml2xmloutdata
networkxml2confdata
networkxml2firewalldata
networkxml2xmlin
networkxml2xmlout
networkxml2xmlupdatein
networkxml2xmlupdateout
nodedevmdevctldata nodedevmdevctltest: Introduce a test case for empty mdevctl output 2023-08-24 13:46:22 +02:00
nodedevschemadata
nodedevxml2xmlout
nssdata
nwfilterxml2firewalldata
nwfilterxml2xmlin nwfilterxml2xmltest: Add test case for parser and formatter quirks 2023-06-05 13:23:06 +02:00
nwfilterxml2xmlout virNWFilterRuleDefDetailsFormat: Refactor formatter 2023-06-05 13:23:06 +02:00
qemuagentdata qemuagenttest: Use real x86_64 capabilities for parsing domain definitions 2023-07-20 15:23:34 +02:00
qemublocktestdata schema: allow 'ssh' as a protocol for network disks 2023-09-19 14:28:49 -05:00
qemucapabilitiesdata qemu: add virtio-blk-vhost-vdpa capability 2023-09-12 11:06:41 -05:00
qemucaps2xmloutdata Revert "capabilities: report full external snapshot support" 2023-09-01 12:09:04 +02:00
qemudomaincheckpointxml2xmlin
qemudomaincheckpointxml2xmlout qemudomaincheckpointxml2xmltest: Use real 'x86_64' capabilities in all test data 2023-07-20 15:23:43 +02:00
qemudomainsnapshotxml2xmlin
qemudomainsnapshotxml2xmlout tests: qemudomainsnapshotxml2xmlout: Use real 'x86_64' capabilities in all test data 2023-07-20 15:23:24 +02:00
qemufirmwaredata tests: Drop tags from BIOS firmware descriptor 2023-08-21 13:51:26 +02:00
qemuhotplugtestcpus tests: qemuhotplugtest: Fix arch-specific parts of 'ppc64' test XMLs 2023-09-04 10:31:52 +02:00
qemuhotplugtestdevices qemu: Move channelTargetDir into stateDir 2023-08-17 17:22:09 +02:00
qemuhotplugtestdomains qemu: Move channelTargetDir into stateDir 2023-08-17 17:22:09 +02:00
qemumemlockdata qemu_domain: Increase memlock limit for NVMe disks 2023-04-20 08:37:22 +02:00
qemumigparamsdata
qemumigrationcookiexmldata
qemumonitorjsondata
qemunbdkitdata qemu: implement ssh-agent auth for ssh disks with nbdkit 2023-09-19 14:28:50 -05:00
qemusecuritydata
qemustatusxml2xmldata qemu: include nbdkit state in private xml 2023-09-19 14:28:50 -05:00
qemuvhostuserdata
qemuxml2argvdata qemu: Improve error message for failed firmware autoselection 2023-09-22 15:50:35 +02:00
qemuxml2xmloutdata qemuxml2argvtest: Consolidate and modernize CPU topology testing 2023-09-06 14:09:45 +02:00
schemas
secretxml2xmlin
securityselinuxhelperdata
securityselinuxlabeldata
storagepoolcapsschemadata
storagepoolschemadata
storagepoolxml2argvdata
storagepoolxml2xmlin
storagepoolxml2xmlout
storagevolschemadata
storagevolxml2argvdata
storagevolxml2xmlin
storagevolxml2xmlout
sysinfodata
vboxsnapshotxmldata
viracpidata tests: Introduce viracpitest 2023-04-06 12:48:22 +02:00
vircaps2xmldata virnumamock: Introduce virNumaGetNodeOfCPU() mock 2023-03-15 12:46:21 +01:00
vircgroupdata
virconfdata
virfilecachedata
virfiledata
virhostcpudata
virjsondata
virmacmaptestdata
virnetdaemondata
virnetdevopenvswitchdata
virnetdevtestdata/sys/class/net
virnetworkportxml2xmldata
virnwfilterbindingxml2xmldata
virpcitestdata
virprocessstatdata
virresctrldata
virscsidata
virstoragetestdata
virstorageutildata
virusbtestdata/sys_bus_usb/devices
vmwareverdata
vmx2xmldata
xlconfigdata libxl: Add support for custom firmware path in config converter 2023-03-10 11:02:02 -07:00
xmconfigdata
xml2vmxdata
.valgrind.supp tests: Refresh valgrind suppressions 2023-07-20 11:22:08 +02:00
bhyveargv2xmlmock.c
bhyveargv2xmltest.c
bhyvexml2argvmock.c
bhyvexml2argvtest.c
bhyvexml2xmltest.c
chxml2xmltest.c test: Introduce chxml2xmltest 2023-02-14 13:59:45 +01:00
commandhelper.c
commandtest.c vircommand: Introduce virCommandMassCloseRange() 2023-08-24 12:45:00 +02:00
cputest.c qemu: capabilities: Don't make callers check return of virQEMUCapsNew(Binary) 2023-03-06 20:55:50 +01:00
domaincapsmock.c qemu: S390 does not provide physical address size 2023-07-19 08:42:08 +02:00
domaincapstest.c domaincapstest: Use obviously fake firmware name in capabilities 2023-07-20 15:22:20 +02:00
domainconftest.c
esxutilstest.c
eventtest.c
fchosttest.c
fdstreamtest.c
genericxml2xmltest.c conf: Generate MAC address instead of keeping all zeroes 2023-09-04 16:01:24 +02:00
interfacexml2xmltest.c
libvirtd-fail
libvirtd-pool
libxlmock.c lib: Finish using struct zero initializer manually 2023-08-03 16:41:19 +02:00
libxlxml2domconfigtest.c libxl: Support specifying a custom firmware path 2023-03-10 11:01:42 -07:00
lxcconf2xmltest.c
lxcxml2xmltest.c
meson.build qemu: Monitor nbdkit process for exit 2023-09-19 14:28:50 -05:00
metadatatest.c
networkmetadatatest.c Add Test driver and testcase for Network Metadata change APIs 2023-08-25 12:36:37 +02:00
networkxml2conftest.c
networkxml2firewalltest.c
networkxml2xmltest.c
networkxml2xmlupdatetest.c
nodedevmdevctltest.c nodedevmdevctltest: Introduce a test case for empty mdevctl output 2023-08-24 13:46:22 +02:00
nodedevxml2xmltest.c
nsslinktest.c
nssmock.c
nsstest.c lib: use struct zero initializer instead of memset 2023-08-03 16:41:19 +02:00
nwfilterebiptablestest.c
nwfilterxml2firewalltest.c lib: use struct zero initializer instead of memset 2023-08-03 16:41:19 +02:00
nwfilterxml2xmltest.c nwfilterxml2xmltest: Add test case for parser and formatter quirks 2023-06-05 13:23:06 +02:00
objecteventtest.c
openvzutilstest.c
openvzutilstest.conf
permitted_file_access.txt
pkix_asn1_tab.c
qemuagenttest.c qemuagenttest: Use real x86_64 capabilities for parsing domain definitions 2023-07-20 15:23:34 +02:00
qemublocktest.c schema: allow 'ssh' as a protocol for network disks 2023-09-19 14:28:49 -05:00
qemucapabilitiesnumbering.c tests: Add support for multiple variants of data for the same qemu version+architecture 2023-04-03 09:19:06 +02:00
qemucapabilitiestest.c qemucapabilitiestest: Add support for '+hvf' variant 2023-04-03 09:19:06 +02:00
qemucaps2xmlmock.c
qemucaps2xmltest.c virQEMUCapsInitGuestFromBinary: Remove return value 2023-04-03 09:19:07 +02:00
qemucapsprobe.c
qemucapsprobemock.c tests: Remove unused includes 2022-06-16 06:43:58 +02:00
qemucommandutiltest.c
qemucpumock.c
qemudomaincheckpointxml2xmltest.c qemudomaincheckpointxml2xmltest: Use real 'x86_64' capabilities in all test data 2023-07-20 15:23:43 +02:00
qemudomainsnapshotxml2xmltest.c tests: qemudomainsnapshotxml2xmlout: Use real 'x86_64' capabilities in all test data 2023-07-20 15:23:24 +02:00
qemufirmwaretest.c tests: Include microvm in firmwaretest 2023-08-21 13:51:27 +02:00
qemuhotplugmock.c qemu: make vdpa connect function more generic 2023-09-12 11:06:41 -05:00
qemuhotplugtest.c qemuhotplugtest: Remove 'modern' field for cpu hotplug tests 2023-09-04 10:31:52 +02:00
qemumemlocktest.c qemumemlocktest: Use 'testQemuInsertRealCaps' 2023-07-20 15:23:16 +02:00
qemumigparamstest.c
qemumigrationcookiexmltest.c qemumigrationcookiexmltest: Don't fetch latest caps files without using them 2023-04-03 09:19:06 +02:00
qemumonitorjsontest.c lib: Finish using struct zero initializer manually 2023-08-03 16:41:19 +02:00
qemumonitortestutils.c lib: use struct zero initializer instead of memset 2023-08-03 16:41:19 +02:00
qemumonitortestutils.h Drop unused qemuMonitorTestAddItemParams 2023-06-05 13:20:12 +02:00
qemunbdkittest.c qemu: implement keyfile auth for ssh disks with nbdkit 2023-09-19 14:28:50 -05:00
qemusecuritymock.c
qemusecuritytest.c qemuTestCapsCacheInsert*: Drop the file cache rather than poisoning it 2023-03-06 20:55:50 +01:00
qemusecuritytest.h
qemustatusxml2xmltest.c qemustatusxml2xmltest: Remove capabilities infrastructure 2023-09-06 14:09:46 +02:00
qemuvhostusertest.c
qemuxml2argvmock.c qemu: make vdpa connect function more generic 2023-09-12 11:06:41 -05:00
qemuxml2argvtest.c qemu: implement password auth for ssh disks with nbdkit 2023-09-19 14:28:50 -05:00
qemuxml2xmltest.c qemuxml2argvtest: Consolidate and modernize CPU topology testing 2023-09-06 14:09:45 +02:00
scsihosttest.c tests: Move fakerootdir handling to common logic 2023-03-03 13:52:37 +01:00
seclabeltest.c
secretxml2xmltest.c
securityselinuxhelper.c
securityselinuxlabeltest.c securityselinuxlabeltest: Convert to testQemuInsertRealCaps 2023-09-06 14:09:42 +02:00
securityselinuxtest.c
shunloadhelper.c
shunloadtest.c syntax-check: sc_avoid_write: Don't use blanket file exceptions 2022-02-15 09:32:23 +01:00
sockettest.c lib: Finish using struct zero initializer manually 2023-08-03 16:41:19 +02:00
ssh.c
storagepoolcapstest.c
storagepoolxml2argvtest.c
storagepoolxml2xmltest.c
storagevolxml2argvtest.c
storagevolxml2xmltest.c
sysinfotest.c
test-lib.sh
testutils.c testutils: Print number of failed tests 2023-07-20 14:59:57 +02:00
testutils.h tests: Introduce helpers for fakerootdir handling 2023-03-03 13:52:37 +01:00
testutilshostcpus.h tests: qemu: Add 'ppc' machine caps based on 'qemu-system-ppc' on fedora 2023-03-06 20:55:50 +01:00
testutilslxc.c tests: Remove unused includes 2022-06-16 06:43:58 +02:00
testutilslxc.h
testutilsqemu.c tests: add ability to test various nbdkit capabilities 2023-09-19 14:28:50 -05:00
testutilsqemu.h tests: add ability to test various nbdkit capabilities 2023-09-19 14:28:50 -05:00
testutilsqemuschema.c testQEMUSchemaValidateObjectMember: validate QMP object member deprecation 2023-06-05 13:20:13 +02:00
testutilsqemuschema.h
testutilsxen.c virCapabilitiesAllocMachines: Use NULL-terminated list as argument and return count 2023-04-03 09:19:07 +02:00
testutilsxen.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
utiltest.c virStringParseVersion: Parse into 'unsigned long long' 2023-04-03 09:19:06 +02:00
vboxsnapshotxmltest.c
viracpitest.c tests: Introduce viracpitest 2023-04-06 12:48:22 +02:00
viralloctest.c
virauthconfigtest.c
virbitmaptest.c Use G_N_ELEMENTS() more 2023-03-13 13:29:07 +01:00
virbuftest.c
vircaps2xmltest.c
vircgroupmock.c
vircgrouptest.c tests: Adopt fakerootdir helpers 2023-03-03 13:52:37 +01:00
virconftest.c
vircryptotest.c vircryptotest: Fix cipher test typo aes265cbc -> aes256cbc 2023-04-03 08:21:27 +02:00
virdnsmasqmock.c
virdriverconnvalidatetest.c
virdrivermoduletest.c tests: Remove unused includes 2022-06-16 06:43:58 +02:00
virendiantest.c
virerrortest.c util: Update format strings in translated messages (part 1) 2023-04-01 11:40:35 +02:00
virfilecachemock.c
virfilecachetest.c
virfilemock.c
virfiletest.c
virfilewrapper.c
virfilewrapper.h
virfirewallmock.c virfirewallmock: Replace virFindFileInPath() with virFirewallDIsRegistered() 2023-05-10 14:44:22 +02:00
virfirewalltest.c tests: Drop dead code 2023-04-04 10:52:15 +02:00
virgdbusmock.c
virhostcpumock.c
virhostcputest.c lib: use struct zero initializer instead of memset 2023-08-03 16:41:19 +02:00
virhostdevmock.c
virhostdevtest.c util: use "stubDriverType" instead of just "stubDriver" 2023-08-24 23:36:18 -04:00
virhostidmock.c
viridentitytest.c
viriscsitest.c
virjsontest.c virjsontest: Introduce a test case for an empty array 2023-08-24 13:47:41 +02:00
virkeycodetest.c
virkmodtest.c
virlockspacetest.c
virlogtest.c
virmacmaptest.c
virmigtest.c
virmock.h
virmockstathelpers.c virmockstathelpers: Adapt to musl-1.2.4 2023-05-16 08:48:17 +02:00
virnetdaemonmock.c
virnetdaemontest.c
virnetdevbandwidthmock.c
virnetdevbandwidthtest.c
virnetdevmock.c
virnetdevopenvswitchtest.c
virnetdevtest.c Use G_N_ELEMENTS() more 2023-03-13 13:29:07 +01:00
virnetmessagetest.c lib: use struct zero initializer instead of memset 2023-08-03 16:41:19 +02:00
virnetserverclientmock.c
virnetserverclienttest.c
virnetsockettest.c Decrease scope of some variables 2023-08-03 16:35:11 +02:00
virnettlscontexttest.c
virnettlshelpers.c
virnettlshelpers.h
virnettlssessiontest.c
virnetworkportxml2xmltest.c
virnumamock.c virnumamock: Introduce virNumaGetNodeOfCPU() mock 2023-03-15 12:46:21 +01:00
virnwfilterbindingxml2xmltest.c
virpcimock.c
virpcitest.c util: rename virPCIDeviceGetDriverPathAndName 2023-08-24 23:36:18 -04:00
virpcivpdtest.c
virpolkittest.c tests: fix incorrect free of GVariant in our GLib mock functions 2020-10-02 12:43:15 +02:00
virportallocatormock.c
virportallocatortest.c
virprocessmock.c
virprocessstattest.c
virrandommock.c virrandommock: Drop virRandomGenerateWWN 2023-07-19 13:09:11 +02:00
virresctrltest.c
virrotatingfiletest.c
virschematest.c virschematest: Validate files in 'chxml2xmlin' and 'chxml2xmlout' directories 2023-08-25 10:07:36 +02:00
virscsitest.c
virsh-auth scripts: Fix the flake8 syntax-check failures 2023-06-29 11:51:27 +02:00
virsh-auth.xml
virsh-checkpoint
virsh-cpuset
virsh-define-dev-segfault
virsh-int-overflow
virsh-optparse
virsh-output
virsh-output-commands
virsh-output.out
virsh-read-bufsiz
virsh-read-non-seekable
virsh-schedinfo
virsh-self-test
virsh-snapshot
virsh-start
virsh-undefine
virsh-uriprecedence
virsh-vcpupin
virshtest.c
virstoragetest.c
virstorageutiltest.c
virstringtest.c util: Remove virStrToLong_l 2023-06-14 12:47:54 +02:00
virsystemdtest.c
virt-aa-helper-test
virt-admin-self-test
virtestmock.c
virtimetest.c
virtypedparamtest.c
viruritest.c Drop checks for virURIFormat() retval 2023-02-08 16:50:45 +01:00
virusbmock.c
virusbtest.c
vmwarevertest.c
vmx2xmltest.c
vshtabletest.c
xlconfigtest.c
xmconfigtest.c
xml2vmxtest.c