mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-27 08:05:24 +00:00
014208c4d0
The nodeinfo is reporting incorrect number of cpus and incorrect host topology on PPC64 KVM hosts. The KVM hypervisor on PPC64 needs only the primary thread in a core to be online, and the secondaries offlined. While scheduling a guest in, the kvm scheduler wakes up the secondaries to run in guest context. The host scheduling of the guests happen at the core level(as only primary thread is online). The kvm scheduler exploits as many threads of the core as needed by guest. Further, starting POWER8, the processor allows splitting a physical core into multiple subcores with 2 or 4 threads each. Again, only the primary thread in a subcore is online in the host. The KVM-PPC scheduler allows guests to exploit all the offline threads in the subcore, by bringing them online when needed. (Kernel patches on split-core http://www.spinics.net/lists/kvm-ppc/msg09121.html) Recently with dynamic micro-threading changes in ppc-kvm, makes sure to utilize all the offline cpus across guests, and across guests with different cpu topologies. (https://www.mail-archive.com/kvm@vger.kernel.org/msg115978.html) Since the offline cpus are brought online in the guest context, it is safe to count them as online. Nodeinfo today discounts these offline cpus from cpu count/topology calclulation, and the nodeinfo output is not of any help and the host appears overcommited when it is actually not. The patch carefully counts those offline threads whose primary threads are online. The host topology displayed by the nodeinfo is also fixed when the host is in valid kvm state. Signed-off-by: Shivaprasad G Bhat <sbhat@linux.vnet.ibm.com> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
78 lines
2.8 KiB
C
78 lines
2.8 KiB
C
/*
|
|
* nodeinfo.h: Helper routines for OS specific node information
|
|
*
|
|
* Copyright (C) 2006-2008, 2011-2012 Red Hat, Inc.
|
|
* Copyright (C) 2006 Daniel P. Berrange
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*
|
|
* Author: Daniel P. Berrange <berrange@redhat.com>
|
|
*/
|
|
|
|
#ifndef __VIR_NODEINFO_H__
|
|
# define __VIR_NODEINFO_H__
|
|
|
|
# include "capabilities.h"
|
|
|
|
int nodeGetInfo(const char *sysfs_prefix, virNodeInfoPtr nodeinfo);
|
|
int nodeCapsInitNUMA(const char *sysfs_prefix, virCapsPtr caps);
|
|
|
|
int nodeGetCPUStats(int cpuNum,
|
|
virNodeCPUStatsPtr params,
|
|
int *nparams,
|
|
unsigned int flags);
|
|
int nodeGetMemoryStats(const char *sysfs_prefix,
|
|
int cellNum,
|
|
virNodeMemoryStatsPtr params,
|
|
int *nparams,
|
|
unsigned int flags);
|
|
int nodeGetCellsFreeMemory(unsigned long long *freeMems,
|
|
int startCell,
|
|
int maxCells);
|
|
int nodeGetMemory(unsigned long long *mem,
|
|
unsigned long long *freeMem);
|
|
|
|
virBitmapPtr nodeGetPresentCPUBitmap(const char *sysfs_prefix);
|
|
virBitmapPtr nodeGetOnlineCPUBitmap(const char *sysfs_prefix);
|
|
int nodeGetCPUCount(const char *sysfs_prefix);
|
|
int nodeGetThreadsPerSubcore(virArch arch);
|
|
|
|
int nodeGetMemoryParameters(virTypedParameterPtr params,
|
|
int *nparams,
|
|
unsigned int flags);
|
|
|
|
int nodeSetMemoryParameters(virTypedParameterPtr params,
|
|
int nparams,
|
|
unsigned int flags);
|
|
|
|
int nodeGetCPUMap(const char *sysfs_prefix,
|
|
unsigned char **cpumap,
|
|
unsigned int *online,
|
|
unsigned int flags);
|
|
|
|
int nodeGetFreePages(unsigned int npages,
|
|
unsigned int *pages,
|
|
int startCell,
|
|
unsigned int cellCount,
|
|
unsigned long long *counts);
|
|
|
|
int nodeAllocPages(unsigned int npages,
|
|
unsigned int *pageSizes,
|
|
unsigned long long *pageCounts,
|
|
int startCell,
|
|
unsigned int cellCount,
|
|
bool add);
|
|
#endif /* __VIR_NODEINFO_H__*/
|