mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-25 15:15:25 +00:00
a48c714115
The current LUKS support has a "luks" volume type which has
a "luks" encryption format.
This partially makes sense if you consider the QEMU shorthand
syntax only requires you to specify a format=luks, and it'll
automagically uses "raw" as the next level driver. QEMU will
however let you override the "raw" with any other driver it
supports (vmdk, qcow, rbd, iscsi, etc, etc)
IOW the intention though is that the "luks" encryption format
is applied to all disk formats (whether raw, qcow2, rbd, gluster
or whatever). As such it doesn't make much sense for libvirt
to say the volume type is "luks" - we should be saying that it
is a "raw" file, but with "luks" encryption applied.
IOW, when creating a storage volume we should use this XML
<volume>
<name>demo.raw</name>
<capacity>5368709120</capacity>
<target>
<format type='raw'/>
<encryption format='luks'>
<secret type='passphrase' uuid='0a81f5b2-8403-7b23-c8d6-21ccd2f80d6f'/>
</encryption>
</target>
</volume>
and when configuring a guest disk we should use
<disk type='file' device='disk'>
<driver name='qemu' type='raw'/>
<source file='/home/berrange/VirtualMachines/demo.raw'/>
<target dev='sda' bus='scsi'/>
<encryption format='luks'>
<secret type='passphrase' uuid='0a81f5b2-8403-7b23-c8d6-21ccd2f80d6f'/>
</encryption>
</disk>
This commit thus removes the "luks" storage volume type added
in
commit
|
||
|---|---|---|
| .. | ||
| vol-file-backing.xml | ||
| vol-file-naming.xml | ||
| vol-file.xml | ||
| vol-gluster-dir-neg-uid.xml | ||
| vol-gluster-dir.xml | ||
| vol-logical-backing.xml | ||
| vol-logical.xml | ||
| vol-luks-cipher.xml | ||
| vol-luks.xml | ||
| vol-partition.xml | ||
| vol-qcow2-0.10-lazy.xml | ||
| vol-qcow2-1.1.xml | ||
| vol-qcow2-lazy.xml | ||
| vol-qcow2-nobacking.xml | ||
| vol-qcow2-nocapacity.xml | ||
| vol-qcow2-nocow.xml | ||
| vol-qcow2.xml | ||
| vol-sheepdog.xml | ||