Michal Privoznik 1c24cfe9d8 virNumaSetPagePoolSize: Produce friendlier error message ...

https://bugzilla.redhat.com/show_bug.cgi?id=1224587

The function takes two important arguments (among many others): @node
and @page_size. From these two a path under /sys is constructed. The
path is then used to read and write the desired size of huge pages
pool. However, if the path does not exists due to either @node or
@page_size having nonexistent value (e.g. there's no such NUMA node or
no page size like -2), an cryptic error message is produced:

  virsh # allocpages --pagesize 2049 --pagecount 8 --cellno -2
  error: Failed to open file '/sys/devices/system/node/node-2/hugepages/hugepages-2049kB/nr_hugepages': No such file or directory

Add two more checks to catch this and therefore produce much more
friendlier error messages.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>

2015-06-10 17:27:16 +02:00

..

iohelper.c

Indent top-level labels by one space in src/util/

2014-03-25 14:58:40 +01:00

keymaps.csv

…

viralloc.c

maint: avoid static zero init in core files

2014-10-29 09:55:09 -06:00

viralloc.h

util: forbid freeing const pointers

2014-07-16 06:48:53 -06:00

virarch.c

Add virLogSource variables to all source files

2014-03-18 14:29:22 +00:00

virarch.h

Cpu: Add support for Power LE Architecture.

2014-11-07 09:16:37 +01:00

viratomic.c

Change file names in comments to match the files they are in

2014-03-10 14:26:04 +01:00

viratomic.h

…

viraudit.c

audit: use bool for audit log choice

2014-10-29 09:55:09 -06:00

viraudit.h

audit: use bool for audit log choice

2014-10-29 09:55:09 -06:00

virauth.c

Remove unnecessary curly brackets in src/util/

2014-11-14 17:13:35 +01:00

virauth.h

virAuth: Don't require virConnectPtr to retrieve authentication creds

2013-07-12 09:22:38 +02:00

virauthconfig.c

Indent top-level labels by one space in src/util/

2014-03-25 14:58:40 +01:00

virauthconfig.h

…

virbitmap.c

util: bitmap: Add virBitmapToDataBuf that does not allocate the buffer

2015-06-03 09:42:07 +02:00

virbitmap.h

util: bitmap: Add virBitmapToDataBuf that does not allocate the buffer

2015-06-03 09:42:07 +02:00

virbuffer.c

virbuffer: fix build on rhel-6

2015-04-16 18:35:41 +02:00

virbuffer.h

util: buffer: Add support for adding text blocks with indentation

2015-03-25 15:42:52 +01:00

vircgroup.c

cgroup: Use virCgroupNewThread

2015-04-09 19:27:08 -04:00

vircgroup.h

cgroup: Use virCgroupNewThread

2015-04-09 19:27:08 -04:00

vircgrouppriv.h

tests: Add tests for virCgroupDetectMounts

2015-03-18 09:53:24 +01:00

virclosecallbacks.c

util: fix removal of callbacks in virCloseCallbacksRun

2015-04-08 09:45:48 +02:00

virclosecallbacks.h

lxc: switch to virCloseCallbacks API

2013-07-18 14:16:54 +02:00

vircommand.c

vircommand: fix polling in virCommandProcessIO

2015-04-22 17:56:53 +03:00

vircommand.h

utils: Implement virCommandPassFDGetFDIndex

2015-03-05 18:57:06 -05:00

vircommandpriv.h

Add ability to register callback for virCommand dry run

2014-03-19 10:47:58 +00:00

virconf.c

virconf: Resolve a possible memory leak in virConfSetValue

2015-01-12 08:59:55 -05:00

virconf.h

virconf: Introduce VIR_CONF_ULONG

2014-12-15 10:34:18 +01:00

vircrypto.c

vircrypto: fix Invalid write in virCryptoHashString()

2014-03-12 16:01:30 -06:00

vircrypto.h

Add helper APIs for generating cryptographic hashes

2014-03-10 16:39:18 +00:00

virdbus.c

systemd: avoid string comparisons on dbus error messages

2015-01-26 09:14:04 +00:00

virdbus.h

systemd: avoid string comparisons on dbus error messages

2015-01-26 09:14:04 +00:00

virdbuspriv.h

build: fix build when not using dbus

2014-11-20 08:48:19 -07:00

virdnsmasq.c

network: escape quotes for dsmasq conf contents

2015-06-09 13:56:00 -04:00

virdnsmasq.h

…

virebtables.c

Convert ebtables code over to use firewall APIs

2014-04-25 15:44:09 +01:00

virebtables.h

Remove unused ebtablesRemoveForwardPolicyReject method

2014-03-11 11:01:52 +00:00

virendian.h

…

virerror.c

Change virConnectPtr into virObjectLocklable

2015-04-15 13:33:35 +02:00

virerror.h

systemd: fix build without dbus

2015-01-26 09:14:04 +00:00

virevent.c

maint: avoid static zero init in core files

2014-10-29 09:55:09 -06:00

virevent.h

…

vireventpoll.c

util: make it more robust to calculate timeout value

2015-05-27 16:59:18 +02:00

vireventpoll.h

Change file names in comments to match the files they are in

2014-03-10 14:26:04 +01:00

virfile.c

storage: fs: Only force directory permissions if required

2015-05-25 20:52:57 -04:00

virfile.h

virfile: virDirCreate: Drop redundant FORCE_PERMS flag

2015-05-19 19:29:39 -04:00

virfirewall.c

util: better error message after failure to initialize firewall backend

2015-05-22 10:15:05 -04:00

virfirewall.h

test: fix nwfilter tests following changes in virfirewall.c

2014-12-22 16:57:21 -05:00

virfirewallpriv.h

Introduce an object for managing firewall rulesets

2014-04-25 15:44:09 +01:00

virhash.c

hash: add common utility functions

2014-04-07 06:14:45 -06:00

virhash.h

hash: add common utility functions

2014-04-07 06:14:45 -06:00

virhashcode.c

…

virhashcode.h

…

virhook.c

virhook: Resolve Coverity NULL_RETURNS

2014-12-01 11:07:31 -05:00

virhook.h

qemu: hook: Provide hook when restoring a domain save image

2014-09-22 17:11:56 +02:00

virhostdev.c

virhostdev: Fix comments for virHostdevReAttachPCIDevices

2015-04-24 13:38:01 -04:00

virhostdev.h

virhostdev.h: remove ATTRIBUTE_NONNULL from oldStateDir

2014-03-19 10:05:31 +01:00

viridentity.c

util: identity: Harden virIdentitySetCurrent()

2015-03-25 13:37:41 +01:00

viridentity.h

Add typesafe APIs for virIdentity attributes

2014-09-24 15:29:22 +01:00

virinitctl.c

Add support for /run/initctl

2014-10-22 13:09:49 +01:00

virinitctl.h

util: use typedefs for enums in "src/util/" directory

2014-05-05 14:30:01 -06:00

viriptables.c

Re-add use of locking with iptables/ip6tables/ebtables

2014-11-14 15:15:16 +00:00

viriptables.h

Convert bridge driver over to use new firewall APIs

2014-04-25 15:44:09 +01:00

viriscsi.c

viriscsi: Need to sendtargets on Initiator IQN

2014-12-10 06:58:37 -05:00

viriscsi.h

util: Sanitize ATTRIBUTE_NONNULL use in viriscsi.h

2014-03-25 08:26:39 +01:00

virjson.c

util: json: add helper to iterate JSON object key=value pairs

2015-01-31 08:53:21 +01:00

virjson.h

util: json: add helper to iterate JSON object key=value pairs

2015-01-31 08:53:21 +01:00

virkeycode-mapgen.py

virkeycode: Allow ANSI_A

2013-12-24 17:36:47 +01:00

virkeycode.c

virkeycode: Allow ANSI_A

2013-12-24 17:36:47 +01:00

virkeycode.h

…

virkeyfile.c

hash: add common utility functions

2014-04-07 06:14:45 -06:00

virkeyfile.h

…

virkmod.c

Typos: Get rid of dependan(t|cies)

2015-04-02 16:05:32 +02:00

virkmod.h

utils: Introduce functions for kernel module manipulation

2014-02-04 08:52:27 -05:00

virlockspace.c

Remove unnecessary curly brackets in src/util/

2014-11-14 17:13:35 +01:00

virlockspace.h

…

virlog.c

qemu: include libvirt & QEMU versions in QEMU log files

2015-02-06 10:22:07 +00:00

virlog.h

qemu: include libvirt & QEMU versions in QEMU log files

2015-02-06 10:22:07 +00:00

virmacaddr.c

util: Functions to update host network device's multicast filter

2014-10-28 14:14:25 -04:00

virmacaddr.h

util: Functions to update host network device's multicast filter

2014-10-28 14:14:25 -04:00

virnetdev.c

virnetdev: fix moving of 802.11 phys

2015-06-03 18:05:23 +02:00

virnetdev.h

util: set MAC address for VF via netlink message to PF+VF# when possible

2015-04-21 12:33:20 -04:00

virnetdevbandwidth.c

Introduce virNetDevBandwidthUpdateFilter

2015-04-17 10:49:03 +02:00

virnetdevbandwidth.h

Introduce virNetDevBandwidthUpdateFilter

2015-04-17 10:49:03 +02:00

virnetdevbridge.c

Cleanup "/sys/class/net" usage

2015-04-15 16:43:28 +02:00

virnetdevbridge.h

util: functions to manage bridge fdb (forwarding database)

2014-12-08 14:39:12 -05:00

virnetdevmacvlan.c

util: set MAC address for VF via netlink message to PF+VF# when possible

2015-04-21 12:33:20 -04:00

virnetdevmacvlan.h

network: Bring netdevs online later

2014-12-10 15:09:01 -05:00

virnetdevmidonet.c

util: functions to support binding/unbinding midonet virtualports

2015-03-17 12:56:37 -04:00

virnetdevmidonet.h

util: functions to support binding/unbinding midonet virtualports

2015-03-17 12:56:37 -04:00

virnetdevopenvswitch.c

util: don't fail if no PortData is found while getting migrateData

2015-03-13 22:43:08 -04:00

virnetdevopenvswitch.h

maint: avoid 'const fooPtr' in virnet files

2013-10-14 13:05:34 -06:00

virnetdevtap.c

network: Add midonet virtual port type support to qemu

2015-03-17 13:10:17 -04:00

virnetdevtap.h

Change int to size_t in size var for tap/vhost FDs

2015-01-15 11:07:13 +00:00

virnetdevveth.c

Cleanup "/sys/class/net" usage

2015-04-15 16:43:28 +02:00

virnetdevveth.h

…

virnetdevvlan.c

maint: avoid 'const fooPtr' in virnet files

2013-10-14 13:05:34 -06:00

virnetdevvlan.h

maint: avoid 'const fooPtr' in virnet files

2013-10-14 13:05:34 -06:00

virnetdevvportprofile.c

docs: schema and docs for the midonet virtualport type

2015-03-17 13:09:05 -04:00

virnetdevvportprofile.h

util: functions to support binding/unbinding midonet virtualports

2015-03-17 12:56:37 -04:00

virnetlink.c

virnetlink: fix build error

2015-03-27 11:06:05 +01:00

virnetlink.h

util: netlink function to delete any network device

2015-03-26 15:29:42 -04:00

virnodesuspend.c

build: Don't use code with dbus_message_unref when built without dbus

2014-04-14 18:19:36 +02:00

virnodesuspend.h

…

virnuma.c

virNumaSetPagePoolSize: Produce friendlier error message

2015-06-10 17:27:16 +02:00

virnuma.h

util: Add virNumaGetHostNodeset

2014-12-16 11:15:27 +01:00

virobject.c

util: Make the virDomainListFree helper more universal

2015-05-11 08:28:53 +02:00

virobject.h

util: Make the virDomainListFree helper more universal

2015-05-11 08:28:53 +02:00

virpci.c

Allow access to vendor and device file for PCI device passthrough

2015-04-24 10:47:41 +02:00

virpci.h

virpci: Implement virPCIDeviceGetAddress function

2015-01-14 18:01:06 +01:00

virpidfile.c

network: escape quotes for dsmasq conf contents

2015-06-09 13:56:00 -04:00

virpidfile.h

util: Introduce virPidFileForceCleanupPath

2014-11-03 16:43:23 +01:00

virpolkit.c

virdbus: don't force users to pass int for bool values

2014-11-19 08:20:39 -07:00

virpolkit.h

Add common API for doing polkit authentication

2014-09-24 15:29:22 +01:00

virportallocator.c

Introduce virBitmapIsBitSet

2015-03-13 15:31:33 +01:00

virportallocator.h

util: Allow port allocator to skip bind() check

2014-09-11 15:40:14 -06:00

virprobe.h

Log dtrace/systemd probes at INFO level instead of DEBUG

2015-01-15 11:07:13 +00:00

virprocess.c

util: process: fix build on FreeBSD

2015-06-08 11:27:39 +04:00

virprocess.h

util: process: Refactor and fix virProcessSetAffinity

2015-06-03 14:20:25 +02:00

virrandom.c

build: include correct header for time()

2015-04-14 13:24:51 -06:00

virrandom.h

…

virscsi.c

Do not call closedir with NULL argument

2014-06-23 14:16:23 +02:00

virscsi.h

add 'driver' info to used_by

2014-03-04 12:24:13 +00:00

virseclabel.c

virseclabel: Resolve Coverity FORWARD_NULL issue

2014-07-14 05:44:20 -04:00

virseclabel.h

virSecurityDeviceLabelDef: substitute 'norelabel' with 'relabel'

2014-07-11 10:36:02 +02:00

virsexpr.c

Remove unnecessary curly brackets in src/util/

2014-11-14 17:13:35 +01:00

virsexpr.h

…

virsocketaddr.c

util: Clear output broadcast address before filling it in

2015-06-03 12:54:32 +02:00

virsocketaddr.h

network: validate DHCP ranges are completely within defined network

2015-06-02 12:40:07 -04:00

virstats.c

maint: clean up _virDomainInterfaceStats

2014-09-17 11:28:48 -06:00

virstats.h

maint: clean up _virDomainInterfaceStats

2014-09-17 11:28:48 -06:00

virstorageencryption.c

Remove unnecessary curly brackets in src/util/

2014-11-14 17:13:35 +01:00

virstorageencryption.h

storage: encryption: Add deep copy function for storage encryption

2014-06-20 09:14:46 +02:00

virstoragefile.c

util: fix memleak in virStorageSourceClear

2015-04-27 15:37:13 +02:00

virstoragefile.h

Split out storage format 'compat' attribute sanity check

2015-04-13 15:07:45 +02:00

virstring.c

build: add pragma directive to fix build on some gcc

2015-04-24 13:40:41 +02:00

virstring.h

Add functions dealing with control characters in strings

2015-04-15 18:41:20 +02:00

virsysinfo.c

util: improve the sysinfo element XML format

2015-05-26 19:57:15 -04:00

virsysinfo.h

util: use typedefs for enums in "src/util/" directory

2014-05-05 14:30:01 -06:00

virsystemd.c

systemd: don't report an error if the guest is already terminated

2015-01-27 13:57:02 +00:00

virsystemd.h

Add support for systemd-machined CreateMachineWithNetwork

2015-01-15 11:07:07 +00:00

virthread.c

virCondWaitUntil: calculate timespec correctly

2015-04-16 15:39:22 +02:00

virthread.h

virThread: Set thread job

2015-03-25 10:00:53 +01:00

virthreadjob.c

Add support for tracking thread jobs

2015-03-25 10:00:53 +01:00

virthreadjob.h

Add support for tracking thread jobs

2015-03-25 10:00:53 +01:00

virthreadpool.c

threadpool: Switch to detached threads

2015-05-21 14:35:02 +02:00

virthreadpool.h

virThreadPool: Set thread worker name

2015-03-25 10:00:53 +01:00

virtime.c

Renamed internal __mon_yday into mon_yday to avoid conflicts

2014-10-28 14:44:18 -06:00

virtime.h

util: virTimeFieldsThenRaw never returns negative

2014-07-25 12:06:07 +02:00

virtpm.c

Indent top-level labels by one space in src/util/

2014-03-25 14:58:40 +01:00

virtpm.h

…

virtypedparam.c

maint: use hanging curly braces

2014-09-04 15:18:43 -06:00

virtypedparam.h

Introduce virTypedParamsCopy internal API

2013-06-25 00:38:25 +02:00

viruri.c

Introduce virStringStripIPv6Brackets

2014-10-15 09:25:33 +02:00

viruri.h

…

virusb.c

usb: Remove redundant comment

2014-07-03 10:41:15 +02:00

virusb.h

add 'driver' info to used_by

2014-03-04 12:24:13 +00:00

virutil.c

util: Properly return error from virGetUserID and virGetGroupID stubs

2015-06-08 09:32:24 +02:00

virutil.h

util: Add macro to overflow check integer assignments

2015-06-03 09:42:08 +02:00

viruuid.c

Use K&R style for curly braces in src/util/

2014-03-20 17:16:18 +01:00

viruuid.h

maint: improve debug of libvirt-{qemu,lxc} apis

2014-01-02 22:17:11 -07:00

virxml.c

Add virXMLValidateAgainstSchema helper method

2015-01-15 14:02:50 +00:00

virxml.h

Add virXMLValidateAgainstSchema helper method

2015-01-15 14:02:50 +00:00