mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-11-02 11:21:12 +00:00
6ea7b3e8d1
Automating a sorting check is the only way to ensure we don't regress. Suggested by Dan Berrange. * src/check-symsorting.pl (check_sorting): Add a parameter, validate that groups are in order, and that files exist. * src/Makefile.am (check-symsorting): Adjust caller. * src/libvirt_private.syms: Fix typo. * src/libvirt_linux.syms: Fix file name. * src/libvirt_vmx.syms: Likewise. * src/libvirt_xenxs.syms: Likewise. * src/libvirt_sasl.syms: Likewise. * src/libvirt_libssh2.syms: Likewise. * src/libvirt_esx.syms: Mention file name. * src/libvirt_openvz.syms: Likewise.
91 lines
2.2 KiB
Perl
Executable File
91 lines
2.2 KiB
Perl
Executable File
#!/usr/bin/perl
|
|
|
|
use strict;
|
|
use warnings;
|
|
|
|
die "syntax: $0 SRCDIR SYMFILE..." unless int(@ARGV) >= 2;
|
|
|
|
my $ret = 0;
|
|
my $srcdir = shift;
|
|
my $lastgroup = undef;
|
|
foreach my $symfile (@ARGV) {
|
|
open SYMFILE, $symfile or die "cannot read $symfile: $!";
|
|
|
|
my $line;
|
|
my $groupfile = "";
|
|
my @group;
|
|
|
|
while (<SYMFILE>) {
|
|
chomp;
|
|
|
|
if (/^#\s*((\w+\/)*(\w+\.h))\s*$/) {
|
|
$groupfile = $1;
|
|
} elsif (/^#/) {
|
|
# Ignore comments
|
|
} elsif (/^\s*$/) {
|
|
if (@group) {
|
|
&check_sorting(\@group, $symfile, $line, $groupfile);
|
|
}
|
|
@group = ();
|
|
$line = $.;
|
|
} else {
|
|
$_ =~ s/;//;
|
|
push @group, $_;
|
|
}
|
|
}
|
|
|
|
close SYMFILE;
|
|
if (@group) {
|
|
&check_sorting(\@group, $symfile, $line, $groupfile);
|
|
}
|
|
$lastgroup = undef;
|
|
}
|
|
|
|
sub check_sorting {
|
|
my $group = shift;
|
|
my $symfile = shift;
|
|
my $line = shift;
|
|
my $groupfile = shift;
|
|
|
|
my @group = @{$group};
|
|
my @sorted = sort { lc $a cmp lc $b } @group;
|
|
my $sorted = 1;
|
|
my $first;
|
|
my $last;
|
|
|
|
# Check that groups are in order and groupfile exists
|
|
if (defined $lastgroup && lc $lastgroup ge lc $groupfile) {
|
|
print "Symbol block at $symfile:$line: block not sorted\n";
|
|
print "Move $groupfile block before $lastgroup block\n";
|
|
print "\n";
|
|
$ret = 1;
|
|
}
|
|
if (! -e "$srcdir/$groupfile") {
|
|
print "Symbol block at $symfile:$line: $groupfile not found\n";
|
|
print "\n";
|
|
$ret = 1;
|
|
}
|
|
$lastgroup = $groupfile;
|
|
|
|
# Check that symbols within a group are in order
|
|
for (my $i = 0 ; $i <= $#sorted ; $i++) {
|
|
if ($sorted[$i] ne $group[$i]) {
|
|
$first = $i unless defined $first;
|
|
$last = $i;
|
|
$sorted = 0;
|
|
}
|
|
}
|
|
if (!$sorted) {
|
|
@group = splice @group, $first, ($last-$first+1);
|
|
@sorted = splice @sorted, $first, ($last-$first+1);
|
|
print "Symbol block at $symfile:$line: symbols not sorted\n";
|
|
print map { " " . $_ . "\n" } @group;
|
|
print "Correct ordering\n";
|
|
print map { " " . $_ . "\n" } @sorted;
|
|
print "\n";
|
|
$ret = 1;
|
|
}
|
|
}
|
|
|
|
exit $ret;
|