mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-25 07:05:28 +00:00
05af6784b1
If QEMU in question supports QMP, this capability is set if QEMU_CAPS_DEVICE_QXL was set based on existence of "-device qxl". If libvirt needs to parse *help*, because there is no QMP support, it checks for existence of "-vga qxl", but it also parses output of "-device ?" and sets QEMU_CAPS_DEVICE_QXL too. Now that libvirt supports only QEMU that has "-device" implemented it's safe to drop this capability and stop using it. Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
444 lines
14 KiB
C
444 lines
14 KiB
C
#include <config.h>
|
|
|
|
#include "testutils.h"
|
|
|
|
#ifdef WITH_QEMU
|
|
|
|
# include <stdio.h>
|
|
# include <stdlib.h>
|
|
|
|
# include "qemu/qemu_capabilities.h"
|
|
# include "viralloc.h"
|
|
# include "virstring.h"
|
|
|
|
# define VIR_FROM_THIS VIR_FROM_NONE
|
|
|
|
struct testInfo {
|
|
const char *name;
|
|
virQEMUCapsPtr flags;
|
|
unsigned int version;
|
|
bool is_kvm;
|
|
unsigned int kvm_version;
|
|
int error;
|
|
};
|
|
|
|
static void printMismatchedFlags(virQEMUCapsPtr got,
|
|
virQEMUCapsPtr expect)
|
|
{
|
|
size_t i;
|
|
|
|
for (i = 0; i < QEMU_CAPS_LAST; i++) {
|
|
bool gotFlag = virQEMUCapsGet(got, i);
|
|
bool expectFlag = virQEMUCapsGet(expect, i);
|
|
if (gotFlag && !expectFlag)
|
|
fprintf(stderr, "Extra flag %zu\n", i);
|
|
if (!gotFlag && expectFlag)
|
|
fprintf(stderr, "Missing flag %zu\n", i);
|
|
}
|
|
}
|
|
|
|
static int testHelpStrParsing(const void *data)
|
|
{
|
|
const struct testInfo *info = data;
|
|
char *path = NULL;
|
|
char *help = NULL;
|
|
unsigned int version, kvm_version;
|
|
bool is_kvm;
|
|
virQEMUCapsPtr flags = NULL;
|
|
int ret = -1;
|
|
char *got = NULL;
|
|
char *expected = NULL;
|
|
|
|
if (virAsprintf(&path, "%s/qemuhelpdata/%s", abs_srcdir, info->name) < 0)
|
|
return -1;
|
|
|
|
if (virTestLoadFile(path, &help) < 0)
|
|
goto cleanup;
|
|
|
|
if (!(flags = virQEMUCapsNew()))
|
|
goto cleanup;
|
|
|
|
if (virQEMUCapsParseHelpStr("QEMU", help, flags,
|
|
&version, &is_kvm, &kvm_version, false, NULL) == -1) {
|
|
virErrorPtr err = virGetLastError();
|
|
|
|
if (info->error && err && err->code == info->error)
|
|
ret = 0;
|
|
goto cleanup;
|
|
}
|
|
|
|
# ifndef WITH_YAJL
|
|
if (virQEMUCapsGet(info->flags, QEMU_CAPS_MONITOR_JSON))
|
|
virQEMUCapsSet(flags, QEMU_CAPS_MONITOR_JSON);
|
|
# endif
|
|
|
|
VIR_FREE(path);
|
|
VIR_FREE(help);
|
|
if (virAsprintf(&path, "%s/qemuhelpdata/%s-device", abs_srcdir,
|
|
info->name) < 0)
|
|
goto cleanup;
|
|
|
|
if (virTestLoadFile(path, &help) < 0)
|
|
goto cleanup;
|
|
|
|
if (virQEMUCapsParseDeviceStr(flags, help) < 0)
|
|
goto cleanup;
|
|
|
|
got = virQEMUCapsFlagsString(flags);
|
|
expected = virQEMUCapsFlagsString(info->flags);
|
|
if (!got || !expected)
|
|
goto cleanup;
|
|
|
|
if (STRNEQ(got, expected)) {
|
|
VIR_TEST_DEBUG("%s: computed flags do not match: got %s, expected %s\n",
|
|
info->name, got, expected);
|
|
|
|
if (virTestGetDebug())
|
|
printMismatchedFlags(flags, info->flags);
|
|
|
|
goto cleanup;
|
|
}
|
|
|
|
if (version != info->version) {
|
|
fprintf(stderr, "%s: parsed versions do not match: got %u, expected %u\n",
|
|
info->name, version, info->version);
|
|
goto cleanup;
|
|
}
|
|
|
|
if (is_kvm != info->is_kvm) {
|
|
fprintf(stderr,
|
|
"%s: parsed is_kvm flag does not match: got %u, expected %u\n",
|
|
info->name, is_kvm, info->is_kvm);
|
|
goto cleanup;
|
|
}
|
|
|
|
if (kvm_version != info->kvm_version) {
|
|
fprintf(stderr,
|
|
"%s: parsed KVM versions do not match: got %u, expected %u\n",
|
|
info->name, kvm_version, info->kvm_version);
|
|
goto cleanup;
|
|
}
|
|
|
|
ret = 0;
|
|
cleanup:
|
|
VIR_FREE(path);
|
|
VIR_FREE(help);
|
|
virObjectUnref(flags);
|
|
VIR_FREE(got);
|
|
VIR_FREE(expected);
|
|
return ret;
|
|
}
|
|
|
|
static int
|
|
mymain(void)
|
|
{
|
|
int ret = 0;
|
|
|
|
# define DO_TEST_FULL(name, version, is_kvm, kvm_version, error, ...) \
|
|
do { \
|
|
struct testInfo info = { \
|
|
name, NULL, version, is_kvm, kvm_version, error \
|
|
}; \
|
|
if (!(info.flags = virQEMUCapsNew())) \
|
|
return EXIT_FAILURE; \
|
|
virQEMUCapsSetList(info.flags, __VA_ARGS__, QEMU_CAPS_LAST); \
|
|
if (virTestRun("QEMU Help String Parsing " name, \
|
|
testHelpStrParsing, &info) < 0) \
|
|
ret = -1; \
|
|
virObjectUnref(info.flags); \
|
|
} while (0)
|
|
|
|
# define DO_TEST(name, version, is_kvm, kvm_version, ...) \
|
|
DO_TEST_FULL(name, version, is_kvm, kvm_version, VIR_ERR_OK, __VA_ARGS__)
|
|
|
|
DO_TEST("qemu-0.12.1", 12001, 0, 0,
|
|
QEMU_CAPS_DRIVE_SERIAL,
|
|
QEMU_CAPS_ENABLE_KVM,
|
|
QEMU_CAPS_SDL,
|
|
QEMU_CAPS_CHARDEV,
|
|
QEMU_CAPS_RTC,
|
|
QEMU_CAPS_NO_HPET,
|
|
QEMU_CAPS_BOOT_MENU,
|
|
QEMU_CAPS_NAME_PROCESS,
|
|
QEMU_CAPS_SMBIOS_TYPE,
|
|
QEMU_CAPS_VGA_NONE,
|
|
QEMU_CAPS_DRIVE_AIO,
|
|
QEMU_CAPS_PIIX3_USB_UHCI,
|
|
QEMU_CAPS_PIIX4_USB_UHCI,
|
|
QEMU_CAPS_USB_HUB,
|
|
QEMU_CAPS_NO_SHUTDOWN,
|
|
QEMU_CAPS_NO_ACPI,
|
|
QEMU_CAPS_SCSI_LSI,
|
|
QEMU_CAPS_VNC,
|
|
QEMU_CAPS_DEVICE_VGA,
|
|
QEMU_CAPS_DEVICE_CIRRUS_VGA,
|
|
QEMU_CAPS_DEVICE_VMWARE_SVGA,
|
|
QEMU_CAPS_DEVICE_USB_SERIAL,
|
|
QEMU_CAPS_DEVICE_USB_NET,
|
|
QEMU_CAPS_DEVICE_PCI_BRIDGE,
|
|
QEMU_CAPS_DEVICE_SCSI_GENERIC,
|
|
QEMU_CAPS_DEVICE_USB_STORAGE,
|
|
QEMU_CAPS_DEVICE_USB_KBD,
|
|
QEMU_CAPS_DEVICE_RTL8139,
|
|
QEMU_CAPS_DEVICE_E1000,
|
|
QEMU_CAPS_DEVICE_VIRTIO_NET);
|
|
DO_TEST("qemu-kvm-0.12.3", 12003, 1, 0,
|
|
QEMU_CAPS_DRIVE_BOOT,
|
|
QEMU_CAPS_KVM,
|
|
QEMU_CAPS_DRIVE_SERIAL,
|
|
QEMU_CAPS_MEM_PATH,
|
|
QEMU_CAPS_SDL,
|
|
QEMU_CAPS_CHARDEV,
|
|
QEMU_CAPS_ENABLE_KVM,
|
|
QEMU_CAPS_RTC,
|
|
QEMU_CAPS_NO_HPET,
|
|
QEMU_CAPS_NO_KVM_PIT,
|
|
QEMU_CAPS_TDF,
|
|
QEMU_CAPS_BOOT_MENU,
|
|
QEMU_CAPS_NESTING,
|
|
QEMU_CAPS_NAME_PROCESS,
|
|
QEMU_CAPS_SMBIOS_TYPE,
|
|
QEMU_CAPS_VGA_NONE,
|
|
QEMU_CAPS_DRIVE_AIO,
|
|
QEMU_CAPS_PIIX3_USB_UHCI,
|
|
QEMU_CAPS_PIIX4_USB_UHCI,
|
|
QEMU_CAPS_USB_HUB,
|
|
QEMU_CAPS_NO_SHUTDOWN,
|
|
QEMU_CAPS_NO_ACPI,
|
|
QEMU_CAPS_SCSI_LSI,
|
|
QEMU_CAPS_VNC,
|
|
QEMU_CAPS_DEVICE_VGA,
|
|
QEMU_CAPS_DEVICE_CIRRUS_VGA,
|
|
QEMU_CAPS_DEVICE_VMWARE_SVGA,
|
|
QEMU_CAPS_DEVICE_USB_SERIAL,
|
|
QEMU_CAPS_DEVICE_USB_NET,
|
|
QEMU_CAPS_DEVICE_PCI_BRIDGE,
|
|
QEMU_CAPS_DEVICE_SCSI_GENERIC,
|
|
QEMU_CAPS_DEVICE_USB_STORAGE,
|
|
QEMU_CAPS_DEVICE_USB_KBD,
|
|
QEMU_CAPS_DEVICE_RTL8139,
|
|
QEMU_CAPS_DEVICE_E1000,
|
|
QEMU_CAPS_DEVICE_VIRTIO_NET);
|
|
DO_TEST("qemu-kvm-0.13.0", 13000, 1, 0,
|
|
QEMU_CAPS_DRIVE_BOOT,
|
|
QEMU_CAPS_DRIVE_CACHE_UNSAFE,
|
|
QEMU_CAPS_KVM,
|
|
QEMU_CAPS_DRIVE_SERIAL,
|
|
QEMU_CAPS_MEM_PATH,
|
|
QEMU_CAPS_SDL,
|
|
QEMU_CAPS_CHARDEV,
|
|
QEMU_CAPS_ENABLE_KVM,
|
|
QEMU_CAPS_MONITOR_JSON,
|
|
QEMU_CAPS_NETDEV,
|
|
QEMU_CAPS_RTC,
|
|
QEMU_CAPS_VHOST_NET,
|
|
QEMU_CAPS_NO_HPET,
|
|
QEMU_CAPS_NO_KVM_PIT,
|
|
QEMU_CAPS_TDF,
|
|
QEMU_CAPS_PCI_CONFIGFD,
|
|
QEMU_CAPS_NODEFCONFIG,
|
|
QEMU_CAPS_BOOT_MENU,
|
|
QEMU_CAPS_FSDEV,
|
|
QEMU_CAPS_NESTING,
|
|
QEMU_CAPS_NAME_PROCESS,
|
|
QEMU_CAPS_SMBIOS_TYPE,
|
|
QEMU_CAPS_VGA_NONE,
|
|
QEMU_CAPS_DRIVE_AIO,
|
|
QEMU_CAPS_PCI_MULTIFUNCTION,
|
|
QEMU_CAPS_PIIX3_USB_UHCI,
|
|
QEMU_CAPS_PIIX4_USB_UHCI,
|
|
QEMU_CAPS_VT82C686B_USB_UHCI,
|
|
QEMU_CAPS_PCI_OHCI,
|
|
QEMU_CAPS_USB_HUB,
|
|
QEMU_CAPS_NO_SHUTDOWN,
|
|
QEMU_CAPS_NO_ACPI,
|
|
QEMU_CAPS_SCSI_LSI,
|
|
QEMU_CAPS_VNC,
|
|
QEMU_CAPS_DEVICE_VGA,
|
|
QEMU_CAPS_DEVICE_CIRRUS_VGA,
|
|
QEMU_CAPS_DEVICE_VMWARE_SVGA,
|
|
QEMU_CAPS_DEVICE_USB_SERIAL,
|
|
QEMU_CAPS_DEVICE_USB_NET,
|
|
QEMU_CAPS_DEVICE_PCI_BRIDGE,
|
|
QEMU_CAPS_DEVICE_SCSI_GENERIC,
|
|
QEMU_CAPS_DEVICE_USB_KBD,
|
|
QEMU_CAPS_DEVICE_USB_STORAGE,
|
|
QEMU_CAPS_HOST_PCI_MULTIDOMAIN,
|
|
QEMU_CAPS_DEVICE_IVSHMEM,
|
|
QEMU_CAPS_DEVICE_RTL8139,
|
|
QEMU_CAPS_DEVICE_E1000,
|
|
QEMU_CAPS_DEVICE_VIRTIO_NET);
|
|
DO_TEST("qemu-1.0", 1000000, 0, 0,
|
|
QEMU_CAPS_DRIVE_CACHE_UNSAFE,
|
|
QEMU_CAPS_DRIVE_SERIAL,
|
|
QEMU_CAPS_MEM_PATH,
|
|
QEMU_CAPS_SDL,
|
|
QEMU_CAPS_CHARDEV,
|
|
QEMU_CAPS_ENABLE_KVM,
|
|
QEMU_CAPS_MONITOR_JSON,
|
|
QEMU_CAPS_NETDEV,
|
|
QEMU_CAPS_RTC,
|
|
QEMU_CAPS_VHOST_NET,
|
|
QEMU_CAPS_NO_HPET,
|
|
QEMU_CAPS_NODEFCONFIG,
|
|
QEMU_CAPS_BOOT_MENU,
|
|
QEMU_CAPS_FSDEV,
|
|
QEMU_CAPS_NAME_PROCESS,
|
|
QEMU_CAPS_SMBIOS_TYPE,
|
|
QEMU_CAPS_SPICE,
|
|
QEMU_CAPS_VGA_NONE,
|
|
QEMU_CAPS_BOOTINDEX,
|
|
QEMU_CAPS_HDA_DUPLEX,
|
|
QEMU_CAPS_DRIVE_AIO,
|
|
QEMU_CAPS_CCID_EMULATED,
|
|
QEMU_CAPS_CCID_PASSTHRU,
|
|
QEMU_CAPS_CHARDEV_SPICEVMC,
|
|
QEMU_CAPS_VIRTIO_TX_ALG,
|
|
QEMU_CAPS_PCI_MULTIFUNCTION,
|
|
QEMU_CAPS_VIRTIO_IOEVENTFD,
|
|
QEMU_CAPS_SGA,
|
|
QEMU_CAPS_VIRTIO_BLK_EVENT_IDX,
|
|
QEMU_CAPS_VIRTIO_NET_EVENT_IDX,
|
|
QEMU_CAPS_DRIVE_CACHE_DIRECTSYNC,
|
|
QEMU_CAPS_PIIX3_USB_UHCI,
|
|
QEMU_CAPS_PIIX4_USB_UHCI,
|
|
QEMU_CAPS_USB_EHCI,
|
|
QEMU_CAPS_ICH9_USB_EHCI1,
|
|
QEMU_CAPS_VT82C686B_USB_UHCI,
|
|
QEMU_CAPS_PCI_OHCI,
|
|
QEMU_CAPS_USB_HUB,
|
|
QEMU_CAPS_NO_SHUTDOWN,
|
|
QEMU_CAPS_ICH9_AHCI,
|
|
QEMU_CAPS_NO_ACPI,
|
|
QEMU_CAPS_FSDEV_READONLY,
|
|
QEMU_CAPS_VIRTIO_BLK_SCSI,
|
|
QEMU_CAPS_FSDEV_WRITEOUT,
|
|
QEMU_CAPS_SCSI_BLOCK,
|
|
QEMU_CAPS_SCSI_CD,
|
|
QEMU_CAPS_IDE_CD,
|
|
QEMU_CAPS_SCSI_LSI,
|
|
QEMU_CAPS_BLOCKIO,
|
|
QEMU_CAPS_VNC,
|
|
QEMU_CAPS_MACHINE_OPT,
|
|
QEMU_CAPS_DEVICE_QXL,
|
|
QEMU_CAPS_DEVICE_VGA,
|
|
QEMU_CAPS_DEVICE_CIRRUS_VGA,
|
|
QEMU_CAPS_DEVICE_VMWARE_SVGA,
|
|
QEMU_CAPS_DEVICE_USB_SERIAL,
|
|
QEMU_CAPS_DEVICE_USB_NET,
|
|
QEMU_CAPS_DEVICE_SCSI_GENERIC,
|
|
QEMU_CAPS_DEVICE_SCSI_GENERIC_BOOTINDEX,
|
|
QEMU_CAPS_DEVICE_USB_KBD,
|
|
QEMU_CAPS_DEVICE_USB_STORAGE,
|
|
QEMU_CAPS_SPLASH_TIMEOUT,
|
|
QEMU_CAPS_DEVICE_IVSHMEM,
|
|
QEMU_CAPS_DEVICE_IOH3420,
|
|
QEMU_CAPS_DEVICE_X3130_UPSTREAM,
|
|
QEMU_CAPS_DEVICE_XIO3130_DOWNSTREAM,
|
|
QEMU_CAPS_DEVICE_RTL8139,
|
|
QEMU_CAPS_DEVICE_E1000,
|
|
QEMU_CAPS_DEVICE_VIRTIO_NET,
|
|
QEMU_CAPS_DISPLAY);
|
|
DO_TEST("qemu-1.1.0", 1001000, 0, 0,
|
|
QEMU_CAPS_DRIVE_CACHE_UNSAFE,
|
|
QEMU_CAPS_DRIVE_SERIAL,
|
|
QEMU_CAPS_MEM_PATH,
|
|
QEMU_CAPS_SDL,
|
|
QEMU_CAPS_CHARDEV,
|
|
QEMU_CAPS_ENABLE_KVM,
|
|
QEMU_CAPS_MONITOR_JSON,
|
|
QEMU_CAPS_NETDEV,
|
|
QEMU_CAPS_RTC,
|
|
QEMU_CAPS_VHOST_NET,
|
|
QEMU_CAPS_NO_HPET,
|
|
QEMU_CAPS_NODEFCONFIG,
|
|
QEMU_CAPS_BOOT_MENU,
|
|
QEMU_CAPS_FSDEV,
|
|
QEMU_CAPS_NAME_PROCESS,
|
|
QEMU_CAPS_SMBIOS_TYPE,
|
|
QEMU_CAPS_SPICE,
|
|
QEMU_CAPS_VGA_NONE,
|
|
QEMU_CAPS_BOOTINDEX,
|
|
QEMU_CAPS_HDA_DUPLEX,
|
|
QEMU_CAPS_DRIVE_AIO,
|
|
QEMU_CAPS_CCID_EMULATED,
|
|
QEMU_CAPS_CCID_PASSTHRU,
|
|
QEMU_CAPS_CHARDEV_SPICEVMC,
|
|
QEMU_CAPS_VIRTIO_TX_ALG,
|
|
QEMU_CAPS_PCI_MULTIFUNCTION,
|
|
QEMU_CAPS_VIRTIO_IOEVENTFD,
|
|
QEMU_CAPS_SGA,
|
|
QEMU_CAPS_VIRTIO_BLK_EVENT_IDX,
|
|
QEMU_CAPS_VIRTIO_NET_EVENT_IDX,
|
|
QEMU_CAPS_DRIVE_CACHE_DIRECTSYNC,
|
|
QEMU_CAPS_PIIX3_USB_UHCI,
|
|
QEMU_CAPS_PIIX4_USB_UHCI,
|
|
QEMU_CAPS_USB_EHCI,
|
|
QEMU_CAPS_ICH9_USB_EHCI1,
|
|
QEMU_CAPS_VT82C686B_USB_UHCI,
|
|
QEMU_CAPS_PCI_OHCI,
|
|
QEMU_CAPS_USB_HUB,
|
|
QEMU_CAPS_NO_SHUTDOWN,
|
|
QEMU_CAPS_ICH9_AHCI,
|
|
QEMU_CAPS_NO_ACPI,
|
|
QEMU_CAPS_FSDEV_READONLY,
|
|
QEMU_CAPS_VIRTIO_BLK_SCSI,
|
|
QEMU_CAPS_DRIVE_COPY_ON_READ,
|
|
QEMU_CAPS_FSDEV_WRITEOUT,
|
|
QEMU_CAPS_DRIVE_IOTUNE,
|
|
QEMU_CAPS_SCSI_DISK_CHANNEL,
|
|
QEMU_CAPS_SCSI_BLOCK,
|
|
QEMU_CAPS_SCSI_CD,
|
|
QEMU_CAPS_IDE_CD,
|
|
QEMU_CAPS_NO_USER_CONFIG,
|
|
QEMU_CAPS_HDA_MICRO,
|
|
QEMU_CAPS_NEC_USB_XHCI,
|
|
QEMU_CAPS_NETDEV_BRIDGE,
|
|
QEMU_CAPS_SCSI_LSI,
|
|
QEMU_CAPS_VIRTIO_SCSI,
|
|
QEMU_CAPS_BLOCKIO,
|
|
QEMU_CAPS_VNC,
|
|
QEMU_CAPS_MACHINE_OPT,
|
|
QEMU_CAPS_DEVICE_QXL,
|
|
QEMU_CAPS_DEVICE_VGA,
|
|
QEMU_CAPS_DEVICE_CIRRUS_VGA,
|
|
QEMU_CAPS_DEVICE_VMWARE_SVGA,
|
|
QEMU_CAPS_DEVICE_USB_SERIAL,
|
|
QEMU_CAPS_DEVICE_USB_NET,
|
|
QEMU_CAPS_DTB,
|
|
QEMU_CAPS_IPV6_MIGRATION,
|
|
QEMU_CAPS_DEVICE_PCI_BRIDGE,
|
|
QEMU_CAPS_DEVICE_SCSI_GENERIC,
|
|
QEMU_CAPS_DEVICE_SCSI_GENERIC_BOOTINDEX,
|
|
QEMU_CAPS_VNC_SHARE_POLICY,
|
|
QEMU_CAPS_DEVICE_USB_KBD,
|
|
QEMU_CAPS_DEVICE_USB_STORAGE,
|
|
QEMU_CAPS_OBJECT_USB_AUDIO,
|
|
QEMU_CAPS_SPLASH_TIMEOUT,
|
|
QEMU_CAPS_DEVICE_IVSHMEM,
|
|
QEMU_CAPS_DEVICE_IOH3420,
|
|
QEMU_CAPS_DEVICE_X3130_UPSTREAM,
|
|
QEMU_CAPS_DEVICE_XIO3130_DOWNSTREAM,
|
|
QEMU_CAPS_DEVICE_RTL8139,
|
|
QEMU_CAPS_DEVICE_E1000,
|
|
QEMU_CAPS_DEVICE_VIRTIO_NET,
|
|
QEMU_CAPS_DISPLAY);
|
|
DO_TEST_FULL("qemu-1.2.0", 1002000, 0, 0, VIR_ERR_CONFIG_UNSUPPORTED,
|
|
QEMU_CAPS_LAST);
|
|
DO_TEST_FULL("qemu-kvm-1.2.0", 1002000, 1, 0, VIR_ERR_CONFIG_UNSUPPORTED,
|
|
QEMU_CAPS_LAST);
|
|
|
|
return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
|
|
}
|
|
|
|
VIRT_TEST_MAIN(mymain)
|
|
|
|
#else
|
|
|
|
int main(void)
|
|
{
|
|
return EXIT_AM_SKIP;
|
|
}
|
|
|
|
#endif /* WITH_QEMU */
|