mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-27 16:15:23 +00:00
d257581417
Since 5084091a, @authcred is filled by a g_key_file_get_string which is
now an allocated string as opposed to some hash table lookup value, so
we need to treat it as so.
Found by Coverity
Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
145 lines
3.6 KiB
C
145 lines
3.6 KiB
C
/*
|
|
* virauthconfig.c: authentication config handling
|
|
*
|
|
* Copyright (C) 2012 Red Hat, Inc.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#include "virauthconfig.h"
|
|
|
|
#include "virlog.h"
|
|
#include "virerror.h"
|
|
#include "virstring.h"
|
|
#include "viralloc.h"
|
|
|
|
struct _virAuthConfig {
|
|
GKeyFile *keyfile;
|
|
char *path;
|
|
};
|
|
|
|
#define VIR_FROM_THIS VIR_FROM_NONE
|
|
|
|
VIR_LOG_INIT("util.authconfig");
|
|
|
|
virAuthConfigPtr virAuthConfigNew(const char *path)
|
|
{
|
|
virAuthConfigPtr auth;
|
|
|
|
if (VIR_ALLOC(auth) < 0)
|
|
goto error;
|
|
|
|
auth->path = g_strdup(path);
|
|
|
|
if (!(auth->keyfile = g_key_file_new()))
|
|
goto error;
|
|
|
|
if (!g_key_file_load_from_file(auth->keyfile, path, 0, NULL))
|
|
goto error;
|
|
|
|
return auth;
|
|
|
|
error:
|
|
virAuthConfigFree(auth);
|
|
return NULL;
|
|
}
|
|
|
|
|
|
virAuthConfigPtr virAuthConfigNewData(const char *path,
|
|
const char *data,
|
|
size_t len)
|
|
{
|
|
virAuthConfigPtr auth;
|
|
|
|
if (VIR_ALLOC(auth) < 0)
|
|
goto error;
|
|
|
|
auth->path = g_strdup(path);
|
|
|
|
if (!(auth->keyfile = g_key_file_new()))
|
|
goto error;
|
|
|
|
if (!g_key_file_load_from_data(auth->keyfile, data, len, 0, NULL))
|
|
goto error;
|
|
|
|
return auth;
|
|
|
|
error:
|
|
virAuthConfigFree(auth);
|
|
return NULL;
|
|
}
|
|
|
|
|
|
void virAuthConfigFree(virAuthConfigPtr auth)
|
|
{
|
|
if (!auth)
|
|
return;
|
|
|
|
g_key_file_free(auth->keyfile);
|
|
VIR_FREE(auth->path);
|
|
VIR_FREE(auth);
|
|
}
|
|
|
|
|
|
int virAuthConfigLookup(virAuthConfigPtr auth,
|
|
const char *service,
|
|
const char *hostname,
|
|
const char *credname,
|
|
char **value)
|
|
{
|
|
g_autofree char *authgroup = NULL;
|
|
g_autofree char *credgroup = NULL;
|
|
g_autofree char *authcred = NULL;
|
|
|
|
*value = NULL;
|
|
|
|
VIR_DEBUG("Lookup '%s' '%s' '%s'", service, NULLSTR(hostname), credname);
|
|
|
|
if (!hostname)
|
|
hostname = "localhost";
|
|
|
|
authgroup = g_strdup_printf("auth-%s-%s", service, hostname);
|
|
|
|
if (!g_key_file_has_group(auth->keyfile, authgroup)) {
|
|
VIR_FREE(authgroup);
|
|
authgroup = g_strdup_printf("auth-%s-%s", service, "default");
|
|
}
|
|
|
|
if (!g_key_file_has_group(auth->keyfile, authgroup))
|
|
return 0;
|
|
|
|
if (!(authcred = g_key_file_get_string(auth->keyfile, authgroup, "credentials", NULL))) {
|
|
virReportError(VIR_ERR_CONF_SYNTAX,
|
|
_("Missing item 'credentials' in group '%s' in '%s'"),
|
|
authgroup, auth->path);
|
|
return -1;
|
|
}
|
|
|
|
credgroup = g_strdup_printf("credentials-%s", authcred);
|
|
|
|
if (!g_key_file_has_group(auth->keyfile, credgroup)) {
|
|
virReportError(VIR_ERR_CONF_SYNTAX,
|
|
_("Missing group 'credentials-%s' referenced from group '%s' in '%s'"),
|
|
authcred, authgroup, auth->path);
|
|
return -1;
|
|
}
|
|
|
|
*value = g_key_file_get_string(auth->keyfile, credgroup, credname, NULL);
|
|
|
|
return 0;
|
|
}
|