libvirt/src
Eric Blake 2086a9905a qemu: forbid snapshot-delete --children-only on external snapshot
https://bugzilla.redhat.com/show_bug.cgi?id=956506 documents that
given a domain where an internal snapshot parent has an external
snapshot child, we lacked a safety check when trying to use the
--children-only option to snapshot-delete:

$ virsh start dom
$ virsh snapshot-create-as dom internal
$ virsh snapshot-create-as dom external --disk-only
$ virsh snapshot-delete dom external
error: Failed to delete snapshot external
error: unsupported configuration: deletion of 1 external disk snapshots not supported yet
$ virsh snapshot-delete dom internal --children
error: Failed to delete snapshot internal
error: unsupported configuration: deletion of 1 external disk snapshots not supported yet
$ virsh snapshot-delete dom internal --children-only
Domain snapshot internal children deleted

While I'd still like to see patches that actually do proper external
snapshot deletion, we should at least fix the inconsistency in the
meantime.  With this patch:

$ virsh snapshot-delete dom internal --children-only
error: Failed to delete snapshot internal
error: unsupported configuration: deletion of 1 external disk snapshots not supported yet

* src/qemu/qemu_driver.c (qemuDomainSnapshotDelete): Fix condition.

Signed-off-by: Eric Blake <eblake@redhat.com>
2014-10-27 14:04:47 -06:00
..
access polkit_driver: fix possible segfault 2014-09-25 12:53:37 +02:00
bhyve Rename virDriver to virHypervisorDriver 2014-10-23 11:09:54 +01:00
conf Fix indentation of sysinfo data 2014-10-24 17:23:52 +01:00
cpu Also filter out non-migratable features out of host-passthrough 2014-09-30 10:51:08 +02:00
esx Rename virDriver to virHypervisorDriver 2014-10-23 11:09:54 +01:00
hyperv hyperv: avoid query memleaks on failure 2014-10-23 17:11:56 -06:00
interface maint: Prohibit "devname" by a syntax check rules 2014-10-01 16:39:01 +02:00
libxl Rename virDriver to virHypervisorDriver 2014-10-23 11:09:54 +01:00
locking remove redundant pidfile path constructions 2014-09-15 09:49:34 +02:00
lxc Rename virDriver to virHypervisorDriver 2014-10-23 11:09:54 +01:00
network network: set interface actual trustGuestRxFilters from network/portgroup 2014-10-06 11:58:57 -04:00
node_device node_device_udev: Try harder to get human readable vendor:product 2014-09-15 15:41:28 +02:00
nwfilter maint: use consistent if-else braces in conf and friends 2014-09-04 08:53:21 -06:00
openvz Rename virDriver to virHypervisorDriver 2014-10-23 11:09:54 +01:00
parallels Rename virDriver to virHypervisorDriver 2014-10-23 11:09:54 +01:00
phyp Rename virDriver to virHypervisorDriver 2014-10-23 11:09:54 +01:00
qemu qemu: forbid snapshot-delete --children-only on external snapshot 2014-10-27 14:04:47 -06:00
remote Rename virDriver to virHypervisorDriver 2014-10-23 11:09:54 +01:00
rpc virnetserver: Raise log level of max_clients related messages 2014-09-25 13:45:29 +02:00
secret drivers: use virDirRead API 2014-04-28 17:52:45 -06:00
security security_selinux: Don't relabel /dev/net/tun 2014-10-08 15:15:58 +02:00
storage storage: Improve error message when traversing backing chains 2014-09-24 10:19:13 +02:00
test Rename virDriver to virHypervisorDriver 2014-10-23 11:09:54 +01:00
uml Rename virDriver to virHypervisorDriver 2014-10-23 11:09:54 +01:00
util util: eliminate "use after free" in callers of virNetDevLinkDump 2014-10-26 12:23:23 -04:00
vbox vbox: network: make sure driver is not NULL in virRegisterNetworkDriver 2014-10-24 11:16:19 -06:00
vmware Rename virDriver to virHypervisorDriver 2014-10-23 11:09:54 +01:00
vmx Implement empty post parse callbacks for all drivers 2014-10-15 10:27:51 +02:00
xen Rename virDriver to virHypervisorDriver 2014-10-23 11:09:54 +01:00
xenapi Rename virDriver to virHypervisorDriver 2014-10-23 11:09:54 +01:00
xenconfig conf: Extend <loader/> and introduce <nvram/> 2014-09-10 09:38:07 +02:00
check-aclperms.pl
check-aclrules.pl
check-driverimpls.pl
check-drivername.pl
check-symfile.pl
check-symsorting.pl
datatypes.c Indent top-level labels by one space in the rest of src/ 2014-03-25 14:58:40 +01:00
datatypes.h Move virDomainSnapshot related APIs out of libvirt.c 2014-10-24 15:59:22 +01:00
driver-hypervisor.h Split driver.h into multiple parts 2014-10-23 11:10:05 +01:00
driver-interface.h Split driver.h into multiple parts 2014-10-23 11:10:05 +01:00
driver-network.h Split driver.h into multiple parts 2014-10-23 11:10:05 +01:00
driver-nodedev.h Split driver.h into multiple parts 2014-10-23 11:10:05 +01:00
driver-nwfilter.h Split driver.h into multiple parts 2014-10-23 11:10:05 +01:00
driver-secret.h Split driver.h into multiple parts 2014-10-23 11:10:05 +01:00
driver-state.h Split driver.h into multiple parts 2014-10-23 11:10:05 +01:00
driver-storage.h Split driver.h into multiple parts 2014-10-23 11:10:05 +01:00
driver-stream.h Split driver.h into multiple parts 2014-10-23 11:10:05 +01:00
driver.c virDriverLoadModule: Honor libvirt func name tranlsation 2014-08-27 07:41:48 +02:00
driver.h Split driver.h into multiple parts 2014-10-23 11:10:05 +01:00
dtrace2systemtap.pl
fdstream.c fix mingw build 2014-08-25 09:44:32 +02:00
fdstream.h fdstream: introduce virFDStreamOpenBlockDevice 2014-08-25 10:46:13 +04:00
gnutls_1_0_compat.h
internal.h Fix spacing around commas 2014-08-22 15:03:39 +02:00
libvirt_atomic.syms
libvirt_daemon.syms
libvirt_driver_modules.syms Use virFileFindResource to locate driver plugins 2014-04-25 11:59:46 +01:00
libvirt_esx.syms
libvirt_gnutls.syms
libvirt_internal.h Make virTypedParameterValidateSet non-static 2014-10-24 16:54:48 +01:00
libvirt_libssh2.syms
libvirt_linux.syms util: virstatslinux: make more generic 2014-07-15 22:00:59 +04:00
libvirt_lxc.syms
libvirt_openvz.syms
libvirt_private.syms Rename virDriver to virHypervisorDriver 2014-10-23 11:09:54 +01:00
libvirt_probes.d
libvirt_public.syms Introduce virNodeAllocPages 2014-09-25 10:24:44 +02:00
libvirt_qemu_probes.d
libvirt_qemu.syms
libvirt_remote.syms remote: create virNetServerServiceNewFDOrUNIX() wrapper 2014-08-22 09:12:13 +02:00
libvirt_sasl.syms
libvirt_vmware.syms
libvirt_vmx.syms
libvirt_xenconfig.syms xen: rename xenxs to xenconfig 2014-08-18 20:36:24 -06:00
libvirt-domain-snapshot.c Move virDomainSnapshot related APIs out of libvirt.c 2014-10-24 15:59:22 +01:00
libvirt-domain.c Move virDomain related APIs out of libvirt.c 2014-10-24 16:59:56 +01:00
libvirt-host.c Move virConnect/virNode related APIs out of libvirt.c 2014-10-24 16:59:58 +01:00
libvirt-interface.c Move virInterface related APIs out of libvirt.c 2014-10-24 16:08:28 +01:00
libvirt-lxc.c Indent top-level labels by one space in the rest of src/ 2014-03-25 14:58:40 +01:00
libvirt-lxc.pc.in Fix build-time pkg-config files in VPATH 2014-10-09 08:03:54 +02:00
libvirt-network.c Move virNetwork related APIs out of libvirt.c 2014-10-24 16:00:21 +01:00
libvirt-nodedev.c Move virNodeDevice related APIs out of libvirt.c 2014-10-24 16:26:55 +01:00
libvirt-nwfilter.c Move virNWFilter related APIs out of libvirt.c 2014-10-24 16:15:46 +01:00
libvirt-qemu.c Indent top-level labels by one space in the rest of src/ 2014-03-25 14:58:40 +01:00
libvirt-qemu.pc.in Fix build-time pkg-config files in VPATH 2014-10-09 08:03:54 +02:00
libvirt-secret.c Move virSecret related APIs out of libvirt.c 2014-10-24 16:39:05 +01:00
libvirt-storage.c Move virStorage{Pool,Vol} related APIs out of libvirt.c 2014-10-24 16:49:10 +01:00
libvirt-stream.c Move virStream related APIs out of libvirt.c 2014-10-24 16:42:49 +01:00
libvirt.c Move virConnect/virNode related APIs out of libvirt.c 2014-10-24 16:59:58 +01:00
libvirt.conf
libvirt.pc.in Fix build-time pkg-config files in VPATH 2014-10-09 08:03:54 +02:00
lock_protocol-structs
lxc_monitor_protocol-structs
lxc_protocol-structs
Makefile.am Add new driver-*.h files to DRIVER_SOURCES 2014-10-24 17:39:48 +01:00
nodeinfo.c nodeinfo: Implement nodeAllocPages 2014-09-25 10:24:45 +02:00
nodeinfo.h nodeinfo: Implement nodeAllocPages 2014-09-25 10:24:45 +02:00
nodeinfopriv.h nodeinfo: Introduce @arch to linuxNodeInfoCPUPopulate 2014-06-20 15:46:52 +02:00
qemu_protocol-structs
README
remote_protocol-structs Introduce virNodeAllocPages 2014-09-25 10:24:44 +02:00
virkeepaliveprotocol-structs
virnetprotocol-structs

       libvirt library code README
       ===========================

The directory provides the bulk of the libvirt codebase. Everything
except for the libvirtd daemon and client tools. The build uses a
large number of libtool convenience libraries - one for each child
directory, and then links them together for the final libvirt.so,
although some bits get linked directly to libvirtd daemon instead.

The files directly in this directory are supporting the public API
entry points & data structures.

There are two core shared modules to be aware of:

 * util/  - a collection of shared APIs that can be used by any
            code. This directory is always in the include path
            for all things built

 * conf/  - APIs for parsing / manipulating all the official XML
            files used by the public API. This directory is only
            in the include path for driver implementation modules

 * vmx/   - VMware VMX config handling (used by esx/ and vmware/)


Then there are the hypervisor implementations:

 * bhyve         - bhyve - The BSD Hypervisor
 * esx/          - VMware ESX and GSX support using vSphere API over SOAP
 * hyperv/       - Microsoft Hyper-V support using WinRM
 * lxc/          - Linux Native Containers
 * openvz/       - OpenVZ containers using cli tools
 * phyp/         - IBM Power Hypervisor using CLI tools over SSH
 * qemu/         - QEMU / KVM using qemu CLI/monitor
 * remote/       - Generic libvirt native RPC client
 * test/         - A "mock" driver for testing
 * uml/          - User Mode Linux
 * vbox/         - Virtual Box using native API
 * vmware/       - VMware Workstation and Player using the vmrun tool
 * xen/          - Xen using hypercalls, XenD SEXPR & XenStore
 * xenapi/       - Xen using libxenserver


Finally some secondary drivers that are shared for several HVs.
Currently these are used by LXC, OpenVZ, QEMU, UML and Xen drivers.
The ESX, Hyper-V, Power Hypervisor, Remote, Test & VirtualBox drivers all
implement the secondary drivers directly

 * cpu/          - CPU feature management
 * interface/    - Host network interface management
 * network/      - Virtual NAT networking
 * nwfilter/     - Network traffic filtering rules
 * node_device/  - Host device enumeration
 * secret/       - Secret management
 * security/     - Mandatory access control drivers
 * storage/      - Storage management drivers


Since both the hypervisor and secondary drivers can be built as
dlopen()able modules, it is *FORBIDDEN* to have build dependencies
between these directories. Drivers are only allowed to depend on
the public API, and the internal APIs in the util/ and conf/
directories