mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-07-08 10:55:51 +00:00
20986e58aa
A few of the tests were missing basic sanity checks, while most of them were doing copy-and-paste initialization (in fact, some of them pasted the argc > 1 check more than once!). It's much nicer to do things in one common place, and minimizes the size of the next patch that fixes getcwd usage. * tests/testutils.h (EXIT_AM_HARDFAIL): New define. (progname, abs_srcdir): Define for all tests. (VIRT_TEST_MAIN): Change callback signature. * tests/testutils.c (virtTestMain): Do more common init. * tests/commandtest.c (mymain): Simplify. * tests/cputest.c (mymain): Likewise. * tests/esxutilstest.c (mymain): Likewise. * tests/eventtest.c (mymain): Likewise. * tests/hashtest.c (mymain): Likewise. * tests/networkxml2xmltest.c (mymain): Likewise. * tests/nodedevxml2xmltest.c (myname): Likewise. * tests/nodeinfotest.c (mymain): Likewise. * tests/nwfilterxml2xmltest.c (mymain): Likewise. * tests/qemuargv2xmltest.c (mymain): Likewise. * tests/qemuhelptest.c (mymain): Likewise. * tests/qemuxml2argvtest.c (mymain): Likewise. * tests/qemuxml2xmltest.c (mymain): Likewise. * tests/qparamtest.c (mymain): Likewise. * tests/sexpr2xmltest.c (mymain): Likewise. * tests/sockettest.c (mymain): Likewise. * tests/statstest.c (mymain): Likewise. * tests/storagepoolxml2xmltest.c (mymain): Likewise. * tests/storagevolxml2xmltest.c (mymain): Likewise. * tests/virbuftest.c (mymain): Likewise. * tests/virshtest.c (mymain): Likewise. * tests/vmx2xmltest.c (mymain): Likewise. * tests/xencapstest.c (mymain): Likewise. * tests/xmconfigtest.c (mymain): Likewise. * tests/xml2sexprtest.c (mymain): Likewise. * tests/xml2vmxtest.c (mymain): Likewise.
145 lines
3.8 KiB
C
145 lines
3.8 KiB
C
#include <config.h>
|
|
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <unistd.h>
|
|
#include <string.h>
|
|
|
|
#include <sys/types.h>
|
|
#include <fcntl.h>
|
|
|
|
#include "internal.h"
|
|
#include "testutils.h"
|
|
#include "xml.h"
|
|
#include "threads.h"
|
|
#include "nwfilter_params.h"
|
|
#include "nwfilter_conf.h"
|
|
#include "testutilsqemu.h"
|
|
|
|
#define MAX_FILE 4096
|
|
|
|
|
|
static int testCompareXMLToXMLFiles(const char *inxml,
|
|
const char *outxml,
|
|
bool expect_error) {
|
|
char inXmlData[MAX_FILE];
|
|
char *inXmlPtr = &(inXmlData[0]);
|
|
char outXmlData[MAX_FILE];
|
|
char *outXmlPtr = &(outXmlData[0]);
|
|
char *actual = NULL;
|
|
int ret = -1;
|
|
virNWFilterDefPtr dev = NULL;
|
|
|
|
if (virtTestLoadFile(inxml, &inXmlPtr, MAX_FILE) < 0)
|
|
goto fail;
|
|
if (virtTestLoadFile(outxml, &outXmlPtr, MAX_FILE) < 0)
|
|
goto fail;
|
|
|
|
virResetLastError();
|
|
|
|
if (!(dev = virNWFilterDefParseString(NULL, inXmlData)))
|
|
goto fail;
|
|
|
|
if (!!virGetLastError() != expect_error)
|
|
goto fail;
|
|
|
|
if (expect_error) {
|
|
/* need to suppress the errors */
|
|
virResetLastError();
|
|
}
|
|
|
|
if (!(actual = virNWFilterDefFormat(dev)))
|
|
goto fail;
|
|
|
|
if (STRNEQ(outXmlData, actual)) {
|
|
virtTestDifference(stderr, outXmlData, actual);
|
|
goto fail;
|
|
}
|
|
|
|
ret = 0;
|
|
|
|
fail:
|
|
free(actual);
|
|
virNWFilterDefFree(dev);
|
|
return ret;
|
|
}
|
|
|
|
typedef struct test_parms {
|
|
const char *name;
|
|
bool expect_warning;
|
|
} test_parms;
|
|
|
|
static int testCompareXMLToXMLHelper(const void *data) {
|
|
const test_parms *tp = data;
|
|
char inxml[PATH_MAX];
|
|
char outxml[PATH_MAX];
|
|
snprintf(inxml, PATH_MAX, "%s/nwfilterxml2xmlin/%s.xml",
|
|
abs_srcdir, tp->name);
|
|
snprintf(outxml, PATH_MAX, "%s/nwfilterxml2xmlout/%s.xml",
|
|
abs_srcdir, tp->name);
|
|
return testCompareXMLToXMLFiles(inxml, outxml, tp->expect_warning);
|
|
}
|
|
|
|
|
|
static int
|
|
mymain(void)
|
|
{
|
|
int ret = 0;
|
|
|
|
#define DO_TEST(NAME, EXPECT_WARN) \
|
|
do { \
|
|
test_parms tp = { \
|
|
.name = NAME, \
|
|
.expect_warning = EXPECT_WARN, \
|
|
}; \
|
|
if (virtTestRun("NWFilter XML-2-XML " NAME, \
|
|
1, testCompareXMLToXMLHelper, (&tp)) < 0) \
|
|
ret = -1; \
|
|
} while (0)
|
|
|
|
DO_TEST("mac-test", true);
|
|
DO_TEST("arp-test", true);
|
|
DO_TEST("rarp-test", true);
|
|
DO_TEST("ip-test", true);
|
|
DO_TEST("ipv6-test", true);
|
|
|
|
DO_TEST("tcp-test", true);
|
|
DO_TEST("udp-test", true);
|
|
DO_TEST("icmp-test", true);
|
|
DO_TEST("igmp-test", false);
|
|
DO_TEST("sctp-test", true);
|
|
DO_TEST("udplite-test", false);
|
|
DO_TEST("esp-test", false);
|
|
DO_TEST("ah-test", false);
|
|
DO_TEST("all-test", false);
|
|
|
|
DO_TEST("tcp-ipv6-test", true);
|
|
DO_TEST("udp-ipv6-test", true);
|
|
DO_TEST("icmpv6-test", true);
|
|
DO_TEST("sctp-ipv6-test", true);
|
|
DO_TEST("udplite-ipv6-test", true);
|
|
DO_TEST("esp-ipv6-test", true);
|
|
DO_TEST("ah-ipv6-test", true);
|
|
DO_TEST("all-ipv6-test", true);
|
|
|
|
DO_TEST("ref-test", false);
|
|
DO_TEST("ref-rule-test", false);
|
|
DO_TEST("ipt-no-macspoof-test", false);
|
|
DO_TEST("icmp-direction-test", false);
|
|
DO_TEST("icmp-direction2-test", false);
|
|
DO_TEST("icmp-direction3-test", false);
|
|
|
|
DO_TEST("conntrack-test", false);
|
|
|
|
DO_TEST("hex-data-test", true);
|
|
|
|
DO_TEST("comment-test", true);
|
|
|
|
DO_TEST("example-1", false);
|
|
DO_TEST("example-2", false);
|
|
|
|
return (ret==0 ? EXIT_SUCCESS : EXIT_FAILURE);
|
|
}
|
|
|
|
VIRT_TEST_MAIN(mymain)
|