libvirt/tests/qemuhelpdata
Laine Stump e9bd5c0e24 Add txmode attribute to interface XML for virtio backend
This is in response to:

   https://bugzilla.redhat.com/show_bug.cgi?id=629662

Explanation

qemu's virtio-net-pci driver allows setting the algorithm used for tx
packets to either "bh" or "timer". This is done by adding ",tx=bh" or
",tx=timer" to the "-device virtio-net-pci" commandline option.

'bh' stands for 'bottom half'; when this is set, packet tx is all done
in an iothread in the bottom half of the driver. (In libvirt, this
option is called the more descriptive "iothread".)

'timer' means that tx work is done in qemu, and if there is more tx
data than can be sent at the present time, a timer is set before qemu
moves on to do other things; when the timer fires, another attempt is
made to send more data. (libvirt retains the name "timer" for this
option.)

The resulting difference, according to the qemu developer who added
the option is:

    bh makes tx more asynchronous and reduces latency, but potentially
    causes more processor bandwidth contention since the cpu doing the
    tx isn't necessarily the cpu where the guest generated the
    packets.

Solution

This patch provides a libvirt domain xml knob to change the option on
the qemu commandline, by adding a new attribute "txmode" to the
<driver> element that can be placed inside any <interface> element in
a domain definition. It's use would be something like this:

    <interface ...>
      ...
      <model type='virtio'/>
      <driver txmode='iothread'/>
      ...
    </interface>

I chose to put this setting as an attribute to <driver> rather than as
a sub-element to <tune> because it is specific to the virtio-net
driver, not something that is generally usable by all network drivers.
(note that this is the same placement as the "driver name=..."
attribute used to choose kernel vs. userland backend for the
virtio-net driver.)

Actually adding the tx=xxx option to the qemu commandline is only done
if the version of qemu being used advertises it in the output of

    qemu -device virtio-net-pci,?

If a particular txmode is requested in the XML, and the option isn't
listed in that help output, an UNSUPPORTED_CONFIG error is logged, and
the domain fails to start.
2011-02-17 11:07:58 -05:00
..
kvm-74 Add qemu help string parsing tests 2009-06-11 14:17:42 +00:00
kvm-83-rhel56 qemu: Fix detection of drive readonly option 2010-10-26 10:31:50 +02:00
kvm-86 Add qemu help string parsing tests 2009-06-11 14:17:42 +00:00
qemu-0.9.1 Add qemu help string parsing tests 2009-06-11 14:17:42 +00:00
qemu-0.10.5 Add qemu help string parsing tests 2009-06-11 14:17:42 +00:00
qemu-0.12.1 Probe for -device and use -nodefaults 2010-01-18 13:39:14 +00:00
qemu-0.12.1-device qemu: improve device flag parsing 2011-01-13 16:03:11 -07:00
qemu-kvm-0.10.5 Add qemu help string parsing tests 2009-06-11 14:17:42 +00:00
qemu-kvm-0.11.0-rc2 Add qemu -help test data for qemu-kvm-0.11.0-rc2 2009-09-10 12:37:35 +01:00
qemu-kvm-0.12.1.2-rhel60 tests: test RHEL 6.0 qemu-kvm -help parsing 2010-12-13 16:30:02 -07:00
qemu-kvm-0.12.1.2-rhel60-device qemu: improve device flag parsing 2011-01-13 16:03:11 -07:00
qemu-kvm-0.12.1.2-rhel61 smartcard: check for qemu capability 2011-02-03 19:28:53 -07:00
qemu-kvm-0.12.1.2-rhel61-device Add txmode attribute to interface XML for virtio backend 2011-02-17 11:07:58 -05:00
qemu-kvm-0.12.3 qemu_conf: fix flag value 2010-05-17 16:28:02 -06:00
qemu-kvm-0.12.3-device qemu: improve device flag parsing 2011-01-13 16:03:11 -07:00
qemu-kvm-0.13.0 tests: test Fedora 14 qemu-kvm -help parsing 2010-12-13 16:30:02 -07:00
qemu-kvm-0.13.0-device Add txmode attribute to interface XML for virtio backend 2011-02-17 11:07:58 -05:00