libvirt/tests
Daniel P. Berrangé ae6a89884a tests: fix two off-by-1 errors in read-big-pipe test
When testPipeFeeder copies the XML document into the padded buffer, it
tells virStrcpy that 'xmlsize' bytes are available. This is under
reporting size by 1 byte, and as a result it fails to copy the trailing
'\n' replacing it with '\0'. The return value of virStrcpy wasn't
checked, but was reporting this truncation.

When testPipeFeeder then sends the padded buffer down the pipe, it asks
to send 'emptyspace + xmlsize + 1' bytes, which means it sends the data,
as well as the trailing '\0' terminator.

Both bugs combined mean it is sending '\0\0' as the last bytes, instead
of '\n' which was intended. When virFileReadAll reads data from the
pipe, it ends up adding another '\0' resulting in a very NUL terminated
string ('\0\0\0'). This is all harmless, but should be fixed regardless.

Reviewed-by: Andrea Bolognani <abologna@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2024-05-08 14:33:42 +01:00
..
bhyveargv2xmldata
bhyvefirmwaredata
bhyvexml2argvdata
bhyvexml2xmloutdata
capabilityschemadata conf: Report CPU clusters in capabilities XML 2024-01-15 14:56:35 +01:00
chxml2xmlin tests: chxml2xmlin: Fix path format for fake paths 2023-08-25 10:07:36 +02:00
chxml2xmlout test: Introduce chxml2xmltest 2023-02-14 13:59:45 +01:00
commanddata commandtest: Test virCommandSetSendBuffer() with virCommandDoAsyncIO() 2022-12-01 14:22:39 +01:00
cputestdata cpu_map: Drop 'mpx' from x86 cpu models 2024-05-02 19:56:45 +02:00
domainbackupxml2xmlin schemas: backup: Allow missing 'type' attribute for backup disk 2023-05-16 10:26:33 +02:00
domainbackupxml2xmlout schemas: backup: Allow missing 'type' attribute for backup disk 2023-05-16 10:26:33 +02:00
domaincapsdata cpu_map: Drop 'mpx' from x86 cpu models 2024-05-02 19:56:45 +02:00
domainconfdata
domainschemadata tests: qemu: Move testing of default cache and disk source with space to 'sata-device' 2023-03-06 20:55:49 +01:00
fchostdata/fc_host
genericxml2xmlindata tests: Add title-and-description 2024-01-30 10:58:13 +01:00
genericxml2xmloutdata qemuxml2xmltest: Move 'graphics-listen-network2' case go genericxml2xmltest 2024-01-04 22:26:10 +01:00
interfaceschemadata
libxlxml2domconfigdata xen: explicitly set hostdev driver.name at runtime, not in postparse 2024-01-07 23:59:00 -05:00
lxcconf2xmldata
lxcxml2xmldata
lxcxml2xmloutdata
networkxml2confdata
networkxml2firewalldata
networkxml2xmlin conf: support manually specifying VFIO variant driver in <hostdev> XML 2024-01-08 01:00:08 -05:00
networkxml2xmlout conf: support manually specifying VFIO variant driver in <hostdev> XML 2024-01-08 01:00:08 -05:00
networkxml2xmlupdatein
networkxml2xmlupdateout
nodedevmdevctldata nodedev: Implement virNodeDeviceUpdate 2024-02-26 11:09:57 +01:00
nodedevschemadata nodedev: add an active config to mdev 2024-02-26 10:59:47 +01:00
nodedevxml2xmlout nodedev: add an active config to mdev 2024-02-26 10:59:47 +01:00
nssdata
nwfilterxml2firewalldata
nwfilterxml2xmlin nwfilterxml2xmltest: Add test case for parser and formatter quirks 2023-06-05 13:23:06 +02:00
nwfilterxml2xmlout virNWFilterRuleDefDetailsFormat: Refactor formatter 2023-06-05 13:23:06 +02:00
qemuagentdata qemuagenttest: Use real x86_64 capabilities for parsing domain definitions 2023-07-20 15:23:34 +02:00
qemublocktestdata qemuBlockStorageSourceGetBackendProps: Unify ordering of fields 2023-11-02 15:31:10 +01:00
qemucapabilitiesdata qemu_capabilities: Add QEMU_CAPS_DEVICE_VIRTIO_SOUND capability 2024-05-02 15:37:53 +02:00
qemucaps2xmloutdata Add test script for loongarch 2024-03-21 14:42:27 +01:00
qemudomaincheckpointxml2xmlin
qemudomaincheckpointxml2xmlout qemudomaincheckpointxml2xmltest: Use real 'x86_64' capabilities in all test data 2023-07-20 15:23:43 +02:00
qemudomainsnapshotxml2xmlin
qemudomainsnapshotxml2xmlout tests: qemudomainsnapshotxml2xmlout: Use real 'x86_64' capabilities in all test data 2023-07-20 15:23:24 +02:00
qemufirmwaredata tests: Don't advertise features for edk2-loongarch64 2024-03-07 13:35:05 +01:00
qemuhotplugtestcpus conf: Allow specifying CPU clusters 2024-01-15 14:56:35 +01:00
qemuhotplugtestdevices tests: remove explicit <driver name='vfio'/> from hostdev test cases 2024-01-07 23:59:00 -05:00
qemuhotplugtestdomains conf: Allow specifying CPU clusters 2024-01-15 14:56:35 +01:00
qemumemlockdata tests: remove explicit <driver name='vfio'/> from hostdev test cases 2024-01-07 23:59:00 -05:00
qemumigparamsdata tests: qemumigparamsdata: Drop deprecated fields 2023-11-10 10:04:04 +01:00
qemumigrationcookiexmldata
qemumonitorjsondata tests: Verify handling of CPU clusters in QMP data 2024-01-15 14:56:36 +01:00
qemunbdkitdata qemu: fix nbdkit command test for backing chains 2024-02-09 14:45:20 -06:00
qemusecuritydata
qemustatusxml2xmldata tests: remove explicit <driver name='vfio'/> from hostdev test cases 2024-01-07 23:59:00 -05:00
qemuvhostuserdata
qemuxmlactive2xmldata qemuxmlactivetest: Add qemu active XML to active/inactive XML tests 2024-01-17 17:31:12 +01:00
qemuxmlconfdata cpu_map: Drop 'mpx' from x86 cpu models 2024-05-02 19:56:45 +02:00
schemas virschematest: Add infrastructure for testing single devices 2022-11-03 09:19:54 +01:00
secretxml2xmlin
securityselinuxhelperdata
securityselinuxlabeldata
storagepoolcapsschemadata
storagepoolschemadata
storagepoolxml2argvdata
storagepoolxml2xmlin
storagepoolxml2xmlout tests: Remove storage pool/vol tests for sheepdog 2022-09-01 13:11:09 +02:00
storagevolschemadata
storagevolxml2argvdata storage: Upgrade default qcow2 verion to 1.1 2024-03-12 10:34:43 +01:00
storagevolxml2xmlin
storagevolxml2xmlout
sysinfodata
vboxsnapshotxmldata
viracpidata tests: Introduce viracpitest 2023-04-06 12:48:22 +02:00
vircaps2xmldata conf: Report CPU clusters in capabilities XML 2024-01-15 14:56:35 +01:00
vircgroupdata
virconfdata
virfilecachedata
virfiledata
virhostcpudata tests: Add hostcpudata for machine with CPU clusters 2024-01-15 14:56:35 +01:00
virjsondata
virmacmaptestdata
virnetdaemondata rpc: Fix error message in virNetServerSetClientLimits 2023-01-02 20:39:09 +01:00
virnetdevopenvswitchdata
virnetdevtestdata/sys/class/net
virnetworkportxml2xmldata conf: support manually specifying VFIO variant driver in <hostdev> XML 2024-01-08 01:00:08 -05:00
virnwfilterbindingxml2xmldata
virpcitestdata virpcimock: Introduce NVMe driver and devices 2019-12-17 10:04:43 +01:00
virprocessstatdata
virresctrldata
virscsidata
virshtestdata virshtest: Add test cases for command completion helper 2024-04-25 14:13:19 +02:00
virstoragetestdata storage_file_probe: Treat qcow2 images with protocol drivers in backing store field as raw 2023-11-27 10:12:34 +01:00
virstorageutildata
virusbtestdata/sys_bus_usb/devices
virutiltestdata util: add virGetSubUIDs 2023-12-14 17:10:22 +01:00
vmwareverdata
vmx2xmldata vmx: Check serialX.vspc before serialX.fileName 2024-05-02 17:22:37 +02:00
xlconfigdata xen: explicitly set hostdev driver.name at runtime, not in postparse 2024-01-07 23:59:00 -05:00
xmconfigdata xen: explicitly set hostdev driver.name at runtime, not in postparse 2024-01-07 23:59:00 -05:00
xml2vmxdata
.valgrind.supp tests: Refresh valgrind suppressions 2023-07-20 11:22:08 +02:00
bhyveargv2xmlmock.c
bhyveargv2xmltest.c
bhyvexml2argvmock.c maint: fix "mixing declarations and code" errors 2022-11-09 18:22:47 +01:00
bhyvexml2argvtest.c
bhyvexml2xmltest.c
chxml2xmlmock.c tests: Introduce chxml2xmlmock 2024-03-12 17:37:51 +01:00
chxml2xmltest.c tests: Introduce chxml2xmlmock 2024-03-12 17:37:51 +01:00
commandhelper.c lib: Replace qsort() with g_qsort_with_data() 2023-11-24 09:53:14 +01:00
commandtest.c vircommand: Introduce virCommandMassCloseRange() 2023-08-24 12:45:00 +02:00
cputest.c cpu: Add removedPolicy parameter to virCPUUpdate 2024-05-02 19:56:45 +02:00
domaincapsmock.c qemu: S390 does not provide physical address size 2023-07-19 08:42:08 +02:00
domaincapstest.c Add test script for loongarch 2024-03-21 14:42:27 +01:00
domainconftest.c
esxutilstest.c tests: Use virTestCompareToString() more 2022-12-01 14:22:39 +01:00
eventtest.c
fchosttest.c
fdstreamtest.c
genericxml2xmltest.c tests: Add title-and-description 2024-01-30 10:58:13 +01:00
interfacexml2xmltest.c
libxlmock.c lib: Finish using struct zero initializer manually 2023-08-03 16:41:19 +02:00
libxlxml2domconfigtest.c libxl: Support specifying a custom firmware path 2023-03-10 11:01:42 -07:00
lxcconf2xmltest.c
lxcxml2xmltest.c
meson.build meson: tests: Add 'virsh' as dependency of 'virshtest' 2024-04-25 14:13:19 +02:00
metadatatest.c
networkmetadatatest.c Add Test driver and testcase for Network Metadata change APIs 2023-08-25 12:36:37 +02:00
networkxml2conftest.c maint: fix "mixing declarations and code" errors 2022-11-09 18:22:47 +01:00
networkxml2firewalltest.c conf: network: Provide only virNetworkDefParse 2022-10-06 10:54:25 +02:00
networkxml2xmltest.c conf: support manually specifying VFIO variant driver in <hostdev> XML 2024-01-08 01:00:08 -05:00
networkxml2xmlupdatetest.c conf: network: Provide only virNetworkDefParse 2022-10-06 10:54:25 +02:00
nodedevmdevctltest.c nodedevmdevctltest: Fix two memleaks 2024-02-26 14:35:52 +01:00
nodedevxml2xmltest.c test: nodedev: fill active_config at driver startup time 2024-04-24 09:38:54 -04:00
nsslinktest.c
nssmock.c tests: mock __open_2() 2024-03-14 15:17:48 +01:00
nsstest.c lib: use struct zero initializer instead of memset 2023-08-03 16:41:19 +02:00
nwfilterebiptablestest.c tests: Use virTestCompareToString() more 2022-12-01 14:22:39 +01:00
nwfilterxml2firewalltest.c lib: use struct zero initializer instead of memset 2023-08-03 16:41:19 +02:00
nwfilterxml2xmltest.c nwfilterxml2xmltest: Add test case for parser and formatter quirks 2023-06-05 13:23:06 +02:00
objecteventtest.c
openvzutilstest.c tests: Use virTestCompareToString() more 2022-12-01 14:22:39 +01:00
openvzutilstest.conf
permitted_file_access.txt
pkix_asn1_tab.c
qemuagenttest.c qemuagenttest: Use real x86_64 capabilities for parsing domain definitions 2023-07-20 15:23:34 +02:00
qemublocktest.c qemu: block: Remove unused flags QEMU_BLOCK_STORAGE_SOURCE_BACKEND_PROPS_ flags 2023-11-02 15:32:43 +01:00
qemucapabilitiestest.c qemucapabilitiestest: Add support for '+hvf' variant 2023-04-03 09:19:06 +02:00
qemucaps2xmlmock.c
qemucaps2xmltest.c virQEMUCapsInitGuestFromBinary: Remove return value 2023-04-03 09:19:07 +02:00
qemucapsprobe.c tests: qemucapsprobe: Fix construction of path to libqemucapsprobemock.so 2024-04-24 14:12:17 +02:00
qemucapsprobemock.c tests: qemucaps: Make JSON output identical to python's 'json.dump' method 2024-02-01 10:39:40 +01:00
qemucommandutiltest.c
qemucpumock.c
qemudomaincheckpointxml2xmltest.c qemudomaincheckpointxml2xmltest: Use real 'x86_64' capabilities in all test data 2023-07-20 15:23:43 +02:00
qemudomainsnapshotxml2xmltest.c tests: qemudomainsnapshotxml2xmlout: Use real 'x86_64' capabilities in all test data 2023-07-20 15:23:24 +02:00
qemufirmwaretest.c Add loongarch cpu support 2024-03-21 14:42:20 +01:00
qemuhotplugmock.c qemu: make vdpa connect function more generic 2023-09-12 11:06:41 -05:00
qemuhotplugtest.c qemuBlockStorageSourceNeedsFormatLayer: Stop formatting 'raw' driver when not needed 2024-02-02 16:03:08 +01:00
qemumemlocktest.c qemumemlocktest: Use 'testQemuInsertRealCaps' 2023-07-20 15:23:16 +02:00
qemumigparamstest.c
qemumigrationcookiexmltest.c qemumigrationcookiexmltest: Don't crash when parsing of status XML fails 2023-11-10 10:04:04 +01:00
qemumonitorjsontest.c tests: Verify handling of CPU clusters in QMP data 2024-01-15 14:56:36 +01:00
qemumonitortestutils.c qemumonitortestutils: Unexport 'qemuMonitorTestProcessFileEntries' 2024-02-01 10:39:40 +01:00
qemumonitortestutils.h qemumonitortestutils: Unexport 'qemuMonitorTestProcessFileEntries' 2024-02-01 10:39:40 +01:00
qemunbdkittest.c qemu: fix nbdkit command test for backing chains 2024-02-09 14:45:20 -06:00
qemusecuritymock.c qemusecuritytest: Call real virFileExists in mock 2024-04-09 16:55:25 +02:00
qemusecuritytest.c qemuxmlconftest: Move data directory 'qemuxml2argvdata' to 'qemuxmlconfdata' 2024-01-24 09:19:28 +01:00
qemusecuritytest.h
qemuvhostusertest.c
qemuxml2argvmock.c qemuxml2argvmock: Mock virNetDevSetMTU 2024-01-04 22:26:10 +01:00
qemuxmlactivetest.c qemuxmlconftest: Move data directory 'qemuxml2argvdata' to 'qemuxmlconfdata' 2024-01-24 09:19:28 +01:00
qemuxmlconftest.c qemu: Generate command line for sound devices with model 'virtio' 2024-05-02 15:38:34 +02:00
scsihosttest.c tests: Move fakerootdir handling to common logic 2023-03-03 13:52:37 +01:00
seclabeltest.c
secretxml2xmltest.c conf: secret: Provide only virSecretDefParse 2022-10-06 10:54:24 +02:00
securityselinuxhelper.c meson: remove obsolete check for linux/magic.h 2022-12-12 10:36:13 +00:00
securityselinuxlabeltest.c tests: mock: Accept spaces in build path 2024-04-15 09:24:16 +02:00
securityselinuxtest.c tests: mock: Accept spaces in build path 2024-04-15 09:24:16 +02:00
shunloadhelper.c
shunloadtest.c
sockettest.c lib: Finish using struct zero initializer manually 2023-08-03 16:41:19 +02:00
ssh.c
storagepoolcapstest.c
storagepoolxml2argvtest.c conf: storage: Provide only virStoragePoolDefParse 2022-10-06 10:54:24 +02:00
storagepoolxml2xmltest.c conf: storage: Provide only virStoragePoolDefParse 2022-10-06 10:54:24 +02:00
storagevolxml2argvtest.c conf: storage: Provide only virStorageVolDefParse 2022-10-06 10:54:24 +02:00
storagevolxml2xmltest.c conf: storage: Provide only virStorageVolDefParse 2022-10-06 10:54:24 +02:00
sysinfotest.c
testutils.c tests: mock: Accept spaces in build path 2024-04-15 09:24:16 +02:00
testutils.h tests: mock: Accept spaces in build path 2024-04-15 09:24:16 +02:00
testutilshostcpus.h Add test script for loongarch 2024-03-21 14:42:27 +01:00
testutilslxc.c
testutilslxc.h
testutilsqemu.c qemuxmlactivetest: Prepare for proper active/inactive -> active/inactive testing 2024-01-17 17:31:12 +01:00
testutilsqemu.h qemuxml2argvtest: Extract setup/parse step 2024-01-17 17:31:12 +01:00
testutilsqemuschema.c testQEMUSchemaValidateObjectMember: validate QMP object member deprecation 2023-06-05 13:20:13 +02:00
testutilsqemuschema.h
testutilsxen.c virCapabilitiesAllocMachines: Use NULL-terminated list as argument and return count 2023-04-03 09:19:07 +02:00
testutilsxen.h
utiltest.c util: add virGetSubUIDs 2023-12-14 17:10:22 +01:00
vboxsnapshotxmltest.c tests: Use virTestCompareToString() more 2022-12-01 14:22:39 +01:00
viracpitest.c tests: Introduce viracpitest 2023-04-06 12:48:22 +02:00
viralloctest.c
virauthconfigtest.c
virbitmaptest.c virbitmap: Introduce virBitmapParseUnlimitedAllowEmpty() 2024-05-06 15:26:58 +02:00
virbuftest.c tests: Use virTestCompareToString() more 2022-12-01 14:22:39 +01:00
vircaps2xmltest.c tests: Add hostcpudata for machine with CPU clusters 2024-01-15 14:56:35 +01:00
vircgroupmock.c tests: mock __open_2() 2024-03-14 15:17:48 +01:00
vircgrouptest.c tests: Adopt fakerootdir helpers 2023-03-03 13:52:37 +01:00
virconftest.c
vircryptotest.c vircryptotest: Fix cipher test typo aes265cbc -> aes256cbc 2023-04-03 08:21:27 +02:00
virdnsmasqmock.c
virdriverconnvalidatetest.c
virdrivermoduletest.c
virendiantest.c
virerrortest.c util: Update format strings in translated messages (part 1) 2023-04-01 11:40:35 +02:00
virfilecachemock.c
virfilecachetest.c
virfilemock.c meson: remove obsolete check for linux/magic.h 2022-12-12 10:36:13 +00:00
virfiletest.c
virfilewrapper.c tests: mock __open_2() 2024-03-14 15:17:48 +01:00
virfilewrapper.h
virfirewallmock.c virfirewallmock: Replace virFindFileInPath() with virFirewallDIsRegistered() 2023-05-10 14:44:22 +02:00
virfirewalltest.c tests: Drop dead code 2023-04-04 10:52:15 +02:00
virgdbusmock.c
virhostcpumock.c
virhostcputest.c tests: Add hostcpudata for machine with CPU clusters 2024-01-15 14:56:35 +01:00
virhostdevmock.c
virhostdevtest.c conf: put hostdev PCI backend into a struct 2024-01-07 23:57:09 -05:00
virhostidmock.c
viridentitytest.c tests: mock: Accept spaces in build path 2024-04-15 09:24:16 +02:00
viriscsitest.c
virjsontest.c virjsontest: Introduce a test case for an empty array 2023-08-24 13:47:41 +02:00
virkeycodetest.c
virkmodtest.c tests: Use virTestCompareToString() more 2022-12-01 14:22:39 +01:00
virlockspacetest.c
virlogtest.c
virmacmaptest.c
virmigtest.c
virmock.h tests: mock __open_2() 2024-03-14 15:17:48 +01:00
virmockstathelpers.c virmockstathelpers: Adapt to musl-1.2.4 2023-05-16 08:48:17 +02:00
virnetdaemonmock.c
virnetdaemontest.c rpc: virnetserver: virNetServerAddService() to void 2024-01-04 17:05:34 +01:00
virnetdevbandwidthmock.c
virnetdevbandwidthtest.c tests: Use virTestCompareToString() more 2022-12-01 14:22:39 +01:00
virnetdevmock.c
virnetdevopenvswitchtest.c tests: Use virTestCompareToString() more 2022-12-01 14:22:39 +01:00
virnetdevtest.c Use G_N_ELEMENTS() more 2023-03-13 13:29:07 +01:00
virnetmessagetest.c lib: use struct zero initializer instead of memset 2023-08-03 16:41:19 +02:00
virnetserverclientmock.c
virnetserverclienttest.c
virnetsockettest.c Decrease scope of some variables 2023-08-03 16:35:11 +02:00
virnettlscontexttest.c tests: Drop needless virrandom mock from two tests 2022-11-21 15:36:08 +01:00
virnettlshelpers.c
virnettlshelpers.h
virnettlssessiontest.c tests: Drop needless virrandom mock from two tests 2022-11-21 15:36:08 +01:00
virnetworkportxml2xmltest.c virnetworkportxml2xmltest: Add simple versions of bridge/network tests 2024-01-04 22:26:10 +01:00
virnumamock.c virnumamock: Introduce virNumaGetNodeOfCPU() mock 2023-03-15 12:46:21 +01:00
virnwfilterbindingxml2xmltest.c conf: nwfilterbinding: Provide only virNWFilterBindingDefParse 2022-10-06 10:54:24 +02:00
virpcimock.c tests: mock __open_2() 2024-03-14 15:17:48 +01:00
virpcitest.c virPCIDeviceGetVPD: Handle errors in callers 2024-01-31 17:24:07 +01:00
virpcivpdtest.c util: virpcivpd: Remove return value from virPCIVPDResourceUpdateKeyword 2024-01-31 17:24:07 +01:00
virpolkittest.c
virportallocatormock.c
virportallocatortest.c
virprocessmock.c
virprocessstattest.c
virrandommock.c virrandommock: Drop virRandomGenerateWWN 2023-07-19 13:09:11 +02:00
virresctrltest.c
virrotatingfiletest.c
virschematest.c qemuxmlconftest: Move 'qemuxml2xmloutdata' into 'qemuxmlconfdata' 2024-01-24 09:19:28 +01:00
virscsitest.c
virsh-auth scripts: Fix the flake8 syntax-check failures 2023-06-29 11:51:27 +02:00
virsh-auth.xml
virshtest.c tests: fix two off-by-1 errors in read-big-pipe test 2024-05-08 14:33:42 +01:00
virstoragetest.c storage_file_probe: Treat qcow2 images with protocol drivers in backing store field as raw 2023-11-27 10:12:34 +01:00
virstorageutiltest.c
virstringtest.c lib: Replace qsort() with g_qsort_with_data() 2023-11-24 09:53:14 +01:00
virsystemdtest.c tests: Add tests for virSystemdResolvedRegisterNameServer 2024-02-07 14:19:42 +01:00
virt-aa-helper-test tests: Allow spaces in path to virt-aa-helper 2024-04-15 09:28:32 +02:00
virtestmock.c tests: mock __open_2() 2024-03-14 15:17:48 +01:00
virtimetest.c
virtypedparamtest.c
viruritest.c Drop checks for virURIFormat() retval 2023-02-08 16:50:45 +01:00
virusbmock.c tests: mock __open_2() 2024-03-14 15:17:48 +01:00
virusbtest.c
vmwarevertest.c
vmx2xmltest.c vmx: Check serialX.vspc before serialX.fileName 2024-05-02 17:22:37 +02:00
vshtabletest.c
xlconfigtest.c libxl: Fix domxml-to-native conversion 2024-05-02 15:57:29 -06:00
xmconfigtest.c libxl: Fix domxml-to-native conversion 2024-05-02 15:57:29 -06:00
xml2vmxtest.c