libvirt/src
Michal Privoznik 25ebb45a81 qemu_tpm: Generate log file path among with storage path
When starting a guest with TPM of type='emulator' an external
process is started with it (swtpm) to emulate TPM. This external
process is passed path to a log file via --logfile. The path to
the log file is generated in qemuTPMEmulatorPrepareHost() which
works, until the daemon is restarted. The problem is that the
path is not stored in private data or anywhere inside live XML
and thus later, when qemuExtTPMStop() is called (when shutting
off the guest) the stored logpath is NULL and thus its seclabel
is not cleaned up (see virSecuritySELinuxRestoreTPMLabels()).

Fortunately, qemuExtDevicesStop() (which calls qemuExtTPMStop()
eventually) does call qemuExtDevicesInitPaths() where the log
path can be generated again.

Basically, tpm->data.emulator.storagepath is generated in
qemuExtTPMInitPaths() and its seclabels are restored properly,
and this commit move logfile onto the same level.

This means, that the log path doesn't have to be generated in
qemuExtDevicesStart() because it was already done in
qemuExtDevicesPrepareHost().

This change also renders @vmname argument of
qemuTPMEmulatorPrepareHost() unused and thus is removed.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1769196
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
2021-03-02 09:45:49 +01:00
..
access access: replace VIR_FREE with g_free in all *Dispose() functions 2021-02-05 00:22:09 -05:00
admin Use g_steal_pointer where possible 2021-03-01 15:54:42 +01:00
bhyve Replace virStringListJoin by g_strjoinv 2021-02-11 17:05:34 +01:00
conf Remove redundant variables/labels 2021-03-01 18:50:22 -05:00
cpu Replace virStringListLength by g_strv_length 2021-02-11 17:05:34 +01:00
cpu_map cpumap: Add support for svme-addr-check CPU feature 2021-03-01 20:09:46 +01:00
esx esx: use g_autofree for datastoreRelatedPath 2021-02-18 13:54:02 +01:00
hyperv hyperv: Fix 32bit compilation 2021-03-01 13:46:20 -05:00
hypervisor virhostdev.c: remove missing PCI devs from hostdev manager 2021-03-01 12:25:33 -03:00
interface Use g_steal_pointer where possible 2021-03-01 15:54:42 +01:00
keycodemapdb@27acf0ef82
libxl libxl: Add lock process indicator to libxlDomainObjPrivate object 2021-02-23 17:55:19 -07:00
locking virJSONValueArrayAppend: Clear pointer when taking ownership of passed value 2021-02-20 13:26:37 +01:00
logging virJSONValueArrayAppend: Clear pointer when taking ownership of passed value 2021-02-20 13:26:37 +01:00
lxc Remove redundant variables/labels 2021-03-01 18:50:22 -05:00
network virJSONValueArrayAppend: Clear pointer when taking ownership of passed value 2021-02-20 13:26:37 +01:00
node_device virJSONValueArrayAppend: Clear pointer when taking ownership of passed value 2021-02-20 13:26:37 +01:00
nwfilter build: Remove unused 'conflicts' key from virt_daemon_unit 2021-02-10 09:30:41 -07:00
openvz openvz: convert VIR_FREE to g_free in other functions that free their arg 2021-02-12 12:10:38 -05:00
qemu qemu_tpm: Generate log file path among with storage path 2021-03-02 09:45:49 +01:00
remote Use g_steal_pointer where possible 2021-03-01 15:54:42 +01:00
rpc Use g_steal_pointer where possible 2021-03-01 15:54:42 +01:00
secret build: Remove unused 'conflicts' key from virt_daemon_unit 2021-02-10 09:30:41 -07:00
security dac, selinux: skip setting/restoring label for absent PCI devices 2021-03-01 12:25:33 -03:00
storage storageBackendProbeTarget: Don't fail if backing store can't be parsed 2021-03-01 15:44:20 +01:00
storage_file Replace virStringListJoin by g_strjoinv 2021-02-11 17:05:34 +01:00
test test_driver: replace VIR_FREE with g_free in all vir*Free() functions 2021-02-05 00:20:43 -05:00
util virpci.c: use virPCIDeviceAddressPtr in virPCIDeviceListDel() 2021-03-01 12:25:33 -03:00
vbox Use g_steal_pointer where possible 2021-03-01 15:54:42 +01:00
vmware vmware: convert VIR_FREE to g_free in other functions that free their arg 2021-02-12 12:10:38 -05:00
vmx vmx: replace VIR_FREE with g_free in all vir*Free() functions 2021-02-05 00:20:44 -05:00
vz Use g_autoptr instead of virNetDevIPRouteFree if possible 2021-03-01 18:50:22 -05:00
admin_protocol-structs
datatypes.c datatypes: replace VIR_FREE with g_free in all *Dispose() functions 2021-02-05 00:22:09 -05:00
datatypes.h datatypes.h: register AUTOPTR_CLEANUP_FUNC for virNodeDevicePtr 2021-02-17 15:47:47 -03:00
driver-hypervisor.h src: define virDomainGetMessages API 2021-02-12 09:19:12 +00:00
driver-interface.h
driver-network.h
driver-nodedev.h
driver-nwfilter.h
driver-secret.h
driver-state.h
driver-storage.h
driver-stream.h Use #pragma once in driver headers 2019-06-13 17:05:08 +02:00
driver.c log error if virConnectCacheOnceInit() fails 2021-02-02 00:27:27 -05:00
driver.h src: don't hide error in VIR_DRV_SUPPORTS_FEATURE 2021-01-06 17:10:10 +03:00
internal.h
libvirt_driver_modules.syms
libvirt_esx.syms
libvirt_internal.h
libvirt_libssh2.syms
libvirt_libssh.syms
libvirt_linux.syms
libvirt_lxc.syms
libvirt_openvz.syms
libvirt_private.syms virhostdev.c: add virHostdevIsPCIDevice() helper 2021-03-01 12:25:33 -03:00
libvirt_probes.d
libvirt_public.syms src: define virDomainGetMessages API 2021-02-12 09:19:12 +00:00
libvirt_qemu.syms
libvirt_remote.syms
libvirt_sasl.syms
libvirt_vmware.syms
libvirt_vmx.syms
libvirt-domain-checkpoint.c
libvirt-domain-snapshot.c api: Discourage use of VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE 2021-02-16 12:25:30 +01:00
libvirt-domain.c virDomainMigrateVersion3Full: Don't set 'cancelled' to the same value 2021-02-16 12:25:30 +01:00
libvirt-host.c src: adopt to VIR_DRV_SUPPORTS_FEATURE return -1 2021-01-06 17:10:01 +03:00
libvirt-interface.c
libvirt-lxc.c use more virStrcpy() and virStrcpyStatic() 2021-01-04 20:18:24 +01:00
libvirt-lxc.pc.in
libvirt-network.c libvirtd: replace straggler VIR_FREE with g_free in all vir*Free() functions 2021-02-05 00:20:45 -05:00
libvirt-nodedev.c virsh: nodedev: filter by AP Matrix capability 2020-12-09 14:03:05 +01:00
libvirt-nwfilter.c
libvirt-qemu.c
libvirt-qemu.pc.in
libvirt-secret.c
libvirt-storage.c
libvirt-stream.c
libvirt.c src: adopt to VIR_DRV_SUPPORTS_FEATURE return -1 2021-01-06 17:10:01 +03:00
libvirt.conf
libvirt.pc.in meson: remove '.libs' from all relevant paths 2020-08-03 09:27:00 +02:00
lock_protocol-structs
lxc_monitor_protocol-structs
lxc_protocol-structs
meson.build build: Remove unused 'conflicts' key from virt_daemon_unit 2021-02-10 09:30:41 -07:00
qemu_protocol-structs
README
remote_protocol-structs remote: add RPC support for the virDomainGetMessages API 2021-02-12 09:19:13 +00:00
virkeepaliveprotocol-structs
virnetprotocol-structs

       libvirt library code README
       ===========================

The directory provides the bulk of the libvirt codebase. Everything
except for the libvirtd daemon and client tools. The build uses a
large number of libtool convenience libraries - one for each child
directory, and then links them together for the final libvirt.so,
although some bits get linked directly to libvirtd daemon instead.

The files directly in this directory are supporting the public API
entry points & data structures.

There are two core shared modules to be aware of:

 * util/  - a collection of shared APIs that can be used by any
            code. This directory is always in the include path
            for all things built

 * conf/  - APIs for parsing / manipulating all the official XML
            files used by the public API. This directory is only
            in the include path for driver implementation modules

 * vmx/   - VMware VMX config handling (used by esx/ and vmware/)


Then there are the hypervisor implementations:

 * bhyve         - bhyve - The BSD Hypervisor
 * esx/          - VMware ESX and GSX support using vSphere API over SOAP
 * hyperv/       - Microsoft Hyper-V support using WinRM
 * lxc/          - Linux Native Containers
 * openvz/       - OpenVZ containers using cli tools
 * qemu/         - QEMU / KVM using qemu CLI/monitor
 * remote/       - Generic libvirt native RPC client
 * test/         - A "mock" driver for testing
 * vbox/         - Virtual Box using native API
 * vmware/       - VMware Workstation and Player using the vmrun tool
 * xen/          - Xen using hypercalls, XenD SEXPR & XenStore


Finally some secondary drivers that are shared for several HVs.
Currently these are used by LXC, OpenVZ, QEMU and Xen drivers.
The ESX, Hyper-V, Remote, Test & VirtualBox drivers all
implement the secondary drivers directly

 * cpu/          - CPU feature management
 * interface/    - Host network interface management
 * network/      - Virtual NAT networking
 * nwfilter/     - Network traffic filtering rules
 * node_device/  - Host device enumeration
 * secret/       - Secret management
 * security/     - Mandatory access control drivers
 * storage/      - Storage management drivers


Since both the hypervisor and secondary drivers can be built as
dlopen()able modules, it is *FORBIDDEN* to have build dependencies
between these directories. Drivers are only allowed to depend on
the public API, and the internal APIs in the util/ and conf/
directories