libvirt/src/bhyve
Andrea Bolognani 10a8997cbb conf: Don't default to raw format for loader/NVRAM
Due to the way the information is stored by the XML parser, we've
had this quirk where specifying any information about the loader
or NVRAM would implicitly set its format to raw. That is,

  <nvram>/path/to/guest_VARS.fd</nvram>

would effectively be interpreted as

  <nvram format='raw'>/path/to/guest_VARS.fd</nvram>

forcing the use of raw format firmware even when qcow2 format
would normally be preferred based on the ordering of firmware
descriptors. This behavior can be worked around in a number of
ways, but it's fairly unintuitive.

In order to remove this quirk, move the selection of the default
firmware format from the parser down to the individual drivers.

Most drivers only support raw firmware images, so they can
unconditionally set the format early and be done with it; the
QEMU driver, however, supports multiple formats and so in that
case we want this default to be applied as late as possible,
when we have already ruled out the possibility of using qcow2
formatted firmware images.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
2023-08-21 13:51:34 +02:00
..
bhyve_capabilities.c bhyve: refactor bhyveProbeCapsFromHelp 2021-12-13 18:20:45 +01:00
bhyve_capabilities.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
bhyve_command.c bhyve: Update format strings in translated messages 2023-04-01 11:40:32 +02:00
bhyve_command.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
bhyve_conf.c bhyve_driver: Use automatic mutex management 2022-02-11 11:04:07 +01:00
bhyve_conf.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
bhyve_device.c maint: fix "mixing declarations and code" errors 2022-11-09 18:22:47 +01:00
bhyve_device.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
bhyve_domain.c bhyve: Update format strings in translated messages 2023-04-01 11:40:32 +02:00
bhyve_domain.h bhyve: Store 'driver' in VM private data 2022-05-17 19:31:08 +02:00
bhyve_driver.c virStringParseVersion: Parse into 'unsigned long long' 2023-04-03 09:19:06 +02:00
bhyve_driver.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
bhyve_firmware.c conf: Don't default to raw format for loader/NVRAM 2023-08-21 13:51:34 +02:00
bhyve_firmware.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
bhyve_monitor.c bhyve: Update format strings in translated messages 2023-04-01 11:40:32 +02:00
bhyve_monitor.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
bhyve_parse_command.c bhyve: Update format strings in translated messages 2023-04-01 11:40:32 +02:00
bhyve_parse_command.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
bhyve_process.c bhyve: Update format strings in translated messages 2023-04-01 11:40:32 +02:00
bhyve_process.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
bhyve_utils.h bhyve: Use new connection close callbacks API 2023-01-06 15:30:09 +01:00
bhyve.conf bhyve: add config file support 2017-03-14 20:46:05 +04:00
libvirtd_bhyve.aug src: fix word spell typos 2020-07-09 10:01:41 +02:00
meson.build bhyve: add <os firmware='efi'> support 2021-03-20 07:53:45 +04:00
test_libvirtd_bhyve.aug.in build: use @CONFIG@ instead of ::CONFIG:: in augeas tests 2019-08-09 14:06:31 +01:00