mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-07-11 12:25:52 +00:00
d16e5b15ed
When using virDomainSnapshotCreateXML with the REDEFINE flag on multiple snapshot metadata XML descriptions, we require that a child cannot be redefined before its parent. Since libvirt already tracks a DAG, it is more convenient if we can ensure that virDomainListAllSnapshots() and friends have a way to return data in an order that we can directly reuse, rather than having to post-process the data ourselves to reconstruct the DAG. Add VIR_DOMAIN_SNAPSHOT_LIST_TOPOLOGICAL as our new guarantee (well, a guarantee at the time of the API call conclusion; there's always a possible TOCTTOU race where someone redefining snapshots in between the API results and the client actually using the list might render the list out-of-date). Four listing APIs are directly benefitted by the new flag; additionally, since we document that the older racy ListNames interfaces should be sized by using the same flags on their Num counterparts, the Num interfaces must document when they accept (and ignore) the flag. We could have supported the new flag just for the ListAll APIs (to discourage people from using the older racy Num/ListNames APIs), but it feels weird to special-case this flag value as being applicable to only a subset of the API while all other List-related flags are trivially applicable to all 6. Signed-off-by: Eric Blake <eblake@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> |
||
|---|---|---|
| .. | ||
| libvirt-admin.h | ||
| libvirt-common.h.in | ||
| libvirt-domain-snapshot.h | ||
| libvirt-domain.h | ||
| libvirt-event.h | ||
| libvirt-host.h | ||
| libvirt-interface.h | ||
| libvirt-lxc.h | ||
| libvirt-network.h | ||
| libvirt-nodedev.h | ||
| libvirt-nwfilter.h | ||
| libvirt-qemu.h | ||
| libvirt-secret.h | ||
| libvirt-storage.h | ||
| libvirt-stream.h | ||
| libvirt.h | ||
| Makefile.am | ||
| virterror.h | ||