mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-10-06 14:25:46 +00:00
2aa167cafd
Use of an 'int' to represent a 'bool' value is confusing. Just because dbus made the mistake of cementing their 4-byte wire format of dbus_bool_t into their API doesn't mean we have to repeat the mistake. With a little bit of finesse, we can guarantee that we provide a large-enough value to the DBus code, while still copying only the relevant one-byte bool to the client code, and isolate the rest of our code base from the DBus stupidity. * src/util/virdbus.c (GET_NEXT_VAL): Add parameter. (virDBusMessageIterDecode): Adjust all clients. * src/util/virpolkit.c (virPolkitCheckAuth): Use nicer type. * tests/virdbustest.c (testMessageSimple, testMessageStruct): Test new behavior. Signed-off-by: Eric Blake <eblake@redhat.com>
256 lines
8.0 KiB
C
256 lines
8.0 KiB
C
/*
|
|
* virpolkit.c: helpers for using polkit APIs
|
|
*
|
|
* Copyright (C) 2013, 2014 Red Hat, Inc.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#if WITH_POLKIT0
|
|
# include <polkit/polkit.h>
|
|
# include <polkit-dbus/polkit-dbus.h>
|
|
#endif
|
|
|
|
#include "virpolkit.h"
|
|
#include "vircommand.h"
|
|
#include "virerror.h"
|
|
#include "virlog.h"
|
|
#include "virstring.h"
|
|
#include "virprocess.h"
|
|
#include "viralloc.h"
|
|
#include "virdbus.h"
|
|
|
|
#define VIR_FROM_THIS VIR_FROM_POLKIT
|
|
|
|
VIR_LOG_INIT("util.polkit");
|
|
|
|
#if WITH_POLKIT1
|
|
/*
|
|
* virPolkitCheckAuth:
|
|
* @actionid: permission to check
|
|
* @pid: client process ID
|
|
* @startTime: process start time, or 0
|
|
* @uid: client process user ID
|
|
* @details: NULL terminated (key, value) pair list
|
|
* @allowInteraction: true if auth prompts are allowed
|
|
*
|
|
* Check if a client is authenticated with polkit
|
|
*
|
|
* Returns 0 on success, -1 on failure, -2 on auth denied
|
|
*/
|
|
int virPolkitCheckAuth(const char *actionid,
|
|
pid_t pid,
|
|
unsigned long long startTime,
|
|
uid_t uid,
|
|
const char **details,
|
|
bool allowInteraction)
|
|
{
|
|
DBusConnection *sysbus;
|
|
DBusMessage *reply = NULL;
|
|
char **retdetails = NULL;
|
|
size_t nretdetails = 0;
|
|
bool is_authorized;
|
|
bool is_challenge;
|
|
bool is_dismissed = false;
|
|
size_t i;
|
|
int ret = -1;
|
|
|
|
if (!(sysbus = virDBusGetSystemBus()))
|
|
goto cleanup;
|
|
|
|
VIR_INFO("Checking PID %lld running as %d",
|
|
(long long) pid, uid);
|
|
|
|
if (virDBusCallMethod(sysbus,
|
|
&reply,
|
|
NULL,
|
|
"org.freedesktop.PolicyKit1",
|
|
"/org/freedesktop/PolicyKit1/Authority",
|
|
"org.freedesktop.PolicyKit1.Authority",
|
|
"CheckAuthorization",
|
|
"(sa{sv})sa&{ss}us",
|
|
"unix-process",
|
|
3,
|
|
"pid", "u", (unsigned int)pid,
|
|
"start-time", "t", startTime,
|
|
"uid", "i", (int)uid,
|
|
actionid,
|
|
virStringListLen(details) / 2,
|
|
details,
|
|
allowInteraction,
|
|
"" /* cancellation ID */) < 0)
|
|
goto cleanup;
|
|
|
|
if (virDBusMessageRead(reply,
|
|
"(bba&{ss})",
|
|
&is_authorized,
|
|
&is_challenge,
|
|
&nretdetails,
|
|
&retdetails) < 0)
|
|
goto cleanup;
|
|
|
|
for (i = 0; i < (nretdetails / 2); i++) {
|
|
if (STREQ(retdetails[(i * 2)], "polkit.dismissed") &&
|
|
STREQ(retdetails[(i * 2) + 1], "true"))
|
|
is_dismissed = true;
|
|
}
|
|
|
|
VIR_DEBUG("is auth %d is challenge %d",
|
|
is_authorized, is_challenge);
|
|
|
|
if (is_authorized) {
|
|
ret = 0;
|
|
} else {
|
|
ret = -2;
|
|
if (is_dismissed)
|
|
virReportError(VIR_ERR_AUTH_CANCELLED, "%s",
|
|
_("user cancelled authentication process"));
|
|
else if (is_challenge)
|
|
virReportError(VIR_ERR_AUTH_FAILED, "%s",
|
|
_("no agent is available to authenticate"));
|
|
else
|
|
virReportError(VIR_ERR_AUTH_FAILED, "%s",
|
|
_("access denied by policy"));
|
|
}
|
|
|
|
cleanup:
|
|
virStringFreeListCount(retdetails, nretdetails);
|
|
return ret;
|
|
}
|
|
|
|
|
|
#elif WITH_POLKIT0
|
|
int virPolkitCheckAuth(const char *actionid,
|
|
pid_t pid,
|
|
unsigned long long startTime ATTRIBUTE_UNUSED,
|
|
uid_t uid,
|
|
const char **details,
|
|
bool allowInteraction ATTRIBUTE_UNUSED)
|
|
{
|
|
PolKitCaller *pkcaller = NULL;
|
|
PolKitAction *pkaction = NULL;
|
|
PolKitContext *pkcontext = NULL;
|
|
PolKitError *pkerr = NULL;
|
|
PolKitResult pkresult;
|
|
DBusError err;
|
|
DBusConnection *sysbus;
|
|
int ret = -1;
|
|
|
|
if (details) {
|
|
virReportError(VIR_ERR_AUTH_FAILED, "%s",
|
|
_("Details not supported with polkit v0"));
|
|
return -1;
|
|
}
|
|
|
|
if (!(sysbus = virDBusGetSystemBus()))
|
|
goto cleanup;
|
|
|
|
VIR_INFO("Checking PID %lld running as %d",
|
|
(long long) pid, uid);
|
|
dbus_error_init(&err);
|
|
if (!(pkcaller = polkit_caller_new_from_pid(sysbus,
|
|
pid, &err))) {
|
|
VIR_DEBUG("Failed to lookup policy kit caller: %s", err.message);
|
|
dbus_error_free(&err);
|
|
goto cleanup;
|
|
}
|
|
|
|
if (!(pkaction = polkit_action_new())) {
|
|
char ebuf[1024];
|
|
VIR_DEBUG("Failed to create polkit action %s",
|
|
virStrerror(errno, ebuf, sizeof(ebuf)));
|
|
goto cleanup;
|
|
}
|
|
polkit_action_set_action_id(pkaction, actionid);
|
|
|
|
if (!(pkcontext = polkit_context_new()) ||
|
|
!polkit_context_init(pkcontext, &pkerr)) {
|
|
char ebuf[1024];
|
|
VIR_DEBUG("Failed to create polkit context %s",
|
|
(pkerr ? polkit_error_get_error_message(pkerr)
|
|
: virStrerror(errno, ebuf, sizeof(ebuf))));
|
|
if (pkerr)
|
|
polkit_error_free(pkerr);
|
|
dbus_error_free(&err);
|
|
goto cleanup;
|
|
}
|
|
|
|
# if HAVE_POLKIT_CONTEXT_IS_CALLER_AUTHORIZED
|
|
pkresult = polkit_context_is_caller_authorized(pkcontext,
|
|
pkaction,
|
|
pkcaller,
|
|
0,
|
|
&pkerr);
|
|
if (pkerr && polkit_error_is_set(pkerr)) {
|
|
VIR_DEBUG("Policy kit failed to check authorization %d %s",
|
|
polkit_error_get_error_code(pkerr),
|
|
polkit_error_get_error_message(pkerr));
|
|
goto cleanup;
|
|
}
|
|
# else
|
|
pkresult = polkit_context_can_caller_do_action(pkcontext,
|
|
pkaction,
|
|
pkcaller);
|
|
# endif
|
|
if (pkresult != POLKIT_RESULT_YES) {
|
|
VIR_DEBUG("Policy kit denied action %s from pid %lld, uid %d, result: %s",
|
|
actionid, (long long) pid, uid,
|
|
polkit_result_to_string_representation(pkresult));
|
|
ret = -2;
|
|
goto cleanup;
|
|
}
|
|
|
|
VIR_DEBUG("Policy allowed action %s from pid %lld, uid %d",
|
|
actionid, (long long)pid, (int)uid);
|
|
|
|
ret = 0;
|
|
|
|
cleanup:
|
|
if (ret < 0) {
|
|
virResetLastError();
|
|
virReportError(VIR_ERR_AUTH_FAILED, "%s",
|
|
_("authentication failed"));
|
|
}
|
|
if (pkcontext)
|
|
polkit_context_unref(pkcontext);
|
|
if (pkcaller)
|
|
polkit_caller_unref(pkcaller);
|
|
if (pkaction)
|
|
polkit_action_unref(pkaction);
|
|
return ret;
|
|
}
|
|
|
|
|
|
#else /* ! WITH_POLKIT1 && ! WITH_POLKIT0 */
|
|
|
|
int virPolkitCheckAuth(const char *actionid ATTRIBUTE_UNUSED,
|
|
pid_t pid ATTRIBUTE_UNUSED,
|
|
unsigned long long startTime ATTRIBUTE_UNUSED,
|
|
uid_t uid ATTRIBUTE_UNUSED,
|
|
const char **details ATTRIBUTE_UNUSED,
|
|
bool allowInteraction ATTRIBUTE_UNUSED)
|
|
{
|
|
VIR_ERROR(_("Polkit auth attempted, even though polkit is not available"));
|
|
virReportError(VIR_ERR_AUTH_FAILED, "%s",
|
|
_("authentication failed"));
|
|
return -1;
|
|
}
|
|
|
|
|
|
#endif /* WITH_POLKIT1 */
|