mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-08-28 11:31:16 +00:00
For S390, the default console target type cannot be of type 'serial'. It is necessary to at least interpret the 'arch' attribute value of the os/type element to produce the correct default type. Therefore we need to extend the signature of defaultConsoleTargetType to account for architecture. As a consequence all the drivers supporting this capability function must be updated. Despite the amount of changed files, the only change in behavior is that for S390 the default console target type will be 'virtio'. N.B.: A more future-proof approach could be to to use hypervisor specific capabilities to determine the best possible console type. For instance one could add an opaque private data pointer to the virCaps structure (in case of QEMU to hold capsCache) which could then be passed to the defaultConsoleTargetType callback to determine the console target type. Seems to be however a bit overengineered for the use case... Signed-off-by: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
319 lines
8.3 KiB
C
319 lines
8.3 KiB
C
#include <config.h>
|
|
|
|
#ifdef WITH_VMX
|
|
|
|
# include <stdio.h>
|
|
# include <string.h>
|
|
# include <unistd.h>
|
|
|
|
# include "internal.h"
|
|
# include "memory.h"
|
|
# include "testutils.h"
|
|
# include "vmx/vmx.h"
|
|
|
|
static virCapsPtr caps;
|
|
static virVMXContext ctx;
|
|
|
|
static int testDefaultConsoleType(const char *ostype ATTRIBUTE_UNUSED,
|
|
const char *arch ATTRIBUTE_UNUSED)
|
|
{
|
|
return VIR_DOMAIN_CHR_CONSOLE_TARGET_TYPE_SERIAL;
|
|
}
|
|
|
|
static void
|
|
testCapsInit(void)
|
|
{
|
|
virCapsGuestPtr guest = NULL;
|
|
|
|
caps = virCapabilitiesNew("i686", 1, 1);
|
|
|
|
if (caps == NULL) {
|
|
return;
|
|
}
|
|
|
|
caps->defaultConsoleTargetType = testDefaultConsoleType;
|
|
|
|
virCapabilitiesSetMacPrefix(caps, (unsigned char[]){ 0x00, 0x0c, 0x29 });
|
|
virCapabilitiesAddHostMigrateTransport(caps, "esx");
|
|
|
|
caps->hasWideScsiBus = true;
|
|
|
|
/* i686 guest */
|
|
guest =
|
|
virCapabilitiesAddGuest(caps, "hvm", "i686", 32, NULL, NULL, 0, NULL);
|
|
|
|
if (guest == NULL) {
|
|
goto failure;
|
|
}
|
|
|
|
if (virCapabilitiesAddGuestDomain(guest, "vmware", NULL, NULL, 0,
|
|
NULL) == NULL) {
|
|
goto failure;
|
|
}
|
|
|
|
/* x86_64 guest */
|
|
guest =
|
|
virCapabilitiesAddGuest(caps, "hvm", "x86_64", 64, NULL, NULL, 0, NULL);
|
|
|
|
if (guest == NULL) {
|
|
goto failure;
|
|
}
|
|
|
|
if (virCapabilitiesAddGuestDomain(guest, "vmware", NULL, NULL, 0,
|
|
NULL) == NULL) {
|
|
goto failure;
|
|
}
|
|
|
|
return;
|
|
|
|
failure:
|
|
virCapabilitiesFree(caps);
|
|
caps = NULL;
|
|
}
|
|
|
|
static int
|
|
testCompareFiles(const char *xml, const char *vmx, int virtualHW_version)
|
|
{
|
|
int result = -1;
|
|
char *xmlData = NULL;
|
|
char *vmxData = NULL;
|
|
char *formatted = NULL;
|
|
virDomainDefPtr def = NULL;
|
|
|
|
if (virtTestLoadFile(xml, &xmlData) < 0) {
|
|
goto failure;
|
|
}
|
|
|
|
if (virtTestLoadFile(vmx, &vmxData) < 0) {
|
|
goto failure;
|
|
}
|
|
|
|
def = virDomainDefParseString(caps, xmlData, 1 << VIR_DOMAIN_VIRT_VMWARE,
|
|
VIR_DOMAIN_XML_INACTIVE);
|
|
|
|
if (def == NULL) {
|
|
goto failure;
|
|
}
|
|
|
|
formatted = virVMXFormatConfig(&ctx, caps, def, virtualHW_version);
|
|
|
|
if (formatted == NULL) {
|
|
goto failure;
|
|
}
|
|
|
|
if (STRNEQ(vmxData, formatted)) {
|
|
virtTestDifference(stderr, vmxData, formatted);
|
|
goto failure;
|
|
}
|
|
|
|
result = 0;
|
|
|
|
failure:
|
|
VIR_FREE(xmlData);
|
|
VIR_FREE(vmxData);
|
|
VIR_FREE(formatted);
|
|
virDomainDefFree(def);
|
|
|
|
return result;
|
|
}
|
|
|
|
struct testInfo {
|
|
const char *input;
|
|
const char *output;
|
|
int virtualHW_version;
|
|
};
|
|
|
|
static int
|
|
testCompareHelper(const void *data)
|
|
{
|
|
int result = -1;
|
|
const struct testInfo *info = data;
|
|
char *xml = NULL;
|
|
char *vmx = NULL;
|
|
|
|
if (virAsprintf(&xml, "%s/xml2vmxdata/xml2vmx-%s.xml", abs_srcdir,
|
|
info->input) < 0 ||
|
|
virAsprintf(&vmx, "%s/xml2vmxdata/xml2vmx-%s.vmx", abs_srcdir,
|
|
info->output) < 0) {
|
|
goto cleanup;
|
|
}
|
|
|
|
result = testCompareFiles(xml, vmx, info->virtualHW_version);
|
|
|
|
cleanup:
|
|
VIR_FREE(xml);
|
|
VIR_FREE(vmx);
|
|
|
|
return result;
|
|
}
|
|
|
|
static int
|
|
testAutodetectSCSIControllerModel(virDomainDiskDefPtr def ATTRIBUTE_UNUSED,
|
|
int *model, void *opaque ATTRIBUTE_UNUSED)
|
|
{
|
|
*model = VIR_DOMAIN_CONTROLLER_MODEL_SCSI_LSILOGIC;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static char *
|
|
testFormatVMXFileName(const char *src, void *opaque ATTRIBUTE_UNUSED)
|
|
{
|
|
bool success = false;
|
|
char *copyOfDatastorePath = NULL;
|
|
char *tmp = NULL;
|
|
char *saveptr = NULL;
|
|
char *datastoreName = NULL;
|
|
char *directoryAndFileName = NULL;
|
|
char *absolutePath = NULL;
|
|
|
|
if (STRPREFIX(src, "[")) {
|
|
/* Found potential datastore path */
|
|
copyOfDatastorePath = strdup(src);
|
|
|
|
if (copyOfDatastorePath == NULL) {
|
|
goto cleanup;
|
|
}
|
|
|
|
/* Expected format: '[<datastore>] <path>' where <path> is optional */
|
|
if ((tmp = STRSKIP(copyOfDatastorePath, "[")) == NULL || *tmp == ']' ||
|
|
(datastoreName = strtok_r(tmp, "]", &saveptr)) == NULL) {
|
|
goto cleanup;
|
|
}
|
|
|
|
directoryAndFileName = strtok_r(NULL, "", &saveptr);
|
|
|
|
if (directoryAndFileName == NULL) {
|
|
directoryAndFileName = (char *)"";
|
|
} else {
|
|
directoryAndFileName += strspn(directoryAndFileName, " ");
|
|
}
|
|
|
|
virAsprintf(&absolutePath, "/vmfs/volumes/%s/%s", datastoreName,
|
|
directoryAndFileName);
|
|
} else if (STRPREFIX(src, "/")) {
|
|
/* Found absolute path */
|
|
absolutePath = strdup(src);
|
|
} else {
|
|
/* Found relative path, this is not supported */
|
|
goto cleanup;
|
|
}
|
|
|
|
success = true;
|
|
|
|
cleanup:
|
|
if (! success) {
|
|
VIR_FREE(absolutePath);
|
|
}
|
|
|
|
VIR_FREE(copyOfDatastorePath);
|
|
|
|
return absolutePath;
|
|
}
|
|
|
|
static int
|
|
mymain(void)
|
|
{
|
|
int result = 0;
|
|
|
|
# define DO_TEST(_in, _out, _version) \
|
|
do { \
|
|
struct testInfo info = { _in, _out, _version }; \
|
|
virResetLastError(); \
|
|
if (virtTestRun("VMware XML-2-VMX "_in" -> "_out, 1, \
|
|
testCompareHelper, &info) < 0) { \
|
|
result = -1; \
|
|
} \
|
|
} while (0)
|
|
|
|
testCapsInit();
|
|
|
|
if (caps == NULL) {
|
|
return EXIT_FAILURE;
|
|
}
|
|
|
|
ctx.opaque = NULL;
|
|
ctx.parseFileName = NULL;
|
|
ctx.formatFileName = testFormatVMXFileName;
|
|
ctx.autodetectSCSIControllerModel = testAutodetectSCSIControllerModel;
|
|
|
|
DO_TEST("minimal", "minimal", 4);
|
|
DO_TEST("minimal-64bit", "minimal-64bit", 4);
|
|
|
|
DO_TEST("graphics-vnc", "graphics-vnc", 4);
|
|
|
|
DO_TEST("scsi-driver", "scsi-driver", 4);
|
|
DO_TEST("scsi-writethrough", "scsi-writethrough", 4);
|
|
|
|
DO_TEST("harddisk-scsi-file", "harddisk-scsi-file", 4);
|
|
DO_TEST("harddisk-ide-file", "harddisk-ide-file", 4);
|
|
|
|
DO_TEST("cdrom-scsi-file", "cdrom-scsi-file", 4);
|
|
DO_TEST("cdrom-scsi-device", "cdrom-scsi-device", 4);
|
|
DO_TEST("cdrom-ide-file", "cdrom-ide-file", 4);
|
|
DO_TEST("cdrom-ide-device", "cdrom-ide-device", 4);
|
|
|
|
DO_TEST("floppy-file", "floppy-file", 4);
|
|
DO_TEST("floppy-device", "floppy-device", 4);
|
|
|
|
DO_TEST("sharedfolder", "sharedfolder", 4);
|
|
|
|
DO_TEST("ethernet-e1000", "ethernet-e1000", 4);
|
|
DO_TEST("ethernet-vmxnet2", "ethernet-vmxnet2", 4);
|
|
|
|
DO_TEST("ethernet-custom", "ethernet-custom", 4);
|
|
DO_TEST("ethernet-bridged", "ethernet-bridged", 4);
|
|
DO_TEST("ethernet-nat", "ethernet-nat", 4);
|
|
|
|
DO_TEST("ethernet-generated", "ethernet-generated", 4);
|
|
DO_TEST("ethernet-static", "ethernet-static", 4);
|
|
DO_TEST("ethernet-vpx", "ethernet-vpx", 4);
|
|
DO_TEST("ethernet-other", "ethernet-other", 4);
|
|
|
|
DO_TEST("serial-file", "serial-file", 4);
|
|
DO_TEST("serial-device", "serial-device", 4);
|
|
DO_TEST("serial-pipe", "serial-pipe", 4);
|
|
DO_TEST("serial-network-server", "serial-network-server", 7);
|
|
DO_TEST("serial-network-client", "serial-network-client", 7);
|
|
|
|
DO_TEST("parallel-file", "parallel-file", 4);
|
|
DO_TEST("parallel-device", "parallel-device", 4);
|
|
|
|
DO_TEST("esx-in-the-wild-1", "esx-in-the-wild-1", 4);
|
|
DO_TEST("esx-in-the-wild-2", "esx-in-the-wild-2", 4);
|
|
DO_TEST("esx-in-the-wild-3", "esx-in-the-wild-3", 4);
|
|
DO_TEST("esx-in-the-wild-4", "esx-in-the-wild-4", 4);
|
|
DO_TEST("esx-in-the-wild-5", "esx-in-the-wild-5", 4);
|
|
DO_TEST("esx-in-the-wild-6", "esx-in-the-wild-6", 4);
|
|
|
|
DO_TEST("gsx-in-the-wild-1", "gsx-in-the-wild-1", 4);
|
|
DO_TEST("gsx-in-the-wild-2", "gsx-in-the-wild-2", 4);
|
|
DO_TEST("gsx-in-the-wild-3", "gsx-in-the-wild-3", 4);
|
|
DO_TEST("gsx-in-the-wild-4", "gsx-in-the-wild-4", 4);
|
|
|
|
DO_TEST("ws-in-the-wild-1", "ws-in-the-wild-1", 8);
|
|
DO_TEST("ws-in-the-wild-2", "ws-in-the-wild-2", 8);
|
|
|
|
DO_TEST("annotation", "annotation", 4);
|
|
|
|
DO_TEST("smbios", "smbios", 4);
|
|
|
|
DO_TEST("svga", "svga", 4);
|
|
|
|
virCapabilitiesFree(caps);
|
|
|
|
return result == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
|
|
}
|
|
|
|
VIRT_TEST_MAIN(mymain)
|
|
|
|
#else
|
|
# include "testutils.h"
|
|
|
|
int main(void)
|
|
{
|
|
return EXIT_AM_SKIP;
|
|
}
|
|
|
|
#endif /* WITH_VMX */
|