libvirt/src/remote
Daniel P. Berrangé 2b5f925112 remote: fix double free of migration params on error
The remote_*_args methods will generally borrow pointers
passed in the caller, so should not be freed.

On failure of the virTypedParamsSerialize method, however,
xdr_free was being called. This is presumably because it
was thought that the params may have been partially
serialized and need cleaning up. This is incorrect, as
virTypedParamsSerialize takes care to cleanup partially
serialized data. This xdr_free call would lead to free'ing
the borrowed cookie pointers, which would be a double free.

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2023-01-10 08:26:27 -05:00
..
libvirtd-admin.socket.in util: drop support for obsolete systemd in RHEL-7 2022-02-17 12:35:42 +00:00
libvirtd-ro.socket.in util: drop support for obsolete systemd in RHEL-7 2022-02-17 12:35:42 +00:00
libvirtd-tcp.socket.in util: drop support for obsolete systemd in RHEL-7 2022-02-17 12:35:42 +00:00
libvirtd-tls.socket.in util: drop support for obsolete systemd in RHEL-7 2022-02-17 12:35:42 +00:00
libvirtd.aug.in daemon: add tcp_min_ssf option 2021-11-04 17:02:56 +01:00
libvirtd.conf.in remote: conf: Mention that 'virtproxyd' doesn't require the '--listen' flag 2022-07-13 09:28:04 +02:00
libvirtd.confd configure: Provide OpenRC scripts for sub-daemons 2019-12-16 10:11:22 +01:00
libvirtd.init.in remote: Drop KRB5_KTNAME override 2020-04-03 11:51:00 +02:00
libvirtd.libxl.logrotate.in logging: ensure virtlogd rollover takes priority over logrotate 2019-07-12 12:44:59 +01:00
libvirtd.logrotate.in daemon: move logrotate files to src/remote/ 2018-02-22 12:26:57 +00:00
libvirtd.lxc.logrotate.in logging: ensure virtlogd rollover takes priority over logrotate 2019-07-12 12:44:59 +01:00
libvirtd.policy Do not generate polkit rules file 2018-03-14 12:46:26 +01:00
libvirtd.qemu.logrotate.in logging: ensure virtlogd rollover takes priority over logrotate 2019-07-12 12:44:59 +01:00
libvirtd.rules daemon: move misc libvirtd policy files to src/remote/ 2018-02-22 12:26:50 +00:00
libvirtd.sasl docs: stop mentioning insecure / broken SASL mechanisms 2021-03-17 09:31:57 +00:00
libvirtd.service.in Remove Before=libvirt-guests.service from other services 2022-10-27 17:39:19 +02:00
libvirtd.socket.in util: drop support for obsolete systemd in RHEL-7 2022-02-17 12:35:42 +00:00
libvirtd.sysctl daemon: move misc libvirtd policy files to src/remote/ 2018-02-22 12:26:50 +00:00
lxc_protocol.x Remove all Author(s): lines from source file headers 2018-12-13 16:08:38 +00:00
meson.build meson: Use dicts to initialize cfg_data objects 2022-04-01 15:33:19 +02:00
qemu_protocol.x lib: Introduce 'virDomainQemuMonitorCommandWithFiles' 2022-03-01 13:29:49 +01:00
remote_daemon_config.c remote: remove unnecessary return value and if branch 2022-09-07 11:53:33 +02:00
remote_daemon_config.h remote: remove unnecessary return value and if branch 2022-09-07 11:53:33 +02:00
remote_daemon_dispatch.c lib: Introduce virDomainFDAssociate API 2023-01-09 14:59:42 +01:00
remote_daemon_dispatch.h remote: Remove unused includes 2022-06-16 06:43:57 +02:00
remote_daemon_stream.c remote: fix misspelling in the documation of 'daemonCreateClientStream' 2023-01-06 10:20:27 +01:00
remote_daemon_stream.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
remote_daemon.c lib: Use the same style in the 'struct option' 2022-11-22 10:15:11 +01:00
remote_daemon.h remote: Remove unused includes 2022-06-16 06:43:57 +02:00
remote_driver.c remote: fix double free of migration params on error 2023-01-10 08:26:27 -05:00
remote_driver.h remote: warn on low SSF 2021-11-04 17:02:56 +01:00
remote_protocol.x lib: Introduce virDomainFDAssociate API 2023-01-09 14:59:42 +01:00
remote_sockets.c remote: fix null string specifier argument in remoteProbeSessionDriverFromBinary 2022-05-26 10:14:46 +02:00
remote_sockets.h remote: extract logic for probing for modular daemons 2021-06-18 16:19:42 +01:00
remote_ssh_helper.c syntax-check: sc_avoid_write: Don't use blanket file exceptions 2022-02-15 09:32:23 +01:00
test_libvirtd.aug.in daemon: add tcp_min_ssf option 2021-11-04 17:02:56 +01:00
virt-guest-shutdown.target Revert "remote: Add libvirtd dependency to virt-guest-shutdown.target" 2021-01-29 10:39:33 -07:00
virtproxyd.confd configure: Provide OpenRC scripts for sub-daemons 2019-12-16 10:11:22 +01:00
virtproxyd.init.in remote: Drop KRB5_KTNAME override 2020-04-03 11:51:00 +02:00
virtproxyd.service.in systemd: Use correct man page name in modular daemon service files 2022-02-01 13:20:11 +01:00