External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-22 12:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity
libvirt/tools
History
Peter Krempa 9223ebbc85 virsh: cmdBlockcopy: Fix generator of block copy disk XML 
In a recent commit I've attempted to rewrite the XML generator to use
virXMLFormatElement instead of manual steps. Unfortunately the commit
had multiple problems resulting in a garbled XML:

1) in certain cases the wrong buffer was used resulting in misplaced
   snippets
2) the child element buffer was improperly set up so sub-elements were
   not indented

This resulted in following XML being generated:

 $ virsh blockcopy cd vda /tmp/test.copy --raw --print-xml
 type='file''/tmp/test.copy'/>
 <driver type='raw'/>
 <disk>
 <source file=</disk>

To fix this we'll generate the '<source>' element in one go and use the
proper buffer for it and other places.

Fixes: 1cd95f858ab83f2baab0e35070d00766bb06ce3a
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2078274
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
2022-04-25 16:37:05 +02:00
..
bash-completion
meson: Use dicts to initialize cfg_data objects
2022-04-01 15:33:19 +02:00
nss
nss: Use shared_library() for nss_libvirt_lib
2021-12-13 14:17:56 +01:00
wireshark
wireshark: Fix dissector for quad types
2022-03-07 12:37:54 +01:00
libvirt_recover_xattrs.sh
tools: fix iterating over argv when recovering xattr
2021-11-30 10:45:35 +00:00
libvirt_win_icon_16x16.ico
…
libvirt_win_icon_32x32.ico
…
libvirt_win_icon_48x48.ico
…
libvirt_win_icon_64x64.ico
…
libvirt-guests.service.in
Make systemd unit ordering more robust
2022-02-22 13:35:47 +01:00
libvirt-guests.sh.in
libvirt-guests: Sync time for autostarted guests
2020-11-04 12:18:05 +01:00
meson.build
meson: Use dicts to initialize cfg_data objects
2022-04-01 15:33:19 +02:00
virsh_win_icon.rc
…
virsh-backup.c
virsh: Use 'virshCompletePathLocalExisting' for options reading local files
2021-09-17 09:40:46 +02:00
virsh-backup.h
backup: Implement virsh support for backup
2019-12-10 12:41:56 +01:00
virsh-checkpoint.c
virsh: Introduce virshCompleteEmpty and use it for places where we can't suggest anything
2021-09-17 09:40:46 +02:00
virsh-checkpoint.h
backup: Implement virsh support for checkpoints
2019-07-26 16:48:58 -05:00
virsh-completer-checkpoint.c
tools: virsh: use automatic cleanup for virDomainObj
2021-08-16 13:10:33 +02:00
virsh-completer-checkpoint.h
virsh-completer*.h: Use modern header style
2021-09-17 09:40:46 +02:00
virsh-completer-domain.c
virsh: Don't open code virshEnumComplete()
2022-03-15 13:36:58 +01:00
virsh-completer-domain.h
virsh: Move 'cmdEvent' and all of its machinery to virsh-domain-event.c
2022-03-03 11:06:56 +01:00
virsh-completer-host.c
virsh: Provide completer for CPU architectures
2022-04-04 16:30:44 +02:00
virsh-completer-host.h
virsh: Provide completer for CPU architectures
2022-04-04 16:30:44 +02:00
virsh-completer-interface.c
virsh: Add wrapper for virInterfaceFree
2021-10-06 09:23:25 +02:00
virsh-completer-interface.h
virsh-completer*.h: Use modern header style
2021-09-17 09:40:46 +02:00
virsh-completer-network.c
virsh: Introduce net-update --section completer
2022-01-19 16:48:33 +01:00
virsh-completer-network.h
virsh: Introduce net-update --section completer
2022-01-19 16:48:33 +01:00
virsh-completer-nodedev.c
virsh: Provide completer for PCI backend drivers
2022-04-04 16:30:48 +02:00
virsh-completer-nodedev.h
virsh: Provide completer for PCI backend drivers
2022-04-04 16:30:48 +02:00
virsh-completer-nwfilter.c
virsh: Add wrapper for virNWFilterFree
2021-10-06 09:27:03 +02:00
virsh-completer-nwfilter.h
virsh-completer*.h: Use modern header style
2021-09-17 09:40:46 +02:00
virsh-completer-pool.c
virsh: Don't open code virshEnumComplete()
2022-03-15 13:36:58 +01:00
virsh-completer-pool.h
virsh-completer*.h: Use modern header style
2021-09-17 09:40:46 +02:00
virsh-completer-secret.c
lib: Drop internal virXXXPtr typedefs
2021-04-13 17:00:38 +02:00
virsh-completer-secret.h
virsh-completer*.h: Use modern header style
2021-09-17 09:40:46 +02:00
virsh-completer-snapshot.c
tools: virsh: use automatic cleanup for virDomainObj
2021-08-16 13:10:33 +02:00
virsh-completer-snapshot.h
virsh-completer*.h: Use modern header style
2021-09-17 09:40:46 +02:00
virsh-completer-volume.c
virsh: Don't open code virshEnumComplete()
2022-03-15 13:36:58 +01:00
virsh-completer-volume.h
virsh: Provide completer for vol-wipe algorithms
2022-03-11 09:10:24 +01:00
virsh-completer.c
virsh: Introduce virshEnumComplete()
2022-03-15 13:36:56 +01:00
virsh-completer.h
virsh: Introduce virshEnumComplete()
2022-03-15 13:36:56 +01:00
virsh-console.c
syntax-check: sc_avoid_write: Don't use blanket file exceptions
2022-02-15 09:32:23 +01:00
virsh-console.h
tools: use #pragma once in headers
2019-06-19 17:12:34 +02:00
virsh-domain-event.c
virsh: fix event registration for single event
2022-04-11 17:03:49 +02:00
virsh-domain-event.h
virsh: Move 'cmdEvent' and all of its machinery to virsh-domain-event.c
2022-03-03 11:06:56 +01:00
virsh-domain-monitor.c
lib: Use g_clear_pointer() more
2022-02-08 08:42:07 +01:00
virsh-domain-monitor.h
virsh: Fix virshDomainInterfaceSourceCompleter
2020-01-07 16:12:55 +01:00
virsh-domain.c
virsh: cmdBlockcopy: Fix generator of block copy disk XML
2022-04-25 16:37:05 +02:00
virsh-domain.h
virsh: Add mode option to domdirtyrate-calc virsh api
2022-02-21 13:34:16 +01:00
virsh-edit.c
Use G_GNUC_FALLTHROUGH instead of ATTRIBUTE_FALLTHROUGH
2019-10-15 16:14:19 +02:00
virsh-host.c
virsh: Provide completer for CPU architectures
2022-04-04 16:30:44 +02:00
virsh-host.h
virsh-host: Avoid 'vir' prefix for locally declared VIR_ENUM* helpers
2021-07-23 09:59:12 +02:00
virsh-interface.c
lib: Use g_clear_pointer() more
2022-02-08 08:42:07 +01:00
virsh-interface.h
tools: use #pragma once in headers
2019-06-19 17:12:34 +02:00
virsh-network.c
lib: Use g_clear_pointer() more
2022-02-08 08:42:07 +01:00
virsh-network.h
virsh: Introduce net-update --section completer
2022-01-19 16:48:33 +01:00
virsh-nodedev.c
virsh: Remove any reference of KVM device assignment
2022-04-06 09:40:13 +02:00
virsh-nodedev.h
tools: s/Nodedev/NodeDevice/
2019-08-09 09:03:53 +02:00
virsh-nwfilter.c
lib: Use g_clear_pointer() more
2022-02-08 08:42:07 +01:00
virsh-nwfilter.h
tools: use #pragma once in headers
2019-06-19 17:12:34 +02:00
virsh-pool.c
lib: Use g_clear_pointer() more
2022-02-08 08:42:07 +01:00
virsh-pool.h
virsh-pool: Remove static from virshStoragePoolList{Free,Collect}
2021-06-16 10:32:33 +02:00
virsh-secret.c
lib: Use g_clear_pointer() more
2022-02-08 08:42:07 +01:00
virsh-secret.h
tools: remove unnecessary includes
2020-08-03 15:30:40 +02:00
virsh-snapshot.c
tools: snapshot: remove pointless checks
2022-04-07 12:02:31 +02:00
virsh-snapshot.h
tools: remove unnecessary includes
2020-08-03 15:30:40 +02:00
virsh-util.c
virsh: Move 'virshDomainBlockJobToString' to virsh-util
2022-03-03 11:06:56 +01:00
virsh-util.h
virsh: Move 'virshDomainBlockJobToString' to virsh-util
2022-03-03 11:06:56 +01:00
virsh-volume.c
virsh: Provide completer for vol-wipe algorithms
2022-03-11 09:10:24 +01:00
virsh-volume.h
virsh: Provide completer for vol-wipe algorithms
2022-03-11 09:10:24 +01:00
virsh.c
virsh: Move 'cmdEvent' and all of its machinery to virsh-domain-event.c
2022-03-03 11:06:56 +01:00
virsh.h
virsh: Move 'cmdEvent' and all of its machinery to virsh-domain-event.c
2022-03-03 11:06:56 +01:00
virt-admin-completer.c
lib: Drop internal virXXXPtr typedefs
2021-04-13 17:00:38 +02:00
virt-admin-completer.h
tools: use #pragma once in headers
2019-06-19 17:12:34 +02:00
virt-admin.c
tools: Use automatic mutex management
2022-02-11 16:03:29 +01:00
virt-admin.h
lib: Drop internal virXXXPtr typedefs
2021-04-13 17:00:38 +02:00
virt-host-validate-bhyve.c
virt-host-validate-bhyve.c: Reintroduce @ret to virHostValidateBhyve()
2020-05-05 14:45:58 +02:00
virt-host-validate-bhyve.h
tools: use #pragma once in headers
2019-06-19 17:12:34 +02:00
virt-host-validate-ch.c
tools: virt-host-validate: fix memory leak
2021-11-23 16:59:36 +01:00
virt-host-validate-ch.h
tools: add virt-host-validate-ch for ch driver
2021-10-12 17:28:35 +02:00
virt-host-validate-common.c
virParseVersionString: rename to virStringParseVersion
2022-02-03 14:10:03 +01:00
virt-host-validate-common.h
tools: only fail validations if VIR_HOST_VALIDATE_FAIL is set
2021-06-08 08:52:07 +02:00
virt-host-validate-lxc.c
virt-host-validate: require freezer for LXC
2018-10-05 15:53:29 +02:00
virt-host-validate-lxc.h
tools: use #pragma once in headers
2019-06-19 17:12:34 +02:00
virt-host-validate-qemu.c
virt-host-validate-qemu: Use automatic memory freeing for virBitmap
2021-12-10 16:37:42 +01:00
virt-host-validate-qemu.h
tools: use #pragma once in headers
2019-06-19 17:12:34 +02:00
virt-host-validate.c
tools: add virt-host-validate-ch for ch driver
2021-10-12 17:28:35 +02:00
virt-login-shell-helper.c
Prefer g_auto(GStrv) over g_strfreev()
2021-11-11 16:16:17 +01:00
virt-login-shell.c
build: generate configmake.h in root directory
2020-01-29 14:51:39 +00:00
virt-login-shell.conf
virt-login-shell: add ability to auto-detect shell from container
2016-06-10 11:03:02 +01:00
virt-pki-query-dn.c
tools: Add virt-pki-query-dn binary
2021-11-12 12:37:29 +01:00
virt-pki-validate.in
Correct links to TLS certificate setup page
2022-04-25 16:33:01 +02:00
virt-sanlock-cleanup.in
build: Extract pod from source files
2016-04-25 15:40:43 +02:00
virt-xml-validate.in
tools: fix XML validator detection of network port XML schema
2019-09-12 16:06:57 +01:00
vsh-table.c
vsh-table: Hide vshTableRow typedef
2021-12-17 15:05:49 +01:00
vsh-table.h
vsh-table: Ensure NULL terminated arguments to vshTable*()
2021-12-17 15:05:58 +01:00
vsh.c
virsh: fflush(stdout) after fputs()
2022-03-10 08:57:31 +01:00
vsh.h
vsh: Add helper for auto-removing temporary file
2022-03-03 11:06:56 +01:00