mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2025-02-08 04:31:33 +00:00
Our virSecret XML is still parsed and formatted using old way (e.g. virXPathString() + virXXXTypeFromString() combo, or formatting elements using plain virBufferAsprintf() instead of virXMLFormatElement()). Modernize the code as it'll make it easier for future expansion. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
263 lines
7.7 KiB
C
263 lines
7.7 KiB
C
/*
|
|
* secret_conf.c: internal <secret> XML handling
|
|
*
|
|
* Copyright (C) 2009-2014, 2016 Red Hat, Inc.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#include "internal.h"
|
|
#include "virbuffer.h"
|
|
#include "virlog.h"
|
|
#include "secret_conf.h"
|
|
#include "virerror.h"
|
|
#include "virsecret.h"
|
|
#include "virstring.h"
|
|
#include "virxml.h"
|
|
#include "viruuid.h"
|
|
|
|
#define VIR_FROM_THIS VIR_FROM_SECRET
|
|
|
|
VIR_LOG_INIT("conf.secret_conf");
|
|
|
|
void
|
|
virSecretDefFree(virSecretDef *def)
|
|
{
|
|
if (def == NULL)
|
|
return;
|
|
|
|
g_free(def->description);
|
|
g_free(def->usage_id);
|
|
g_free(def);
|
|
}
|
|
|
|
static int
|
|
virSecretDefParseUsage(xmlXPathContextPtr ctxt,
|
|
virSecretDef *def)
|
|
{
|
|
xmlNodePtr node = NULL;
|
|
VIR_XPATH_NODE_AUTORESTORE(ctxt)
|
|
|
|
if (!(node = virXPathNode("./usage", ctxt)))
|
|
return 0;
|
|
|
|
ctxt->node = node;
|
|
|
|
if (virXMLPropEnum(node, "type",
|
|
virSecretUsageTypeFromString,
|
|
VIR_XML_PROP_REQUIRED,
|
|
&def->usage_type) < 0) {
|
|
return -1;
|
|
}
|
|
|
|
switch (def->usage_type) {
|
|
case VIR_SECRET_USAGE_TYPE_NONE:
|
|
break;
|
|
|
|
case VIR_SECRET_USAGE_TYPE_VOLUME:
|
|
def->usage_id = virXPathString("string(./volume)", ctxt);
|
|
if (!def->usage_id) {
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
_("volume usage specified, but volume path is missing"));
|
|
return -1;
|
|
}
|
|
break;
|
|
|
|
case VIR_SECRET_USAGE_TYPE_CEPH:
|
|
def->usage_id = virXPathString("string(./name)", ctxt);
|
|
if (!def->usage_id) {
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
_("Ceph usage specified, but name is missing"));
|
|
return -1;
|
|
}
|
|
break;
|
|
|
|
case VIR_SECRET_USAGE_TYPE_ISCSI:
|
|
def->usage_id = virXPathString("string(./target)", ctxt);
|
|
if (!def->usage_id) {
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
_("iSCSI usage specified, but target is missing"));
|
|
return -1;
|
|
}
|
|
break;
|
|
|
|
case VIR_SECRET_USAGE_TYPE_TLS:
|
|
def->usage_id = virXPathString("string(./name)", ctxt);
|
|
if (!def->usage_id) {
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
_("TLS usage specified, but name is missing"));
|
|
return -1;
|
|
}
|
|
break;
|
|
|
|
case VIR_SECRET_USAGE_TYPE_VTPM:
|
|
def->usage_id = virXPathString("string(./name)", ctxt);
|
|
if (!def->usage_id) {
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
_("vTPM usage specified, but name is missing"));
|
|
return -1;
|
|
}
|
|
break;
|
|
|
|
case VIR_SECRET_USAGE_TYPE_LAST:
|
|
default:
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
_("unexpected secret usage type %1$d"),
|
|
def->usage_type);
|
|
return -1;
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
|
|
static virSecretDef *
|
|
virSecretParseXML(xmlXPathContext *ctxt)
|
|
{
|
|
g_autoptr(virSecretDef) def = NULL;
|
|
g_autofree char *ephemeralstr = NULL;
|
|
g_autofree char *privatestr = NULL;
|
|
g_autofree char *uuidstr = NULL;
|
|
|
|
def = g_new0(virSecretDef, 1);
|
|
|
|
if ((ephemeralstr = virXPathString("string(./@ephemeral)", ctxt))) {
|
|
if (virStringParseYesNo(ephemeralstr, &def->isephemeral) < 0) {
|
|
virReportError(VIR_ERR_XML_ERROR, "%s",
|
|
_("invalid value of 'ephemeral'"));
|
|
return NULL;
|
|
}
|
|
}
|
|
|
|
if ((privatestr = virXPathString("string(./@private)", ctxt))) {
|
|
if (virStringParseYesNo(privatestr, &def->isprivate) < 0) {
|
|
virReportError(VIR_ERR_XML_ERROR, "%s",
|
|
_("invalid value of 'private'"));
|
|
return NULL;
|
|
}
|
|
}
|
|
|
|
uuidstr = virXPathString("string(./uuid)", ctxt);
|
|
if (!uuidstr) {
|
|
if (virUUIDGenerate(def->uuid) < 0) {
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
"%s", _("Failed to generate UUID"));
|
|
return NULL;
|
|
}
|
|
} else {
|
|
if (virUUIDParse(uuidstr, def->uuid) < 0) {
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
"%s", _("malformed uuid element"));
|
|
return NULL;
|
|
}
|
|
}
|
|
|
|
def->description = virXPathString("string(./description)", ctxt);
|
|
|
|
if (virSecretDefParseUsage(ctxt, def) < 0)
|
|
return NULL;
|
|
|
|
return g_steal_pointer(&def);
|
|
}
|
|
|
|
|
|
virSecretDef *
|
|
virSecretDefParse(const char *xmlStr,
|
|
const char *filename,
|
|
unsigned int flags)
|
|
{
|
|
g_autoptr(xmlDoc) xml = NULL;
|
|
g_autoptr(xmlXPathContext) ctxt = NULL;
|
|
bool validate = flags & VIR_SECRET_DEFINE_VALIDATE;
|
|
|
|
if (!(xml = virXMLParse(filename, xmlStr, _("(definition_of_secret)"),
|
|
"secret", &ctxt, "secret.rng", validate)))
|
|
return NULL;
|
|
|
|
return virSecretParseXML(ctxt);
|
|
}
|
|
|
|
|
|
static int
|
|
virSecretDefFormatUsage(virBuffer *buf,
|
|
const virSecretDef *def)
|
|
{
|
|
g_auto(virBuffer) attrBuf = VIR_BUFFER_INITIALIZER;
|
|
g_auto(virBuffer) childBuf = VIR_BUFFER_INIT_CHILD(buf);
|
|
|
|
virBufferAsprintf(&attrBuf, " type='%s'",
|
|
virSecretUsageTypeToString(def->usage_type));
|
|
|
|
switch (def->usage_type) {
|
|
case VIR_SECRET_USAGE_TYPE_NONE:
|
|
break;
|
|
|
|
case VIR_SECRET_USAGE_TYPE_VOLUME:
|
|
virBufferEscapeString(&childBuf, "<volume>%s</volume>\n", def->usage_id);
|
|
break;
|
|
|
|
case VIR_SECRET_USAGE_TYPE_CEPH:
|
|
virBufferEscapeString(&childBuf, "<name>%s</name>\n", def->usage_id);
|
|
break;
|
|
|
|
case VIR_SECRET_USAGE_TYPE_ISCSI:
|
|
virBufferEscapeString(&childBuf, "<target>%s</target>\n", def->usage_id);
|
|
break;
|
|
|
|
case VIR_SECRET_USAGE_TYPE_TLS:
|
|
virBufferEscapeString(&childBuf, "<name>%s</name>\n", def->usage_id);
|
|
break;
|
|
|
|
case VIR_SECRET_USAGE_TYPE_VTPM:
|
|
virBufferEscapeString(&childBuf, "<name>%s</name>\n", def->usage_id);
|
|
break;
|
|
|
|
default:
|
|
case VIR_SECRET_USAGE_TYPE_LAST:
|
|
virReportEnumRangeError(virSecretUsageType, def->usage_type);
|
|
return -1;
|
|
}
|
|
|
|
virXMLFormatElement(buf, "usage", &attrBuf, &childBuf);
|
|
|
|
return 0;
|
|
}
|
|
|
|
char *
|
|
virSecretDefFormat(const virSecretDef *def)
|
|
{
|
|
g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
|
|
g_auto(virBuffer) attrBuf = VIR_BUFFER_INITIALIZER;
|
|
g_auto(virBuffer) childBuf = VIR_BUFFER_INIT_CHILD(&buf);
|
|
char uuidstr[VIR_UUID_STRING_BUFLEN];
|
|
|
|
virBufferAsprintf(&attrBuf, " ephemeral='%s' private='%s'",
|
|
def->isephemeral ? "yes" : "no",
|
|
def->isprivate ? "yes" : "no");
|
|
|
|
virUUIDFormat(def->uuid, uuidstr);
|
|
virBufferEscapeString(&childBuf, "<uuid>%s</uuid>\n", uuidstr);
|
|
if (def->description != NULL)
|
|
virBufferEscapeString(&childBuf, "<description>%s</description>\n",
|
|
def->description);
|
|
if (def->usage_type != VIR_SECRET_USAGE_TYPE_NONE &&
|
|
virSecretDefFormatUsage(&childBuf, def) < 0)
|
|
return NULL;
|
|
|
|
virXMLFormatElement(&buf, "secret", &attrBuf, &childBuf);
|
|
return virBufferContentAndReset(&buf);
|
|
}
|