mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-29 17:15:23 +00:00
aaea56dc99
Coverity warns if the majority of callers check a function for errors, but a few don't; but in qemu_audit and qemu_domain, the choice to not check for failures was safe. In qemu_command, the failure to generate a uuid can only occur on a bad pointer. * src/qemu/qemu_audit.c (qemuAuditCgroup): Ignore failure to get cgroup controller. * src/qemu/qemu_domain.c (qemuDomainObjEnterMonitor) (qemuDomainObjEnterMonitorWithDriver): Ignore failure to get timestamp. * src/qemu/qemu_command.c (qemuParseCommandLine): Check for error.
954 lines
27 KiB
C
954 lines
27 KiB
C
/*
|
|
* qemu_domain.h: QEMU domain private state
|
|
*
|
|
* Copyright (C) 2006-2011 Red Hat, Inc.
|
|
* Copyright (C) 2006 Daniel P. Berrange
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*
|
|
* Author: Daniel P. Berrange <berrange@redhat.com>
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#include "qemu_domain.h"
|
|
#include "qemu_command.h"
|
|
#include "qemu_capabilities.h"
|
|
#include "memory.h"
|
|
#include "logging.h"
|
|
#include "virterror_internal.h"
|
|
#include "c-ctype.h"
|
|
#include "cpu/cpu.h"
|
|
#include "ignore-value.h"
|
|
#include "uuid.h"
|
|
#include "files.h"
|
|
|
|
#include <sys/time.h>
|
|
#include <fcntl.h>
|
|
|
|
#include <libxml/xpathInternals.h>
|
|
|
|
#define VIR_FROM_THIS VIR_FROM_QEMU
|
|
|
|
#define QEMU_NAMESPACE_HREF "http://libvirt.org/schemas/domain/qemu/1.0"
|
|
|
|
|
|
static void qemuDomainEventDispatchFunc(virConnectPtr conn,
|
|
virDomainEventPtr event,
|
|
virConnectDomainEventGenericCallback cb,
|
|
void *cbopaque,
|
|
void *opaque)
|
|
{
|
|
struct qemud_driver *driver = opaque;
|
|
|
|
/* Drop the lock whle dispatching, for sake of re-entrancy */
|
|
qemuDriverUnlock(driver);
|
|
virDomainEventDispatchDefaultFunc(conn, event, cb, cbopaque, NULL);
|
|
qemuDriverLock(driver);
|
|
}
|
|
|
|
void qemuDomainEventFlush(int timer ATTRIBUTE_UNUSED, void *opaque)
|
|
{
|
|
struct qemud_driver *driver = opaque;
|
|
|
|
qemuDriverLock(driver);
|
|
virDomainEventStateFlush(driver->domainEventState,
|
|
qemuDomainEventDispatchFunc,
|
|
driver);
|
|
qemuDriverUnlock(driver);
|
|
}
|
|
|
|
|
|
/* driver must be locked before calling */
|
|
void qemuDomainEventQueue(struct qemud_driver *driver,
|
|
virDomainEventPtr event)
|
|
{
|
|
virDomainEventStateQueue(driver->domainEventState, event);
|
|
}
|
|
|
|
|
|
static void *qemuDomainObjPrivateAlloc(void)
|
|
{
|
|
qemuDomainObjPrivatePtr priv;
|
|
|
|
if (VIR_ALLOC(priv) < 0)
|
|
return NULL;
|
|
|
|
if (virCondInit(&priv->jobCond) < 0)
|
|
goto initfail;
|
|
|
|
if (virCondInit(&priv->signalCond) < 0) {
|
|
ignore_value(virCondDestroy(&priv->jobCond));
|
|
goto initfail;
|
|
}
|
|
|
|
return priv;
|
|
|
|
initfail:
|
|
VIR_FREE(priv);
|
|
return NULL;
|
|
}
|
|
|
|
static void qemuDomainObjPrivateFree(void *data)
|
|
{
|
|
qemuDomainObjPrivatePtr priv = data;
|
|
|
|
qemuCapsFree(priv->qemuCaps);
|
|
|
|
qemuDomainPCIAddressSetFree(priv->pciaddrs);
|
|
virDomainChrSourceDefFree(priv->monConfig);
|
|
VIR_FREE(priv->vcpupids);
|
|
ignore_value(virCondDestroy(&priv->jobCond));
|
|
ignore_value(virCondDestroy(&priv->signalCond));
|
|
VIR_FREE(priv->lockState);
|
|
|
|
/* This should never be non-NULL if we get here, but just in case... */
|
|
if (priv->mon) {
|
|
VIR_ERROR(_("Unexpected QEMU monitor still active during domain deletion"));
|
|
qemuMonitorClose(priv->mon);
|
|
}
|
|
VIR_FREE(priv);
|
|
}
|
|
|
|
|
|
static int qemuDomainObjPrivateXMLFormat(virBufferPtr buf, void *data)
|
|
{
|
|
qemuDomainObjPrivatePtr priv = data;
|
|
const char *monitorpath;
|
|
|
|
/* priv->monitor_chr is set only for qemu */
|
|
if (priv->monConfig) {
|
|
switch (priv->monConfig->type) {
|
|
case VIR_DOMAIN_CHR_TYPE_UNIX:
|
|
monitorpath = priv->monConfig->data.nix.path;
|
|
break;
|
|
default:
|
|
case VIR_DOMAIN_CHR_TYPE_PTY:
|
|
monitorpath = priv->monConfig->data.file.path;
|
|
break;
|
|
}
|
|
|
|
virBufferEscapeString(buf, " <monitor path='%s'", monitorpath);
|
|
if (priv->monJSON)
|
|
virBufferAddLit(buf, " json='1'");
|
|
virBufferAsprintf(buf, " type='%s'/>\n",
|
|
virDomainChrTypeToString(priv->monConfig->type));
|
|
}
|
|
|
|
|
|
if (priv->nvcpupids) {
|
|
int i;
|
|
virBufferAddLit(buf, " <vcpus>\n");
|
|
for (i = 0 ; i < priv->nvcpupids ; i++) {
|
|
virBufferAsprintf(buf, " <vcpu pid='%d'/>\n", priv->vcpupids[i]);
|
|
}
|
|
virBufferAddLit(buf, " </vcpus>\n");
|
|
}
|
|
|
|
if (priv->qemuCaps) {
|
|
int i;
|
|
virBufferAddLit(buf, " <qemuCaps>\n");
|
|
for (i = 0 ; i < QEMU_CAPS_LAST ; i++) {
|
|
if (qemuCapsGet(priv->qemuCaps, i)) {
|
|
virBufferAsprintf(buf, " <flag name='%s'/>\n",
|
|
qemuCapsTypeToString(i));
|
|
}
|
|
}
|
|
virBufferAddLit(buf, " </qemuCaps>\n");
|
|
}
|
|
|
|
if (priv->lockState)
|
|
virBufferAsprintf(buf, " <lockstate>%s</lockstate>\n", priv->lockState);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int qemuDomainObjPrivateXMLParse(xmlXPathContextPtr ctxt, void *data)
|
|
{
|
|
qemuDomainObjPrivatePtr priv = data;
|
|
char *monitorpath;
|
|
char *tmp;
|
|
int n, i;
|
|
xmlNodePtr *nodes = NULL;
|
|
virBitmapPtr qemuCaps = NULL;
|
|
|
|
if (VIR_ALLOC(priv->monConfig) < 0) {
|
|
virReportOOMError();
|
|
goto error;
|
|
}
|
|
|
|
if (!(monitorpath =
|
|
virXPathString("string(./monitor[1]/@path)", ctxt))) {
|
|
qemuReportError(VIR_ERR_INTERNAL_ERROR,
|
|
"%s", _("no monitor path"));
|
|
goto error;
|
|
}
|
|
|
|
tmp = virXPathString("string(./monitor[1]/@type)", ctxt);
|
|
if (tmp)
|
|
priv->monConfig->type = virDomainChrTypeFromString(tmp);
|
|
else
|
|
priv->monConfig->type = VIR_DOMAIN_CHR_TYPE_PTY;
|
|
VIR_FREE(tmp);
|
|
|
|
if (virXPathBoolean("count(./monitor[@json = '1']) > 0", ctxt)) {
|
|
priv->monJSON = 1;
|
|
} else {
|
|
priv->monJSON = 0;
|
|
}
|
|
|
|
switch (priv->monConfig->type) {
|
|
case VIR_DOMAIN_CHR_TYPE_PTY:
|
|
priv->monConfig->data.file.path = monitorpath;
|
|
break;
|
|
case VIR_DOMAIN_CHR_TYPE_UNIX:
|
|
priv->monConfig->data.nix.path = monitorpath;
|
|
break;
|
|
default:
|
|
VIR_FREE(monitorpath);
|
|
qemuReportError(VIR_ERR_INTERNAL_ERROR,
|
|
_("unsupported monitor type '%s'"),
|
|
virDomainChrTypeToString(priv->monConfig->type));
|
|
goto error;
|
|
}
|
|
|
|
n = virXPathNodeSet("./vcpus/vcpu", ctxt, &nodes);
|
|
if (n < 0)
|
|
goto error;
|
|
if (n) {
|
|
priv->nvcpupids = n;
|
|
if (VIR_REALLOC_N(priv->vcpupids, priv->nvcpupids) < 0) {
|
|
virReportOOMError();
|
|
goto error;
|
|
}
|
|
|
|
for (i = 0 ; i < n ; i++) {
|
|
char *pidstr = virXMLPropString(nodes[i], "pid");
|
|
if (!pidstr)
|
|
goto error;
|
|
|
|
if (virStrToLong_i(pidstr, NULL, 10, &(priv->vcpupids[i])) < 0) {
|
|
VIR_FREE(pidstr);
|
|
goto error;
|
|
}
|
|
VIR_FREE(pidstr);
|
|
}
|
|
VIR_FREE(nodes);
|
|
}
|
|
|
|
if ((n = virXPathNodeSet("./qemuCaps/flag", ctxt, &nodes)) < 0) {
|
|
qemuReportError(VIR_ERR_INTERNAL_ERROR,
|
|
"%s", _("failed to parse qemu capabilities flags"));
|
|
goto error;
|
|
}
|
|
if (n > 0) {
|
|
if (!(qemuCaps = qemuCapsNew()))
|
|
goto error;
|
|
|
|
for (i = 0 ; i < n ; i++) {
|
|
char *str = virXMLPropString(nodes[i], "name");
|
|
if (str) {
|
|
int flag = qemuCapsTypeFromString(str);
|
|
if (flag < 0) {
|
|
qemuReportError(VIR_ERR_INTERNAL_ERROR,
|
|
_("Unknown qemu capabilities flag %s"), str);
|
|
VIR_FREE(str);
|
|
goto error;
|
|
}
|
|
VIR_FREE(str);
|
|
qemuCapsSet(qemuCaps, flag);
|
|
}
|
|
}
|
|
|
|
priv->qemuCaps = qemuCaps;
|
|
}
|
|
VIR_FREE(nodes);
|
|
|
|
priv->lockState = virXPathString("string(./lockstate)", ctxt);
|
|
|
|
return 0;
|
|
|
|
error:
|
|
virDomainChrSourceDefFree(priv->monConfig);
|
|
priv->monConfig = NULL;
|
|
VIR_FREE(nodes);
|
|
qemuCapsFree(qemuCaps);
|
|
return -1;
|
|
}
|
|
|
|
|
|
static void
|
|
qemuDomainDefNamespaceFree(void *nsdata)
|
|
{
|
|
qemuDomainCmdlineDefPtr cmd = nsdata;
|
|
unsigned int i;
|
|
|
|
if (!cmd)
|
|
return;
|
|
|
|
for (i = 0; i < cmd->num_args; i++)
|
|
VIR_FREE(cmd->args[i]);
|
|
for (i = 0; i < cmd->num_env; i++) {
|
|
VIR_FREE(cmd->env_name[i]);
|
|
VIR_FREE(cmd->env_value[i]);
|
|
}
|
|
VIR_FREE(cmd->args);
|
|
VIR_FREE(cmd->env_name);
|
|
VIR_FREE(cmd->env_value);
|
|
VIR_FREE(cmd);
|
|
}
|
|
|
|
static int
|
|
qemuDomainDefNamespaceParse(xmlDocPtr xml,
|
|
xmlNodePtr root,
|
|
xmlXPathContextPtr ctxt,
|
|
void **data)
|
|
{
|
|
qemuDomainCmdlineDefPtr cmd = NULL;
|
|
xmlNsPtr ns;
|
|
xmlNodePtr *nodes = NULL;
|
|
int n, i;
|
|
|
|
ns = xmlSearchNs(xml, root, BAD_CAST "qemu");
|
|
if (!ns)
|
|
/* this is fine; it just means there was no qemu namespace listed */
|
|
return 0;
|
|
|
|
if (STRNEQ((const char *)ns->href, QEMU_NAMESPACE_HREF)) {
|
|
qemuReportError(VIR_ERR_INTERNAL_ERROR,
|
|
_("Found namespace '%s' doesn't match expected '%s'"),
|
|
ns->href, QEMU_NAMESPACE_HREF);
|
|
return -1;
|
|
}
|
|
|
|
if (xmlXPathRegisterNs(ctxt, ns->prefix, ns->href) < 0) {
|
|
qemuReportError(VIR_ERR_INTERNAL_ERROR,
|
|
_("Failed to register xml namespace '%s'"), ns->href);
|
|
return -1;
|
|
}
|
|
|
|
if (VIR_ALLOC(cmd) < 0) {
|
|
virReportOOMError();
|
|
return -1;
|
|
}
|
|
|
|
/* first handle the extra command-line arguments */
|
|
n = virXPathNodeSet("./qemu:commandline/qemu:arg", ctxt, &nodes);
|
|
if (n < 0)
|
|
goto error;
|
|
|
|
if (n && VIR_ALLOC_N(cmd->args, n) < 0)
|
|
goto no_memory;
|
|
|
|
for (i = 0; i < n; i++) {
|
|
cmd->args[cmd->num_args] = virXMLPropString(nodes[i], "value");
|
|
if (cmd->args[cmd->num_args] == NULL) {
|
|
qemuReportError(VIR_ERR_INTERNAL_ERROR,
|
|
"%s", _("No qemu command-line argument specified"));
|
|
goto error;
|
|
}
|
|
cmd->num_args++;
|
|
}
|
|
|
|
VIR_FREE(nodes);
|
|
|
|
/* now handle the extra environment variables */
|
|
n = virXPathNodeSet("./qemu:commandline/qemu:env", ctxt, &nodes);
|
|
if (n < 0)
|
|
goto error;
|
|
|
|
if (n && VIR_ALLOC_N(cmd->env_name, n) < 0)
|
|
goto no_memory;
|
|
|
|
if (n && VIR_ALLOC_N(cmd->env_value, n) < 0)
|
|
goto no_memory;
|
|
|
|
for (i = 0; i < n; i++) {
|
|
char *tmp;
|
|
|
|
tmp = virXMLPropString(nodes[i], "name");
|
|
if (tmp == NULL) {
|
|
qemuReportError(VIR_ERR_INTERNAL_ERROR,
|
|
"%s", _("No qemu environment name specified"));
|
|
goto error;
|
|
}
|
|
if (tmp[0] == '\0') {
|
|
qemuReportError(VIR_ERR_INTERNAL_ERROR,
|
|
"%s", _("Empty qemu environment name specified"));
|
|
goto error;
|
|
}
|
|
if (!c_isalpha(tmp[0]) && tmp[0] != '_') {
|
|
qemuReportError(VIR_ERR_INTERNAL_ERROR,
|
|
"%s", _("Invalid environment name, it must begin with a letter or underscore"));
|
|
goto error;
|
|
}
|
|
if (strspn(tmp, "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789_") != strlen(tmp)) {
|
|
qemuReportError(VIR_ERR_INTERNAL_ERROR,
|
|
"%s", _("Invalid environment name, it must contain only alphanumerics and underscore"));
|
|
goto error;
|
|
}
|
|
|
|
cmd->env_name[cmd->num_env] = tmp;
|
|
|
|
cmd->env_value[cmd->num_env] = virXMLPropString(nodes[i], "value");
|
|
/* a NULL value for command is allowed, since it might be empty */
|
|
cmd->num_env++;
|
|
}
|
|
|
|
VIR_FREE(nodes);
|
|
|
|
*data = cmd;
|
|
|
|
return 0;
|
|
|
|
no_memory:
|
|
virReportOOMError();
|
|
|
|
error:
|
|
VIR_FREE(nodes);
|
|
qemuDomainDefNamespaceFree(cmd);
|
|
return -1;
|
|
}
|
|
|
|
static int
|
|
qemuDomainDefNamespaceFormatXML(virBufferPtr buf,
|
|
void *nsdata)
|
|
{
|
|
qemuDomainCmdlineDefPtr cmd = nsdata;
|
|
unsigned int i;
|
|
|
|
if (!cmd->num_args && !cmd->num_env)
|
|
return 0;
|
|
|
|
virBufferAddLit(buf, " <qemu:commandline>\n");
|
|
for (i = 0; i < cmd->num_args; i++)
|
|
virBufferEscapeString(buf, " <qemu:arg value='%s'/>\n",
|
|
cmd->args[i]);
|
|
for (i = 0; i < cmd->num_env; i++) {
|
|
virBufferAsprintf(buf, " <qemu:env name='%s'", cmd->env_name[i]);
|
|
if (cmd->env_value[i])
|
|
virBufferEscapeString(buf, " value='%s'", cmd->env_value[i]);
|
|
virBufferAddLit(buf, "/>\n");
|
|
}
|
|
virBufferAddLit(buf, " </qemu:commandline>\n");
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const char *
|
|
qemuDomainDefNamespaceHref(void)
|
|
{
|
|
return "xmlns:qemu='" QEMU_NAMESPACE_HREF "'";
|
|
}
|
|
|
|
|
|
void qemuDomainSetPrivateDataHooks(virCapsPtr caps)
|
|
{
|
|
/* Domain XML parser hooks */
|
|
caps->privateDataAllocFunc = qemuDomainObjPrivateAlloc;
|
|
caps->privateDataFreeFunc = qemuDomainObjPrivateFree;
|
|
caps->privateDataXMLFormat = qemuDomainObjPrivateXMLFormat;
|
|
caps->privateDataXMLParse = qemuDomainObjPrivateXMLParse;
|
|
|
|
}
|
|
|
|
void qemuDomainSetNamespaceHooks(virCapsPtr caps)
|
|
{
|
|
/* Domain Namespace XML parser hooks */
|
|
caps->ns.parse = qemuDomainDefNamespaceParse;
|
|
caps->ns.free = qemuDomainDefNamespaceFree;
|
|
caps->ns.format = qemuDomainDefNamespaceFormatXML;
|
|
caps->ns.href = qemuDomainDefNamespaceHref;
|
|
}
|
|
|
|
/*
|
|
* obj must be locked before calling, qemud_driver must NOT be locked
|
|
*
|
|
* This must be called by anything that will change the VM state
|
|
* in any way, or anything that will use the QEMU monitor.
|
|
*
|
|
* Upon successful return, the object will have its ref count increased,
|
|
* successful calls must be followed by EndJob eventually
|
|
*/
|
|
|
|
/* Give up waiting for mutex after 30 seconds */
|
|
#define QEMU_JOB_WAIT_TIME (1000ull * 30)
|
|
|
|
int qemuDomainObjBeginJob(virDomainObjPtr obj)
|
|
{
|
|
qemuDomainObjPrivatePtr priv = obj->privateData;
|
|
unsigned long long now;
|
|
unsigned long long then;
|
|
|
|
if (virTimeMs(&now) < 0)
|
|
return -1;
|
|
then = now + QEMU_JOB_WAIT_TIME;
|
|
|
|
virDomainObjRef(obj);
|
|
|
|
while (priv->jobActive) {
|
|
if (virCondWaitUntil(&priv->jobCond, &obj->lock, then) < 0) {
|
|
/* Safe to ignore value since ref count was incremented above */
|
|
ignore_value(virDomainObjUnref(obj));
|
|
if (errno == ETIMEDOUT)
|
|
qemuReportError(VIR_ERR_OPERATION_TIMEOUT,
|
|
"%s", _("cannot acquire state change lock"));
|
|
else
|
|
virReportSystemError(errno,
|
|
"%s", _("cannot acquire job mutex"));
|
|
return -1;
|
|
}
|
|
}
|
|
priv->jobActive = QEMU_JOB_UNSPECIFIED;
|
|
priv->jobSignals = 0;
|
|
memset(&priv->jobSignalsData, 0, sizeof(priv->jobSignalsData));
|
|
priv->jobStart = now;
|
|
memset(&priv->jobInfo, 0, sizeof(priv->jobInfo));
|
|
|
|
return 0;
|
|
}
|
|
|
|
/*
|
|
* obj must be locked before calling, qemud_driver must be locked
|
|
*
|
|
* This must be called by anything that will change the VM state
|
|
* in any way, or anything that will use the QEMU monitor.
|
|
*/
|
|
int qemuDomainObjBeginJobWithDriver(struct qemud_driver *driver,
|
|
virDomainObjPtr obj)
|
|
{
|
|
qemuDomainObjPrivatePtr priv = obj->privateData;
|
|
unsigned long long now;
|
|
unsigned long long then;
|
|
|
|
if (virTimeMs(&now) < 0)
|
|
return -1;
|
|
then = now + QEMU_JOB_WAIT_TIME;
|
|
|
|
virDomainObjRef(obj);
|
|
qemuDriverUnlock(driver);
|
|
|
|
while (priv->jobActive) {
|
|
if (virCondWaitUntil(&priv->jobCond, &obj->lock, then) < 0) {
|
|
if (errno == ETIMEDOUT)
|
|
qemuReportError(VIR_ERR_OPERATION_TIMEOUT,
|
|
"%s", _("cannot acquire state change lock"));
|
|
else
|
|
virReportSystemError(errno,
|
|
"%s", _("cannot acquire job mutex"));
|
|
virDomainObjUnlock(obj);
|
|
qemuDriverLock(driver);
|
|
virDomainObjLock(obj);
|
|
/* Safe to ignore value since ref count was incremented above */
|
|
ignore_value(virDomainObjUnref(obj));
|
|
return -1;
|
|
}
|
|
}
|
|
priv->jobActive = QEMU_JOB_UNSPECIFIED;
|
|
priv->jobSignals = 0;
|
|
memset(&priv->jobSignalsData, 0, sizeof(priv->jobSignalsData));
|
|
priv->jobStart = now;
|
|
memset(&priv->jobInfo, 0, sizeof(priv->jobInfo));
|
|
|
|
virDomainObjUnlock(obj);
|
|
qemuDriverLock(driver);
|
|
virDomainObjLock(obj);
|
|
|
|
return 0;
|
|
}
|
|
|
|
/*
|
|
* obj must be locked before calling, qemud_driver does not matter
|
|
*
|
|
* To be called after completing the work associated with the
|
|
* earlier qemuDomainBeginJob() call
|
|
*
|
|
* Returns remaining refcount on 'obj', maybe 0 to indicated it
|
|
* was deleted
|
|
*/
|
|
int qemuDomainObjEndJob(virDomainObjPtr obj)
|
|
{
|
|
qemuDomainObjPrivatePtr priv = obj->privateData;
|
|
|
|
priv->jobActive = QEMU_JOB_NONE;
|
|
priv->jobSignals = 0;
|
|
memset(&priv->jobSignalsData, 0, sizeof(priv->jobSignalsData));
|
|
priv->jobStart = 0;
|
|
memset(&priv->jobInfo, 0, sizeof(priv->jobInfo));
|
|
virCondSignal(&priv->jobCond);
|
|
|
|
return virDomainObjUnref(obj);
|
|
}
|
|
|
|
|
|
/*
|
|
* obj must be locked before calling, qemud_driver must be unlocked
|
|
*
|
|
* To be called immediately before any QEMU monitor API call
|
|
* Must have already called qemuDomainObjBeginJob(), and checked
|
|
* that the VM is still active.
|
|
*
|
|
* To be followed with qemuDomainObjExitMonitor() once complete
|
|
*/
|
|
void qemuDomainObjEnterMonitor(virDomainObjPtr obj)
|
|
{
|
|
qemuDomainObjPrivatePtr priv = obj->privateData;
|
|
|
|
qemuMonitorLock(priv->mon);
|
|
qemuMonitorRef(priv->mon);
|
|
ignore_value(virTimeMs(&priv->monStart));
|
|
virDomainObjUnlock(obj);
|
|
}
|
|
|
|
|
|
/* obj must NOT be locked before calling, qemud_driver must be unlocked
|
|
*
|
|
* Should be paired with an earlier qemuDomainObjEnterMonitor() call
|
|
*/
|
|
void qemuDomainObjExitMonitor(virDomainObjPtr obj)
|
|
{
|
|
qemuDomainObjPrivatePtr priv = obj->privateData;
|
|
int refs;
|
|
|
|
refs = qemuMonitorUnref(priv->mon);
|
|
|
|
if (refs > 0)
|
|
qemuMonitorUnlock(priv->mon);
|
|
|
|
virDomainObjLock(obj);
|
|
|
|
priv->monStart = 0;
|
|
if (refs == 0) {
|
|
priv->mon = NULL;
|
|
}
|
|
}
|
|
|
|
|
|
/*
|
|
* obj must be locked before calling, qemud_driver must be locked
|
|
*
|
|
* To be called immediately before any QEMU monitor API call
|
|
* Must have already called qemuDomainObjBeginJob().
|
|
*
|
|
* To be followed with qemuDomainObjExitMonitorWithDriver() once complete
|
|
*/
|
|
void qemuDomainObjEnterMonitorWithDriver(struct qemud_driver *driver,
|
|
virDomainObjPtr obj)
|
|
{
|
|
qemuDomainObjPrivatePtr priv = obj->privateData;
|
|
|
|
qemuMonitorLock(priv->mon);
|
|
qemuMonitorRef(priv->mon);
|
|
ignore_value(virTimeMs(&priv->monStart));
|
|
virDomainObjUnlock(obj);
|
|
qemuDriverUnlock(driver);
|
|
}
|
|
|
|
|
|
/* obj must NOT be locked before calling, qemud_driver must be unlocked,
|
|
* and will be locked after returning
|
|
*
|
|
* Should be paired with an earlier qemuDomainObjEnterMonitorWithDriver() call
|
|
*/
|
|
void qemuDomainObjExitMonitorWithDriver(struct qemud_driver *driver,
|
|
virDomainObjPtr obj)
|
|
{
|
|
qemuDomainObjPrivatePtr priv = obj->privateData;
|
|
int refs;
|
|
|
|
refs = qemuMonitorUnref(priv->mon);
|
|
|
|
if (refs > 0)
|
|
qemuMonitorUnlock(priv->mon);
|
|
|
|
qemuDriverLock(driver);
|
|
virDomainObjLock(obj);
|
|
|
|
priv->monStart = 0;
|
|
if (refs == 0) {
|
|
priv->mon = NULL;
|
|
}
|
|
}
|
|
|
|
void qemuDomainObjEnterRemoteWithDriver(struct qemud_driver *driver,
|
|
virDomainObjPtr obj)
|
|
{
|
|
virDomainObjRef(obj);
|
|
virDomainObjUnlock(obj);
|
|
qemuDriverUnlock(driver);
|
|
}
|
|
|
|
void qemuDomainObjExitRemoteWithDriver(struct qemud_driver *driver,
|
|
virDomainObjPtr obj)
|
|
{
|
|
qemuDriverLock(driver);
|
|
virDomainObjLock(obj);
|
|
/* Safe to ignore value, since we incremented ref in
|
|
* qemuDomainObjEnterRemoteWithDriver */
|
|
ignore_value(virDomainObjUnref(obj));
|
|
}
|
|
|
|
|
|
char *qemuDomainDefFormatXML(struct qemud_driver *driver,
|
|
virDomainDefPtr def,
|
|
int flags)
|
|
{
|
|
char *ret = NULL;
|
|
virCPUDefPtr cpu = NULL;
|
|
virCPUDefPtr def_cpu;
|
|
|
|
def_cpu = def->cpu;
|
|
|
|
/* Update guest CPU requirements according to host CPU */
|
|
if ((flags & VIR_DOMAIN_XML_UPDATE_CPU) && def_cpu && def_cpu->model) {
|
|
if (!driver->caps || !driver->caps->host.cpu) {
|
|
qemuReportError(VIR_ERR_OPERATION_FAILED,
|
|
"%s", _("cannot get host CPU capabilities"));
|
|
goto cleanup;
|
|
}
|
|
|
|
if (!(cpu = virCPUDefCopy(def_cpu))
|
|
|| cpuUpdate(cpu, driver->caps->host.cpu))
|
|
goto cleanup;
|
|
def->cpu = cpu;
|
|
}
|
|
|
|
ret = virDomainDefFormat(def, flags);
|
|
|
|
cleanup:
|
|
def->cpu = def_cpu;
|
|
virCPUDefFree(cpu);
|
|
return ret;
|
|
}
|
|
|
|
char *qemuDomainFormatXML(struct qemud_driver *driver,
|
|
virDomainObjPtr vm,
|
|
int flags)
|
|
{
|
|
virDomainDefPtr def;
|
|
|
|
if ((flags & VIR_DOMAIN_XML_INACTIVE) && vm->newDef)
|
|
def = vm->newDef;
|
|
else
|
|
def = vm->def;
|
|
|
|
return qemuDomainDefFormatXML(driver, def, flags);
|
|
}
|
|
|
|
|
|
void qemuDomainObjTaint(struct qemud_driver *driver,
|
|
virDomainObjPtr obj,
|
|
enum virDomainTaintFlags taint,
|
|
int logFD)
|
|
{
|
|
virErrorPtr orig_err = NULL;
|
|
|
|
if (virDomainObjTaint(obj, taint)) {
|
|
char uuidstr[VIR_UUID_STRING_BUFLEN];
|
|
virUUIDFormat(obj->def->uuid, uuidstr);
|
|
|
|
VIR_WARN("Domain id=%d name='%s' uuid=%s is tainted: %s",
|
|
obj->def->id,
|
|
obj->def->name,
|
|
uuidstr,
|
|
virDomainTaintTypeToString(taint));
|
|
|
|
/* We don't care about errors logging taint info, so
|
|
* preserve original error, and clear any error that
|
|
* is raised */
|
|
orig_err = virSaveLastError();
|
|
if (qemuDomainAppendLog(driver, obj, logFD,
|
|
"Domain id=%d is tainted: %s\n",
|
|
obj->def->id,
|
|
virDomainTaintTypeToString(taint)) < 0)
|
|
virResetLastError();
|
|
if (orig_err) {
|
|
virSetError(orig_err);
|
|
virFreeError(orig_err);
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
void qemuDomainObjCheckTaint(struct qemud_driver *driver,
|
|
virDomainObjPtr obj,
|
|
int logFD)
|
|
{
|
|
int i;
|
|
|
|
if (driver->privileged &&
|
|
(!driver->clearEmulatorCapabilities ||
|
|
driver->user == 0 ||
|
|
driver->group == 0))
|
|
qemuDomainObjTaint(driver, obj, VIR_DOMAIN_TAINT_HIGH_PRIVILEGES, logFD);
|
|
|
|
if (obj->def->namespaceData) {
|
|
qemuDomainCmdlineDefPtr qemucmd = obj->def->namespaceData;
|
|
if (qemucmd->num_args || qemucmd->num_env)
|
|
qemuDomainObjTaint(driver, obj, VIR_DOMAIN_TAINT_CUSTOM_ARGV, logFD);
|
|
}
|
|
|
|
for (i = 0 ; i < obj->def->ndisks ; i++)
|
|
qemuDomainObjCheckDiskTaint(driver, obj, obj->def->disks[i], logFD);
|
|
|
|
for (i = 0 ; i < obj->def->nnets ; i++)
|
|
qemuDomainObjCheckNetTaint(driver, obj, obj->def->nets[i], logFD);
|
|
}
|
|
|
|
|
|
void qemuDomainObjCheckDiskTaint(struct qemud_driver *driver,
|
|
virDomainObjPtr obj,
|
|
virDomainDiskDefPtr disk,
|
|
int logFD)
|
|
{
|
|
if (!disk->driverType &&
|
|
driver->allowDiskFormatProbing)
|
|
qemuDomainObjTaint(driver, obj, VIR_DOMAIN_TAINT_DISK_PROBING, logFD);
|
|
}
|
|
|
|
|
|
void qemuDomainObjCheckNetTaint(struct qemud_driver *driver,
|
|
virDomainObjPtr obj,
|
|
virDomainNetDefPtr net,
|
|
int logFD)
|
|
{
|
|
if ((net->type == VIR_DOMAIN_NET_TYPE_ETHERNET &&
|
|
net->data.ethernet.script != NULL) ||
|
|
(net->type == VIR_DOMAIN_NET_TYPE_BRIDGE &&
|
|
net->data.bridge.script != NULL))
|
|
qemuDomainObjTaint(driver, obj, VIR_DOMAIN_TAINT_SHELL_SCRIPTS, logFD);
|
|
}
|
|
|
|
|
|
static int
|
|
qemuDomainOpenLogHelper(struct qemud_driver *driver,
|
|
virDomainObjPtr vm,
|
|
int flags,
|
|
mode_t mode)
|
|
{
|
|
char *logfile;
|
|
int fd = -1;
|
|
|
|
if (virAsprintf(&logfile, "%s/%s.log", driver->logDir, vm->def->name) < 0) {
|
|
virReportOOMError();
|
|
return -1;
|
|
}
|
|
|
|
if ((fd = open(logfile, flags, mode)) < 0) {
|
|
virReportSystemError(errno, _("failed to create logfile %s"),
|
|
logfile);
|
|
goto cleanup;
|
|
}
|
|
if (virSetCloseExec(fd) < 0) {
|
|
virReportSystemError(errno, _("failed to set close-on-exec flag on %s"),
|
|
logfile);
|
|
VIR_FORCE_CLOSE(fd);
|
|
goto cleanup;
|
|
}
|
|
|
|
cleanup:
|
|
VIR_FREE(logfile);
|
|
return fd;
|
|
}
|
|
|
|
|
|
int
|
|
qemuDomainCreateLog(struct qemud_driver *driver, virDomainObjPtr vm, bool append)
|
|
{
|
|
int flags;
|
|
|
|
flags = O_CREAT | O_WRONLY;
|
|
/* Only logrotate files in /var/log, so only append if running privileged */
|
|
if (driver->privileged || append)
|
|
flags |= O_APPEND;
|
|
else
|
|
flags |= O_TRUNC;
|
|
|
|
return qemuDomainOpenLogHelper(driver, vm, flags, S_IRUSR | S_IWUSR);
|
|
}
|
|
|
|
|
|
int
|
|
qemuDomainOpenLog(struct qemud_driver *driver, virDomainObjPtr vm, off_t pos)
|
|
{
|
|
int fd;
|
|
off_t off;
|
|
int whence;
|
|
|
|
if ((fd = qemuDomainOpenLogHelper(driver, vm, O_RDONLY, 0)) < 0)
|
|
return -1;
|
|
|
|
if (pos < 0) {
|
|
off = 0;
|
|
whence = SEEK_END;
|
|
} else {
|
|
off = pos;
|
|
whence = SEEK_SET;
|
|
}
|
|
|
|
if (lseek(fd, off, whence) < 0) {
|
|
if (whence == SEEK_END)
|
|
virReportSystemError(errno,
|
|
_("unable to seek to end of log for %s"),
|
|
vm->def->name);
|
|
else
|
|
virReportSystemError(errno,
|
|
_("unable to seek to %lld from start for %s"),
|
|
(long long)off, vm->def->name);
|
|
VIR_FORCE_CLOSE(fd);
|
|
}
|
|
|
|
return fd;
|
|
}
|
|
|
|
|
|
int qemuDomainAppendLog(struct qemud_driver *driver,
|
|
virDomainObjPtr obj,
|
|
int logFD,
|
|
const char *fmt, ...)
|
|
{
|
|
int fd = logFD;
|
|
va_list argptr;
|
|
char *message = NULL;
|
|
int ret = -1;
|
|
|
|
va_start(argptr, fmt);
|
|
|
|
if ((fd == -1) &&
|
|
(fd = qemuDomainCreateLog(driver, obj, true)) < 0)
|
|
goto cleanup;
|
|
|
|
if (virVasprintf(&message, fmt, argptr) < 0) {
|
|
virReportOOMError();
|
|
goto cleanup;
|
|
}
|
|
if (safewrite(fd, message, strlen(message)) < 0) {
|
|
virReportSystemError(errno, _("Unable to write to domain logfile %s"),
|
|
obj->def->name);
|
|
goto cleanup;
|
|
}
|
|
|
|
ret = 0;
|
|
|
|
cleanup:
|
|
va_end(argptr);
|
|
|
|
if (fd != logFD)
|
|
VIR_FORCE_CLOSE(fd);
|
|
|
|
VIR_FREE(message);
|
|
return ret;
|
|
}
|