mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-10-09 15:55:47 +00:00
540c339a25
There is one problem that causes various errors in the daemon. When domain is waiting for a job, it is unlocked while waiting on the condition. However, if that domain is for example transient and being removed in another API (e.g. cancelling incoming migration), it get's unref'd. If the first call, that was waiting, fails to get the job, it unref's the domain object, and because it was the last reference, it causes clearing of the whole domain object. However, when finishing the call, the domain must be unlocked, but there is no way for the API to know whether it was cleaned or not (unless there is some ugly temporary variable, but let's scratch that). The root cause is that our APIs don't ref the objects they are using and all use the implicit reference that the object has when it is in the domain list. That reference can be removed when the API is waiting for a job. And because each domain doesn't do its ref'ing, it results in the ugly checking of the return value of virObjectUnref() that we have everywhere. This patch changes qemuDomObjFromDomain() to ref the domain (using virDomainObjListFindByUUIDRef()) and adds qemuDomObjEndAPI() which should be the only function in which the return value of virObjectUnref() is checked. This makes all reference counting deterministic and makes the code a bit clearer. Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
181 lines
7.4 KiB
C
181 lines
7.4 KiB
C
/*
|
|
* qemu_migration.h: QEMU migration handling
|
|
*
|
|
* Copyright (C) 2006-2011, 2014 Red Hat, Inc.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*
|
|
*/
|
|
|
|
#ifndef __QEMU_MIGRATION_H__
|
|
# define __QEMU_MIGRATION_H__
|
|
|
|
# include "qemu_conf.h"
|
|
# include "qemu_domain.h"
|
|
|
|
/* All supported qemu migration flags. */
|
|
# define QEMU_MIGRATION_FLAGS \
|
|
(VIR_MIGRATE_LIVE | \
|
|
VIR_MIGRATE_PEER2PEER | \
|
|
VIR_MIGRATE_TUNNELLED | \
|
|
VIR_MIGRATE_PERSIST_DEST | \
|
|
VIR_MIGRATE_UNDEFINE_SOURCE | \
|
|
VIR_MIGRATE_PAUSED | \
|
|
VIR_MIGRATE_NON_SHARED_DISK | \
|
|
VIR_MIGRATE_NON_SHARED_INC | \
|
|
VIR_MIGRATE_CHANGE_PROTECTION | \
|
|
VIR_MIGRATE_UNSAFE | \
|
|
VIR_MIGRATE_OFFLINE | \
|
|
VIR_MIGRATE_COMPRESSED | \
|
|
VIR_MIGRATE_ABORT_ON_ERROR | \
|
|
VIR_MIGRATE_AUTO_CONVERGE | \
|
|
VIR_MIGRATE_RDMA_PIN_ALL)
|
|
|
|
/* All supported migration parameters and their types. */
|
|
# define QEMU_MIGRATION_PARAMETERS \
|
|
VIR_MIGRATE_PARAM_URI, VIR_TYPED_PARAM_STRING, \
|
|
VIR_MIGRATE_PARAM_DEST_NAME, VIR_TYPED_PARAM_STRING, \
|
|
VIR_MIGRATE_PARAM_DEST_XML, VIR_TYPED_PARAM_STRING, \
|
|
VIR_MIGRATE_PARAM_BANDWIDTH, VIR_TYPED_PARAM_ULLONG, \
|
|
VIR_MIGRATE_PARAM_GRAPHICS_URI, VIR_TYPED_PARAM_STRING, \
|
|
VIR_MIGRATE_PARAM_LISTEN_ADDRESS, VIR_TYPED_PARAM_STRING, \
|
|
NULL
|
|
|
|
|
|
typedef enum {
|
|
QEMU_MIGRATION_PHASE_NONE = 0,
|
|
QEMU_MIGRATION_PHASE_PERFORM2,
|
|
QEMU_MIGRATION_PHASE_BEGIN3,
|
|
QEMU_MIGRATION_PHASE_PERFORM3,
|
|
QEMU_MIGRATION_PHASE_PERFORM3_DONE,
|
|
QEMU_MIGRATION_PHASE_CONFIRM3_CANCELLED,
|
|
QEMU_MIGRATION_PHASE_CONFIRM3,
|
|
QEMU_MIGRATION_PHASE_PREPARE,
|
|
QEMU_MIGRATION_PHASE_FINISH2,
|
|
QEMU_MIGRATION_PHASE_FINISH3,
|
|
|
|
QEMU_MIGRATION_PHASE_LAST
|
|
} qemuMigrationJobPhase;
|
|
VIR_ENUM_DECL(qemuMigrationJobPhase)
|
|
|
|
int qemuMigrationJobStart(virQEMUDriverPtr driver,
|
|
virDomainObjPtr vm,
|
|
qemuDomainAsyncJob job)
|
|
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_RETURN_CHECK;
|
|
void qemuMigrationJobSetPhase(virQEMUDriverPtr driver,
|
|
virDomainObjPtr vm,
|
|
qemuMigrationJobPhase phase)
|
|
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2);
|
|
void qemuMigrationJobStartPhase(virQEMUDriverPtr driver,
|
|
virDomainObjPtr vm,
|
|
qemuMigrationJobPhase phase)
|
|
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2);
|
|
void qemuMigrationJobContinue(virDomainObjPtr obj)
|
|
ATTRIBUTE_NONNULL(1);
|
|
bool qemuMigrationJobIsActive(virDomainObjPtr vm,
|
|
qemuDomainAsyncJob job)
|
|
ATTRIBUTE_NONNULL(1);
|
|
void qemuMigrationJobFinish(virQEMUDriverPtr driver, virDomainObjPtr obj)
|
|
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2);
|
|
|
|
int qemuMigrationSetOffline(virQEMUDriverPtr driver,
|
|
virDomainObjPtr vm);
|
|
|
|
char *qemuMigrationBegin(virConnectPtr conn,
|
|
virDomainObjPtr vm,
|
|
const char *xmlin,
|
|
const char *dname,
|
|
char **cookieout,
|
|
int *cookieoutlen,
|
|
unsigned long flags);
|
|
|
|
virDomainDefPtr qemuMigrationPrepareDef(virQEMUDriverPtr driver,
|
|
const char *dom_xml,
|
|
const char *dname,
|
|
char **origname);
|
|
|
|
int qemuMigrationPrepareTunnel(virQEMUDriverPtr driver,
|
|
virConnectPtr dconn,
|
|
const char *cookiein,
|
|
int cookieinlen,
|
|
char **cookieout,
|
|
int *cookieoutlen,
|
|
virStreamPtr st,
|
|
virDomainDefPtr *def,
|
|
const char *origname,
|
|
unsigned long flags);
|
|
|
|
int qemuMigrationPrepareDirect(virQEMUDriverPtr driver,
|
|
virConnectPtr dconn,
|
|
const char *cookiein,
|
|
int cookieinlen,
|
|
char **cookieout,
|
|
int *cookieoutlen,
|
|
const char *uri_in,
|
|
char **uri_out,
|
|
virDomainDefPtr *def,
|
|
const char *origname,
|
|
const char *listenAddress,
|
|
unsigned long flags);
|
|
|
|
int qemuMigrationPerform(virQEMUDriverPtr driver,
|
|
virConnectPtr conn,
|
|
virDomainObjPtr vm,
|
|
const char *xmlin,
|
|
const char *dconnuri,
|
|
const char *uri,
|
|
const char *graphicsuri,
|
|
const char *listenAddress,
|
|
const char *cookiein,
|
|
int cookieinlen,
|
|
char **cookieout,
|
|
int *cookieoutlen,
|
|
unsigned long flags,
|
|
const char *dname,
|
|
unsigned long resource,
|
|
bool v3proto);
|
|
|
|
virDomainPtr qemuMigrationFinish(virQEMUDriverPtr driver,
|
|
virConnectPtr dconn,
|
|
virDomainObjPtr vm,
|
|
const char *cookiein,
|
|
int cookieinlen,
|
|
char **cookieout,
|
|
int *cookieoutlen,
|
|
unsigned long flags,
|
|
int retcode,
|
|
bool v3proto);
|
|
|
|
int qemuMigrationConfirm(virConnectPtr conn,
|
|
virDomainObjPtr vm,
|
|
const char *cookiein,
|
|
int cookieinlen,
|
|
unsigned int flags,
|
|
int cancelled);
|
|
|
|
bool qemuMigrationIsAllowed(virQEMUDriverPtr driver, virDomainObjPtr vm,
|
|
virDomainDefPtr def, bool remote,
|
|
bool abort_on_error);
|
|
|
|
int qemuMigrationToFile(virQEMUDriverPtr driver, virDomainObjPtr vm,
|
|
int fd, off_t offset, const char *path,
|
|
const char *compressor,
|
|
bool bypassSecurityDriver,
|
|
qemuDomainAsyncJob asyncJob)
|
|
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(5)
|
|
ATTRIBUTE_RETURN_CHECK;
|
|
|
|
#endif /* __QEMU_MIGRATION_H__ */
|