libvirt

mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-01 14:52:31 +00:00

History

Ian Campbell cc99d240f5 libxl: avoid freeing an uninitialised bitmap

If vm->def->cputune.nvcpupin is 0 in libxlDomainSetVcpuAffinities (as
seems to be the case on arm) then the VIR_FREE after cleanup: would be
operating on an uninitialised pointer in map.map.

Fix this by using libxl_bitmap_init and libxl_bitmap_dispose in the
appropriate places (like VIR_FREE, libxl_bitmap_dispose is also
idempotent, so there is no double free on exit from the loop).

libxl_bitmap_dispose is slightly preferable since it also sets
map.size back to 0, avoiding a potential source of confusion.

This fixes the crashes we've been seeing in the Xen automated tests on
ARM.

I had a glance at the handful of other users of libxl_bitmap and none
of them looked to have a similar issue.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

2015-06-19 13:10:45 -06:00

libvirtd_libxl.aug

libxl: provide integration with lock manager

2015-04-29 10:51:36 -06:00

libxl_conf.c

libxl: Add timestamp to the libxl driver log.

2015-06-12 19:13:59 -06:00

libxl_conf.h

libxl: change reservedVNCPorts to reservedGraphicsPorts

2015-05-28 12:40:43 -06:00

libxl_domain.c

libxl: avoid freeing an uninitialised bitmap