libvirt/src
John Ferlan 33188c9fcb Perform disk config validity checking for attach-device config
https://bugzilla.redhat.com/show_bug.cgi?id=1078126

Using 'virsh attach-device --config' (or --persistent) to attach a
file backed lun device will succeed; however, subsequent domain restarts
will result in failure because the configuration of a file backed lun
is not supported.

Although allowing 'illegal configurations' is something that can be
allowed, it may not be practical in this case. Generally, when attaching
a device to a domain means the domain must be running. A way around
this is using the --config (or --persistent) option. When an attach
is done to a running domain, a temporary configuration is modified
first followed by the live update. The live update will make a number
of disk validity checks when building the qemu command to attach the
disk. If any fail, then change is rejected.

Rather than allow a potentially illegal combination, adjust the code
in the configuration path to make the same checks as the running path
will make with respect to disk validity checks. This way we avoid
having the potential for some subsequent start/reboot to fail because
an illegal combination was allowed.

NB: The live path still checks the configuration since it is possible
to just do --live guest modification...
2014-08-21 07:06:35 -04:00
..
access Introduce virDomain{Get,Set}Time APIs 2014-05-15 16:15:54 +02:00
bhyve bhyve: add volumes support 2014-08-19 20:50:22 +04:00
conf cleanup spaces between parentheses and braces 2014-08-20 14:50:21 +02:00
cpu Use virBufferCheckError everywhere we report OOM error 2014-07-03 10:48:14 +02:00
esx esx: Fix a comment about VSphere versions 2014-07-17 21:19:42 +02:00
hyperv Use virBufferCheckError everywhere we report OOM error 2014-07-03 10:48:14 +02:00
interface interface_backend_udev: Implement link speed & state 2014-06-11 09:57:45 +02:00
libxl hostdev: Introduce virDomainHostdevSubsysPCI 2014-07-24 06:39:27 -04:00
locking Fix const correctness 2014-07-16 12:07:24 +02:00
lxc cleanup spaces between parentheses and braces 2014-08-20 14:50:21 +02:00
network network: fix crash when starting a network with no <pf> element 2014-08-15 02:42:52 -04:00
node_device nodedev: fix pci express memory leak 2014-07-28 14:10:29 -06:00
nwfilter nwfilter: plug memory leak with firewall 2014-07-23 13:15:14 -06:00
openvz util: virstatslinux: make more generic 2014-07-15 22:00:59 +04:00
parallels domain: Introduce ./hugepages/page/[@size, @unit, @nodeset] 2014-07-29 12:02:34 +01:00
phyp virStoragePoolSourceAdapter: Refine the SCSI_HOST adapter name 2014-07-21 12:55:10 -04:00
qemu Perform disk config validity checking for attach-device config 2014-08-21 07:06:35 -04:00
remote Fix const correctness 2014-07-16 12:07:24 +02:00
rpc cleanup spaces between parentheses and braces 2014-08-20 14:50:21 +02:00
secret drivers: use virDirRead API 2014-04-28 17:52:45 -06:00
security cleanup spaces between parentheses and braces 2014-08-20 14:50:21 +02:00
storage storage: make disk source pool translation generic 2014-08-19 20:50:12 +04:00
test metadata: track title edits across libvirtd restart 2014-07-23 10:07:34 -06:00
uml support for QEMU vhost-user 2014-07-16 18:44:57 +02:00
util nodeCapsInitNUMA: Avoid @cpumap leak 2014-08-20 16:15:00 +02:00
vbox hvsupport: Adapt to vbox driver rewrite 2014-08-20 18:17:07 +02:00
vmware capabilities: use bool instead of int 2014-07-14 08:00:46 -06:00
vmx Use virBufferCheckError everywhere we report OOM error 2014-07-03 10:48:14 +02:00
xen cleanup spaces between parentheses and braces 2014-08-20 14:50:21 +02:00
xenapi maint: improve syntax check for space around = 2014-08-12 11:21:17 -06:00
xenconfig src/xenconfig: move common parsing/formatting to xen_common 2014-08-18 20:47:38 -06:00
check-aclperms.pl Fix naming of permission for detecting storage pools 2013-09-12 17:20:07 +01:00
check-aclrules.pl maint: fix line numbers in check-aclrules reports 2014-02-10 14:07:22 -07:00
check-driverimpls.pl
check-drivername.pl
check-symfile.pl
check-symsorting.pl
datatypes.c Indent top-level labels by one space in the rest of src/ 2014-03-25 14:58:40 +01:00
datatypes.h datatypes: Fix comment of secret uuid 2014-05-05 10:20:51 +02:00
driver.c Use virFileFindResource to locate driver plugins 2014-04-25 11:59:46 +01:00
driver.h driver: Move virDrvNetworkGetDHCPLeases to the appropriate section 2014-08-19 15:08:20 +02:00
dtrace2systemtap.pl
fdstream.c Use virFileFindResource to locate iohelper for fdstream 2014-04-25 11:59:46 +01:00
fdstream.h Use virFileFindResource to locate iohelper for fdstream 2014-04-25 11:59:46 +01:00
gnutls_1_0_compat.h
internal.h net-dhcp-leases: Add virsh support 2014-06-24 12:26:31 +01:00
libvirt_atomic.syms
libvirt_daemon.syms
libvirt_driver_modules.syms Use virFileFindResource to locate driver plugins 2014-04-25 11:59:46 +01:00
libvirt_esx.syms
libvirt_gnutls.syms
libvirt_internal.h event: server RPC protocol tweaks for domain lifecycle events 2014-02-12 10:48:15 -07:00
libvirt_libssh2.syms
libvirt_linux.syms util: virstatslinux: make more generic 2014-07-15 22:00:59 +04:00
libvirt_lxc.syms
libvirt_openvz.syms
libvirt_private.syms storage: Refresh storage pool after upload 2014-08-04 10:35:52 -04:00
libvirt_probes.d
libvirt_public.syms Introduce virConnectGetDomainCapabilities 2014-07-03 12:22:37 +02:00
libvirt_qemu_probes.d
libvirt_qemu.syms qemu: new API for tracking arbitrary monitor events 2014-03-20 11:25:37 -06:00
libvirt_remote.syms build: fix build --without-remote 2013-10-04 17:01:47 -06:00
libvirt_sasl.syms
libvirt_vmware.syms VMware: Make version parsing testable and add tests 2013-09-20 08:23:31 -05:00
libvirt_vmx.syms VMX: Create virVMXFormatDisk() from HD and CD-ROM 2013-09-01 23:11:50 -05:00
libvirt_xenconfig.syms xen: rename xenxs to xenconfig 2014-08-18 20:36:24 -06:00
libvirt-lxc.c Indent top-level labels by one space in the rest of src/ 2014-03-25 14:58:40 +01:00
libvirt-lxc.pc.in Add pkg-config files to allow deps to build against source tree 2014-06-23 16:17:55 +01:00
libvirt-qemu.c Indent top-level labels by one space in the rest of src/ 2014-03-25 14:58:40 +01:00
libvirt-qemu.pc.in Add pkg-config files to allow deps to build against source tree 2014-06-23 16:17:55 +01:00
libvirt.c cleanup spaces between parentheses and braces 2014-08-20 14:50:21 +02:00
libvirt.conf
libvirt.pc.in Add pkg-config files to allow deps to build against source tree 2014-06-23 16:17:55 +01:00
lock_protocol-structs tests: check remaining .x files 2013-09-09 12:04:03 -06:00
lxc_monitor_protocol-structs tests: check remaining .x files 2013-09-09 12:04:03 -06:00
lxc_protocol-structs
Makefile.am src/xenconfig: move common parsing/formatting to xen_common 2014-08-18 20:47:38 -06:00
nodeinfo.c nodeCapsInitNUMA: Avoid @cpumap leak 2014-08-20 16:15:00 +02:00
nodeinfo.h nodeinfo: Implement nodeGetFreePages 2014-06-19 15:10:50 +02:00
nodeinfopriv.h nodeinfo: Introduce @arch to linuxNodeInfoCPUPopulate 2014-06-20 15:46:52 +02:00
qemu_protocol-structs qemu: wire up RPC for qemu monitor events 2014-03-20 11:25:37 -06:00
README bhyve: add basic documentation 2014-03-01 23:44:58 +04:00
remote_protocol-structs Introduce virConnectGetDomainCapabilities 2014-07-03 12:22:37 +02:00
virkeepaliveprotocol-structs
virnetprotocol-structs

       libvirt library code README
       ===========================

The directory provides the bulk of the libvirt codebase. Everything
except for the libvirtd daemon and client tools. The build uses a
large number of libtool convenience libraries - one for each child
directory, and then links them together for the final libvirt.so,
although some bits get linked directly to libvirtd daemon instead.

The files directly in this directory are supporting the public API
entry points & data structures.

There are two core shared modules to be aware of:

 * util/  - a collection of shared APIs that can be used by any
            code. This directory is always in the include path
            for all things built

 * conf/  - APIs for parsing / manipulating all the official XML
            files used by the public API. This directory is only
            in the include path for driver implementation modules

 * vmx/   - VMware VMX config handling (used by esx/ and vmware/)


Then there are the hypervisor implementations:

 * bhyve         - bhyve - The BSD Hypervisor
 * esx/          - VMware ESX and GSX support using vSphere API over SOAP
 * hyperv/       - Microsoft Hyper-V support using WinRM
 * lxc/          - Linux Native Containers
 * openvz/       - OpenVZ containers using cli tools
 * phyp/         - IBM Power Hypervisor using CLI tools over SSH
 * qemu/         - QEMU / KVM using qemu CLI/monitor
 * remote/       - Generic libvirt native RPC client
 * test/         - A "mock" driver for testing
 * uml/          - User Mode Linux
 * vbox/         - Virtual Box using native API
 * vmware/       - VMware Workstation and Player using the vmrun tool
 * xen/          - Xen using hypercalls, XenD SEXPR & XenStore
 * xenapi/       - Xen using libxenserver


Finally some secondary drivers that are shared for several HVs.
Currently these are used by LXC, OpenVZ, QEMU, UML and Xen drivers.
The ESX, Hyper-V, Power Hypervisor, Remote, Test & VirtualBox drivers all
implement the secondary drivers directly

 * cpu/          - CPU feature management
 * interface/    - Host network interface management
 * network/      - Virtual NAT networking
 * nwfilter/     - Network traffic filtering rules
 * node_device/  - Host device enumeration
 * secret/       - Secret management
 * security/     - Mandatory access control drivers
 * storage/      - Storage management drivers


Since both the hypervisor and secondary drivers can be built as
dlopen()able modules, it is *FORBIDDEN* to have build dependencies
between these directories. Drivers are only allowed to depend on
the public API, and the internal APIs in the util/ and conf/
directories