libvirt/src
Eric Blake d95488dce5 security, storage: plug memory leaks for security_context_t
security_context_t happens to be a typedef for char*, and happens to
begin with a string usable as a raw context string.  But in reality,
it is an opaque type that may or may not have additional information
after the first NUL byte, where that additional information can
include pointers that can only be freed via freecon().

Proof is from this valgrind run of daemon/libvirtd:

==6028== 839,169 (40 direct, 839,129 indirect) bytes in 1 blocks are definitely lost in loss record 274 of 274
==6028==    at 0x4A0515D: malloc (vg_replace_malloc.c:195)
==6028==    by 0x3022E0D48C: selabel_open (label.c:165)
==6028==    by 0x3022E11646: matchpathcon_init_prefix (matchpathcon.c:296)
==6028==    by 0x3022E1190D: matchpathcon (matchpathcon.c:317)
==6028==    by 0x4F9D842: SELinuxRestoreSecurityFileLabel (security_selinux.c:382)

800k is a lot of memory to be leaking.

* src/storage/storage_backend.c
(virStorageBackendUpdateVolTargetInfoFD): Avoid leak on error.
* src/security/security_selinux.c
(SELinuxReserveSecurityLabel, SELinuxGetSecurityProcessLabel)
(SELinuxRestoreSecurityFileLabel): Use correct function to free
security_context_t.
2010-11-24 15:23:43 -07:00
..
conf network: plug memory leak 2010-11-24 15:23:43 -07:00
cpu maint: use gnulib configmake rather than open-coding things 2010-11-17 08:58:58 -07:00
esx Implementations of virDomainIsUpdated for drivers except qemu 2010-11-24 11:22:30 -07:00
interface Implement forgotten backend of virInterfaceIsActive() 2010-04-14 10:38:18 -04:00
lxc Implementations of virDomainIsUpdated for drivers except qemu 2010-11-24 11:22:30 -07:00
network maint: use gnulib configmake rather than open-coding things 2010-11-17 08:58:58 -07:00
node_device bye to close(), welcome to VIR_(FORCE_)CLOSE() 2010-11-09 15:48:48 -05:00
nwfilter nwfilter: re-order lock grabbed by IP addr. learn thread 2010-11-19 20:41:25 -05:00
opennebula Implementations of virDomainIsUpdated for drivers except qemu 2010-11-24 11:22:30 -07:00
openvz Implementations of virDomainIsUpdated for drivers except qemu 2010-11-24 11:22:30 -07:00
phyp Implementations of virDomainIsUpdated for drivers except qemu 2010-11-24 11:22:30 -07:00
qemu qemu: plug memory leak 2010-11-24 15:23:43 -07:00
remote implement the remote protocol 2010-11-23 15:04:42 -07:00
secret maint: use gnulib configmake rather than open-coding things 2010-11-17 08:58:58 -07:00
security security, storage: plug memory leaks for security_context_t 2010-11-24 15:23:43 -07:00
storage security, storage: plug memory leaks for security_context_t 2010-11-24 15:23:43 -07:00
test Implementations of virDomainIsUpdated for drivers except qemu 2010-11-24 11:22:30 -07:00
uml Implementations of virDomainIsUpdated for drivers except qemu 2010-11-24 11:22:30 -07:00
util build: enforce files.h usage 2010-11-24 15:23:43 -07:00
vbox Implementations of virDomainIsUpdated for drivers except qemu 2010-11-24 11:22:30 -07:00
xen Implementations of virDomainIsUpdated for drivers except qemu 2010-11-24 11:22:30 -07:00
xenapi Implementations of virDomainIsUpdated for drivers except qemu 2010-11-24 11:22:30 -07:00
.gitignore util: add missing export 2010-10-12 09:42:18 -06:00
datatypes.c Always close drivers when a virConnectPtr is released 2010-11-24 22:48:36 +01:00
datatypes.h Snapshot API framework. 2010-04-05 10:24:34 -04:00
driver.c maint: use gnulib configmake rather than open-coding things 2010-11-17 08:58:58 -07:00
driver.h define internal driver API 2010-11-23 15:04:41 -07:00
fdstream.c Add a generic internal API for handling any FD based stream 2010-11-11 16:02:57 +00:00
fdstream.h Add a generic internal API for handling any FD based stream 2010-11-11 16:02:57 +00:00
gnutls_1_0_compat.h build: consistently indent preprocessor directives 2010-03-09 19:22:28 +01:00
internal.h maint: improve i18n on non-Linux 2010-11-17 10:12:57 -07:00
libvirt_bridge.syms
libvirt_daemon.syms Export conditional state driver symbols only when they are defined 2010-03-23 02:05:18 +01:00
libvirt_driver_modules.syms
libvirt_internal.h build: consistently indent preprocessor directives 2010-03-09 19:22:28 +01:00
libvirt_linux.syms
libvirt_macvtap.syms macvtap teardown rework 2010-02-18 15:13:48 +01:00
libvirt_nwfilter.syms Some NWFilter symbols are conditional and have to be exported conditional 2010-04-23 19:51:00 +02:00
libvirt_private.syms maint: sort exports 2010-11-23 14:05:20 -07:00
libvirt_public.syms virDomainIsUpdated: define the new public API 2010-11-23 14:22:31 -07:00
libvirt_qemu.syms Qemu Monitor API entry point. 2010-07-23 17:30:14 -04:00
libvirt-qemu.c Qemu Monitor API entry point. 2010-07-23 17:30:14 -04:00
libvirt.c implement public API virDomainIsUpdated 2010-11-23 15:04:41 -07:00
Makefile.am maint: use gnulib configmake rather than open-coding things 2010-11-17 08:58:58 -07:00
nodeinfo.c deprecate fclose() and introduce VIR_{FORCE_}FCLOSE() 2010-11-16 21:13:29 -05:00
nodeinfo.h build: consistently indent preprocessor directives 2010-03-09 19:22:28 +01:00
README Add a README file to src/ explaining the directory structure 2009-09-21 14:41:47 +01:00
remote_protocol-structs implement the remote protocol 2010-11-23 15:04:42 -07:00

       libvirt library code README
       ===========================

The directory provides the bulk of the libvirt codebase. Everything
except for the libvirtd daemon and client tools. The build uses a
large number of libtool convenience libraries - one for each child
directory, and then links them together for the final libvirt.so,
although some bits get linked directly to libvirtd daemon instead.

The files directly in this directory are supporting the public API
entry points & data structures.

There are two core shared modules to be aware of:

 * util/  - a collection of shared APIs that can be used by any
            code. This directory is always in the include path
            for all things built

 * conf/  - APIs for parsing / manipulating all the official XML
            files used by the public API. This directory is only
            in the include path for driver implementation modules


Then there are the hypervisor implementations:

 * esx/          - VMware ESX and GSX support using vSphere API over SOAP
 * lxc/          - Linux Native Containers
 * opennebula/   - Open Nebula using XMLRPC
 * openvz/       - OpenVZ containers using cli tools
 * phyp/         - IBM Power Hypervisor using CLI tools over SSH
 * qemu/         - QEMU / KVM using qemu CLI/monitor
 * remote/       - Generic libvirt native RPC client
 * test/         - A "mock" driver for testing
 * uml/          - User Mode Linux
 * vbox/         - Virtual Box using native API
 * xen/          - Xen using hypercalls, XenD SEXPR & XenStore


Finally some secondary drivers that are shared for several HVs.
Currently these are used by LXC, OpenVZ, QEMU, UML and Xen drivers.
The ESX, OpenNebula, Power Hypervisor, Remote, Test & VirtualBox
drivers all implement the secondary drivers directly

 * interface/    - Host network interface management
 * network/      - Virtual NAT networking
 * node_device/  - Host device enumeration
 * secret/       - Secret management
 * security/     - Mandatory access control drivers
 * storage/      - Storage management drivers


Since both the hypervisor and secondary drivers can be built as
dlopen()able modules, it is *FORBIDDEN* to have build dependencies
between these directories. Drivers are only allowed to depend on
the public API, and the internal APIs in the util/ and conf/
directories