mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-08-28 11:31:16 +00:00
In many files there are header comments that contain an Author: statement, supposedly reflecting who originally wrote the code. In a large collaborative project like libvirt, any non-trivial file will have been modified by a large number of different contributors. IOW, the Author: comments are quickly out of date, omitting people who have made significant contribitions. In some places Author: lines have been added despite the person merely being responsible for creating the file by moving existing code out of another file. IOW, the Author: lines give an incorrect record of authorship. With this all in mind, the comments are useless as a means to identify who to talk to about code in a particular file. Contributors will always be better off using 'git log' and 'git blame' if they need to find the author of a particular bit of code. This commit thus deletes all Author: comments from the source and adds a rule to prevent them reappearing. The Copyright headers are similarly misleading and inaccurate, however, we cannot delete these as they have legal meaning, despite being largely inaccurate. In addition only the copyright holder is permitted to change their respective copyright statement. Reviewed-by: Erik Skultety <eskultet@redhat.com> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
115 lines
2.9 KiB
C
115 lines
2.9 KiB
C
/*
|
|
* Copyright (C) 2013 Red Hat, Inc.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#include "testutils.h"
|
|
#include "virerror.h"
|
|
#include "viralloc.h"
|
|
#include "virlog.h"
|
|
|
|
#include "domain_conf.h"
|
|
|
|
#define VIR_FROM_THIS VIR_FROM_NONE
|
|
|
|
VIR_LOG_INIT("tests.domainconftest");
|
|
|
|
static virCapsPtr caps;
|
|
static virDomainXMLOptionPtr xmlopt;
|
|
|
|
struct testGetFilesystemData {
|
|
const char *filename;
|
|
const char *path;
|
|
bool expectEntry;
|
|
};
|
|
|
|
static int testGetFilesystem(const void *opaque)
|
|
{
|
|
int ret = -1;
|
|
virDomainDefPtr def = NULL;
|
|
char *filename = NULL;
|
|
const struct testGetFilesystemData *data = opaque;
|
|
virDomainFSDefPtr fsdef;
|
|
|
|
if (virAsprintf(&filename, "%s/domainconfdata/%s.xml",
|
|
abs_srcdir, data->filename) < 0)
|
|
goto cleanup;
|
|
|
|
if (!(def = virDomainDefParseFile(filename, caps, xmlopt, NULL, 0)))
|
|
goto cleanup;
|
|
|
|
fsdef = virDomainGetFilesystemForTarget(def,
|
|
data->path);
|
|
if (!fsdef) {
|
|
if (data->expectEntry) {
|
|
fprintf(stderr, "Expected FS for path '%s' in '%s'\n",
|
|
data->path, filename);
|
|
goto cleanup;
|
|
}
|
|
} else {
|
|
if (!data->expectEntry) {
|
|
fprintf(stderr, "Unexpected FS for path '%s' in '%s'\n",
|
|
data->path, filename);
|
|
goto cleanup;
|
|
}
|
|
}
|
|
|
|
ret = 0;
|
|
|
|
cleanup:
|
|
virDomainDefFree(def);
|
|
VIR_FREE(filename);
|
|
return ret;
|
|
}
|
|
|
|
static int
|
|
mymain(void)
|
|
{
|
|
int ret = 0;
|
|
|
|
if ((caps = virTestGenericCapsInit()) == NULL)
|
|
goto cleanup;
|
|
|
|
if (!(xmlopt = virTestGenericDomainXMLConfInit()))
|
|
goto cleanup;
|
|
|
|
#define DO_TEST_GET_FS(fspath, expect) \
|
|
do { \
|
|
struct testGetFilesystemData data = { \
|
|
.filename = "getfilesystem", \
|
|
.path = fspath, \
|
|
.expectEntry = expect, \
|
|
}; \
|
|
if (virTestRun("Get FS " fspath, testGetFilesystem, &data) < 0) \
|
|
ret = -1; \
|
|
} while (0)
|
|
|
|
DO_TEST_GET_FS("/", true);
|
|
DO_TEST_GET_FS("/dev", true);
|
|
DO_TEST_GET_FS("/dev/pts", false);
|
|
DO_TEST_GET_FS("/doesnotexist", false);
|
|
|
|
virObjectUnref(caps);
|
|
virObjectUnref(xmlopt);
|
|
|
|
cleanup:
|
|
return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
|
|
}
|
|
|
|
VIR_TEST_MAIN(mymain)
|