libvirt/src/conf
Peter Krempa 6622e3cc33 virDomainDeviceInfoParseXML: Reject '0' value for ACPI index
Value of '0' is treated equivalently to when it's not provided by the
user. Reject an explicit '0' provided by the user as it would get
ignored.

In this rare case we can make the XML parser more strict, as libvirt
would never format the '<acpi/>' element if the index is '0' thus there
are no libvirt-generated XMLs we'd not load back, as of such this is
identical to rejecting it in the validation phase.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2037146
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
2022-01-19 16:54:32 +01:00
..
backup_conf.c virDomainBackupDefFormat: Propagate private data callbacks 2021-11-04 10:55:28 +01:00
backup_conf.h virDomainBackupDefFormat: Propagate private data callbacks 2021-11-04 10:55:28 +01:00
capabilities.c conf: capabilities: Clean up freeing of virBitmap 2021-12-10 16:36:24 +01:00
capabilities.h conf: Introduce virCapabilitiesHostNUMAGetMaxNode() 2021-08-23 13:59:28 +02:00
checkpoint_conf.c conf: snapshot/checkpoint: Rewrite 'AlignDisk' logic to appease clang 2021-08-23 16:59:23 +02:00
checkpoint_conf.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
cpu_conf.c virCPUDefParseXML: Prefer virXMLPropUInt over virXPathUInt 2021-10-01 10:52:35 +02:00
cpu_conf.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
device_conf.c conf: device: compare drive address fields separately 2021-11-16 16:40:33 +01:00
device_conf.h qemuBuildDeviceAddressProps: Format also 'drive' addresses 2021-10-12 10:26:04 +02:00
domain_addr.c Switch away from virHashFree 2021-12-01 13:53:12 +01:00
domain_addr.h conf: Make virDomainDeviceInfoFormat() const correct 2021-10-20 16:53:01 +02:00
domain_audit.c conf: Properly instantiate virDomainChrSourceDef in virDomainTPMDef 2021-11-19 12:38:35 +01:00
domain_audit.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
domain_capabilities.c conf: extend domain capabilities for max SEV guest count 2021-12-14 16:04:17 +00:00
domain_capabilities.h conf: extend domain capabilities for max SEV guest count 2021-12-14 16:04:17 +00:00
domain_conf.c virDomainDeviceInfoParseXML: Reject '0' value for ACPI index 2022-01-19 16:54:32 +01:00
domain_conf.h qemu: split handling of distinct firmware enum conversions 2022-01-14 18:56:39 +00:00
domain_event.c qemu: Wire up MEMORY_DEVICE_SIZE_CHANGE event 2021-10-01 11:04:47 +02:00
domain_event.h qemu: Wire up MEMORY_DEVICE_SIZE_CHANGE event 2021-10-01 11:04:47 +02:00
domain_nwfilter.c virNWFilterBindingDefForNet: Remove superfluous gotos 2021-07-19 09:39:15 +02:00
domain_nwfilter.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
domain_validate.c conf: reject unfiltered sgio on validation 2022-01-19 13:57:59 +01:00
domain_validate.h conf: validate: Move qemu-specific LUN disk validation to global validation 2021-09-09 10:17:28 +02:00
interface_conf.c virInterfaceDefParse: Simplify and cleanup 2022-01-14 15:38:50 +01:00
interface_conf.h lib: Introduce and use g_autoptr() for virInterfaceDef 2021-11-02 10:52:18 +01:00
meson.build util: move virStorageEncryption code into conf 2021-01-22 11:10:27 +01:00
moment_conf.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
moment_conf.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
netdev_bandwidth_conf.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
netdev_bandwidth_conf.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
netdev_vlan_conf.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
netdev_vlan_conf.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
netdev_vport_profile_conf.c lib: Drop needless one line labels 2021-11-22 12:39:59 +01:00
netdev_vport_profile_conf.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
network_conf.c src: network_conf: propagate only bool to virNetworkDefParseString() 2021-09-10 17:38:06 +02:00
network_conf.h src: network_conf: propagate only bool to virNetworkDefParseString() 2021-09-10 17:38:06 +02:00
network_event.c virNetworkEventDispatchDefaultFunc: Cleanup 2021-11-08 14:32:32 +01:00
network_event.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
networkcommon_conf.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
networkcommon_conf.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
node_device_conf.c virNodeDeviceCapVPDParseCustomFields: Don't use 'virXPathStringLimit' 2021-11-24 09:20:39 +01:00
node_device_conf.h Add PCI VPD Capability Support 2021-10-21 17:34:04 +01:00
node_device_event.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
node_device_event.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
node_device_util.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
node_device_util.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
numa_conf.c virBitmapSetBitExpand: Remove return value 2021-12-10 16:36:25 +01:00
numa_conf.h numa_conf: Expose virNumaInterconnect formatter 2021-06-15 10:41:22 +02:00
nwfilter_conf.c Switch away from virHashFree 2021-12-01 13:53:12 +01:00
nwfilter_conf.h nwfilter_conf: add validation against schema in define 2021-08-20 15:38:53 +02:00
nwfilter_ipaddrmap.c Switch away from virHashFree 2021-12-01 13:53:12 +01:00
nwfilter_ipaddrmap.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
nwfilter_params.c virNWFilterParseParamAttributes: Simplify loop 2021-08-04 10:39:27 +02:00
nwfilter_params.h conf: Add AUTOPTR_CLEANUP_FUNC for virNWFilterVarValue 2021-07-23 11:27:05 +02:00
object_event_private.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
object_event.c virObjectEventCallbackListAddID: Remove pointless cleanup of 'cb' 2021-08-06 08:53:26 +02:00
object_event.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
secret_conf.c secret_conf: add validation against schema in define 2021-08-20 15:41:22 +02:00
secret_conf.h secret_conf: add validation against schema in define 2021-08-20 15:41:22 +02:00
secret_event.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
secret_event.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
snapshot_conf_priv.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
snapshot_conf.c virDomainSnapshotRedefinePrep: Don't do partial redefine 2022-01-14 18:11:58 +01:00
snapshot_conf.h virDomainSnapshotRedefinePrep: Don't do partial redefine 2022-01-14 18:11:58 +01:00
storage_adapter_conf.c virStorageAdapterParseXML: Use virXMLProp* 2021-05-20 11:52:44 +02:00
storage_adapter_conf.h virStorageAdapterFCHost: Change type of "type" to virStorageAdapterType 2021-05-20 11:52:41 +02:00
storage_capabilities.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
storage_capabilities.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
storage_conf.c lib: Drop needless one line labels 2021-11-22 12:39:59 +01:00
storage_conf.h storage_conf: add validation against schema in pool define 2021-08-25 09:57:51 +02:00
storage_encryption_conf.c conf: add luks2 encryption format 2021-10-25 14:06:15 +02:00
storage_encryption_conf.h conf: add luks2 encryption format 2021-10-25 14:06:15 +02:00
storage_event.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
storage_event.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
storage_source_conf.c storage: Introduce 'extended_l2' feature for storage volume 2021-12-21 13:23:09 +01:00
storage_source_conf.h storage: Introduce 'extended_l2' feature for storage volume 2021-12-21 13:23:09 +01:00
virchrdev.c Switch away from virHashFree 2021-12-01 13:53:12 +01:00
virchrdev.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virconftypes.h conf: Refactor launch security to allow more types 2021-07-21 13:30:14 +02:00
virdomaincheckpointobjlist.c lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virdomaincheckpointobjlist.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virdomainmomentobjlist.c virDomainMomentAssignDef: Simplify error handling 2022-01-14 18:05:29 +01:00
virdomainmomentobjlist.h conf: moment: Export helpers to create the virDomainMoment wrapper 2022-01-12 16:00:18 +01:00
virdomainobjlist.c lib: Drop some needless labels 2021-12-03 17:19:35 +01:00
virdomainobjlist.h virDomainObjListAdd: Transfer definition ownership 2021-11-24 13:12:20 +01:00
virdomainsnapshotobjlist.c virDomainSnapshotRedefinePrep: Don't do partial redefine 2022-01-14 18:11:58 +01:00
virdomainsnapshotobjlist.h virDomainSnapshotRedefinePrep: Don't do partial redefine 2022-01-14 18:11:58 +01:00
virinterfaceobj.c Switch away from virHashFree 2021-12-01 13:53:12 +01:00
virinterfaceobj.h virInterfaceObjListAssignDef: Transfer definition ownership 2021-11-24 13:12:20 +01:00
virnetworkobj.c conf: remove radvdPid from virNetworkObj 2021-12-15 15:28:17 +01:00
virnetworkobj.h conf: remove radvdPid from virNetworkObj 2021-12-15 15:28:17 +01:00
virnetworkportdef.c conf: virnetworkportdef: add validation against schema in network port create 2021-09-06 17:08:59 +02:00
virnetworkportdef.h conf: virnetworkportdef: add validation against schema in network port create 2021-09-06 17:08:59 +02:00
virnodedeviceobj.c Switch away from virHashFree 2021-12-01 13:53:12 +01:00
virnodedeviceobj.h nodedev: implement virNodeDevice(Get|Set)Autostart() 2021-09-14 14:24:00 -05:00
virnwfilterbindingdef.c Switch away from virHashFree 2021-12-01 13:53:12 +01:00
virnwfilterbindingdef.h conf: virnwfilterbindingdef: add validation against schema in create 2021-09-06 17:08:59 +02:00
virnwfilterbindingobj.c lib: Drop intermediary return variables 2021-10-25 12:48:46 +02:00
virnwfilterbindingobj.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virnwfilterbindingobjlist.c Switch away from virHashFree 2021-12-01 13:53:12 +01:00
virnwfilterbindingobjlist.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virnwfilterobj.c lib: Drop intermediary return variables 2021-10-25 12:48:46 +02:00
virnwfilterobj.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virsavecookie.c lib: Drop needless one line labels 2021-11-22 12:39:59 +01:00
virsavecookie.h lib: Drop internal virXXXPtr typedefs 2021-04-13 17:00:38 +02:00
virsecretobj.c Switch away from virHashFree 2021-12-01 13:53:12 +01:00
virsecretobj.h virSecretObjListAdd: Transfer definition ownership 2021-11-24 13:12:20 +01:00
virstorageobj.c Switch away from virHashFree 2021-12-01 13:53:12 +01:00
virstorageobj.h virStoragePoolObjListAdd: Transfer definition ownership 2021-11-24 13:12:20 +01:00