mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-10-13 09:39:17 +00:00
407a281a8e
This reverts commit e4b980c853.
When a binary links against a .a archive (as opposed to a shared library),
any symbols which are marked as 'weak' get silently dropped. As a result
when the binary later runs, those 'weak' functions have an address of
0x0 and thus crash when run.
This happened with virtlogd and virtlockd because they don't link to
libvirt.so, but instead just libvirt_util.a and libvirt_rpc.a. The
virRandomBits symbols was weak and so left out of the virtlogd &
virtlockd binaries, despite being required by virHashTable functions.
Various other binaries like libvirt_lxc, libvirt_iohelper, etc also
link directly to .a files instead of libvirt.so, so are potentially
at risk of dropping symbols leading to a later runtime crash.
This is normal linker behaviour because a weak symbol is not treated
as undefined, so nothing forces it to be pulled in from the .a You
have to force the linker to pull in weak symbols using -u$SYMNAME
which is not a practical approach.
This risk is silent bad linkage that affects runtime behaviour is
not acceptable for a fix that was merely trying to fix the test
suite. So stop using __weak__ again.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
119 lines
3.8 KiB
C
119 lines
3.8 KiB
C
/*
|
|
* qemu_capspriv.h: private declarations for QEMU capabilities generation
|
|
*
|
|
* Copyright (C) 2015 Samsung Electronics Co. Ltd
|
|
* Copyright (C) 2015 Pavel Fedin
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*
|
|
* Author: Pavel Fedin <p.fedin@samsung.com>
|
|
*/
|
|
|
|
#ifndef __QEMU_CAPSPRIV_H_ALLOW__
|
|
# error "qemu_capspriv.h may only be included by qemu_capabilities.c or test suites"
|
|
#endif
|
|
|
|
#ifndef __QEMU_CAPSPRIV_H__
|
|
# define __QEMU_CAPSPRIV_H__
|
|
|
|
struct _virQEMUCapsCache {
|
|
virMutex lock;
|
|
virHashTablePtr binaries;
|
|
char *libDir;
|
|
char *cacheDir;
|
|
uid_t runUid;
|
|
gid_t runGid;
|
|
};
|
|
|
|
virQEMUCapsPtr virQEMUCapsNewCopy(virQEMUCapsPtr qemuCaps);
|
|
|
|
virQEMUCapsPtr
|
|
virQEMUCapsNewForBinaryInternal(virCapsPtr caps,
|
|
const char *binary,
|
|
const char *libDir,
|
|
const char *cacheDir,
|
|
uid_t runUid,
|
|
gid_t runGid,
|
|
bool qmpOnly);
|
|
|
|
int virQEMUCapsLoadCache(virCapsPtr caps,
|
|
virQEMUCapsPtr qemuCaps,
|
|
const char *filename,
|
|
time_t *selfctime,
|
|
unsigned long *selfvers);
|
|
char *virQEMUCapsFormatCache(virQEMUCapsPtr qemuCaps,
|
|
time_t selfCTime,
|
|
unsigned long selfVersion);
|
|
|
|
int
|
|
virQEMUCapsInitQMPMonitor(virQEMUCapsPtr qemuCaps,
|
|
qemuMonitorPtr mon);
|
|
|
|
int
|
|
virQEMUCapsInitQMPMonitorTCG(virQEMUCapsPtr qemuCaps,
|
|
qemuMonitorPtr mon);
|
|
|
|
void
|
|
virQEMUCapsSetArch(virQEMUCapsPtr qemuCaps,
|
|
virArch arch);
|
|
|
|
void
|
|
virQEMUCapsSetVersion(virQEMUCapsPtr qemuCaps,
|
|
unsigned int version);
|
|
|
|
void
|
|
virQEMUCapsInitHostCPUModel(virQEMUCapsPtr qemuCaps,
|
|
virCapsPtr caps,
|
|
virDomainVirtType type);
|
|
|
|
int
|
|
virQEMUCapsInitCPUModel(virQEMUCapsPtr qemuCaps,
|
|
virDomainVirtType type,
|
|
virCPUDefPtr cpu,
|
|
bool migratable);
|
|
|
|
void
|
|
virQEMUCapsInitQMPBasicArch(virQEMUCapsPtr qemuCaps);
|
|
|
|
void
|
|
virQEMUCapsSetCPUModelInfo(virQEMUCapsPtr qemuCaps,
|
|
virDomainVirtType type,
|
|
qemuMonitorCPUModelInfoPtr modelInfo);
|
|
|
|
virCPUDefPtr
|
|
virQEMUCapsProbeHostCPUForEmulator(virCapsPtr caps,
|
|
virQEMUCapsPtr qemuCaps,
|
|
virDomainVirtType type) ATTRIBUTE_NOINLINE;
|
|
|
|
void
|
|
virQEMUCapsSetGICCapabilities(virQEMUCapsPtr qemuCaps,
|
|
virGICCapability *capabilities,
|
|
size_t ncapabilities);
|
|
|
|
int
|
|
virQEMUCapsParseHelpStr(const char *qemu,
|
|
const char *str,
|
|
virQEMUCapsPtr qemuCaps,
|
|
unsigned int *version,
|
|
bool *is_kvm,
|
|
unsigned int *kvm_version,
|
|
bool check_yajl,
|
|
const char *qmperr);
|
|
|
|
int
|
|
virQEMUCapsParseDeviceStr(virQEMUCapsPtr qemuCaps,
|
|
const char *str);
|
|
#endif
|