libvirt/tests/storagepoolcapstest.c
Michal Privoznik 5d99b157bc tests: Return EXIT_FAILURE/EXIT_SUCCESS instead of -1/0
When using VIR_TEST_MAIN() or VIR_TEST_MAIN_PRELOAD() macros, the
retval of mymain() will become retval of main(). Hence, mymain()
should use EXIT_FAILURE and EXIT_SUCCESS return values for
greater portability. Another reason is that otherwise our summary
printing of failed tests doesn't work (see following commit for
more info).

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
2021-05-17 09:25:32 +02:00

108 lines
2.8 KiB
C

/*
* Copyright (C) Red Hat, Inc. 2019
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2.1 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this library. If not, see
* <http://www.gnu.org/licenses/>.
*/
#include <config.h>
#include "testutils.h"
#include "storage_conf.h"
#include "storage_capabilities.h"
#define VIR_FROM_THIS VIR_FROM_NONE
struct test_virStoragePoolCapsFormatData {
const char *filename;
virCaps *driverCaps;
};
static void
test_virCapabilitiesAddFullStoragePool(virCaps *caps)
{
size_t i;
for (i = 0; i < VIR_STORAGE_POOL_LAST; i++)
virCapabilitiesAddStoragePool(caps, i);
}
static void
test_virCapabilitiesAddFSStoragePool(virCaps *caps)
{
virCapabilitiesAddStoragePool(caps, VIR_STORAGE_POOL_FS);
}
static int
test_virStoragePoolCapsFormat(const void *opaque)
{
struct test_virStoragePoolCapsFormatData *data =
(struct test_virStoragePoolCapsFormatData *) opaque;
virCaps *driverCaps = data->driverCaps;
g_autoptr(virStoragePoolCaps) poolCaps = NULL;
g_autofree char *path = NULL;
g_autofree char *poolCapsXML = NULL;
if (!(poolCaps = virStoragePoolCapsNew(driverCaps)))
return -1;
path = g_strdup_printf("%s/storagepoolcapsschemadata/poolcaps-%s.xml",
abs_srcdir, data->filename);
if (!(poolCapsXML = virStoragePoolCapsFormat(poolCaps)))
return -1;
if (virTestCompareToFile(poolCapsXML, path) < 0)
return -1;
return 0;
}
static int
mymain(void)
{
int ret = 0;
g_autoptr(virCaps) fullCaps = NULL;
g_autoptr(virCaps) fsCaps = NULL;
#define DO_TEST(Filename, DriverCaps) \
do { \
struct test_virStoragePoolCapsFormatData data = \
{.filename = Filename, .driverCaps = DriverCaps }; \
if (virTestRun(Filename, test_virStoragePoolCapsFormat, &data) < 0) \
ret = -1; \
} while (0)
if (!(fullCaps = virCapabilitiesNew(VIR_ARCH_NONE, false, false)) ||
!(fsCaps = virCapabilitiesNew(VIR_ARCH_NONE, false, false))) {
return -1;
}
test_virCapabilitiesAddFullStoragePool(fullCaps);
test_virCapabilitiesAddFSStoragePool(fsCaps);
DO_TEST("full", fullCaps);
DO_TEST("fs", fsCaps);
return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
}
VIR_TEST_MAIN(mymain)